56672 2011-03-18 13:42:55 -0700 Leaks beneath RenderSVGShadowTreeRootContainer::updateFromElement seen on SnowLeopard Intel Leaks 2011-11-18 11:04:39 -0800 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) Mac OS X 10.6 RESOLVED FIXED http://build.webkit.org/LeaksViewer/?url=http%3A%2F%2Fbuild.webkit.org%2F%2Fresults%2FSnowLeopard%20Intel%20Leaks%2Fr81496%20(15670)%2F InRadar, MakingBotsRed P2 Normal --- 1 aroben webkit-unassigned commit-queue dglazkov leo.yang sam zimmermann oldest_to_newest 369827 0 aroben 2011-03-18 13:42:55 -0700 To see the leaks: 1. Go to http://build.webkit.org/LeaksViewer/?url=http%3A%2F%2Fbuild.webkit.org%2F%2Fresults%2FSnowLeopard%20Intel%20Leaks%2Fr81496%20(15670)%2F 2. Dig into malloc_zone_malloc > malloc > WTF::fastMalloc Many of the leaks in that node are (indirect) callees of RenderSVGShadowTreeRootContainer::updateFromElement. 369853 1 jberlin 2011-03-18 14:06:01 -0700 <rdar://problem/9156332> 370083 2 sam 2011-03-18 19:58:26 -0700 It looks like at least some of this leak is coming from somewhere in this set: sputnik/Unicode/Unicode_410 ......................................... sputnik/Unicode/Unicode_500 ......................................... sputnik/Unicode/Unicode_510 ......................................... storage .................................. storage/domstorage ...... storage/domstorage/events ..... storage/domstorage/localstorage ........ storage/domstorage/localstorage/storagetracker ..... storage/domstorage/sessionstorage ........ svg/W3C-I18N ......................................... svg/W3C-SVG-1.1-SE ...................... svg/W3C-SVG-1.1 .................................................................................................................................................................................................................................................................................... svg/animations ............................. svg/batik/filters .. svg/batik/masking . svg/batik/paints ..... svg/batik/text ............................ svg/carto.net .......... svg/clip-path .......................................... svg/css ............................. svg/custom ..................................................................................................................................................................................................................................................................................................... ? checking for leaks in DumpRenderTree + 24 leaks (11312 bytes including 2 excluded leaks) were found, details in /Volumes/Data/WebKit-BuildSlave/snowleopard-intel-leaks/build/layout-test-results/DumpRenderTree6-leaks.txt which can be helpful for find a reproducible test of this happening. 370084 3 sam 2011-03-18 19:59:43 -0700 Adding on to what Adam was noting, RenderSVGShadowTreeRootContainers are leaking, so all the children of that element are also leaking. 370085 4 sam 2011-03-18 20:00:08 -0700 (In reply to comment #3) > Adding on to what Adam was noting, RenderSVGShadowTreeRootContainers are leaking, so all the children of that element are also leaking. Make that the SVGShadowTreeRootElement, not the RenderSVGShadowTreeRootContainer. 387549 5 89993 leo.yang 2011-04-17 22:50:46 -0700 Created attachment 89993 Patch I can't see the leak results from the above links. But I can see the following leak in recent build, so I'm assume the bug was reporting the same issue. Leak: 0x1165e1df0 size=464 zone: DefaultMallocZone_0x105f89000 instance of 'WebCore::SVGShadowTreeRootElement', type C++, implemented in WebCore 0x02fd30d8 0x00000001 0x02fd36d0 0x00000001 .0.......6...... 0x16600000 0x00000000 0x165a08b0 0x00000001 ..`.......Z..... 0x00000000 0x00000000 0x00000000 0x00000000 ................ 0x07e34a00 0x00000001 0x00000000 0x00000000 .J.............. 0x00000000 0x00000000 0x00000000 0x00000000 ................ 0x005c085c 0x00000000 0x00000000 0x00000000 \.\............. 0x00000000 0x00000000 0x0ce6a1d0 0x00000001 ................ 0x00000000 0x00000000 0x00000000 0x00000000 ................ ... Call stack: [thread 0x7fff70e15ca0]: | 0x2 | start | main | dumpRenderTree(int, char const**) | runTestingServerLoop() | runTest(std::string const&) | -[NSRunLoop(NSRunLoop) runMode:beforeDate:] | CFRunLoopRunSpecific | __CFRunLoopRun | __CFRunLoopDoSources0 | MultiplexerSource::perform() | URLConnectionClient::processEvents() | URLConnectionClient::ClientConnectionEventQueue::processAllEventsAndConsumePayload(XConnectionEventInfo<XClientEvent, XClientEventParams>*, long) | URLConnectionClient::_clientDidReceiveData(__CFData const*, URLConnectionClient::ClientConnectionEventQueue*) | _NSURLConnectionDidReceiveData | -[WebCoreResourceHandleAsDelegate connection:didReceiveData:lengthReceived:] | WebCore::ResourceLoader::didReceiveData(WebCore::ResourceHandle*, char const*, int, int) | WebCore::MainResourceLoader::didReceiveData(char const*, int, long long, bool) | WebCore::ResourceLoader::didReceiveData(char const*, int, long long, bool) | WebCore::MainResourceLoader::addData(char const*, int, bool) | WebCore::DocumentLoader::receivedData(char const*, int) | WebCore::DocumentLoader::commitLoad(char const*, int) | WebFrameLoaderClient::committedLoad(WebCore::DocumentLoader*, char const*, int) | -[WebDataSource(WebInternal) _receivedData:] | -[WebHTMLRepresentation receivedData:withDataSource:] | -[WebFrame(WebInternal) _commitData:] | WebCore::DocumentLoader::commitData(char const*, int) | WebCore::DocumentWriter::addData(char const*, int, bool) | WebCore::DecodedDataDocumentParser::appendBytes(WebCore::DocumentWriter*, char const*, int, bool) | WebCore::XMLDocumentParser::append(WebCore::SegmentedString const&) | WebCore::XMLDocumentParser::doWrite(WTF::String const&) | xmlParseChunk | xmlParseXMLDecl | WebCore::startElementNsHandler(void*, unsigned char const*, unsigned char const*, unsigned char const*, int, unsigned char const**, int, int, unsigned char const**) | WebCore::XMLDocumentParser::startElementNs(unsigned char const*, unsigned char const*, unsigned char const*, int, unsigned char const**, int, int, unsigned char const**) | WebCore::SVGUseElement::attach() | WebCore::SVGStyledElement::attach() | WebCore::RenderSVGShadowTreeRootContainer::updateFromElement() | WebCore::SVGShadowTreeRootElement::create(WebCore::Document*, WebCore::SVGUseElement*) | WTF::fastMalloc(unsigned long) | malloc | malloc_zone_malloc 387792 6 89993 eric 2011-04-18 09:29:27 -0700 Comment on attachment 89993 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=89993&action=review > Source/WebCore/rendering/svg/RenderSVGShadowTreeRootContainer.cpp:42 > m_shadowRoot->clearShadowHost(); I don't understand why "clearing" the host doesn't also detach it? Aren't we releasing a ref-counted DOM Node here? When it's destroyed, doesn't it also destroy its renderer? 388213 7 leo.yang 2011-04-18 18:59:30 -0700 (In reply to comment #6) > (From update of attachment 89993 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=89993&action=review > > > Source/WebCore/rendering/svg/RenderSVGShadowTreeRootContainer.cpp:42 > > m_shadowRoot->clearShadowHost(); > > I don't understand why "clearing" the host doesn't also detach it? Aren't we releasing a ref-counted DOM Node here? When it's destroyed, doesn't it also destroy its renderer? Good point! I was trying to keep the previous detach. I also agree that it needs not detach if we clear shadow host. 388215 8 90128 leo.yang 2011-04-18 19:01:42 -0700 Created attachment 90128 Revised patch 388328 9 90128 krit 2011-04-18 23:48:02 -0700 Comment on attachment 90128 Revised patch Fix looks good to me. r=me 388330 10 90128 commit-queue 2011-04-18 23:51:38 -0700 Comment on attachment 90128 Revised patch Rejecting attachment 90128 from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-8', 'apply-..." exit_code: 2 Last 500 characters of output: k Schulze', u'--for..." exit_code: 1 Parsed 2 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/rendering/svg/RenderSVGShadowTreeRootContainer.cpp Hunk #1 FAILED at 36. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/rendering/svg/RenderSVGShadowTreeRootContainer.cpp.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Dirk Schulze', u'--for..." exit_code: 1 Full output: http://queues.webkit.org/results/8475164 389038 11 90300 leo.yang 2011-04-19 21:12:03 -0700 Created attachment 90300 Rebased patch 389045 12 90300 eric 2011-04-19 21:42:34 -0700 Comment on attachment 90300 Rebased patch OK. Why was the previous code only clear it when attached? This seems fine though. 389094 13 90300 krit 2011-04-19 23:52:09 -0700 Comment on attachment 90300 Rebased patch Setting cq+. 389116 14 90300 commit-queue 2011-04-20 01:16:15 -0700 Comment on attachment 90300 Rebased patch Clearing flags on attachment: 90300 Committed r84350: <http://trac.webkit.org/changeset/84350> 389117 15 commit-queue 2011-04-20 01:16:22 -0700 All reviewed patches have been landed. Closing bug. 389174 16 aroben 2011-04-20 06:34:56 -0700 Thanks for looking into this! It's going to be very hard to tell if this is fixed until bug 58889 is fixed, too. 505920 17 aroben 2011-11-18 11:04:39 -0800 Looks like this was either never fixed or has come back. I filed bug 72741 rather than reopening this one as I thought it would be clearer. 89993 2011-04-17 22:50:46 -0700 2011-04-18 19:01:42 -0700 Patch 0001-2011-04-17-Leo-Yang-leo.yang-torchmobile.com.cn.patch text/plain 2405 leo.yang RnJvbSA2YjE0NjYzNjBmNjA0YWFiNGJhYzZkZjMxZWQwNjBkZWM5ODhiNDY0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMZW8gWWFuZyA8bGVvLnlhbmdAdG9yY2htb2JpbGUuY29tLmNu PgpEYXRlOiBNb24sIDE4IEFwciAyMDExIDEzOjMwOjMzICswODAwClN1YmplY3Q6IFtQQVRDSF0g MjAxMS0wNC0xNyAgTGVvIFlhbmcgIDxsZW8ueWFuZ0B0b3JjaG1vYmlsZS5jb20uY24+CgogICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKICAgICAgICBMZWFrcyBiZW5lYXRoIFJl bmRlclNWR1NoYWRvd1RyZWVSb290Q29udGFpbmVyOjp1cGRhdGVGcm9tRWxlbWVudCBzZWVuIG9u IFNub3dMZW9wYXJkIEludGVsIExlYWtzCiAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTU2NjcyCgogICAgICAgIENsZWFyIHNoYWRvdyBob3N0IGlmIG1fc2hh ZG93Um9vdCBpcyB2YWxpZCB0byBwcmV2ZW50IGxlYWtpbmcuCgogICAgICAgIEZpeCBsZWFraW5n LCBubyBuZXcgdGVzdHMuCgogICAgICAgICogcmVuZGVyaW5nL3N2Zy9SZW5kZXJTVkdTaGFkb3dU cmVlUm9vdENvbnRhaW5lci5jcHA6CiAgICAgICAgKFdlYkNvcmU6OlJlbmRlclNWR1NoYWRvd1Ry ZWVSb290Q29udGFpbmVyOjp+UmVuZGVyU1ZHU2hhZG93VHJlZVJvb3RDb250YWluZXIpOgotLS0K IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAx NCArKysrKysrKysrKysrKwogLi4uL3N2Zy9SZW5kZXJTVkdTaGFkb3dUcmVlUm9vdENvbnRhaW5l ci5jcHAgICAgICAgfCAgICA1ICsrKy0tCiAyIGZpbGVzIGNoYW5nZWQsIDE3IGluc2VydGlvbnMo KyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9n IGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGM5MjM2YzcuLjUxZDZlN2QgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMS0wNC0xNyAgTGVvIFlhbmcgIDxsZW8ueWFuZ0B0 b3JjaG1vYmlsZS5jb20uY24+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgTGVha3MgYmVuZWF0aCBSZW5kZXJTVkdTaGFkb3dUcmVlUm9vdENvbnRhaW5l cjo6dXBkYXRlRnJvbUVsZW1lbnQgc2VlbiBvbiBTbm93TGVvcGFyZCBJbnRlbCBMZWFrcworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTY2NzIKKworICAg ICAgICBDbGVhciBzaGFkb3cgaG9zdCBpZiBtX3NoYWRvd1Jvb3QgaXMgdmFsaWQgdG8gcHJldmVu dCBsZWFraW5nLgorCisgICAgICAgIExlYWsgZml4LCBubyBuZXcgdGVzdHMuCisKKyAgICAgICAg KiByZW5kZXJpbmcvc3ZnL1JlbmRlclNWR1NoYWRvd1RyZWVSb290Q29udGFpbmVyLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OlJlbmRlclNWR1NoYWRvd1RyZWVSb290Q29udGFpbmVyOjp+UmVuZGVy U1ZHU2hhZG93VHJlZVJvb3RDb250YWluZXIpOgorCiAyMDExLTA0LTE3ICBEYW4gQmVybnN0ZWlu ICA8bWl0ekBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTWFjaWVqIFN0YWNob3dp YWsuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3ZnL1JlbmRlclNWR1No YWRvd1RyZWVSb290Q29udGFpbmVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdmcv UmVuZGVyU1ZHU2hhZG93VHJlZVJvb3RDb250YWluZXIuY3BwCmluZGV4IDU3MzYzMzMuLjUyY2U5 NWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdmcvUmVuZGVyU1ZHU2hh ZG93VHJlZVJvb3RDb250YWluZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9z dmcvUmVuZGVyU1ZHU2hhZG93VHJlZVJvb3RDb250YWluZXIuY3BwCkBAIC0zNiw4ICszNiw5IEBA IFJlbmRlclNWR1NoYWRvd1RyZWVSb290Q29udGFpbmVyOjpSZW5kZXJTVkdTaGFkb3dUcmVlUm9v dENvbnRhaW5lcihTVkdVc2VFbGVtZW50CiAKIFJlbmRlclNWR1NoYWRvd1RyZWVSb290Q29udGFp bmVyOjp+UmVuZGVyU1ZHU2hhZG93VHJlZVJvb3RDb250YWluZXIoKQogewotICAgIGlmIChtX3No YWRvd1Jvb3QgJiYgbV9zaGFkb3dSb290LT5hdHRhY2hlZCgpKSB7Ci0gICAgICAgIG1fc2hhZG93 Um9vdC0+ZGV0YWNoKCk7CisgICAgaWYgKG1fc2hhZG93Um9vdCkgeworICAgICAgICBpZiAobV9z aGFkb3dSb290LT5hdHRhY2hlZCgpKQorICAgICAgICAgICAgbV9zaGFkb3dSb290LT5kZXRhY2go KTsKICAgICAgICAgbV9zaGFkb3dSb290LT5jbGVhclNoYWRvd0hvc3QoKTsKICAgICB9CiB9Ci0t IAoxLjcuMC40Cgo= 90128 2011-04-18 19:01:42 -0700 2011-04-19 21:12:03 -0700 Revised patch 0001-2011-04-17-Leo-Yang-leo.yang-torchmobile.com.cn.patch text/plain 2416 leo.yang RnJvbSA4NDZlZWZmNWQxYTgxY2JlNzU4NWRmZDMwYWRhMGI1NWI5ZGZkN2ZhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMZW8gWWFuZyA8bGVvLnlhbmdAdG9yY2htb2JpbGUuY29tLmNu PgpEYXRlOiBNb24sIDE4IEFwciAyMDExIDEzOjMwOjMzICswODAwClN1YmplY3Q6IFtQQVRDSF0g MjAxMS0wNC0xNyAgTGVvIFlhbmcgIDxsZW8ueWFuZ0B0b3JjaG1vYmlsZS5jb20uY24+CgogICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKICAgICAgICBMZWFrcyBiZW5lYXRoIFJl bmRlclNWR1NoYWRvd1RyZWVSb290Q29udGFpbmVyOjp1cGRhdGVGcm9tRWxlbWVudCBzZWVuIG9u IFNub3dMZW9wYXJkIEludGVsIExlYWtzCiAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTU2NjcyCgogICAgICAgIENsZWFyIHNoYWRvdyBob3N0IGlmIG1fc2hh ZG93Um9vdCBpcyB2YWxpZCB0byBwcmV2ZW50IGxlYWtpbmcuCgogICAgICAgIEZpeGluZyBsZWFr aW5nLCBubyBuZXcgdGVzdHMuCgogICAgICAgICogcmVuZGVyaW5nL3N2Zy9SZW5kZXJTVkdTaGFk b3dUcmVlUm9vdENvbnRhaW5lci5jcHA6CiAgICAgICAgKFdlYkNvcmU6OlJlbmRlclNWR1NoYWRv d1RyZWVSb290Q29udGFpbmVyOjp+UmVuZGVyU1ZHU2hhZG93VHJlZVJvb3RDb250YWluZXIpOgot LS0KIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgIHwg ICAxNCArKysrKysrKysrKysrKwogLi4uL3N2Zy9SZW5kZXJTVkdTaGFkb3dUcmVlUm9vdENvbnRh aW5lci5jcHAgICAgICAgfCAgICA0ICstLS0KIDIgZmlsZXMgY2hhbmdlZCwgMTUgaW5zZXJ0aW9u cygrKSwgMyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VM b2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzkyMzZjNy4uYWE4ZDdkNiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDExLTA0LTE3ICBMZW8gWWFuZyAgPGxlby55YW5n QHRvcmNobW9iaWxlLmNvbS5jbj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBMZWFrcyBiZW5lYXRoIFJlbmRlclNWR1NoYWRvd1RyZWVSb290Q29udGFp bmVyOjp1cGRhdGVGcm9tRWxlbWVudCBzZWVuIG9uIFNub3dMZW9wYXJkIEludGVsIExlYWtzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NjY3MgorCisg ICAgICAgIENsZWFyIHNoYWRvdyBob3N0IGlmIG1fc2hhZG93Um9vdCBpcyB2YWxpZCB0byBwcmV2 ZW50IGxlYWtpbmcuCisKKyAgICAgICAgRml4aW5nIGxlYWtpbmcsIG5vIG5ldyB0ZXN0cy4KKwor ICAgICAgICAqIHJlbmRlcmluZy9zdmcvUmVuZGVyU1ZHU2hhZG93VHJlZVJvb3RDb250YWluZXIu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyU1ZHU2hhZG93VHJlZVJvb3RDb250YWluZXI6 On5SZW5kZXJTVkdTaGFkb3dUcmVlUm9vdENvbnRhaW5lcik6CisKIDIwMTEtMDQtMTcgIERhbiBC ZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBNYWNpZWog U3RhY2hvd2lhay4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdmcvUmVu ZGVyU1ZHU2hhZG93VHJlZVJvb3RDb250YWluZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL3N2Zy9SZW5kZXJTVkdTaGFkb3dUcmVlUm9vdENvbnRhaW5lci5jcHAKaW5kZXggNTczNjMz My4uOGZlZWIzOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N2Zy9SZW5k ZXJTVkdTaGFkb3dUcmVlUm9vdENvbnRhaW5lci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL3N2Zy9SZW5kZXJTVkdTaGFkb3dUcmVlUm9vdENvbnRhaW5lci5jcHAKQEAgLTM2LDEw ICszNiw4IEBAIFJlbmRlclNWR1NoYWRvd1RyZWVSb290Q29udGFpbmVyOjpSZW5kZXJTVkdTaGFk b3dUcmVlUm9vdENvbnRhaW5lcihTVkdVc2VFbGVtZW50CiAKIFJlbmRlclNWR1NoYWRvd1RyZWVS b290Q29udGFpbmVyOjp+UmVuZGVyU1ZHU2hhZG93VHJlZVJvb3RDb250YWluZXIoKQogewotICAg IGlmIChtX3NoYWRvd1Jvb3QgJiYgbV9zaGFkb3dSb290LT5hdHRhY2hlZCgpKSB7Ci0gICAgICAg IG1fc2hhZG93Um9vdC0+ZGV0YWNoKCk7CisgICAgaWYgKG1fc2hhZG93Um9vdCkKICAgICAgICAg bV9zaGFkb3dSb290LT5jbGVhclNoYWRvd0hvc3QoKTsKLSAgICB9CiB9CiAKIHZvaWQgUmVuZGVy U1ZHU2hhZG93VHJlZVJvb3RDb250YWluZXI6OnVwZGF0ZVN0eWxlKE5vZGU6OlN0eWxlQ2hhbmdl IGNoYW5nZSkKLS0gCjEuNy4wLjQKCg== 90300 2011-04-19 21:12:03 -0700 2011-04-20 01:16:15 -0700 Rebased patch 0001-2011-04-18-Leo-Yang-leo.yang-torchmobile.com.cn.patch text/plain 3046 leo.yang RnJvbSA1ZjM0MTQ5MTEyYjU5NjA5NWI4NjYwNGExNmM3MGVhMDg2YWRkOWM1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMZW8gWWFuZyA8bGVvLnlhbmdAdG9yY2htb2JpbGUuY29tLmNu PgpEYXRlOiBNb24sIDE4IEFwciAyMDExIDEzOjMwOjMzICswODAwClN1YmplY3Q6IFtQQVRDSF0g MjAxMS0wNC0xOCAgTGVvIFlhbmcgIDxsZW8ueWFuZ0B0b3JjaG1vYmlsZS5jb20uY24+CgogICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKICAgICAgICBMZWFrcyBiZW5lYXRoIFJl bmRlclNWR1NoYWRvd1RyZWVSb290Q29udGFpbmVyOjp1cGRhdGVGcm9tRWxlbWVudCBzZWVuIG9u IFNub3dMZW9wYXJkIEludGVsIExlYWtzCiAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTU2NjcyCgogICAgICAgIH5SZW5kZXJTVkdTaGFkb3dUcmVlUm9vdENv bnRhaW5lcigpIGNsZWFyZWQgc2hhZG93IGhvc3Qgb25seSBpZgogICAgICAgIHRoZSBzaGFkb3cg cm9vdCBpcyBhdHRhY2hlZC4gVGhpcyBpcyB3cm9uZyBiZWNhdXNlIGl0IHdpbGwKICAgICAgICBs ZWFrIHNoYWRvdyByb290IHdoZW4gdGhlIHJvb3QgaXMgbm90IGF0dGFjaGVkLiBGb3IgZXhhbXBs ZSwgaXQKICAgICAgICBsZWFrcyBzaGFkb3cgcm9vdCBvZiA8dXNlPiBlbGVtZW50IHdoaWNoIGlz IHBlbmRpbmcgb24gcmVzb3VyY2UuCgogICAgICAgIFRoaXMgcGF0Y2ggaXMgY2xlYXJpbmcgc2hh ZG93IGhvc3QgaWYgbV9zaGFkb3dSb290IGlzIHZhbGlkIHRvCiAgICAgICAgcHJldmVudCBsZWFr aW5nLgoKICAgICAgICBGaXhpbmcgbGVha2luZywgbm8gbmV3IHRlc3RzLgoKICAgICAgICAqIHJl bmRlcmluZy9zdmcvUmVuZGVyU1ZHU2hhZG93VHJlZVJvb3RDb250YWluZXIuY3BwOgogICAgICAg IChXZWJDb3JlOjpSZW5kZXJTVkdTaGFkb3dUcmVlUm9vdENvbnRhaW5lcjo6flJlbmRlclNWR1No YWRvd1RyZWVSb290Q29udGFpbmVyKToKLS0tCiBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgICAg ICAgICAgICAgICAgICAgICAgICAgICB8ICAgMjAgKysrKysrKysrKysrKysrKysrKysKIC4uLi9z dmcvUmVuZGVyU1ZHU2hhZG93VHJlZVJvb3RDb250YWluZXIuY3BwICAgICAgIHwgICAgNCArLS0t CiAyIGZpbGVzIGNoYW5nZWQsIDIxIGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCmluZGV4IDIyODM4MGMuLjViYmQ0MTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMyBAQAor MjAxMS0wNC0xOCAgTGVvIFlhbmcgIDxsZW8ueWFuZ0B0b3JjaG1vYmlsZS5jb20uY24+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTGVha3MgYmVuZWF0 aCBSZW5kZXJTVkdTaGFkb3dUcmVlUm9vdENvbnRhaW5lcjo6dXBkYXRlRnJvbUVsZW1lbnQgc2Vl biBvbiBTbm93TGVvcGFyZCBJbnRlbCBMZWFrcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTY2NzIKKworICAgICAgICB+UmVuZGVyU1ZHU2hhZG93VHJl ZVJvb3RDb250YWluZXIoKSBjbGVhcmVkIHNoYWRvdyBob3N0IG9ubHkgaWYKKyAgICAgICAgdGhl IHNoYWRvdyByb290IGlzIGF0dGFjaGVkLiBUaGlzIGlzIHdyb25nIGJlY2F1c2UgaXQgd2lsbAor ICAgICAgICBsZWFrIHNoYWRvdyByb290IHdoZW4gdGhlIHJvb3QgaXMgbm90IGF0dGFjaGVkLiBG b3IgZXhhbXBsZSwgaXQKKyAgICAgICAgbGVha3Mgc2hhZG93IHJvb3Qgb2YgPHVzZT4gZWxlbWVu dCB3aGljaCBpcyBwZW5kaW5nIG9uIHJlc291cmNlLgorCisgICAgICAgIFRoaXMgcGF0Y2ggaXMg Y2xlYXJpbmcgc2hhZG93IGhvc3QgaWYgbV9zaGFkb3dSb290IGlzIHZhbGlkIHRvCisgICAgICAg IHByZXZlbnQgbGVha2luZy4KKworICAgICAgICBGaXhpbmcgbGVha2luZywgbm8gbmV3IHRlc3Rz LgorCisgICAgICAgICogcmVuZGVyaW5nL3N2Zy9SZW5kZXJTVkdTaGFkb3dUcmVlUm9vdENvbnRh aW5lci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJTVkdTaGFkb3dUcmVlUm9vdENvbnRh aW5lcjo6flJlbmRlclNWR1NoYWRvd1RyZWVSb290Q29udGFpbmVyKToKKwogMjAxMS0wNC0xOSAg Unlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBF cmljIFNlaWRlbC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdmcvUmVu ZGVyU1ZHU2hhZG93VHJlZVJvb3RDb250YWluZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL3N2Zy9SZW5kZXJTVkdTaGFkb3dUcmVlUm9vdENvbnRhaW5lci5jcHAKaW5kZXggZDJhMTEw My4uMmZhODg0YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N2Zy9SZW5k ZXJTVkdTaGFkb3dUcmVlUm9vdENvbnRhaW5lci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL3N2Zy9SZW5kZXJTVkdTaGFkb3dUcmVlUm9vdENvbnRhaW5lci5jcHAKQEAgLTM2LDEw ICszNiw4IEBAIFJlbmRlclNWR1NoYWRvd1RyZWVSb290Q29udGFpbmVyOjpSZW5kZXJTVkdTaGFk b3dUcmVlUm9vdENvbnRhaW5lcihTVkdVc2VFbGVtZW50CiAKIFJlbmRlclNWR1NoYWRvd1RyZWVS b290Q29udGFpbmVyOjp+UmVuZGVyU1ZHU2hhZG93VHJlZVJvb3RDb250YWluZXIoKQogewotICAg IGlmIChtX3NoYWRvd1Jvb3QgJiYgbV9zaGFkb3dSb290LT5hdHRhY2hlZCgpKSB7Ci0gICAgICAg IG1fc2hhZG93Um9vdC0+ZGV0YWNoKCk7CisgICAgaWYgKG1fc2hhZG93Um9vdCkKICAgICAgICAg bV9zaGFkb3dSb290LT5jbGVhclNWR1NoYWRvd0hvc3QoKTsKLSAgICB9CiB9CiAKIHZvaWQgUmVu ZGVyU1ZHU2hhZG93VHJlZVJvb3RDb250YWluZXI6OnVwZGF0ZVN0eWxlKE5vZGU6OlN0eWxlQ2hh bmdlIGNoYW5nZSkKLS0gCjEuNy4wLjQKCg==