56669 2011-03-18 13:14:16 -0700 [Qt] QtWebKit rendering problem when maximizing and doing a back 2014-02-03 03:17:23 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) PC Linux RESOLVED INVALID Qt, QtTriaged P1 Normal --- 1 aparna.nand aparna.nand abarth benjamin commit-queue eric joel.parks kling laszlo.gombos max.hong.shen menard mitz webkit.review.bot oldest_to_newest 369814 0 aparna.nand 2011-03-18 13:14:16 -0700 Preconditions - QtTestBrowser is not maximized Steps to reproduce: 1. From QtTestBrowser, go to google.com 2. Search for example meego - Page 1 3. Open a link, say first link from search page - Page 2 4. Maximize the window 5. Now press back button Expected - Page 1 content should now be displayed in entire browser Actual - There is an overlap of page 1 and page 2 content 369831 1 benjamin 2011-03-18 13:47:32 -0700 Setting P1 since it is a regression. For reference: https://bugs.webkit.org/show_bug.cgi?id=51892 370879 2 86361 aparna.nand 2011-03-21 14:07:17 -0700 Created attachment 86361 Patch for review Bug is caused due to changes made in http://trac.webkit.org/changeset/79167 On resizing and going back, contentsResized() is not getting called. Before the above changeset, contentsResized was called from ScrollView::setFrameRect(). Now ScrollView::setBoundsSize makes the call to contentsResized. Changes made are similar to changes made in resize() of Widget.h. 370889 3 86361 menard 2011-03-21 14:15:57 -0700 Comment on attachment 86361 Patch for review Look goods to me. It was related to this changes too : http://trac.webkit.org/changeset/79450 370890 4 menard 2011-03-21 14:18:21 -0700 Perhaps you should put my name for the test just in case we have stability problems, so if needed it's possible to find the original author :). 370894 5 aparna.nand 2011-03-21 14:19:36 -0700 (In reply to comment #4) > Perhaps you should put my name for the test just in case we have stability problems, so if needed it's possible to find the original author :). I just left a message to you IRC, I was not sure how to add your name too as author :). Where should it go? 370913 6 86367 aparna.nand 2011-03-21 14:41:24 -0700 Created attachment 86367 Patch v02 for review Adding Alexis as author of the auto test. 371064 7 86367 tonikitoo 2011-03-21 17:39:25 -0700 Comment on attachment 86367 Patch v02 for review View in context: https://bugs.webkit.org/attachment.cgi?id=86367&action=review Was it wrong in the original patch? no layout test catching it? Is it possible to test it through DRT? > Source/WebKit/qt/tests/qwebview/tst_qwebview.cpp:442 > +void tst_QWebView::rendering() this name is meaningless. 371348 8 86367 benjamin 2011-03-22 06:19:09 -0700 Comment on attachment 86367 Patch v02 for review View in context: https://bugs.webkit.org/attachment.cgi?id=86367&action=review No idea about the validity of change itself though, maybe Andreas... :) > Source/WebKit/qt/tests/qwebview/tst_qwebview.cpp:472 > + QApplication::processEvents(); Can't you just waitForSignal() on loadFinished()? 371391 9 86367 kling 2011-03-22 08:08:52 -0700 Comment on attachment 86367 Patch v02 for review View in context: https://bugs.webkit.org/attachment.cgi?id=86367&action=review > Source/WebCore/loader/FrameLoader.cpp:2196 > + view->setBoundsSize(IntSize(rect.width(), rect.height())); view->setBoundsSize(rect.size()); 372009 10 86582 aparna.nand 2011-03-23 00:42:39 -0700 Created attachment 86582 Patch v03 with comments implemented 1. Renamed the function in test. 2. Corrected the code as per comments from Andreas. 3. Corrected the code in test 3. Could not add layout test (DRT) as window.resizeTo(w, h) is not happening in QtTestBrowser. 372107 11 86582 menard 2011-03-23 06:22:47 -0700 Comment on attachment 86582 Patch v03 with comments implemented LGTM :D 372120 12 86582 kling 2011-03-23 06:51:28 -0700 Comment on attachment 86582 Patch v03 with comments implemented LGTM, too :) 372169 13 86582 commit-queue 2011-03-23 08:54:46 -0700 Comment on attachment 86582 Patch v03 with comments implemented Clearing flags on attachment: 86582 Committed r81775: <http://trac.webkit.org/changeset/81775> 372170 14 commit-queue 2011-03-23 08:54:51 -0700 All reviewed patches have been landed. Closing bug. 372280 15 webkit.review.bot 2011-03-23 11:28:05 -0700 http://trac.webkit.org/changeset/81775 might have broken GTK Linux 64-bit Debug 407562 16 laszlo.gombos 2011-05-21 14:39:14 -0700 Reopen as this test fails on Symbian and possible on other "small screen" platforms - (see http://build.webkit.sed.hu/builders/Qt%20Symbian%20ARMv5%20Release/builds/1156/steps/API%20tests/logs/stdio) FAIL! : tst_QWebView::renderingAfterMaxAndBack() Compared values are not the same Loc: [D:/w/qt-symbian-release/build/Source/WebKit/qt/tests/qwebview/tst_qwebview.cpp(504)] Perhaps the test should render smaller sized content - e.g. 50x50 instead of 1024x768. Disabling the scrollbars would be a good ideas as well (see http://trac.webkit.org/changeset/84332) CCd Yi who might be able to help with testing on Symbian. 428228 17 joel.parks 2011-06-27 13:31:24 -0700 (In reply to comment #16) > Reopen as this test fails on Symbian and possible on other "small screen" platforms - (see http://build.webkit.sed.hu/builders/Qt%20Symbian%20ARMv5%20Release/builds/1156/steps/API%20tests/logs/stdio) > > FAIL! : tst_QWebView::renderingAfterMaxAndBack() Compared values are not the same > Loc: [D:/w/qt-symbian-release/build/Source/WebKit/qt/tests/qwebview/tst_qwebview.cpp(504)] > > Perhaps the test should render smaller sized content - e.g. 50x50 instead of 1024x768. Disabling the scrollbars would be a good ideas as well (see http://trac.webkit.org/changeset/84332) > > CCd Yi who might be able to help with testing on Symbian. Still failing at build #1774 http://build.webkit.sed.hu/builders/Qt%20Symbian%20ARMv5%20Release/builds/1774/steps/API%20tests/logs/stdio But is this really a P1 error? 975190 18 jturcotte 2014-02-03 03:17:23 -0800 === Bulk closing of Qt bugs === If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary. If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines. 86361 2011-03-21 14:07:17 -0700 2011-03-21 14:41:24 -0700 Patch for review patch text/plain 4269 aparna.nand ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3ZWE3YjE4Li4yOTVjYWU3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTEtMDMtMjEgIEFwYXJuYSBOYW5keWFsICA8YXBhcm5hLm5hbmRAd2lwcm8uY29tPgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gUXRX ZWJLaXQgcmVuZGVyaW5nIHByb2JsZW0gd2hlbiBtYXhpbWl6aW5nIGFuZCBkb2luZyBhIGJhY2sK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU2NjY5CisK KyAgICAgICAgQ29udGVudHMgb2YgdGhlIHBhZ2UgYXJlIG5vdCByZS1zaXplZCBvbiBnb2luZyBi YWNrIGFmdGVyCisgICAgICAgIG1heGltaXppbmcuIENvbnRlbnRzUmVzaXplZCgpIGlzIG5vdCBn ZXR0aW5nIGNhbGxlZC4gSGVuY2Ugb2xkCisgICAgICAgIGRvY3VtZW50IHdpZHRoIGFuZCBoZWln aHQgYXJlIHVzZWQuIENvcnJlY3RlZCB0aGlzIGJlaGF2aW91ciBieSAKKyAgICAgICAgY2FsbGlu ZyBzZXRCb3VuZHNTaXplKCkgd2hpY2ggY2FsbHMgY29udGVudHNTaXplKCkuIAorCisgICAgICAg ICogbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lTG9hZGVy OjpvcGVuKToKKwogMjAxMS0wMy0yMSAgRG9taW5pYyBDb29uZXkgIDxkb21pbmljY0Bnb29nbGUu Y29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEplcmVteSBPcmxvdy4KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sb2Fk ZXIvRnJhbWVMb2FkZXIuY3BwCmluZGV4IDE1ODcxYzYuLjEzZmVmZTkgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv bG9hZGVyL0ZyYW1lTG9hZGVyLmNwcApAQCAtMjE5MCw4ICsyMTkwLDExIEBAIHZvaWQgRnJhbWVM b2FkZXI6Om9wZW4oQ2FjaGVkRnJhbWVCYXNlJiBjYWNoZWRGcmFtZSkKICAgICB2aWV3LT5zZXRX YXNTY3JvbGxlZEJ5VXNlcihmYWxzZSk7CiAKICAgICAvLyBVc2UgdGhlIGN1cnJlbnQgU2Nyb2xs VmlldydzIGZyYW1lIHJlY3QuCi0gICAgaWYgKG1fZnJhbWUtPnZpZXcoKSkKLSAgICAgICAgdmll dy0+c2V0RnJhbWVSZWN0KG1fZnJhbWUtPnZpZXcoKS0+ZnJhbWVSZWN0KCkpOworICAgIGlmICht X2ZyYW1lLT52aWV3KCkpIHsKKyAgICAgICAgSW50UmVjdCByZWN0ID0gbV9mcmFtZS0+dmlldygp LT5mcmFtZVJlY3QoKTsKKyAgICAgICAgdmlldy0+c2V0RnJhbWVSZWN0KHJlY3QpOworICAgICAg ICB2aWV3LT5zZXRCb3VuZHNTaXplKEludFNpemUocmVjdC53aWR0aCgpLCByZWN0LmhlaWdodCgp KSk7CisgICAgfQogICAgIG1fZnJhbWUtPnNldFZpZXcodmlldyk7CiAgICAgCiAgICAgbV9mcmFt ZS0+c2V0RG9jdW1lbnQoZG9jdW1lbnQpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9xdC9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L3F0L0NoYW5nZUxvZwppbmRleCBkZTNlODk5Li4wM2Mx ZDM1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L3F0L0NoYW5nZUxvZworKysgYi9Tb3VyY2Uv V2ViS2l0L3F0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDExLTAzLTIxICBBcGFybmEg TmFuZHlhbCAgPGFwYXJuYS5uYW5kQHdpcHJvLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIFF0V2ViS2l0IHJlbmRlcmluZyBwcm9ibGVt IHdoZW4gbWF4aW1pemluZyBhbmQgZG9pbmcgYSBiYWNrCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NjY2OQorCisgICAgICAgIEFkZGVkIGFuIGF1dG8g dGVzdC4KKyAKKyAgICAgICAgKiB0ZXN0cy9xd2Vidmlldy90c3RfcXdlYnZpZXcuY3BwOgorICAg ICAgICAodHN0X1FXZWJWaWV3OjpyZW5kZXJpbmcpOgorCiAyMDExLTAzLTE5ICBBbmRyZWFzIEts aW5nICA8a2xpbmdAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBCZW5qYW1pbiBQ b3VsYWluLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9xdC90ZXN0cy9xd2Vidmlldy90c3Rf cXdlYnZpZXcuY3BwIGIvU291cmNlL1dlYktpdC9xdC90ZXN0cy9xd2Vidmlldy90c3RfcXdlYnZp ZXcuY3BwCmluZGV4IDUzM2Q0ZTUuLjQ1OTk4NGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv cXQvdGVzdHMvcXdlYnZpZXcvdHN0X3F3ZWJ2aWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L3F0 L3Rlc3RzL3F3ZWJ2aWV3L3RzdF9xd2Vidmlldy5jcHAKQEAgLTQyLDYgKzQyLDcgQEAgcHVibGlj IHNsb3RzOgogICAgIHZvaWQgY2xlYW51cCgpOwogCiBwcml2YXRlIHNsb3RzOgorICAgIHZvaWQg cmVuZGVyaW5nKCk7CiAgICAgdm9pZCByZW5kZXJIaW50cygpOwogICAgIHZvaWQgZ2V0V2ViS2l0 VmVyc2lvbigpOwogCkBAIC00MzgsNiArNDM5LDYyIEBAIHZvaWQgdHN0X1FXZWJWaWV3OjpzZXRQ YWxldHRlKCkKICAgICBRVkVSSUZZKGltZzEgIT0gaW1nMik7CiB9CiAKK3ZvaWQgdHN0X1FXZWJW aWV3OjpyZW5kZXJpbmcoKQoreworICAgIFFVcmwgdXJsID0gUVVybCgiZGF0YTp0ZXh0L2h0bWws PGh0bWw+PGhlYWQ+PC9oZWFkPiIKKyAgICAgICAgICAgICAgICAgICAiPGJvZHkgd2lkdGg9MTAy NCBoZWlnaHQ9NzY4IGJnY29sb3I9cmVkPiIKKyAgICAgICAgICAgICAgICAgICAiPC9ib2R5PiIK KyAgICAgICAgICAgICAgICAgICAiPC9odG1sPiIpOworCisgICAgUVdlYlZpZXcgdmlldzsKKyAg ICB2aWV3LnBhZ2UoKS0+bWFpbkZyYW1lKCktPmxvYWQodXJsKTsKKyAgICB2aWV3LnNob3coKTsK KworICAgIHZpZXcucGFnZSgpLT5zZXR0aW5ncygpLT5zZXRNYXhpbXVtUGFnZXNJbkNhY2hlKDMp OworCisgICAgUVRlc3Q6OnFXYWl0Rm9yV2luZG93U2hvd24oJnZpZXcpOworCisgICAgUVBpeG1h cCByZWZlcmVuY2Uodmlldy5wYWdlKCktPnZpZXdwb3J0U2l6ZSgpKTsKKyAgICByZWZlcmVuY2Uu ZmlsbChRdDo6cmVkKTsKKworICAgIFFQaXhtYXAgaW1hZ2Uodmlldy5wYWdlKCktPnZpZXdwb3J0 U2l6ZSgpKTsKKyAgICBRUGFpbnRlciBwYWludGVyKCZpbWFnZSk7CisgICAgdmlldy5wYWdlKCkt PmN1cnJlbnRGcmFtZSgpLT5yZW5kZXIoJnBhaW50ZXIpOworCisgICAgUUNPTVBBUkUoaW1hZ2Us IHJlZmVyZW5jZSk7CisKKyAgICBRVXJsIHVybDIgPSBRVXJsKCJkYXRhOnRleHQvaHRtbCw8aHRt bD48aGVhZD48L2hlYWQ+IgorICAgICAgICAgICAgICAgICAgICAgIjxib2R5IHdpZHRoPTEwMjQg aGVpZ2h0PTc2OCBiZ2NvbG9yPWJsdWU+IgorICAgICAgICAgICAgICAgICAgICAgIjwvYm9keT4i CisgICAgICAgICAgICAgICAgICAgICAiPC9odG1sPiIpOworICAgIHZpZXcucGFnZSgpLT5tYWlu RnJhbWUoKS0+bG9hZCh1cmwyKTsKKworICAgIFFBcHBsaWNhdGlvbjo6cHJvY2Vzc0V2ZW50cygp OworCisgICAgdmlldy5zaG93TWF4aW1pemVkKCk7CisKKyAgICBRVGVzdDo6cVdhaXRGb3JXaW5k b3dTaG93bigmdmlldyk7CisKKyAgICBRUGl4bWFwIHJlZmVyZW5jZTIodmlldy5wYWdlKCktPnZp ZXdwb3J0U2l6ZSgpKTsKKyAgICByZWZlcmVuY2UyLmZpbGwoUXQ6OmJsdWUpOworCisgICAgUVBp eG1hcCBpbWFnZTIodmlldy5wYWdlKCktPnZpZXdwb3J0U2l6ZSgpKTsKKyAgICBRUGFpbnRlciBw YWludGVyMigmaW1hZ2UyKTsKKyAgICB2aWV3LnBhZ2UoKS0+Y3VycmVudEZyYW1lKCktPnJlbmRl cigmcGFpbnRlcjIpOworCisgICAgUUNPTVBBUkUoaW1hZ2UyLCByZWZlcmVuY2UyKTsKKworICAg IHZpZXcuYmFjaygpOworCisgICAgUVBpeG1hcCByZWZlcmVuY2UzKHZpZXcucGFnZSgpLT52aWV3 cG9ydFNpemUoKSk7CisgICAgcmVmZXJlbmNlMy5maWxsKFF0OjpyZWQpOworICAgIFFQaXhtYXAg aW1hZ2UzKHZpZXcucGFnZSgpLT52aWV3cG9ydFNpemUoKSk7CisgICAgUVBhaW50ZXIgcGFpbnRl cjMoJmltYWdlMyk7CisgICAgdmlldy5wYWdlKCktPmN1cnJlbnRGcmFtZSgpLT5yZW5kZXIoJnBh aW50ZXIzKTsKKworICAgIFFDT01QQVJFKGltYWdlMywgcmVmZXJlbmNlMyk7Cit9CisKIFFURVNU X01BSU4odHN0X1FXZWJWaWV3KQogI2luY2x1ZGUgInRzdF9xd2Vidmlldy5tb2MiCiAK 86367 2011-03-21 14:41:24 -0700 2011-03-23 00:42:39 -0700 Patch v02 for review patch_03 text/plain 4342 aparna.nand ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3ZWE3YjE4Li4yOTVjYWU3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTEtMDMtMjEgIEFwYXJuYSBOYW5keWFsICA8YXBhcm5hLm5hbmRAd2lwcm8uY29tPgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gUXRX ZWJLaXQgcmVuZGVyaW5nIHByb2JsZW0gd2hlbiBtYXhpbWl6aW5nIGFuZCBkb2luZyBhIGJhY2sK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU2NjY5CisK KyAgICAgICAgQ29udGVudHMgb2YgdGhlIHBhZ2UgYXJlIG5vdCByZS1zaXplZCBvbiBnb2luZyBi YWNrIGFmdGVyCisgICAgICAgIG1heGltaXppbmcuIENvbnRlbnRzUmVzaXplZCgpIGlzIG5vdCBn ZXR0aW5nIGNhbGxlZC4gSGVuY2Ugb2xkCisgICAgICAgIGRvY3VtZW50IHdpZHRoIGFuZCBoZWln aHQgYXJlIHVzZWQuIENvcnJlY3RlZCB0aGlzIGJlaGF2aW91ciBieSAKKyAgICAgICAgY2FsbGlu ZyBzZXRCb3VuZHNTaXplKCkgd2hpY2ggY2FsbHMgY29udGVudHNTaXplKCkuIAorCisgICAgICAg ICogbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lTG9hZGVy OjpvcGVuKToKKwogMjAxMS0wMy0yMSAgRG9taW5pYyBDb29uZXkgIDxkb21pbmljY0Bnb29nbGUu Y29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEplcmVteSBPcmxvdy4KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sb2Fk ZXIvRnJhbWVMb2FkZXIuY3BwCmluZGV4IDE1ODcxYzYuLjEzZmVmZTkgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv bG9hZGVyL0ZyYW1lTG9hZGVyLmNwcApAQCAtMjE5MCw4ICsyMTkwLDExIEBAIHZvaWQgRnJhbWVM b2FkZXI6Om9wZW4oQ2FjaGVkRnJhbWVCYXNlJiBjYWNoZWRGcmFtZSkKICAgICB2aWV3LT5zZXRX YXNTY3JvbGxlZEJ5VXNlcihmYWxzZSk7CiAKICAgICAvLyBVc2UgdGhlIGN1cnJlbnQgU2Nyb2xs VmlldydzIGZyYW1lIHJlY3QuCi0gICAgaWYgKG1fZnJhbWUtPnZpZXcoKSkKLSAgICAgICAgdmll dy0+c2V0RnJhbWVSZWN0KG1fZnJhbWUtPnZpZXcoKS0+ZnJhbWVSZWN0KCkpOworICAgIGlmICht X2ZyYW1lLT52aWV3KCkpIHsKKyAgICAgICAgSW50UmVjdCByZWN0ID0gbV9mcmFtZS0+dmlldygp LT5mcmFtZVJlY3QoKTsKKyAgICAgICAgdmlldy0+c2V0RnJhbWVSZWN0KHJlY3QpOworICAgICAg ICB2aWV3LT5zZXRCb3VuZHNTaXplKEludFNpemUocmVjdC53aWR0aCgpLCByZWN0LmhlaWdodCgp KSk7CisgICAgfQogICAgIG1fZnJhbWUtPnNldFZpZXcodmlldyk7CiAgICAgCiAgICAgbV9mcmFt ZS0+c2V0RG9jdW1lbnQoZG9jdW1lbnQpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9xdC9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L3F0L0NoYW5nZUxvZwppbmRleCBkZTNlODk5Li5mYzY1 M2I3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L3F0L0NoYW5nZUxvZworKysgYi9Tb3VyY2Uv V2ViS2l0L3F0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDExLTAzLTIxICBBcGFybmEg TmFuZHlhbCAgPGFwYXJuYS5uYW5kQHdpcHJvLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIFF0V2ViS2l0IHJlbmRlcmluZyBwcm9ibGVt IHdoZW4gbWF4aW1pemluZyBhbmQgZG9pbmcgYSBiYWNrCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NjY2OQorCisgICAgICAgIEFkZGVkIGFuIGF1dG8g dGVzdC4KKyAgICAgICAgUGF0Y2ggYnkgQWxleGlzIE1lbmFyZCA8IGFsZXhpcy5tZW5hcmRAbm9r aWEuY29tPiBvbiAyMDExLTAzLTIxCisgCisgICAgICAgICogdGVzdHMvcXdlYnZpZXcvdHN0X3F3 ZWJ2aWV3LmNwcDoKKyAgICAgICAgKHRzdF9RV2ViVmlldzo6cmVuZGVyaW5nKToKKwogMjAxMS0w My0xOSAgQW5kcmVhcyBLbGluZyAgPGtsaW5nQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgQmVuamFtaW4gUG91bGFpbi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvcXQvdGVz dHMvcXdlYnZpZXcvdHN0X3F3ZWJ2aWV3LmNwcCBiL1NvdXJjZS9XZWJLaXQvcXQvdGVzdHMvcXdl YnZpZXcvdHN0X3F3ZWJ2aWV3LmNwcAppbmRleCA1MzNkNGU1Li40NTk5ODRjIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0L3F0L3Rlc3RzL3F3ZWJ2aWV3L3RzdF9xd2Vidmlldy5jcHAKKysrIGIv U291cmNlL1dlYktpdC9xdC90ZXN0cy9xd2Vidmlldy90c3RfcXdlYnZpZXcuY3BwCkBAIC00Miw2 ICs0Miw3IEBAIHB1YmxpYyBzbG90czoKICAgICB2b2lkIGNsZWFudXAoKTsKIAogcHJpdmF0ZSBz bG90czoKKyAgICB2b2lkIHJlbmRlcmluZygpOwogICAgIHZvaWQgcmVuZGVySGludHMoKTsKICAg ICB2b2lkIGdldFdlYktpdFZlcnNpb24oKTsKIApAQCAtNDM4LDYgKzQzOSw2MiBAQCB2b2lkIHRz dF9RV2ViVmlldzo6c2V0UGFsZXR0ZSgpCiAgICAgUVZFUklGWShpbWcxICE9IGltZzIpOwogfQog Cit2b2lkIHRzdF9RV2ViVmlldzo6cmVuZGVyaW5nKCkKK3sKKyAgICBRVXJsIHVybCA9IFFVcmwo ImRhdGE6dGV4dC9odG1sLDxodG1sPjxoZWFkPjwvaGVhZD4iCisgICAgICAgICAgICAgICAgICAg Ijxib2R5IHdpZHRoPTEwMjQgaGVpZ2h0PTc2OCBiZ2NvbG9yPXJlZD4iCisgICAgICAgICAgICAg ICAgICAgIjwvYm9keT4iCisgICAgICAgICAgICAgICAgICAgIjwvaHRtbD4iKTsKKworICAgIFFX ZWJWaWV3IHZpZXc7CisgICAgdmlldy5wYWdlKCktPm1haW5GcmFtZSgpLT5sb2FkKHVybCk7Cisg ICAgdmlldy5zaG93KCk7CisKKyAgICB2aWV3LnBhZ2UoKS0+c2V0dGluZ3MoKS0+c2V0TWF4aW11 bVBhZ2VzSW5DYWNoZSgzKTsKKworICAgIFFUZXN0OjpxV2FpdEZvcldpbmRvd1Nob3duKCZ2aWV3 KTsKKworICAgIFFQaXhtYXAgcmVmZXJlbmNlKHZpZXcucGFnZSgpLT52aWV3cG9ydFNpemUoKSk7 CisgICAgcmVmZXJlbmNlLmZpbGwoUXQ6OnJlZCk7CisKKyAgICBRUGl4bWFwIGltYWdlKHZpZXcu cGFnZSgpLT52aWV3cG9ydFNpemUoKSk7CisgICAgUVBhaW50ZXIgcGFpbnRlcigmaW1hZ2UpOwor ICAgIHZpZXcucGFnZSgpLT5jdXJyZW50RnJhbWUoKS0+cmVuZGVyKCZwYWludGVyKTsKKworICAg IFFDT01QQVJFKGltYWdlLCByZWZlcmVuY2UpOworCisgICAgUVVybCB1cmwyID0gUVVybCgiZGF0 YTp0ZXh0L2h0bWwsPGh0bWw+PGhlYWQ+PC9oZWFkPiIKKyAgICAgICAgICAgICAgICAgICAgICI8 Ym9keSB3aWR0aD0xMDI0IGhlaWdodD03NjggYmdjb2xvcj1ibHVlPiIKKyAgICAgICAgICAgICAg ICAgICAgICI8L2JvZHk+IgorICAgICAgICAgICAgICAgICAgICAgIjwvaHRtbD4iKTsKKyAgICB2 aWV3LnBhZ2UoKS0+bWFpbkZyYW1lKCktPmxvYWQodXJsMik7CisKKyAgICBRQXBwbGljYXRpb246 OnByb2Nlc3NFdmVudHMoKTsKKworICAgIHZpZXcuc2hvd01heGltaXplZCgpOworCisgICAgUVRl c3Q6OnFXYWl0Rm9yV2luZG93U2hvd24oJnZpZXcpOworCisgICAgUVBpeG1hcCByZWZlcmVuY2Uy KHZpZXcucGFnZSgpLT52aWV3cG9ydFNpemUoKSk7CisgICAgcmVmZXJlbmNlMi5maWxsKFF0Ojpi bHVlKTsKKworICAgIFFQaXhtYXAgaW1hZ2UyKHZpZXcucGFnZSgpLT52aWV3cG9ydFNpemUoKSk7 CisgICAgUVBhaW50ZXIgcGFpbnRlcjIoJmltYWdlMik7CisgICAgdmlldy5wYWdlKCktPmN1cnJl bnRGcmFtZSgpLT5yZW5kZXIoJnBhaW50ZXIyKTsKKworICAgIFFDT01QQVJFKGltYWdlMiwgcmVm ZXJlbmNlMik7CisKKyAgICB2aWV3LmJhY2soKTsKKworICAgIFFQaXhtYXAgcmVmZXJlbmNlMyh2 aWV3LnBhZ2UoKS0+dmlld3BvcnRTaXplKCkpOworICAgIHJlZmVyZW5jZTMuZmlsbChRdDo6cmVk KTsKKyAgICBRUGl4bWFwIGltYWdlMyh2aWV3LnBhZ2UoKS0+dmlld3BvcnRTaXplKCkpOworICAg IFFQYWludGVyIHBhaW50ZXIzKCZpbWFnZTMpOworICAgIHZpZXcucGFnZSgpLT5jdXJyZW50RnJh bWUoKS0+cmVuZGVyKCZwYWludGVyMyk7CisKKyAgICBRQ09NUEFSRShpbWFnZTMsIHJlZmVyZW5j ZTMpOworfQorCiBRVEVTVF9NQUlOKHRzdF9RV2ViVmlldykKICNpbmNsdWRlICJ0c3RfcXdlYnZp ZXcubW9jIgogCg== 86582 2011-03-23 00:42:39 -0700 2011-03-23 08:54:46 -0700 Patch v03 with comments implemented patch_04 text/plain 4439 aparna.nand ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3ZWE3YjE4Li4yOTVjYWU3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTEtMDMtMjEgIEFwYXJuYSBOYW5keWFsICA8YXBhcm5hLm5hbmRAd2lwcm8uY29tPgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gUXRX ZWJLaXQgcmVuZGVyaW5nIHByb2JsZW0gd2hlbiBtYXhpbWl6aW5nIGFuZCBkb2luZyBhIGJhY2sK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU2NjY5CisK KyAgICAgICAgQ29udGVudHMgb2YgdGhlIHBhZ2UgYXJlIG5vdCByZS1zaXplZCBvbiBnb2luZyBi YWNrIGFmdGVyCisgICAgICAgIG1heGltaXppbmcuIENvbnRlbnRzUmVzaXplZCgpIGlzIG5vdCBn ZXR0aW5nIGNhbGxlZC4gSGVuY2Ugb2xkCisgICAgICAgIGRvY3VtZW50IHdpZHRoIGFuZCBoZWln aHQgYXJlIHVzZWQuIENvcnJlY3RlZCB0aGlzIGJlaGF2aW91ciBieSAKKyAgICAgICAgY2FsbGlu ZyBzZXRCb3VuZHNTaXplKCkgd2hpY2ggY2FsbHMgY29udGVudHNTaXplKCkuIAorCisgICAgICAg ICogbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lTG9hZGVy OjpvcGVuKToKKwogMjAxMS0wMy0yMSAgRG9taW5pYyBDb29uZXkgIDxkb21pbmljY0Bnb29nbGUu Y29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEplcmVteSBPcmxvdy4KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sb2Fk ZXIvRnJhbWVMb2FkZXIuY3BwCmluZGV4IDE1ODcxYzYuLjhjZmQyOTQgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv bG9hZGVyL0ZyYW1lTG9hZGVyLmNwcApAQCAtMjE5MCw4ICsyMTkwLDExIEBAIHZvaWQgRnJhbWVM b2FkZXI6Om9wZW4oQ2FjaGVkRnJhbWVCYXNlJiBjYWNoZWRGcmFtZSkKICAgICB2aWV3LT5zZXRX YXNTY3JvbGxlZEJ5VXNlcihmYWxzZSk7CiAKICAgICAvLyBVc2UgdGhlIGN1cnJlbnQgU2Nyb2xs VmlldydzIGZyYW1lIHJlY3QuCi0gICAgaWYgKG1fZnJhbWUtPnZpZXcoKSkKLSAgICAgICAgdmll dy0+c2V0RnJhbWVSZWN0KG1fZnJhbWUtPnZpZXcoKS0+ZnJhbWVSZWN0KCkpOworICAgIGlmICht X2ZyYW1lLT52aWV3KCkpIHsKKyAgICAgICAgSW50UmVjdCByZWN0ID0gbV9mcmFtZS0+dmlldygp LT5mcmFtZVJlY3QoKTsKKyAgICAgICAgdmlldy0+c2V0RnJhbWVSZWN0KHJlY3QpOworICAgICAg ICB2aWV3LT5zZXRCb3VuZHNTaXplKHJlY3Quc2l6ZSgpKTsKKyAgICB9CiAgICAgbV9mcmFtZS0+ c2V0Vmlldyh2aWV3KTsKICAgICAKICAgICBtX2ZyYW1lLT5zZXREb2N1bWVudChkb2N1bWVudCk7 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L3F0L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv cXQvQ2hhbmdlTG9nCmluZGV4IGRlM2U4OTkuLmZjNjUzYjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQvcXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTYgQEAKKzIwMTEtMDMtMjEgIEFwYXJuYSBOYW5keWFsICA8YXBhcm5hLm5hbmRAd2lw cm8uY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFtRdF0gUXRXZWJLaXQgcmVuZGVyaW5nIHByb2JsZW0gd2hlbiBtYXhpbWl6aW5nIGFuZCBkb2lu ZyBhIGJhY2sKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTU2NjY5CisKKyAgICAgICAgQWRkZWQgYW4gYXV0byB0ZXN0LgorICAgICAgICBQYXRjaCBieSBB bGV4aXMgTWVuYXJkIDwgYWxleGlzLm1lbmFyZEBub2tpYS5jb20+IG9uIDIwMTEtMDMtMjEKKyAK KyAgICAgICAgKiB0ZXN0cy9xd2Vidmlldy90c3RfcXdlYnZpZXcuY3BwOgorICAgICAgICAodHN0 X1FXZWJWaWV3OjpyZW5kZXJpbmcpOgorCiAyMDExLTAzLTE5ICBBbmRyZWFzIEtsaW5nICA8a2xp bmdAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBCZW5qYW1pbiBQb3VsYWluLgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9xdC90ZXN0cy9xd2Vidmlldy90c3RfcXdlYnZpZXcu Y3BwIGIvU291cmNlL1dlYktpdC9xdC90ZXN0cy9xd2Vidmlldy90c3RfcXdlYnZpZXcuY3BwCmlu ZGV4IDUzM2Q0ZTUuLjBmOTA1ZWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvcXQvdGVzdHMv cXdlYnZpZXcvdHN0X3F3ZWJ2aWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L3F0L3Rlc3RzL3F3 ZWJ2aWV3L3RzdF9xd2Vidmlldy5jcHAKQEAgLTQyLDYgKzQyLDcgQEAgcHVibGljIHNsb3RzOgog ICAgIHZvaWQgY2xlYW51cCgpOwogCiBwcml2YXRlIHNsb3RzOgorICAgIHZvaWQgcmVuZGVyaW5n QWZ0ZXJNYXhBbmRCYWNrKCk7CiAgICAgdm9pZCByZW5kZXJIaW50cygpOwogICAgIHZvaWQgZ2V0 V2ViS2l0VmVyc2lvbigpOwogCkBAIC00MzgsNiArNDM5LDYzIEBAIHZvaWQgdHN0X1FXZWJWaWV3 OjpzZXRQYWxldHRlKCkKICAgICBRVkVSSUZZKGltZzEgIT0gaW1nMik7CiB9CiAKK3ZvaWQgdHN0 X1FXZWJWaWV3OjpyZW5kZXJpbmdBZnRlck1heEFuZEJhY2soKQoreworICAgIFFVcmwgdXJsID0g UVVybCgiZGF0YTp0ZXh0L2h0bWwsPGh0bWw+PGhlYWQ+PC9oZWFkPiIKKyAgICAgICAgICAgICAg ICAgICAiPGJvZHkgd2lkdGg9MTAyNCBoZWlnaHQ9NzY4IGJnY29sb3I9cmVkPiIKKyAgICAgICAg ICAgICAgICAgICAiPC9ib2R5PiIKKyAgICAgICAgICAgICAgICAgICAiPC9odG1sPiIpOworCisg ICAgUVdlYlZpZXcgdmlldzsKKyAgICB2aWV3LnBhZ2UoKS0+bWFpbkZyYW1lKCktPmxvYWQodXJs KTsKKyAgICBRVkVSSUZZKHdhaXRGb3JTaWduYWwoJnZpZXcsIFNJR05BTChsb2FkRmluaXNoZWQo Ym9vbCkpKSk7CisgICAgdmlldy5zaG93KCk7CisKKyAgICB2aWV3LnBhZ2UoKS0+c2V0dGluZ3Mo KS0+c2V0TWF4aW11bVBhZ2VzSW5DYWNoZSgzKTsKKworICAgIFFUZXN0OjpxV2FpdEZvcldpbmRv d1Nob3duKCZ2aWV3KTsKKworICAgIFFQaXhtYXAgcmVmZXJlbmNlKHZpZXcucGFnZSgpLT52aWV3 cG9ydFNpemUoKSk7CisgICAgcmVmZXJlbmNlLmZpbGwoUXQ6OnJlZCk7CisKKyAgICBRUGl4bWFw IGltYWdlKHZpZXcucGFnZSgpLT52aWV3cG9ydFNpemUoKSk7CisgICAgUVBhaW50ZXIgcGFpbnRl cigmaW1hZ2UpOworICAgIHZpZXcucGFnZSgpLT5jdXJyZW50RnJhbWUoKS0+cmVuZGVyKCZwYWlu dGVyKTsKKworICAgIFFDT01QQVJFKGltYWdlLCByZWZlcmVuY2UpOworCisgICAgUVVybCB1cmwy ID0gUVVybCgiZGF0YTp0ZXh0L2h0bWwsPGh0bWw+PGhlYWQ+PC9oZWFkPiIKKyAgICAgICAgICAg ICAgICAgICAgICI8Ym9keSB3aWR0aD0xMDI0IGhlaWdodD03NjggYmdjb2xvcj1ibHVlPiIKKyAg ICAgICAgICAgICAgICAgICAgICI8L2JvZHk+IgorICAgICAgICAgICAgICAgICAgICAgIjwvaHRt bD4iKTsKKyAgICB2aWV3LnBhZ2UoKS0+bWFpbkZyYW1lKCktPmxvYWQodXJsMik7CisKKyAgICBR VkVSSUZZKHdhaXRGb3JTaWduYWwoJnZpZXcsIFNJR05BTChsb2FkRmluaXNoZWQoYm9vbCkpKSk7 CisKKyAgICB2aWV3LnNob3dNYXhpbWl6ZWQoKTsKKworICAgIFFUZXN0OjpxV2FpdEZvcldpbmRv d1Nob3duKCZ2aWV3KTsKKworICAgIFFQaXhtYXAgcmVmZXJlbmNlMih2aWV3LnBhZ2UoKS0+dmll d3BvcnRTaXplKCkpOworICAgIHJlZmVyZW5jZTIuZmlsbChRdDo6Ymx1ZSk7CisKKyAgICBRUGl4 bWFwIGltYWdlMih2aWV3LnBhZ2UoKS0+dmlld3BvcnRTaXplKCkpOworICAgIFFQYWludGVyIHBh aW50ZXIyKCZpbWFnZTIpOworICAgIHZpZXcucGFnZSgpLT5jdXJyZW50RnJhbWUoKS0+cmVuZGVy KCZwYWludGVyMik7CisKKyAgICBRQ09NUEFSRShpbWFnZTIsIHJlZmVyZW5jZTIpOworCisgICAg dmlldy5iYWNrKCk7CisKKyAgICBRUGl4bWFwIHJlZmVyZW5jZTModmlldy5wYWdlKCktPnZpZXdw b3J0U2l6ZSgpKTsKKyAgICByZWZlcmVuY2UzLmZpbGwoUXQ6OnJlZCk7CisgICAgUVBpeG1hcCBp bWFnZTModmlldy5wYWdlKCktPnZpZXdwb3J0U2l6ZSgpKTsKKyAgICBRUGFpbnRlciBwYWludGVy MygmaW1hZ2UzKTsKKyAgICB2aWV3LnBhZ2UoKS0+Y3VycmVudEZyYW1lKCktPnJlbmRlcigmcGFp bnRlcjMpOworCisgICAgUUNPTVBBUkUoaW1hZ2UzLCByZWZlcmVuY2UzKTsKK30KKwogUVRFU1Rf TUFJTih0c3RfUVdlYlZpZXcpCiAjaW5jbHVkZSAidHN0X3F3ZWJ2aWV3Lm1vYyIKIAo=