56615 2011-03-17 17:37:34 -0700 Implement PluginProcessProxy::setModalWindowIsShowing 2011-03-17 17:45:30 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 369431 0 andersca 2011-03-17 17:37:34 -0700 Implement PluginProcessProxy::setModalWindowIsShowing 369432 1 86122 andersca 2011-03-17 17:39:28 -0700 Created attachment 86122 Patch 369434 2 86122 sam 2011-03-17 17:42:50 -0700 Comment on attachment 86122 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=86122&action=review > Source/WebKit2/UIProcess/Plugins/mac/PluginProcessProxyMac.mm:45 > +} > +@end Please add a newline. 369438 3 andersca 2011-03-17 17:45:30 -0700 Committed r81418: <http://trac.webkit.org/changeset/81418> 86122 2011-03-17 17:39:28 -0700 2011-03-17 17:42:49 -0700 Patch bug-56615-20110317173927.patch text/plain 6750 andersca SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDgxNDE3KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMzMgQEAKKzIwMTEtMDMtMTcgIEFuZGVycyBD YXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBJbXBsZW1lbnQgUGx1Z2luUHJvY2Vzc1Byb3h5OjpzZXRN b2RhbFdpbmRvd0lzU2hvd2luZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NTY2MTUKKworICAgICAgICAqIFVJUHJvY2Vzcy9QbHVnaW5zL1BsdWdpblBy b2Nlc3NQcm94eS5jcHA6CisgICAgICAgIChXZWJLaXQ6OlBsdWdpblByb2Nlc3NQcm94eTo6UGx1 Z2luUHJvY2Vzc1Byb3h5KToKKyAgICAgICAgSW5pdGlhbGl6ZSBtX21vZGFsV2luZG93SXNTaG93 aW5nLgorCisgICAgICAgIChXZWJLaXQ6OlBsdWdpblByb2Nlc3NQcm94eTo6ZGlkQ2xvc2UpOgor ICAgICAgICBJZiBtX21vZGFsV2luZG93SXNTaG93aW5nIGlzIHRydWUsIHdlIG11c3QgY2FsbCBl bmRNb2RhbC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9QbHVnaW5zL21hYy9QbHVnaW5Qcm9jZXNz UHJveHlNYWMubW06CisgICAgICAgICgtW1dLUGxhY2Vob2xkZXJNb2RhbFdpbmRvdyBfd2FudHNV c2VyQXR0ZW50aW9uXSk6CisgICAgICAgIEFkZCBhIFdLUGxhY2Vob2xkZXJNb2RhbFdpbmRvdy4K KworICAgICAgICAoV2ViS2l0OjpQbHVnaW5Qcm9jZXNzUHJveHk6OnNldE1vZGFsV2luZG93SXNT aG93aW5nKToKKyAgICAgICAgQ2FsbCBiZWdpbk1vZGFsIG9yIGVuZE1vZGFsIGRlcGVuZGluZyBv biB3aGV0aGVyIHdlJ3JlIHNob3dpbmcgYSBtb2RhbCB3aW5kb3cgb3Igbm90LgorCisgICAgICAg IChXZWJLaXQ6OlBsdWdpblByb2Nlc3NQcm94eTo6YmVnaW5Nb2RhbCk6CisgICAgICAgIENyZWF0 ZSBhIGZha2Ugd2luZG93IGFuZCBzdGFydCBhIG5lc3RlZCBydW4gbG9vcC4gTGlzdGVuIGZvciBO U0FwcGxpY2F0aW9uV2lsbEJlY29tZUFjdGl2ZU5vdGlmaWNhdGlvbiBub3RpZmljYXRpb25zLgor CisgICAgICAgIChXZWJLaXQ6OlBsdWdpblByb2Nlc3NQcm94eTo6ZW5kTW9kYWwpOgorICAgICAg ICBUZWFyIGRvd24gdGhlIHdpbmRvdyBhbmQgdGhlIHJ1biBsb29wLgorCisgICAgICAgIChXZWJL aXQ6OlBsdWdpblByb2Nlc3NQcm94eTo6YXBwbGljYXRpb25EaWRCZWNvbWVBY3RpdmUpOgorICAg ICAgICBNYWtlIHN1cmUgdGhhdCB0aGUgcGx1Zy1pbiBwcm9jZXNzIGlzIGZyb250bW9zdC4KKwog MjAxMS0wMy0xNyAgSmVmZiBNaWxsZXIgIDxqZWZmbUBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2 aWV3ZWQgYnkgQWRhbSBSb2Jlbi4KSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9QbHVn aW5zL1BsdWdpblByb2Nlc3NQcm94eS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL1BsdWdpbnMvUGx1Z2luUHJvY2Vzc1Byb3h5LmNwcAkocmV2aXNpb24gODEzOTYp CisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvUGx1Z2lucy9QbHVnaW5Qcm9jZXNzUHJveHku Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC00OCw2ICs0OCw5IEBAIFBsdWdpblByb2Nlc3NQcm94eTo6 UGx1Z2luUHJvY2Vzc1Byb3h5KFAKICAgICA6IG1fcGx1Z2luUHJvY2Vzc01hbmFnZXIoUGx1Z2lu UHJvY2Vzc01hbmFnZXIpCiAgICAgLCBtX3BsdWdpbkluZm8ocGx1Z2luSW5mbykKICAgICAsIG1f bnVtUGVuZGluZ0Nvbm5lY3Rpb25SZXF1ZXN0cygwKQorI2lmIFBMQVRGT1JNKE1BQykKKyAgICAs IG1fbW9kYWxXaW5kb3dJc1Nob3dpbmcoZmFsc2UpCisjZW5kaWYKIHsKICAgICBQcm9jZXNzTGF1 bmNoZXI6OkxhdW5jaE9wdGlvbnMgbGF1bmNoT3B0aW9uczsKICAgICBsYXVuY2hPcHRpb25zLnBy b2Nlc3NUeXBlID0gUHJvY2Vzc0xhdW5jaGVyOjpQbHVnaW5Qcm9jZXNzOwpAQCAtMTQzLDYgKzE0 NiwxMSBAQCB2b2lkIFBsdWdpblByb2Nlc3NQcm94eTo6ZGlkUmVjZWl2ZU1lc3NhCiAKIHZvaWQg UGx1Z2luUHJvY2Vzc1Byb3h5OjpkaWRDbG9zZShDb3JlSVBDOjpDb25uZWN0aW9uKikKIHsKKyNp ZiBQTEFURk9STShNQUMpCisgICAgaWYgKG1fbW9kYWxXaW5kb3dJc1Nob3dpbmcpCisgICAgICAg IGVuZE1vZGFsKCk7CisjZW5kaWYKKwogICAgIHBsdWdpblByb2Nlc3NDcmFzaGVkT3JGYWlsZWRU b0xhdW5jaCgpOwogfQogCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvUGx1Z2lucy9Q bHVnaW5Qcm9jZXNzUHJveHkuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvUGx1Z2lucy9QbHVnaW5Qcm9jZXNzUHJveHkuaAkocmV2aXNpb24gODE0MTIpCisrKyBTb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvUGx1Z2lucy9QbHVnaW5Qcm9jZXNzUHJveHkuaAkod29ya2lu ZyBjb3B5KQpAQCAtMzMsNiArMzMsMTIgQEAKICNpbmNsdWRlICJQcm9jZXNzTGF1bmNoZXIuaCIK ICNpbmNsdWRlIDx3dGYvRGVxdWUuaD4KIAorI2lmIFBMQVRGT1JNKE1BQykKKyNpbmNsdWRlIDx3 dGYvUmV0YWluUHRyLmg+CitPQkpDX0NMQVNTIE5TT2JqZWN0OworT0JKQ19DTEFTUyBXS1BsYWNl aG9sZGVyTW9kYWxXaW5kb3c7CisjZW5kaWYKKwogLy8gRklYTUU6IFRoaXMgaXMgcGxhdGZvcm0g c3BlY2lmaWMuCiBuYW1lc3BhY2UgQ29yZUlQQyB7CiAgICAgY2xhc3MgTWFjaFBvcnQ7CkBAIC04 Nyw2ICs5MywxMSBAQCBwcml2YXRlOgogI2lmIFBMQVRGT1JNKE1BQykKICAgICB2b2lkIHNldE1v ZGFsV2luZG93SXNTaG93aW5nKGJvb2wpOwogICAgIHZvaWQgc2V0RnVsbHNjcmVlbldpbmRvd0lz U2hvd2luZyhib29sKTsKKworICAgIHZvaWQgYmVnaW5Nb2RhbCgpOworICAgIHZvaWQgZW5kTW9k YWwoKTsKKworICAgIHZvaWQgYXBwbGljYXRpb25EaWRCZWNvbWVBY3RpdmUoKTsKICNlbmRpZgog CiAgICAgdm9pZCBwbGF0Zm9ybUluaXRpYWxpemVQbHVnaW5Qcm9jZXNzKFBsdWdpblByb2Nlc3ND cmVhdGlvblBhcmFtZXRlcnMmIHBhcmFtZXRlcnMpOwpAQCAtMTIwLDYgKzEzMSwxMiBAQCBwcml2 YXRlOgogICAgIC8vIElmIGNyZWF0ZVBsdWdpbkNvbm5lY3Rpb24gaXMgY2FsbGVkIHdoaWxlIHRo ZSBwcm9jZXNzIGlzIHN0aWxsIGxhdW5jaGluZyB3ZSdsbCBrZWVwIGNvdW50IG9mIGl0IGFuZCBz ZW5kIGEgYnVuY2ggb2YgcmVxdWVzdHMKICAgICAvLyB3aGVuIHRoZSBwcm9jZXNzIGZpbmlzaGVz IGxhdW5jaGluZy4KICAgICB1bnNpZ25lZCBtX251bVBlbmRpbmdDb25uZWN0aW9uUmVxdWVzdHM7 CisKKyNpZiBQTEFURk9STShNQUMpCisgICAgUmV0YWluUHRyPE5TT2JqZWN0PiBtX2FjdGl2YXRp b25PYnNlcnZlcjsKKyAgICBSZXRhaW5QdHI8V0tQbGFjZWhvbGRlck1vZGFsV2luZG93ICo+IG1f cGxhY2Vob2xkZXJXaW5kb3c7CisgICAgYm9vbCBtX21vZGFsV2luZG93SXNTaG93aW5nOworI2Vu ZGlmCiB9OwogCiB9IC8vIG5hbWVzcGFjZSBXZWJLaXQKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9QbHVnaW5zL21hYy9QbHVnaW5Qcm9jZXNzUHJveHlNYWMubW0KPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1BsdWdpbnMvbWFjL1BsdWdpblByb2Nlc3NQcm94 eU1hYy5tbQkocmV2aXNpb24gODE0MTIpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvUGx1 Z2lucy9tYWMvUGx1Z2luUHJvY2Vzc1Byb3h5TWFjLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0zMSw2 ICszMSwxOSBAQAogI2ltcG9ydCAiUGx1Z2luUHJvY2Vzc0NyZWF0aW9uUGFyYW1ldGVycy5oIgog I2ltcG9ydCAiV2ViS2l0U3lzdGVtSW50ZXJmYWNlLmgiCiAKK0BpbnRlcmZhY2UgV0tQbGFjZWhv bGRlck1vZGFsV2luZG93IDogTlNXaW5kb3cgCitAZW5kCisKK0BpbXBsZW1lbnRhdGlvbiBXS1Bs YWNlaG9sZGVyTW9kYWxXaW5kb3cKKworLy8gUHJldmVudCBOU0FwcCBmcm9tIGNhbGxpbmcgcmVx dWVzdFVzZXJBdHRlbnRpb246IHdoZW4gdGhlIHdpbmRvdyBpcyBzaG93biAKKy8vIG1vZGFsbHks IGV2ZW4gaWYgdGhlIGFwcCBpcyBpbmFjdGl2ZS4gU2VlIDY4MjMwNDkuCistIChCT09MKV93YW50 c1VzZXJBdHRlbnRpb24KK3sKKyAgICByZXR1cm4gTk87ICAgCit9CitAZW5kCisKIG5hbWVzcGFj ZSBXZWJLaXQgewogICAgIAogYm9vbCBQbHVnaW5Qcm9jZXNzUHJveHk6OnBsdWdpbk5lZWRzRXhl Y3V0YWJsZUhlYXAoY29uc3QgUGx1Z2luSW5mb1N0b3JlOjpQbHVnaW4mIHBsdWdpbkluZm8pCkBA IC01Nyw3ICs3MCwxNSBAQCB2b2lkIFBsdWdpblByb2Nlc3NQcm94eTo6cGxhdGZvcm1Jbml0aWFs CiAKIHZvaWQgUGx1Z2luUHJvY2Vzc1Byb3h5OjpzZXRNb2RhbFdpbmRvd0lzU2hvd2luZyhib29s IG1vZGFsV2luZG93SXNTaG93aW5nKQogewotICAgIC8vIEZJWE1FOiBJbXBsZW1lbnQuCisgICAg aWYgKG1vZGFsV2luZG93SXNTaG93aW5nID09IG1fbW9kYWxXaW5kb3dJc1Nob3dpbmcpIAorICAg ICAgICByZXR1cm47CisgICAgCisgICAgbV9tb2RhbFdpbmRvd0lzU2hvd2luZyA9IG1vZGFsV2lu ZG93SXNTaG93aW5nOworICAgIAorICAgIGlmIChtX21vZGFsV2luZG93SXNTaG93aW5nKQorICAg ICAgICBiZWdpbk1vZGFsKCk7CisgICAgZWxzZQorICAgICAgICBlbmRNb2RhbCgpOwogfQogCiB2 b2lkIFBsdWdpblByb2Nlc3NQcm94eTo6c2V0RnVsbHNjcmVlbldpbmRvd0lzU2hvd2luZyhib29s IGZ1bGxzY3JlZW5XaW5kb3dJc1Nob3dpbmcpCkBAIC02NSw2ICs4Niw1MCBAQCB2b2lkIFBsdWdp blByb2Nlc3NQcm94eTo6c2V0RnVsbHNjcmVlbldpCiAgICAgLy8gRklYTUU6IEltcGxlbWVudC4K IH0KIAordm9pZCBQbHVnaW5Qcm9jZXNzUHJveHk6OmJlZ2luTW9kYWwoKQoreworICAgIEFTU0VS VCghbV9wbGFjZWhvbGRlcldpbmRvdyk7CisgICAgQVNTRVJUKCFtX2FjdGl2YXRpb25PYnNlcnZl cik7CisgICAgCisgICAgbV9wbGFjZWhvbGRlcldpbmRvdy5hZG9wdE5TKFtbV0tQbGFjZWhvbGRl ck1vZGFsV2luZG93IGFsbG9jXSBpbml0V2l0aENvbnRlbnRSZWN0Ok5TTWFrZVJlY3QoMCwgMCwg MSwgMSkgc3R5bGVNYXNrOk5TQm9yZGVybGVzc1dpbmRvd01hc2sgYmFja2luZzpOU0JhY2tpbmdT dG9yZUJ1ZmZlcmVkIGRlZmVyOllFU10pOworICAgIAorICAgIG1fYWN0aXZhdGlvbk9ic2VydmVy ID0gW1tOU05vdGlmaWNhdGlvbkNlbnRlciBkZWZhdWx0Q2VudGVyXSBhZGRPYnNlcnZlckZvck5h bWU6TlNBcHBsaWNhdGlvbldpbGxCZWNvbWVBY3RpdmVOb3RpZmljYXRpb24gb2JqZWN0Ok5TQXBw IHF1ZXVlOm5pbAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVzaW5nQmxvY2s6XihOU05vdGlmaWNhdGlvbiAq KXsgYXBwbGljYXRpb25EaWRCZWNvbWVBY3RpdmUoKTsgfV07CisgICAgCisgICAgW05TQXBwIHJ1 bk1vZGFsRm9yV2luZG93Om1fcGxhY2Vob2xkZXJXaW5kb3cuZ2V0KCldOworICAgIAorICAgIFtt X3BsYWNlaG9sZGVyV2luZG93LmdldCgpIG9yZGVyT3V0Om5pbF07CisgICAgbV9wbGFjZWhvbGRl cldpbmRvdyA9IG51bGxwdHI7Cit9CisKK3ZvaWQgUGx1Z2luUHJvY2Vzc1Byb3h5OjplbmRNb2Rh bCgpCit7CisgICAgQVNTRVJUKG1fcGxhY2Vob2xkZXJXaW5kb3cpOworICAgIEFTU0VSVChtX2Fj dGl2YXRpb25PYnNlcnZlcik7CisgICAgCisgICAgW1tOU05vdGlmaWNhdGlvbkNlbnRlciBkZWZh dWx0Q2VudGVyXSByZW1vdmVPYnNlcnZlcjptX2FjdGl2YXRpb25PYnNlcnZlci5nZXQoKV07Cisg ICAgbV9hY3RpdmF0aW9uT2JzZXJ2ZXIgPSBudWxscHRyOworICAgIAorICAgIFtOU0FwcCBzdG9w TW9kYWxdOworICAgIAorICAgIC8vIE1ha2Ugb3Vyc2VsdmVzIHRoZSBmcm9udCBwcm9jZXNzLgor ICAgIFByb2Nlc3NTZXJpYWxOdW1iZXIgcHJvY2Vzc1NlcmlhbE51bWJlcjsKKyAgICBHZXRDdXJy ZW50UHJvY2VzcygmcHJvY2Vzc1NlcmlhbE51bWJlcik7CisgICAgU2V0RnJvbnRQcm9jZXNzKCZw cm9jZXNzU2VyaWFsTnVtYmVyKTsgICAgICAgICAgICAKK30KKyAgICAKK3ZvaWQgUGx1Z2luUHJv Y2Vzc1Byb3h5OjphcHBsaWNhdGlvbkRpZEJlY29tZUFjdGl2ZSgpCit7CisgICAgcGlkX3QgcGx1 Z2luUHJvY2Vzc1BJRCA9IG1fcHJvY2Vzc0xhdW5jaGVyLT5wcm9jZXNzSWRlbnRpZmllcigpOwor ICAgIFByb2Nlc3NTZXJpYWxOdW1iZXIgcHJvY2Vzc1NlcmlhbE51bWJlcjsKKworICAgIGlmIChH ZXRQcm9jZXNzRm9yUElEKHBsdWdpblByb2Nlc3NQSUQsICZwcm9jZXNzU2VyaWFsTnVtYmVyKSAh PSBub0VycikKKyAgICAgICAgcmV0dXJuOworCisgICAgU2V0RnJvbnRQcm9jZXNzKCZwcm9jZXNz U2VyaWFsTnVtYmVyKTsKK30KKworCiB9IC8vIG5hbWVzcGFjZSBXZWJLaXQKIAogI2VuZGlmIC8v IEVOQUJMRShQTFVHSU5fUFJPQ0VTUykK