56612 2011-03-17 17:01:03 -0700 Web page shouldn't swallow alt-key combinations on Windows 2011-03-17 17:12:33 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC Windows 7 RESOLVED FIXED P2 Normal --- 1 jeffm jeffm aroben oldest_to_newest 369415 0 jeffm 2011-03-17 17:01:03 -0700 With the exception of Alt+Left Arrow and Alt+Right arrow to go back and forward (which seems to be a standard convention on Windows), web pages shouldn't swallow alt-key combinations, these should bubble up to the client. 369417 1 86118 jeffm 2011-03-17 17:05:05 -0700 Created attachment 86118 Patch 369420 2 86118 aroben 2011-03-17 17:09:17 -0700 Comment on attachment 86118 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=86118&action=review What about Control-key combinations? > Source/WebKit2/ChangeLog:9 > + sure any alt-key combinations bubble up to the client. I think you mean "any other alt-key combinations". 369421 3 jeffm 2011-03-17 17:10:52 -0700 (In reply to comment #2) > (From update of attachment 86118 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=86118&action=review > > What about Control-key combinations? > > > Source/WebKit2/ChangeLog:9 > > + sure any alt-key combinations bubble up to the client. > > I think you mean "any other alt-key combinations". Yes I did, thanks. 369424 4 jeffm 2011-03-17 17:11:56 -0700 Committed r81416: <http://trac.webkit.org/changeset/81416> 369425 5 aroben 2011-03-17 17:12:33 -0700 (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 86118 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=86118&action=review > > > > What about Control-key combinations? So what's the answer to this? 86118 2011-03-17 17:05:05 -0700 2011-03-17 17:09:17 -0700 Patch bug-56612-20110317170503.patch text/plain 3043 jeffm SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDgxNDExKQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDMtMTcgIEplZmYgTWls bGVyICA8amVmZm1AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFdlYiBwYWdlIHNob3VsZG4ndCBzd2FsbG93IGFsdC1rZXkgY29tYmlu YXRpb25zIG9uIFdpbmRvd3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTU2NjEyCisgICAgICAgIAorICAgICAgICBNYWtlIEFsdCtMZWZ0IEFycm93IGFu ZCBBbHQrUmlnaHQgQXJyb3cgZ28gYmFjayBhbmQgZm9yd2FyZCwgYnV0IG1ha2UKKyAgICAgICAg c3VyZSBhbnkgYWx0LWtleSBjb21iaW5hdGlvbnMgYnViYmxlIHVwIHRvIHRoZSBjbGllbnQuCisK KyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2Uvd2luL1dlYlBhZ2VXaW4uY3BwOgorICAgICAg ICAoV2ViS2l0OjpXZWJQYWdlOjpwZXJmb3JtRGVmYXVsdEJlaGF2aW9yRm9yS2V5RXZlbnQpOiBN YWtlIEFsdCtMZWZ0IEFycm93IGFuZCBBbHQrUmlnaHQgQXJyb3cgZ28gYmFjayBhbmQgZm9yd2Fy ZCwgaWdub3JlIG90aGVyIGFsdC1rZXkgY29tYmluYXRpb25zLgorCiAyMDExLTAzLTE3ICBTYW0g V2VpbmlnICA8c2FtQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQnJhZHkgRWlk c29uLgpJbmRleDogU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL3dpbi9XZWJQYWdl V2luLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2Uv d2luL1dlYlBhZ2VXaW4uY3BwCShyZXZpc2lvbiA4MTM5OCkKKysrIFNvdXJjZS9XZWJLaXQyL1dl YlByb2Nlc3MvV2ViUGFnZS93aW4vV2ViUGFnZVdpbi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTIw OSwzMyArMjA5LDUzIEBAIGJvb2wgV2ViUGFnZTo6cGVyZm9ybURlZmF1bHRCZWhhdmlvckZvcksK IAogICAgIHN3aXRjaCAoa2V5Ym9hcmRFdmVudC53aW5kb3dzVmlydHVhbEtleUNvZGUoKSkgewog ICAgIGNhc2UgVktfQkFDSzoKKyAgICAgICAgaWYgKGtleWJvYXJkRXZlbnQuaXNTeXN0ZW1LZXko KSkKKyAgICAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICAgICAgaWYgKGtleWJvYXJkRXZlbnQu c2hpZnRLZXkoKSkKICAgICAgICAgICAgIG1fcGFnZS0+Z29Gb3J3YXJkKCk7CiAgICAgICAgIGVs c2UKICAgICAgICAgICAgIG1fcGFnZS0+Z29CYWNrKCk7CiAgICAgICAgIGJyZWFrOwogICAgIGNh c2UgVktfTEVGVDoKLSAgICAgICAgc2Nyb2xsKG1fcGFnZS5nZXQoKSwgU2Nyb2xsTGVmdCwgU2Ny b2xsQnlMaW5lKTsKKyAgICAgICAgaWYgKGtleWJvYXJkRXZlbnQuaXNTeXN0ZW1LZXkoKSkKKyAg ICAgICAgICAgIG1fcGFnZS0+Z29CYWNrKCk7CisgICAgICAgIGVsc2UKKyAgICAgICAgICAgIHNj cm9sbChtX3BhZ2UuZ2V0KCksIFNjcm9sbExlZnQsIFNjcm9sbEJ5TGluZSk7CiAgICAgICAgIGJy ZWFrOwogICAgIGNhc2UgVktfUklHSFQ6Ci0gICAgICAgIHNjcm9sbChtX3BhZ2UuZ2V0KCksIFNj cm9sbFJpZ2h0LCBTY3JvbGxCeUxpbmUpOworICAgICAgICBpZiAoa2V5Ym9hcmRFdmVudC5pc1N5 c3RlbUtleSgpKQorICAgICAgICAgICAgbV9wYWdlLT5nb0ZvcndhcmQoKTsKKyAgICAgICAgZWxz ZQorICAgICAgICAgICAgc2Nyb2xsKG1fcGFnZS5nZXQoKSwgU2Nyb2xsUmlnaHQsIFNjcm9sbEJ5 TGluZSk7CiAgICAgICAgIGJyZWFrOwogICAgIGNhc2UgVktfVVA6CisgICAgICAgIGlmIChrZXli b2FyZEV2ZW50LmlzU3lzdGVtS2V5KCkpCisgICAgICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAg ICAgIHNjcm9sbChtX3BhZ2UuZ2V0KCksIFNjcm9sbFVwLCBTY3JvbGxCeUxpbmUpOwogICAgICAg ICBicmVhazsKICAgICBjYXNlIFZLX0RPV046CisgICAgICAgIGlmIChrZXlib2FyZEV2ZW50Lmlz U3lzdGVtS2V5KCkpCisgICAgICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgICAgIHNjcm9sbCht X3BhZ2UuZ2V0KCksIFNjcm9sbERvd24sIFNjcm9sbEJ5TGluZSk7CiAgICAgICAgIGJyZWFrOwog ICAgIGNhc2UgVktfSE9NRToKKyAgICAgICAgaWYgKGtleWJvYXJkRXZlbnQuaXNTeXN0ZW1LZXko KSkKKyAgICAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICAgICAgbG9naWNhbFNjcm9sbChtX3Bh Z2UuZ2V0KCksIFNjcm9sbEJsb2NrRGlyZWN0aW9uQmFja3dhcmQsIFNjcm9sbEJ5RG9jdW1lbnQp OwogICAgICAgICBicmVhazsKICAgICBjYXNlIFZLX0VORDoKKyAgICAgICAgaWYgKGtleWJvYXJk RXZlbnQuaXNTeXN0ZW1LZXkoKSkKKyAgICAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICAgICAg bG9naWNhbFNjcm9sbChtX3BhZ2UuZ2V0KCksIFNjcm9sbEJsb2NrRGlyZWN0aW9uRm9yd2FyZCwg U2Nyb2xsQnlEb2N1bWVudCk7CiAgICAgICAgIGJyZWFrOwogICAgIGNhc2UgVktfUFJJT1I6Cisg ICAgICAgIGlmIChrZXlib2FyZEV2ZW50LmlzU3lzdGVtS2V5KCkpCisgICAgICAgICAgICByZXR1 cm4gZmFsc2U7CiAgICAgICAgIGxvZ2ljYWxTY3JvbGwobV9wYWdlLmdldCgpLCBTY3JvbGxCbG9j a0RpcmVjdGlvbkJhY2t3YXJkLCBTY3JvbGxCeVBhZ2UpOwogICAgICAgICBicmVhazsKICAgICBj YXNlIFZLX05FWFQ6CisgICAgICAgIGlmIChrZXlib2FyZEV2ZW50LmlzU3lzdGVtS2V5KCkpCisg ICAgICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgICAgIGxvZ2ljYWxTY3JvbGwobV9wYWdlLmdl dCgpLCBTY3JvbGxCbG9ja0RpcmVjdGlvbkZvcndhcmQsIFNjcm9sbEJ5UGFnZSk7CiAgICAgICAg IGJyZWFrOwogICAgIGRlZmF1bHQ6Cg==