56607 2011-03-17 16:01:13 -0700 RequestAnimationFrame callbacks prevent Document from being released on detach 2011-03-17 17:02:33 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 zmo zmo abarth jamesr kbr vangelis oldest_to_newest 369368 0 zmo 2011-03-17 16:01:13 -0700 This is also reported in crbug: http://code.google.com/p/chromium/issues/detail?id=74636 After a discussion with Adam, it seems like using ActiveDOMObject for RequestAnimationFrameCallback is the proper way, however, delete callbacks on Document::detach also fixes this memory holding. Let's get the quick/simple fix in now and merge back to chrome M10 and M11, then we can do the proper ActiveDOMObject thing on the top of the tree. 369372 1 86107 zmo 2011-03-17 16:04:48 -0700 Created attachment 86107 Patch 369379 2 86107 abarth 2011-03-17 16:14:15 -0700 Comment on attachment 86107 Patch Can you add a FIXME comment to both these locations saying that we should consider using ActiveDOMObject in the future? 369381 3 zmo 2011-03-17 16:15:24 -0700 Will do upon landing. 369389 4 zmo 2011-03-17 16:26:52 -0700 Committed r81407: <http://trac.webkit.org/changeset/81407> 369397 5 jamesr 2011-03-17 16:39:01 -0700 As a nit, I personally like .clear() instead of = 0 to null out an OwnPtr<>'s reference. As for ActiveDOMObject you are all welcome to debate ap@ on that point but I'm not inclined to jump on that grenade again. 369416 6 zmo 2011-03-17 17:02:33 -0700 (In reply to comment #5) > As a nit, I personally like .clear() instead of = 0 to null out an OwnPtr<>'s reference. > > As for ActiveDOMObject you are all welcome to debate ap@ on that point but I'm not inclined to jump on that grenade again. Feel free to change it, and thanks for the warning of the grenade. :) 86107 2011-03-17 16:04:48 -0700 2011-03-17 16:14:15 -0700 Patch bug-56607-20110317160446.patch text/plain 1558 zmo SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDgxMzk4KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDMtMTcgIFpoZW55YW8g TW8gIDx6bW9AZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBSZXF1ZXN0QW5pbWF0aW9uRnJhbWUgY2FsbGJhY2tzIHByZXZlbnQgRG9j dW1lbnQgZnJvbSBiZWluZyByZWxlYXNlZCBvbiBkZXRhY2gKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU2NjA3CisKKyAgICAgICAgKiBkb20vRG9jdW1l bnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnQ6OnJlbW92ZWRMYXN0UmVmKTogUmVt b3ZlIFJlcXVlc3RBbmltYXRpb25GcmFtZUNhbGxiYWNrIGRhdGEuCisgICAgICAgIChXZWJDb3Jl OjpEb2N1bWVudDo6ZGV0YWNoKTogRGl0dG8uCisKIDIwMTEtMDMtMTcgIEplZmYgTWlsbGVyICA8 amVmZm1AYXBwbGUuY29tPgogCiAgICAgICAgIFVzZSBhIGNvbnNpc3RlbnQgc2V0IG9mIGZpbGUg cGF0dGVybnMgaW4gdGhlIHN2bjppZ25vcmUgcHJvcGVydHkgZm9yIGFsbCAueGNvZGVwcm9qIGRp cmVjdG9yaWVzLCBzcGVjaWZpY2FsbHk6CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1l bnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAJKHJl dmlzaW9uIDgxMTM0KQorKysgU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtNTQ1LDYgKzU0NSwxMCBAQCB2b2lkIERvY3VtZW50OjpyZW1vdmVkTGFzdFJl ZigpCiAKICAgICAgICAgbV9jc3NDYW52YXNFbGVtZW50cy5jbGVhcigpOwogCisjaWYgRU5BQkxF KFJFUVVFU1RfQU5JTUFUSU9OX0ZSQU1FKQorICAgICAgICBtX3NjcmlwdGVkQW5pbWF0aW9uQ29u dHJvbGxlciA9IDA7CisjZW5kaWYKKwogI2lmbmRlZiBOREVCVUcKICAgICAgICAgbV9pblJlbW92 ZWRMYXN0UmVmRnVuY3Rpb24gPSBmYWxzZTsKICNlbmRpZgpAQCAtMTc1NSw3ICsxNzU5LDExIEBA IHZvaWQgRG9jdW1lbnQ6OmRldGFjaCgpCiAKICAgICBjbGVhckFYT2JqZWN0Q2FjaGUoKTsKICAg ICBzdG9wQWN0aXZlRE9NT2JqZWN0cygpOwotICAgIAorCisjaWYgRU5BQkxFKFJFUVVFU1RfQU5J TUFUSU9OX0ZSQU1FKQorICAgIG1fc2NyaXB0ZWRBbmltYXRpb25Db250cm9sbGVyID0gMDsKKyNl bmRpZgorCiAgICAgUmVuZGVyT2JqZWN0KiByZW5kZXIgPSByZW5kZXJlcigpOwogCiAgICAgLy8g U2VuZCBvdXQgZG9jdW1lbnRXaWxsQmVjb21lSW5hY3RpdmUoKSBub3RpZmljYXRpb25zIHRvIHJl Z2lzdGVyZWQgZWxlbWVudHMsCg==