56605 2011-03-17 16:00:30 -0700 Allow passing a certificate chain as a user message 2011-03-17 16:07:24 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 sam sam webkit.review.bot oldest_to_newest 369366 0 sam 2011-03-17 16:00:30 -0700 Allow passing a certificate chain as a user message 369369 1 86106 sam 2011-03-17 16:02:25 -0700 Created attachment 86106 Patch 369371 2 webkit.review.bot 2011-03-17 16:04:35 -0700 Attachment 86106 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/Shared/UserMessageCoders.h:35: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 369374 3 sam 2011-03-17 16:07:24 -0700 Landed in r81400. 86106 2011-03-17 16:02:25 -0700 2011-03-17 16:06:15 -0700 Patch bug-56605-20110317160224.patch text/plain 4234 sam SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDgxMzk4KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMDMtMTcgIFNhbSBXZWlu aWcgIDxzYW1Ad2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBBbGxvdyBwYXNzaW5nIGEgY2VydGlmaWNhdGUgY2hhaW4gYXMgYSB1c2Vy IG1lc3NhZ2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTU2NjA1CisKKyAgICAgICAgKiBTaGFyZWQvQVBJL2MvbWFjL1dLQ2VydGlmaWNhdGVJbmZvTWFj Lmg6CisgICAgICAgICogU2hhcmVkL0FQSS9jL21hYy9XS0NlcnRpZmljYXRlSW5mb01hYy5tbToK KyAgICAgICAgKFdLQ2VydGlmaWNhdGVJbmZvQ3JlYXRlV2l0aENlcnRmaWNhdGVDaGFpbik6Cisg ICAgICAgIEFkZGVkLiBDcmVhdGVzIGEgV0tDZXJ0aWZpY2F0ZSBmcm9tIGEgY2VydGlmaWNhdGUg Y2hhaW4uCisKKyAgICAgICAgKiBTaGFyZWQvVXNlck1lc3NhZ2VDb2RlcnMuaDoKKyAgICAgICAg KFdlYktpdDo6VXNlck1lc3NhZ2VFbmNvZGVyOjpiYXNlRW5jb2RlKToKKyAgICAgICAgKFdlYktp dDo6VXNlck1lc3NhZ2VEZWNvZGVyOjpiYXNlRGVjb2RlKToKKyAgICAgICAgQWRkIGVuY29kaW5n L2RlY29kaW5nIG9mIFdlYkNlcnRpZmljYXRlSW5mby4KKwogMjAxMS0wMy0xNyAgQW5kZXJzIENh cmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNhbSBX ZWluaWcuCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvVXNlck1lc3NhZ2VDb2RlcnMuaAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvVXNlck1lc3NhZ2VDb2RlcnMuaAko cmV2aXNpb24gODEzOTgpCisrKyBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvVXNlck1lc3NhZ2VDb2Rl cnMuaAkod29ya2luZyBjb3B5KQpAQCAtMzIsNiArMzIsNyBAQAogI2luY2x1ZGUgIkltbXV0YWJs ZURpY3Rpb25hcnkuaCIKICNpbmNsdWRlICJTaGFyZWFibGVCaXRtYXAuaCIKICNpbmNsdWRlICJX ZWJDb3JlQXJndW1lbnRDb2RlcnMuaCIKKyNpbmNsdWRlICJXZWJDZXJ0aWZpY2F0ZUluZm8uaCIK ICNpbmNsdWRlICJXZWJEYXRhLmgiCiAjaW5jbHVkZSAiV2ViSW1hZ2UuaCIKICNpbmNsdWRlICJX ZWJOdW1iZXIuaCIKQEAgLTQ4LDYgKzQ5LDcgQEAgbmFtZXNwYWNlIFdlYktpdCB7CiAvLyAgIC0g U2VyaWFsaXplZFNjcmlwdFZhbHVlIC0+IFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZQogLy8gICAtIFN0 cmluZyAtPiBTdHJpbmcKIC8vICAgLSBVc2VyQ29udGVudFVSTFBhdHRlcm4gLT4gVXNlckNvbnRl bnRVUkxQYXR0ZXJuCisvLyAgIC0gV2ViQ2VydGlmaWNhdGVJbmZvIC0+IFdlYkNlcnRpZmljYXRl SW5mbwogLy8gICAtIFdlYkRhdGEgLT4gV2ViRGF0YQogLy8gICAtIFdlYkRvdWJsZSAtPiBXZWJE b3VibGUKIC8vICAgLSBXZWJJbWFnZSAtPiBXZWJJbWFnZQpAQCAtMTQ1LDYgKzE0NywxMSBAQCBw dWJsaWM6CiAgICAgICAgICAgICBlbmNvZGVyLT5lbmNvZGVCeXRlcyhkYXRhLT5ieXRlcygpLCBk YXRhLT5zaXplKCkpOwogICAgICAgICAgICAgcmV0dXJuIHRydWU7CiAgICAgICAgIH0KKyAgICAg ICAgY2FzZSBBUElPYmplY3Q6OlR5cGVDZXJ0aWZpY2F0ZUluZm86IHsKKyAgICAgICAgICAgIFdl YkNlcnRpZmljYXRlSW5mbyogY2VydGlmaWNhdGVJbmZvID0gc3RhdGljX2Nhc3Q8V2ViQ2VydGlm aWNhdGVJbmZvKj4obV9yb290KTsKKyAgICAgICAgICAgIGVuY29kZXItPmVuY29kZShjZXJ0aWZp Y2F0ZUluZm8tPnBsYXRmb3JtQ2VydGlmaWNhdGVJbmZvKCkpOworICAgICAgICAgICAgcmV0dXJu IHRydWU7CisgICAgICAgIH0KICAgICAgICAgZGVmYXVsdDoKICAgICAgICAgICAgIGJyZWFrOwog ICAgICAgICB9CkBAIC0xNjksNiArMTc2LDcgQEAgcHJvdGVjdGVkOgogLy8gICAtIFNlcmlhbGl6 ZWRTY3JpcHRWYWx1ZSAtPiBTZXJpYWxpemVkU2NyaXB0VmFsdWUKIC8vICAgLSBTdHJpbmcgLT4g U3RyaW5nCiAvLyAgIC0gVXNlckNvbnRlbnRVUkxQYXR0ZXJuIC0+IFVzZXJDb250ZW50VVJMUGF0 dGVybgorLy8gICAtIFdlYkNlcnRpZmljYXRlSW5mbyAtPiBXZWJDZXJ0aWZpY2F0ZUluZm8KIC8v ICAgLSBXZWJEYXRhIC0+IFdlYkRhdGEKIC8vICAgLSBXZWJEb3VibGUgLT4gV2ViRG91YmxlCiAv LyAgIC0gV2ViSW1hZ2UgLT4gV2ViSW1hZ2UKQEAgLTMwMyw3ICszMTEsMTMgQEAgcHVibGljOgog ICAgICAgICAgICAgY29kZXIubV9yb290ID0gV2ViRGF0YTo6Y3JlYXRlKGJ1ZmZlcik7CiAgICAg ICAgICAgICBicmVhazsKICAgICAgICAgfQotCisgICAgICAgIGNhc2UgQVBJT2JqZWN0OjpUeXBl Q2VydGlmaWNhdGVJbmZvOiB7CisgICAgICAgICAgICBQbGF0Zm9ybUNlcnRpZmljYXRlSW5mbyBw bGF0Zm9ybUNlcnRpZmljYXRlSW5mbzsKKyAgICAgICAgICAgIGlmICghZGVjb2Rlci0+ZGVjb2Rl KHBsYXRmb3JtQ2VydGlmaWNhdGVJbmZvKSkKKyAgICAgICAgICAgICAgICByZXR1cm4gZmFsc2U7 CisgICAgICAgICAgICBjb2Rlci5tX3Jvb3QgPSBXZWJDZXJ0aWZpY2F0ZUluZm86OmNyZWF0ZShw bGF0Zm9ybUNlcnRpZmljYXRlSW5mbyk7CisgICAgICAgICAgICBicmVhazsKKyAgICAgICAgfQog ICAgICAgICBkZWZhdWx0OgogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIH0KSW5kZXg6IFNv dXJjZS9XZWJLaXQyL1NoYXJlZC9BUEkvYy9tYWMvV0tDZXJ0aWZpY2F0ZUluZm9NYWMuaAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvQVBJL2MvbWFjL1dLQ2VydGlmaWNhdGVJ bmZvTWFjLmgJKHJldmlzaW9uIDgxMzk4KQorKysgU291cmNlL1dlYktpdDIvU2hhcmVkL0FQSS9j L21hYy9XS0NlcnRpZmljYXRlSW5mb01hYy5oCSh3b3JraW5nIGNvcHkpCkBAIC0zMyw2ICszMyw3 IEBACiBleHRlcm4gIkMiIHsKICNlbmRpZgogCitXS19FWFBPUlQgV0tDZXJ0aWZpY2F0ZUluZm9S ZWYgV0tDZXJ0aWZpY2F0ZUluZm9DcmVhdGVXaXRoQ2VydGZpY2F0ZUNoYWluKENGQXJyYXlSZWYg Y2VydGlmaWNhdGVDaGFpbik7CiBXS19FWFBPUlQgQ0ZBcnJheVJlZiBXS0NlcnRpZmljYXRlSW5m b0dldENlcnRpZmljYXRlQ2hhaW4oV0tDZXJ0aWZpY2F0ZUluZm9SZWYgY2VydGlmaWNhdGVJbmZv KTsKIAogI2lmZGVmIF9fY3BsdXNwbHVzCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvQVBJ L2MvbWFjL1dLQ2VydGlmaWNhdGVJbmZvTWFjLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQyL1NoYXJlZC9BUEkvYy9tYWMvV0tDZXJ0aWZpY2F0ZUluZm9NYWMubW0JKHJldmlzaW9uIDgx Mzk4KQorKysgU291cmNlL1dlYktpdDIvU2hhcmVkL0FQSS9jL21hYy9XS0NlcnRpZmljYXRlSW5m b01hYy5tbQkod29ya2luZyBjb3B5KQpAQCAtMzEsNiArMzEsMTIgQEAKIAogdXNpbmcgbmFtZXNw YWNlIFdlYktpdDsKIAorV0tDZXJ0aWZpY2F0ZUluZm9SZWYgV0tDZXJ0aWZpY2F0ZUluZm9DcmVh dGVXaXRoQ2VydGZpY2F0ZUNoYWluKENGQXJyYXlSZWYgY2VydGlmaWNhdGVDaGFpbikKK3sKKyAg ICBSZWZQdHI8V2ViQ2VydGlmaWNhdGVJbmZvPiBjZXJ0aWZpY2F0ZUluZm8gPSBXZWJDZXJ0aWZp Y2F0ZUluZm86OmNyZWF0ZShQbGF0Zm9ybUNlcnRpZmljYXRlSW5mbyhjZXJ0aWZpY2F0ZUNoYWlu KSk7CisgICAgcmV0dXJuIHRvQVBJKGNlcnRpZmljYXRlSW5mby5yZWxlYXNlKCkubGVha1JlZigp KTsKK30KKwogQ0ZBcnJheVJlZiBXS0NlcnRpZmljYXRlSW5mb0dldENlcnRpZmljYXRlQ2hhaW4o V0tDZXJ0aWZpY2F0ZUluZm9SZWYgY2VydGlmaWNhdGVJbmZvUmVmKQogewogICAgIHJldHVybiB0 b0ltcGwoY2VydGlmaWNhdGVJbmZvUmVmKS0+cGxhdGZvcm1DZXJ0aWZpY2F0ZUluZm8oKS5jZXJ0 aWZpY2F0ZUNoYWluKCk7Cg==