56596 2011-03-17 14:45:54 -0700 Overlay scrollbars sometimes fail to appear 2011-03-17 16:22:53 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED InRadar P2 Normal --- 1 bdakin bdakin bdakin oldest_to_newest 369313 0 bdakin 2011-03-17 14:45:54 -0700 * SUMMARY The overlay scrollbars fail to appear sometimes… it is pretty reproducible, and has something to do with beginning a scroll while they scrollbars are fading out. * STEPS TO REPRODUCE 1. Using a build with overlay scrollbars, go to a website with a vertical scrollbar 2. Use trackpad to scroll 3. Briefly stop scrolling; leave your 2 fingers on the trackpad 4. When the scrollbars start to fade away, resume scrolling * RESULTS If you time it just right, the scrollbars won't re-appear. You can scroll just fine, there is just no visual scrollbar. <rdar://problem/8953779> Patch forthcoming. 369314 1 86097 bdakin 2011-03-17 14:48:01 -0700 Created attachment 86097 Patch 369385 2 86097 darin 2011-03-17 16:20:01 -0700 Comment on attachment 86097 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=86097&action=review > Source/WebCore/platform/mac/ScrollAnimatorMac.mm:401 > + [[NSAnimationContext currentContext] setDuration:duration]; It’s a little weird that we have to pass the duration here and also to the animation. 369387 3 bdakin 2011-03-17 16:22:53 -0700 Thanks, Darin! Committed with revision 81406. 86097 2011-03-17 14:48:01 -0700 2011-03-17 16:20:01 -0700 Patch for-review.txt text/plain 2834 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDgxMzg3KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDMtMTcgIEJldGggRGFr aW4gIDxiZGFraW5AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEZpeCBmb3IgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTU2NTk2IE92ZXJsYXkgc2Nyb2xsYmFycyBzb21ldGltZXMgCisgICAgICAgIGZhaWwg dG8gYXBwZWFyCisgICAgICAgIC1hbmQgY29ycmVzcG9uZGluZy0KKyAgICAgICAgPHJkYXI6Ly9w cm9ibGVtLzg5NTM3Nzk+CisKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvU2Nyb2xsQW5pbWF0b3JN YWMubW06CisgICAgICAgICgtW1Njcm9sbGJhclBhaW50ZXJEZWxlZ2F0ZSBzZXRVcEFuaW1hdGlv bjpzY3JvbGxlclBhaW50ZXI6cGFydDpXZWJDb3JlOjphbmltYXRlQWxwaGFUbzpkdXJhdGlvbjpd KToKKwogMjAxMS0wMy0xNyAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAg ICAgICBSZXZpZXdlZCBieSBBZGVsZSBQZXRlcnNvbiBhbmQgRW5yaWNhIENhc3VjY2kuCkluZGV4 OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvU2Nyb2xsQW5pbWF0b3JNYWMubW0KPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL1Njcm9sbEFuaW1hdG9yTWFjLm1t CShyZXZpc2lvbiA4MTM3NikKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9TY3JvbGxB bmltYXRvck1hYy5tbQkod29ya2luZyBjb3B5KQpAQCAtMzc2LDEzICszNzYsOCBAQCAtIChDQUxh eWVyICopbGF5ZXIKIAogLSAodm9pZClzZXRVcEFuaW1hdGlvbjooUmV0YWluUHRyPFNjcm9sbGJh clBhcnRBbmltYXRpb24+JilzY3JvbGxiYXJQYXJ0QW5pbWF0aW9uIHNjcm9sbGVyUGFpbnRlcjoo V0tTY3JvbGxiYXJQYWludGVyUmVmKXNjcm9sbGVyUGFpbnRlciBwYXJ0OihXZWJDb3JlOjpTY3Jv bGxiYXJQYXJ0KXBhcnQgYW5pbWF0ZUFscGhhVG86KENHRmxvYXQpbmV3QWxwaGEgZHVyYXRpb246 KE5TVGltZUludGVydmFsKWR1cmF0aW9uCiB7Ci0gICAgQ0dGbG9hdCBjdXJyZW50QWxwaGEgPSBw YXJ0ID09IFdlYkNvcmU6OlRodW1iUGFydCA/IHdrU2Nyb2xsYmFyUGFpbnRlcktub2JBbHBoYShz Y3JvbGxlclBhaW50ZXIpCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgOiB3a1Njcm9sbGJh clBhaW50ZXJUcmFja0FscGhhKHNjcm9sbGVyUGFpbnRlcik7Ci0gICAgaWYgKG5ld0FscGhhID09 IGN1cnJlbnRBbHBoYSkKLSAgICAgICAgcmV0dXJuOwotCiAgICAgLy8gSWYgdGhlIHVzZXIgaGFz IHNjcm9sbGVkIHRoZSBwYWdlLCB0aGVuIHRoZSBzY3JvbGxiYXJzIG11c3QgYmUgYW5pbWF0ZWQg aGVyZS4gCi0gICAgLy8gVGhpcyBvdmVycmlkZXMgdGhlIHJlbWFpbmluZyBlYXJseSByZXR1cm5z LgorICAgIC8vIFRoaXMgb3ZlcnJpZGVzIHRoZSBlYXJseSByZXR1cm5zLgogICAgIGJvb2wgbXVz dEFuaW1hdGUgPSBfYW5pbWF0b3ItPmhhdmVTY3JvbGxlZFNpbmNlUGFnZUxvYWQoKTsKIAogICAg IGlmIChfYW5pbWF0b3ItPnNjcm9sbGJhclBhaW50VGltZXJJc0FjdGl2ZSgpICYmICFtdXN0QW5p bWF0ZSkKQEAgLTQwMSw3ICszOTYsOSBAQCAtICh2b2lkKXNldFVwQW5pbWF0aW9uOihSZXRhaW5Q dHI8U2Nyb2xsCiAgICAgICAgIFtzY3JvbGxiYXJQYXJ0QW5pbWF0aW9uLmdldCgpIHN0b3BBbmlt YXRpb25dOwogICAgICAgICBzY3JvbGxiYXJQYXJ0QW5pbWF0aW9uID0gbmlsOwogICAgIH0KLSAg ICAKKworICAgIFtOU0FuaW1hdGlvbkNvbnRleHQgYmVnaW5Hcm91cGluZ107CisgICAgW1tOU0Fu aW1hdGlvbkNvbnRleHQgY3VycmVudENvbnRleHRdIHNldER1cmF0aW9uOmR1cmF0aW9uXTsKICAg ICBzY3JvbGxiYXJQYXJ0QW5pbWF0aW9uLmFkb3B0TlMoW1tTY3JvbGxiYXJQYXJ0QW5pbWF0aW9u IGFsbG9jXSBpbml0V2l0aFNjcm9sbGJhclBhaW50ZXI6c2Nyb2xsZXJQYWludGVyIAogICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBwYXJ0OnBhcnQKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgc2Nyb2xsQW5pbWF0b3I6X2FuaW1hdG9yIApAQCAt NDA5LDYgKzQwNiw3IEBAIC0gKHZvaWQpc2V0VXBBbmltYXRpb246KFJldGFpblB0cjxTY3JvbGwK ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgZHVyYXRpb246ZHVyYXRpb25dKTsKICAgICBbc2Nyb2xsYmFyUGFydEFuaW1h dGlvbi5nZXQoKSBzZXRBbmltYXRpb25CbG9ja2luZ01vZGU6TlNBbmltYXRpb25Ob25ibG9ja2lu Z107CiAgICAgW3Njcm9sbGJhclBhcnRBbmltYXRpb24uZ2V0KCkgc3RhcnRBbmltYXRpb25dOwor ICAgIFtOU0FuaW1hdGlvbkNvbnRleHQgZW5kR3JvdXBpbmddOwogfQogCiAtICh2b2lkKXNjcm9s bGVySW1wOihpZClzY3JvbGxlckltcCBhbmltYXRlS25vYkFscGhhVG86KENHRmxvYXQpbmV3S25v YkFscGhhIGR1cmF0aW9uOihOU1RpbWVJbnRlcnZhbClkdXJhdGlvbgo=