56585 2011-03-17 13:29:27 -0700 [chromium] Turn off accelerated compositing for RTL style pages. 2011-03-17 15:17:29 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 enne enne enne jamesr nduca simon.fraser vangelis xji oldest_to_newest 369253 0 enne 2011-03-17 13:29:27 -0700 [chromium] Turn off accelerated compositing for RTL style pages. 369258 1 enne 2011-03-17 13:36:10 -0700 RTL style is not properly supported in the compositor, so turn it off until a proper fix has been implemented. 369261 2 86087 enne 2011-03-17 13:37:16 -0700 Created attachment 86087 Patch 369267 3 enne 2011-03-17 13:42:49 -0700 I tested this both on an initial page as well as by switching the style dynamically from RTL to LTR and back. doLayout() seemed like the best place to do this dynamic check in. Backporting this to m11 fixes the problem there too. 369283 4 enne 2011-03-17 14:04:13 -0700 Nat asks the question: "What about iframes?" Answer: an ltr page with an iframe that references an rtl page desn't appear to render properly even with this fix. Accelerated compositing doesn't get turned off because the page is still ltr even though the iframe is rtl. However, the compositor doesn't have the same indexing problems because the page is still ltr. I guess I could try to detect if any element on the page was RTL and then disable accelerated compositing, but that seems a bit much. This is intended to be a temporary fix, anyway. 369290 5 simon.fraser 2011-03-17 14:14:28 -0700 > RTL style is not properly supported in the compositor What bugs cover that? 369295 6 enne 2011-03-17 14:21:02 -0700 (In reply to comment #5) > > RTL style is not properly supported in the compositor > What bugs cover that? This was just discovered yesterday and I was trying to fight the fire first with this bug. I filed a bug here to fix it properly: https://bugs.webkit.org/show_bug.cgi?id=56591 For what it's worth, this is a Chromium-only issue. 369312 7 86087 jamesr 2011-03-17 14:43:56 -0700 Comment on attachment 86087 Patch R=me. this is unfortunate but I think it's better to force software for these pages instead of rendering incorrectly. 369341 8 enne 2011-03-17 15:17:29 -0700 Committed r81395: <http://trac.webkit.org/changeset/81395> 86087 2011-03-17 13:37:16 -0700 2011-03-17 14:44:17 -0700 Patch bug-56585-20110317133715.patch text/plain 3082 enne U3VidmVyc2lvbiBSZXZpc2lvbjogODEzNzgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg YzNjNTA1ODA2NzdkYzFhNzgwMTRjNzRmZjIzZmY1NzAyYThkNmNhOC4uNGQwYzJjMGQ1ODAzOTBl MTk3NzFiNGIxOWYxOGQzNmYwYjUwYThlZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxNiBAQAorMjAxMS0wMy0xNyAgQWRyaWVubmUgV2Fsa2VyICA8ZW5uZUBnb29nbGUu Y29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtj aHJvbWl1bV0gVHVybiBvZmYgYWNjZWxlcmF0ZWQgY29tcG9zaXRpbmcgZm9yIFJUTCBzdHlsZSBw YWdlcy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU2 NTg1CisKKyAgICAgICAgKiBzcmMvV2ViVmlld0ltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpX ZWJWaWV3SW1wbDo6bGF5b3V0KToKKyAgICAgICAgKFdlYktpdDo6V2ViVmlld0ltcGw6OnBhZ2VI YXNSVExTdHlsZSk6CisgICAgICAgIChXZWJLaXQ6OldlYlZpZXdJbXBsOjpzZXRSb290R3JhcGhp Y3NMYXllcik6CisgICAgICAgICogc3JjL1dlYlZpZXdJbXBsLmg6CisKIDIwMTEtMDMtMTcgIEph eSBDaXZlbGxpICA8amNpdmVsbGlAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IERhdmlkIExldmluLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2Vi Vmlld0ltcGwuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3Bw CmluZGV4IDEzMGNmNDBjZmNmZGFkYjBlM2M5NTc5YjljYTZkYWVhNDgzMWMzYjYuLjRlYWZiODFl MGU3OWUyMGIxYjBjNWZhYzUyMGU1OTRiMzM2MzY2ODEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9t aXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAKQEAgLTk5NCw2ICs5OTQsMTIgQEAgdm9pZCBXZWJWaWV3 SW1wbDo6YW5pbWF0ZSgpCiAKIHZvaWQgV2ViVmlld0ltcGw6OmxheW91dCgpCiB7CisjaWYgVVNF KEFDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HKQorICAgIC8vIEZJWE1FOiBSVEwgc3R5bGUgbm90IHN1 cHBvcnRlZCBieSB0aGUgY29tcG9zaXRvciB5ZXQuCisgICAgaWYgKGlzQWNjZWxlcmF0ZWRDb21w b3NpdGluZ0FjdGl2ZSgpICYmIHBhZ2VIYXNSVExTdHlsZSgpKQorICAgICAgICBzZXRJc0FjY2Vs ZXJhdGVkQ29tcG9zaXRpbmdBY3RpdmUoZmFsc2UpOworI2VuZGlmCisKICAgICBXZWJGcmFtZUlt cGwqIHdlYmZyYW1lID0gbWFpbkZyYW1lSW1wbCgpOwogICAgIGlmICh3ZWJmcmFtZSkgewogICAg ICAgICAvLyBJbiBvcmRlciBmb3Igb3VyIGNoaWxkIEhXTkRzIChOYXRpdmVXaW5kb3dXaWRnZXRz KSB0byB1cGRhdGUgcHJvcGVybHksCkBAIC0yMjc0LDkgKzIyODAsMjYgQEAgYm9vbCBXZWJWaWV3 SW1wbDo6YWxsb3dzQWNjZWxlcmF0ZWRDb21wb3NpdGluZygpCiAgICAgcmV0dXJuICFtX2NvbXBv c2l0b3JDcmVhdGlvbkZhaWxlZDsKIH0KIAorYm9vbCBXZWJWaWV3SW1wbDo6cGFnZUhhc1JUTFN0 eWxlKCkgY29uc3QKK3sKKyAgICBpZiAoIXBhZ2UoKSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOwor ICAgIERvY3VtZW50KiBkb2N1bWVudCA9IHBhZ2UoKS0+bWFpbkZyYW1lKCktPmRvY3VtZW50KCk7 CisgICAgaWYgKCFkb2N1bWVudCkKKyAgICAgICAgcmV0dXJuIGZhbHNlOworICAgIFJlbmRlclZp ZXcqIHJlbmRlclZpZXcgPSBkb2N1bWVudC0+cmVuZGVyVmlldygpOworICAgIGlmICghcmVuZGVy VmlldykKKyAgICAgICAgcmV0dXJuIGZhbHNlOworICAgIFJlbmRlclN0eWxlKiBzdHlsZSA9IHJl bmRlclZpZXctPnN0eWxlKCk7CisgICAgaWYgKCFzdHlsZSkKKyAgICAgICAgcmV0dXJuIGZhbHNl OworICAgIHJldHVybiAoc3R5bGUtPmRpcmVjdGlvbigpID09IFJUTCk7Cit9CisKIHZvaWQgV2Vi Vmlld0ltcGw6OnNldFJvb3RHcmFwaGljc0xheWVyKFdlYkNvcmU6OlBsYXRmb3JtTGF5ZXIqIGxh eWVyKQogewotICAgIHNldElzQWNjZWxlcmF0ZWRDb21wb3NpdGluZ0FjdGl2ZShsYXllciA/IHRy dWUgOiBmYWxzZSk7CisgICAgLy8gRklYTUU6IFJUTCBzdHlsZSBub3Qgc3VwcG9ydGVkIGJ5IHRo ZSBjb21wb3NpdG9yIHlldC4KKyAgICBzZXRJc0FjY2VsZXJhdGVkQ29tcG9zaXRpbmdBY3RpdmUo bGF5ZXIgJiYgIXBhZ2VIYXNSVExTdHlsZSgpID8gdHJ1ZSA6IGZhbHNlKTsKICAgICBpZiAobV9s YXllclJlbmRlcmVyKQogICAgICAgICBtX2xheWVyUmVuZGVyZXItPnNldFJvb3RMYXllcihsYXll cik7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBs LmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5oCmluZGV4IGQxYjhm MTY1MmY1MWMyZTc0N2Y1YmUxYzA2ZGJmYjBlNTkwMzMzOGEuLjA4ZjAzYzQ5OTBlZGFjNzQyNzA0 YmQyYTYxYzYwYzE1YWExYTg2MmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0v c3JjL1dlYlZpZXdJbXBsLmgKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmll d0ltcGwuaApAQCAtMzI3LDYgKzMyNyw3IEBAIHB1YmxpYzoKIAogI2lmIFVTRShBQ0NFTEVSQVRF RF9DT01QT1NJVElORykKICAgICBib29sIGFsbG93c0FjY2VsZXJhdGVkQ29tcG9zaXRpbmcoKTsK KyAgICBib29sIHBhZ2VIYXNSVExTdHlsZSgpIGNvbnN0OwogICAgIHZvaWQgc2V0Um9vdEdyYXBo aWNzTGF5ZXIoV2ViQ29yZTo6UGxhdGZvcm1MYXllciopOwogICAgIHZvaWQgc2V0Um9vdExheWVy TmVlZHNEaXNwbGF5KCk7CiAgICAgdm9pZCBzY3JvbGxSb290TGF5ZXJSZWN0KGNvbnN0IFdlYkNv cmU6OkludFNpemUmIHNjcm9sbERlbHRhLCBjb25zdCBXZWJDb3JlOjpJbnRSZWN0JiBjbGlwUmVj dCk7Cg==