56574 2011-03-17 10:49:19 -0700 Dealloc'ing a WKView can leave a stale reference to it in NSWindow 2011-03-17 11:41:43 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Mac OS X 10.6 RESOLVED FIXED P2 Normal --- 1 sullivan sullivan oldest_to_newest 369152 0 sullivan 2011-03-17 10:49:19 -0700 WKView is setting itself as the window's _growBoxOwner in an override of _updateGrowBoxForWindowFrameChange, but isn't clearing it at any point. NSWindow doesn't retain/release its growBoxOwner, so this can lead to a bad object ref in NSWindow that results in crashes. 369157 1 86069 sullivan 2011-03-17 10:53:29 -0700 Created attachment 86069 Patch to clear growBoxOwner at the appropriate time. 369185 2 sullivan 2011-03-17 11:41:43 -0700 Committed in http://trac.webkit.org/changeset/81372 86069 2011-03-17 10:53:29 -0700 2011-03-17 11:20:23 -0700 Patch to clear growBoxOwner at the appropriate time. growBoxOwner_patch.txt text/plain 1739 sullivan SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDgxMzY0KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDMtMTcgIEpvaG4gU3Vs bGl2YW4gIDxzdWxsaXZhbkBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTU2NTc0CisgICAgICAgIERlYWxsb2MnaW5nIGEgV0tWaWV3IGNhbiBsZWF2ZSBhIHN0YWxl IHJlZmVyZW5jZSB0byBpdCBpbiBOU1dpbmRvdworCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9t YWMvV0tWaWV3Lm1tOgorICAgICAgICAoLVtXS1ZpZXcgdmlld1dpbGxNb3ZlVG9XaW5kb3c6XSk6 CisgICAgICAgIENsZWFyIHRoZSBvdXRnb2luZyB3aW5kb3cncyBncm93Qm94T3duZXIgaWYgaXQg aXMgdGhpcyB2aWV3LgorCiAyMDExLTAzLTE3ICBPbGVnIFJvbWFzaGluICA8b2xlZy5yb21hc2hp bkBub2tpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQW5kZXJzIENhcmxzc29uLgpJbmRl eDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3Lm1tCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1dLVmlldy5tbQkocmV2aXNpb24g ODEzNDQpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL21hYy9XS1ZpZXcubW0JKHdv cmtpbmcgY29weSkKQEAgLTc3LDYgKzc3LDcgQEAgLSAodm9pZClzcGVha1N0cmluZzooTlNTdHJp bmcgKilzdHJpbmc7CiAKIEBpbnRlcmZhY2UgTlNXaW5kb3cgKERldGFpbHMpCiAtIChOU1JlY3Qp X2dyb3dCb3hSZWN0OworLSAoaWQpX2dyb3dCb3hPd25lcjsKIC0gKHZvaWQpX3NldFNob3dPcGFx dWVHcm93Qm94Rm9yT3duZXI6KGlkKW93bmVyOwogLSAoQk9PTClfdXBkYXRlR3Jvd0JveEZvcldp bmRvd0ZyYW1lQ2hhbmdlOwogQGVuZApAQCAtMTQyNywxMCArMTQyOCwxNSBAQCAtICh2b2lkKXJl bW92ZVdpbmRvd09ic2VydmVycwogCiAtICh2b2lkKXZpZXdXaWxsTW92ZVRvV2luZG93OihOU1dp bmRvdyAqKXdpbmRvdwogewotICAgIGlmICh3aW5kb3cgIT0gW3NlbGYgd2luZG93XSkgewotICAg ICAgICBbc2VsZiByZW1vdmVXaW5kb3dPYnNlcnZlcnNdOwotICAgICAgICBbc2VsZiBhZGRXaW5k b3dPYnNlcnZlcnNGb3JXaW5kb3c6d2luZG93XTsKLSAgICB9CisgICAgTlNXaW5kb3cgKmN1cnJl bnRXaW5kb3cgPSBbc2VsZiB3aW5kb3ddOworICAgIGlmICh3aW5kb3cgPT0gY3VycmVudFdpbmRv dykKKyAgICAgICAgcmV0dXJuOworICAgIAorICAgIFtzZWxmIHJlbW92ZVdpbmRvd09ic2VydmVy c107CisgICAgW3NlbGYgYWRkV2luZG93T2JzZXJ2ZXJzRm9yV2luZG93OndpbmRvd107CisgICAg CisgICAgaWYgKFtjdXJyZW50V2luZG93IF9ncm93Qm94T3duZXJdID09IHNlbGYpCisgICAgICAg IFtjdXJyZW50V2luZG93IF9zZXRTaG93T3BhcXVlR3Jvd0JveEZvck93bmVyOm5pbF07CiB9CiAK IC0gKHZvaWQpdmlld0RpZE1vdmVUb1dpbmRvdwo=