56557 2011-03-17 06:05:39 -0700 Web Inspector: Clean up Inspector strings 2011-03-17 10:51:19 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 mnaganov mnaganov abarth apavlov bweinstein eric joepeck keishi loislo pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 369027 0 mnaganov 2011-03-17 06:05:39 -0700 The following unused strings have been removed: "Error in fetching root path for file system." "File System root path not available." "File System is disabled." "Persistent File System" "Reveal folder in OS" "Temporary File System" "File System" "Clear changes log." "Retaining paths of the selected object" "<source is not available>" "Show changes view." "%d style change" "Hide changes view." "Drag" "%d style changes" Also, I have modified the check-inspector-strings script to deal correctly with "\xNN" escapes, and to check strings in Chromium's DevTools.js. 369028 1 86051 mnaganov 2011-03-17 06:09:12 -0700 Created attachment 86051 patch 369121 2 webkit.review.bot 2011-03-17 10:26:45 -0700 http://trac.webkit.org/changeset/81358 might have broken Leopard Intel Release (Tests) The following tests are not passing: http/tests/inspector/resource-parameters.html 369154 3 mnaganov 2011-03-17 10:51:19 -0700 Manually committed: http://trac.webkit.org/changeset/81358 2011-03-17 Mikhail Naganov <mnaganov@chromium.org> Reviewed by Yury Semikhatsky. Web Inspector: Clean up Inspector strings. https://bugs.webkit.org/show_bug.cgi?id=56557 * English.lproj/localizedStrings.js: 2011-03-17 Mikhail Naganov <mnaganov@chromium.org> Reviewed by Yury Semikhatsky. Web Inspector: Clean up Inspector strings. https://bugs.webkit.org/show_bug.cgi?id=56557 Modify the script to deal correctly with "\xNN" escapes, and to check strings in Chromium's DevTools.js. * Scripts/check-inspector-strings: 86051 2011-03-17 06:09:12 -0700 2011-03-17 06:29:29 -0700 patch patch-56557 text/plain 4913 mnaganov ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAxYjliZTZiLi5lOGE2N2FlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg QEAKKzIwMTEtMDMtMTcgIE1pa2hhaWwgTmFnYW5vdiAgPG1uYWdhbm92QGNocm9taXVtLm9yZz4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZWIgSW5z cGVjdG9yOiBDbGVhbiB1cCBJbnNwZWN0b3Igc3RyaW5ncy4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU2NTU3CisKKyAgICAgICAgKiBFbmdsaXNoLmxw cm9qL2xvY2FsaXplZFN0cmluZ3MuanM6CisKIDIwMTEtMDMtMTcgIEd1c3Rhdm8gTm9yb25oYSBT aWx2YSAgPGd1c3Rhdm8ubm9yb25oYUBjb2xsYWJvcmEuY28udWs+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgQW5kcmVhcyBLbGluZy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0VuZ2xpc2gu bHByb2ovbG9jYWxpemVkU3RyaW5ncy5qcyBiL1NvdXJjZS9XZWJDb3JlL0VuZ2xpc2gubHByb2ov bG9jYWxpemVkU3RyaW5ncy5qcwppbmRleCBmMjYyMDlmNmIxNWNkNjBhYTU4NWJiZjU4N2RiMzNk YzZkN2U4NGZiLi42NWU0N2M2OTg4ODY1M2I0OTNiZGNiMmY5ZGQwNWViMGYxM2ZhYzExIDEwMDY0 NApHSVQgYmluYXJ5IHBhdGNoCmRlbHRhIDkzCnpjbWNiJWo9NjBmXk0qMzYmMmlsOHhIY35uNkF7 PktxMFhiUWQ3MWs9X1FANmowK1ZrVWI0QC1Nel9yO2R6YCU0ZQp3Un50bVlwb01FUU44MWpRJHAj PztvNWdsZFY0MXZibiNTZ0poaWBGQm8/eTxoSXFMaSRifHgrYzBHR0BwRiNyR24KCmRlbHRhIDEy MzYKemNtYjdESiFsaFE3PUE7cWpUe2p8JUpyeUdJaW1IYV8wazU3NnxCPDFXUSRmUm9tJU1gbFVS d0ReYiU4QzZyO0VhCnpqbkN3dSp0TFR3Q3Y+U09MYlcocHg7VklIY2pAbG5gJnw+ZjNtM0orJE1K cGQmLTMlWF92Ql5JX3QhbWRZViFVSAp6UnB9bFRETXVQKkAhXkd2YyZKYkR5d1dXKSRmTj1tNiY7 aGtlWDRKaWElanAqemZUTz9tbEprYmVrYmJfUkd8e3gKekM1eTVTLX4hKEBaZTN5JDhpVW1NRUhE e15aY3FgJVlYOWdTXjEwKGg+PHNBa0YobmRLVEFjWSZLb2w5R0t5a2JzCnpRZFFSM1JeKk9peUh+ ZXxoWW8wYGNnPmgpVFpFViMtSnV4R2FneiZ0Vnc4M20zY0ZreDImOHA8T2k2WSteKXNrPwp6djE/ cUFxYXtYZlc+bUVreUE+N2FTa0IxeVNZe15LTEI1XlJzN0pkKjl6R2ghWUNWRDwzRTYmQ3w4IT5Y NT9nR3IKelZtRVE7NEopI2FzakZkcFQ/XlV3KkIocFJESkV5SlFaV21tKV51aiF0SjJlTTR8VWpT PXlTcnlHTEp6SnYpRWhCCnotJEBVfkhPS3dgczFwODxpcH1ZbTMhXysheHd+SXdNeX5TY1ROe1Yq KiZfKm1vcXd4KEp7dHthWHJAbU5gczE7Vwp6U1Y8X3ktUFUoUVkzMVZWO2JEd1QkYDNUMmczMHt5 dGZUNnpza2olcXNLYDVSaXRJTCVpZmQ9JTl3JEBtZ0speSkKelVSXlFIYEI/UkRrbl5NPVYyKXRe eT4hVW41ZVB5aHtAIUV9ZjhlZ3JHI1gxJCNXI2s8NztoeWB6Kzh7bTZZSEJZCnBpa2woYS1VdFc5 JnMoQkFvXzxUPmBvPS1tZWRPN2VnajFpN1ZtVD88YEBafU57cyNWTjYpeWspCgpkaWZmIC0tZ2l0 IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IGM2YmZjYjQuLjVkNzEy YzEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxNSBAQAorMjAxMS0wMy0xNyAgTWlraGFpbCBOYWdhbm92ICA8bW5hZ2Fub3ZAY2hy b21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFdlYiBJbnNwZWN0b3I6IENsZWFuIHVwIEluc3BlY3RvciBzdHJpbmdzLgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTY1NTcKKworICAgICAgICBN b2RpZnkgdGhlIHNjcmlwdCB0byBkZWFsIGNvcnJlY3RseSB3aXRoICJceE5OIiBlc2NhcGVzLCBh bmQgdG8KKyAgICAgICAgY2hlY2sgc3RyaW5ncyBpbiBDaHJvbWl1bSdzIERldlRvb2xzLmpzLgor CisgICAgICAgICogU2NyaXB0cy9jaGVjay1pbnNwZWN0b3Itc3RyaW5nczoKKwogMjAxMS0wMy0x NyAgS2VpdGggS3l6aXZhdCAgPGtlaXRoLmt5eml2YXRAbm9raWEuY29tPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IEJlbmphbWluIFBvdWxhaW4uCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL2No ZWNrLWluc3BlY3Rvci1zdHJpbmdzIGIvVG9vbHMvU2NyaXB0cy9jaGVjay1pbnNwZWN0b3Itc3Ry aW5ncwppbmRleCAwMzUwYWNhLi5kZDg1MGFhIDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL2No ZWNrLWluc3BlY3Rvci1zdHJpbmdzCisrKyBiL1Rvb2xzL1NjcmlwdHMvY2hlY2staW5zcGVjdG9y LXN0cmluZ3MKQEAgLTQwLDEwICs0MCwxNSBAQCBmcm9tIHdlYmtpdHB5LnN0eWxlLmZpbGVyZWFk ZXIgaW1wb3J0IFRleHRGaWxlUmVhZGVyCiBmcm9tIHdlYmtpdHB5LnN0eWxlLm1haW4gaW1wb3J0 IGNoYW5nZV9kaXJlY3RvcnkKIAogX2luc3BlY3Rvcl9kaXJlY3RvcnkgPSAiU291cmNlL1dlYkNv cmUvaW5zcGVjdG9yL2Zyb250LWVuZCIKK19kZXZ0b29sc19kaXJlY3RvcnkgPSAiU291cmNlL1dl YktpdC9jaHJvbWl1bS9zcmMvanMiCiBfbG9jYWxpemVkX3N0cmluZ3MgPSAiU291cmNlL1dlYkNv cmUvRW5nbGlzaC5scHJvai9sb2NhbGl6ZWRTdHJpbmdzLmpzIgogCiBfbG9nID0gbG9nZ2luZy5n ZXRMb2dnZXIoImNoZWNrLWluc3BlY3Rvci1zdHJpbmdzIikKIAorZGVmIGRlY29kZV91bmljb2Rl X2VzY2FwZXMocyk6CisgICAgeE5OX2NvbnZlcnRlZF90b191MDBOTiA9IHMucmVwbGFjZSgiXFx4 IiwgIlxcdTAwIikKKyAgICByZXR1cm4gZXZhbCgidXJcIiIgKyB4Tk5fY29udmVydGVkX3RvX3Uw ME5OICsgIlwiIikKKwogY2xhc3MgU3RyaW5nc0V4dHJhY3RvcihQcm9jZXNzb3JCYXNlKToKICAg ICBkZWYgX19pbml0X18oc2VsZiwgcGF0dGVybnMpOgogICAgICAgICBzZWxmLl9wYXR0ZXJucyA9 IHBhdHRlcm5zCkBAIC01NCw5ICs1OSw2IEBAIGNsYXNzIFN0cmluZ3NFeHRyYWN0b3IoUHJvY2Vz c29yQmFzZSk6CiAgICAgZGVmIHNob3VsZF9wcm9jZXNzKHNlbGYsIGZpbGVfcGF0aCk6CiAgICAg ICAgIHJldHVybiBmaWxlX3BhdGguZW5kc3dpdGgoIi5qcyIpIGFuZCAobm90IGZpbGVfcGF0aC5l bmRzd2l0aCgiSW5qZWN0ZWRTY3JpcHQuanMiKSkKIAotICAgIGRlZiBkZWNvZGVfdW5pY29kZV9l c2NhcGVzKHNlbGYsIHMpOgotICAgICAgICByZXR1cm4gZXZhbCgidXJcIiIgKyBzICsgIlwiIikK LQogICAgIGRlZiBwcm9jZXNzKHNlbGYsIGxpbmVzLCBmaWxlX3BhdGgsIGxpbmVfbnVtYmVycz1O b25lKToKICAgICAgICAgZm9yIGxpbmUgaW4gbGluZXM6CiAgICAgICAgICAgICBjb21tZW50X3N0 YXJ0ID0gbGluZS5maW5kKCIvLyIpCkBAIC02Niw3ICs2OCw3IEBAIGNsYXNzIFN0cmluZ3NFeHRy YWN0b3IoUHJvY2Vzc29yQmFzZSk6CiAgICAgICAgICAgICBmb3IgcGF0dGVybiBpbiBzZWxmLl9w YXR0ZXJuczoKICAgICAgICAgICAgICAgICBsaW5lX3N0cmluZ3MgPSByZS5maW5kYWxsKHBhdHRl cm4sIGxpbmUpCiAgICAgICAgICAgICAgICAgZm9yIHN0cmluZyBpbiBsaW5lX3N0cmluZ3M6Ci0g ICAgICAgICAgICAgICAgICAgIHNlbGYuc3RyaW5nc1tpbmRleF0uYXBwZW5kKHNlbGYuZGVjb2Rl X3VuaWNvZGVfZXNjYXBlcyhzdHJpbmcpKQorICAgICAgICAgICAgICAgICAgICBzZWxmLnN0cmlu Z3NbaW5kZXhdLmFwcGVuZChkZWNvZGVfdW5pY29kZV9lc2NhcGVzKHN0cmluZykpCiAgICAgICAg ICAgICAgICAgaW5kZXggKz0gMQogCiBjbGFzcyBMb2NhbGl6ZWRTdHJpbmdzRXh0cmFjdG9yOgpA QCAtODEsNyArODMsNyBAQCBjbGFzcyBMb2NhbGl6ZWRTdHJpbmdzRXh0cmFjdG9yOgogICAgICAg ICAgICAgZm9yIGxpbmUgaW4gbGluZXM6CiAgICAgICAgICAgICAgICAgbWF0Y2ggPSByZS5tYXRj aChyImxvY2FsaXplZFN0cmluZ3NcW1wiKCg/OlteXCJcXF18XFwuKSo/KVwiIiwgbGluZSkKICAg ICAgICAgICAgICAgICBpZiBtYXRjaDoKLSAgICAgICAgICAgICAgICAgICAgc2VsZi5sb2NhbGl6 ZWRfc3RyaW5ncy5hcHBlbmQobWF0Y2guZ3JvdXAoMSkpCisgICAgICAgICAgICAgICAgICAgIHNl bGYubG9jYWxpemVkX3N0cmluZ3MuYXBwZW5kKGRlY29kZV91bmljb2RlX2VzY2FwZXMobWF0Y2gu Z3JvdXAoMSkpKQogICAgICAgICBmaW5hbGx5OgogICAgICAgICAgICAgbG9jYWxpemVkX3N0cmlu Z3NfZmlsZS5jbG9zZSgpCiAKQEAgLTk5LDcgKzEwMSw3IEBAIGlmIF9fbmFtZV9fID09ICJfX21h aW5fXyI6CiAKICAgICBzdHJpbmdzX2V4dHJhY3RvciA9IFN0cmluZ3NFeHRyYWN0b3IoW3IiV2Vi SW5zcGVjdG9yXC4oPzpVSVN0cmluZ3xmb3JtYXRMb2NhbGl6ZWQpXChcIigoPzpbXlwiXFxdfFxc LikqPylcIiIsIHIiXCIoKD86W15cIlxcXXxcXC4pKj8pXCIiXSkKICAgICBmaWxlX3JlYWRlciA9 IFRleHRGaWxlUmVhZGVyKHN0cmluZ3NfZXh0cmFjdG9yKQotICAgIGZpbGVfcmVhZGVyLnByb2Nl c3NfcGF0aHMoW19pbnNwZWN0b3JfZGlyZWN0b3J5XSkKKyAgICBmaWxlX3JlYWRlci5wcm9jZXNz X3BhdGhzKFtfaW5zcGVjdG9yX2RpcmVjdG9yeSwgX2RldnRvb2xzX2RpcmVjdG9yeV0pCiAgICAg bG9jYWxpemVkX3N0cmluZ3NfZXh0cmFjdG9yID0gTG9jYWxpemVkU3RyaW5nc0V4dHJhY3Rvcigp CiAgICAgbG9jYWxpemVkX3N0cmluZ3NfZXh0cmFjdG9yLnByb2Nlc3NfZmlsZShfbG9jYWxpemVk X3N0cmluZ3MpCiAgICAgdWlfc3RyaW5ncyA9IGZyb3plbnNldChzdHJpbmdzX2V4dHJhY3Rvci5z dHJpbmdzWzBdKQo=