56513 2011-03-16 17:59:16 -0700 Fix MIPS build with const void* 2011-03-16 19:48:44 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Normal --- 0 fu webkit-unassigned abarth commit-queue eric webkit.review.bot oldest_to_newest 368701 0 fu 2011-03-16 17:59:16 -0700 Hi, I will send a patch to fix MIPS build with const *void for load32 and store32. Thanks! Regards, Chao-ying 368704 1 86014 fu 2011-03-16 18:04:57 -0700 Created attachment 86014 Use const void* for load32 and store32 Here is the patch. Thanks! 368715 2 86014 commit-queue 2011-03-16 18:53:31 -0700 Comment on attachment 86014 Use const void* for load32 and store32 Clearing flags on attachment: 86014 Committed r81308: <http://trac.webkit.org/changeset/81308> 368716 3 commit-queue 2011-03-16 18:53:35 -0700 All reviewed patches have been landed. Closing bug. 368749 4 webkit.review.bot 2011-03-16 19:48:44 -0700 http://trac.webkit.org/changeset/81308 might have broken Qt Linux Release The following tests are not passing: fast/viewport/viewport-1.html fast/viewport/viewport-10.html fast/viewport/viewport-100.html fast/viewport/viewport-101.html fast/viewport/viewport-102.html fast/viewport/viewport-103.html fast/viewport/viewport-104.html fast/viewport/viewport-105.html fast/viewport/viewport-106.html fast/viewport/viewport-107.html fast/viewport/viewport-108.html fast/viewport/viewport-109.html fast/viewport/viewport-11.html fast/viewport/viewport-110.html fast/viewport/viewport-111.html fast/viewport/viewport-112.html fast/viewport/viewport-113.html fast/viewport/viewport-114.html fast/viewport/viewport-115.html fast/viewport/viewport-116.html fast/viewport/viewport-117.html fast/viewport/viewport-118.html fast/viewport/viewport-119.html fast/viewport/viewport-12.html fast/viewport/viewport-120.html fast/viewport/viewport-121.html fast/viewport/viewport-122.html fast/viewport/viewport-123.html fast/viewport/viewport-124.html fast/viewport/viewport-125.html fast/viewport/viewport-129.html fast/viewport/viewport-13.html fast/viewport/viewport-14.html fast/viewport/viewport-15.html fast/viewport/viewport-16.html fast/viewport/viewport-17.html fast/viewport/viewport-18.html fast/viewport/viewport-19.html fast/viewport/viewport-2.html fast/viewport/viewport-20.html fast/viewport/viewport-21.html fast/viewport/viewport-22.html fast/viewport/viewport-23.html fast/viewport/viewport-24.html fast/viewport/viewport-25.html fast/viewport/viewport-26.html fast/viewport/viewport-27.html fast/viewport/viewport-28.html fast/viewport/viewport-29.html fast/viewport/viewport-3.html fast/viewport/viewport-30.html fast/viewport/viewport-31.html fast/viewport/viewport-32.html fast/viewport/viewport-33.html fast/viewport/viewport-34.html fast/viewport/viewport-35.html fast/viewport/viewport-36.html fast/viewport/viewport-37.html fast/viewport/viewport-38.html fast/viewport/viewport-39.html fast/viewport/viewport-4.html fast/viewport/viewport-40.html fast/viewport/viewport-41.html fast/viewport/viewport-42.html fast/viewport/viewport-43.html fast/viewport/viewport-44.html fast/viewport/viewport-46.html fast/viewport/viewport-47.html fast/viewport/viewport-48.html fast/viewport/viewport-49.html fast/viewport/viewport-5.html fast/viewport/viewport-50.html fast/viewport/viewport-51.html fast/viewport/viewport-52.html fast/viewport/viewport-53.html fast/viewport/viewport-54.html fast/viewport/viewport-55.html fast/viewport/viewport-56.html fast/viewport/viewport-57.html fast/viewport/viewport-59.html fast/viewport/viewport-60.html fast/viewport/viewport-61.html fast/viewport/viewport-62.html fast/viewport/viewport-63.html fast/viewport/viewport-64.html fast/viewport/viewport-66.html fast/viewport/viewport-67.html fast/viewport/viewport-68.html fast/viewport/viewport-69.html fast/viewport/viewport-7.html fast/viewport/viewport-70.html fast/viewport/viewport-71.html fast/viewport/viewport-72.html fast/viewport/viewport-73.html fast/viewport/viewport-74.html fast/viewport/viewport-75.html fast/viewport/viewport-76.html fast/viewport/viewport-77.html fast/viewport/viewport-78.html fast/viewport/viewport-79.html fast/viewport/viewport-8.html fast/viewport/viewport-80.html fast/viewport/viewport-81.html fast/viewport/viewport-83.html fast/viewport/viewport-85.html fast/viewport/viewport-86.html fast/viewport/viewport-88.html fast/viewport/viewport-9.html fast/viewport/viewport-90.html fast/viewport/viewport-91.html fast/viewport/viewport-92.html fast/viewport/viewport-93.html fast/viewport/viewport-94.html fast/viewport/viewport-95.html fast/viewport/viewport-96.html fast/viewport/viewport-warnings-1.html fast/viewport/viewport-warnings-2.html fast/viewport/viewport-warnings-3.html fast/viewport/viewport-warnings-4.html fast/viewport/viewport-warnings-5.html fast/viewport/viewport-warnings-6.html 86014 2011-03-16 18:04:57 -0700 2011-03-16 18:53:31 -0700 Use const void* for load32 and store32 mips.diff text/plain 1540 fu SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gODEzMDUpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAK KzIwMTEtMDMtMTYgIENoYW8teWluZyBGdSAgPGZ1QG1pcHMuY29tPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBNSVBTIGJ1aWxkIHdpdGggY29u c3QgKnZvaWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTU2NTEzCisKKyAgICAgICAgKiBhc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJNSVBTLmg6CisgICAg ICAgIChKU0M6Ok1hY3JvQXNzZW1ibGVyTUlQUzo6bG9hZDMyKToKKyAgICAgICAgKEpTQzo6TWFj cm9Bc3NlbWJsZXJNSVBTOjpzdG9yZTMyKToKKwogMjAxMS0wMy0xNiAgT2xpdmVyIEh1bnQgIDxv bGl2ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpJbmRl eDogU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlck1JUFMuaAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1i bGVyTUlQUy5oCShyZXZpc2lvbiA4MTI1NikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3Nl bWJsZXIvTWFjcm9Bc3NlbWJsZXJNSVBTLmgJKHdvcmtpbmcgY29weSkKQEAgLTU4MSw3ICs1ODEs NyBAQCBwdWJsaWM6CiAgICAgICAgIH0KICAgICB9CiAKLSAgICB2b2lkIGxvYWQzMih2b2lkKiBh ZGRyZXNzLCBSZWdpc3RlcklEIGRlc3QpCisgICAgdm9pZCBsb2FkMzIoY29uc3Qgdm9pZCogYWRk cmVzcywgUmVnaXN0ZXJJRCBkZXN0KQogICAgIHsKICAgICAgICAgLyoKICAgICAgICAgICAgIGxp ICBhZGRyVGVtcCwgYWRkcmVzcwpAQCAtNzQ5LDcgKzc0OSw3IEBAIHB1YmxpYzoKICAgICAgICAg fQogICAgIH0KIAotICAgIHZvaWQgc3RvcmUzMihSZWdpc3RlcklEIHNyYywgdm9pZCogYWRkcmVz cykKKyAgICB2b2lkIHN0b3JlMzIoUmVnaXN0ZXJJRCBzcmMsIGNvbnN0IHZvaWQqIGFkZHJlc3Mp CiAgICAgewogICAgICAgICAvKgogICAgICAgICAgICAgbGkgIGFkZHJUZW1wLCBhZGRyZXNzCkBA IC03NTksNyArNzU5LDcgQEAgcHVibGljOgogICAgICAgICBtX2Fzc2VtYmxlci5zdyhzcmMsIGFk ZHJUZW1wUmVnaXN0ZXIsIDApOwogICAgIH0KIAotICAgIHZvaWQgc3RvcmUzMihJbW0zMiBpbW0s IHZvaWQqIGFkZHJlc3MpCisgICAgdm9pZCBzdG9yZTMyKEltbTMyIGltbSwgY29uc3Qgdm9pZCog YWRkcmVzcykKICAgICB7CiAgICAgICAgIC8qCiAgICAgICAgICAgICBsaSAgaW1tVGVtcCwgaW1t Cg==