56489 2011-03-16 14:14:11 -0700 Improve robustness of controls-without-preload by seeking to the start explicitly at the end of the test. 2011-03-17 09:11:50 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 56473 1 dglazkov dglazkov eric.carlson oldest_to_newest 368534 0 dglazkov 2011-03-16 14:14:11 -0700 Improve robustness of controls-without-preload by seeking to the start explicitly at the end of the test. 368536 1 85974 dglazkov 2011-03-16 14:14:56 -0700 Created attachment 85974 Patch 368546 2 85974 eric.carlson 2011-03-16 14:28:39 -0700 Comment on attachment 85974 Patch Nice change, thanks! 368559 3 dglazkov 2011-03-16 14:48:05 -0700 Committed r81280: <http://trac.webkit.org/changeset/81280> 369058 4 eric.carlson 2011-03-17 08:49:20 -0700 Odd, this caused a failure on the Leopard release bot: http://build.webkit.org/results/Leopard%20Intel%20Release%20(Tests)/r81306%20(29853)/media/controls-without-preload-pretty-diff.html So Sam checked in new results: https://bugs.webkit.org/show_bug.cgi?id=56522 369060 5 dglazkov 2011-03-17 08:53:34 -0700 (In reply to comment #4) > Odd, this caused a failure on the Leopard release bot: http://build.webkit.org/results/Leopard%20Intel%20Release%20(Tests)/r81306%20(29853)/media/controls-without-preload-pretty-diff.html > > So Sam checked in new results: https://bugs.webkit.org/show_bug.cgi?id=56522 Nah. The test was failing like that for a long time. I thought I broke it too, but I looked back and could see this failing as far as r80697: http://build.webkit.org/results/Leopard%20Intel%20Release%20(Tests)/r80697%20%2829439%29/media/controls-without-preload-pretty-diff.html 369062 6 dglazkov 2011-03-17 08:54:49 -0700 And here's Sam's conclusion: https://bugs.webkit.org/show_bug.cgi?id=56532 369068 7 eric.carlson 2011-03-17 09:03:59 -0700 Indeed, the problem is that the fullscreen button isn't showing (it is 16x16, the mute button is 14x12): - RenderButton {INPUT} at (297,4) size 16x16 - RenderButton {INPUT} at (267,6) size 14x12 + RenderButton {INPUT} at (297,6) size 14x12 but Sam's conclusion in https://bugs.webkit.org/show_bug.cgi?id=56532 is for WebKit2. In any case, the failure didn't start with this change. 369071 8 dglazkov 2011-03-17 09:11:50 -0700 (In reply to comment #7) > Indeed, the problem is that the fullscreen button isn't showing (it is 16x16, the mute button is 14x12): > > - RenderButton {INPUT} at (297,4) size 16x16 > - RenderButton {INPUT} at (267,6) size 14x12 > + RenderButton {INPUT} at (297,6) size 14x12 > > but Sam's conclusion in https://bugs.webkit.org/show_bug.cgi?id=56532 is for WebKit2. > > In any case, the failure didn't start with this change. So the MediaPlayerPrivate::supportsFullscreen must be returning false for Leopard on this bot? That seems to be the only code path that could diverge. 85974 2011-03-16 14:14:56 -0700 2011-03-16 14:28:39 -0700 Patch bug-56489-20110316141455.patch text/plain 1941 dglazkov U3VidmVyc2lvbiBSZXZpc2lvbjogODEyNzQKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAyMGM1Yjc1MDFjOWI3NGJhYzRiZmFi NTBkOGQ4YTkwOTQ4OTc2YTRhLi5lOTEzNzljNDM4MmI5YWMzODAwOTdjMTNhYWQzY2FjMTcwYWMy NDAyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDMtMTYgIERpbWl0cmkgR2xhemtvdiAg PGRnbGF6a292QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBJbXByb3ZlIHJvYnVzdG5lc3Mgb2YgY29udHJvbHMtd2l0aG91dC1w cmVsb2FkIGJ5IHNlZWtpbmcgdG8gdGhlIHN0YXJ0IGV4cGxpY2l0bHkgYXQgdGhlIGVuZCBvZiB0 aGUgdGVzdC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTU2NDg5CisKKyAgICAgICAgKiBtZWRpYS9jb250cm9scy13aXRob3V0LXByZWxvYWQuaHRtbDog QWRkZWQgYW4gZXh0cmEgc3RlcCB0byBzZWVrIHRvIDAgYmVmb3JlIHRoZSBlbmQgb2YgdGhlIHRl c3QuCisKIDIwMTEtMDMtMTYgIEJyaWFuIFdlaW5zdGVpbiAgPGJ3ZWluc3RlaW5AYXBwbGUuY29t PgogCiAgICAgICAgIFNraXAgcGx1Z2lucy9yZWZjb3VudC1sZWFrcy5odG1sIG9uIFdpbmRvd3Ms IGJlY2F1c2UgaXQgaXMgZmFpbGluZyBpbiByZWxlYXNlIGJ1aWxkcywKZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL21lZGlhL2NvbnRyb2xzLXdpdGhvdXQtcHJlbG9hZC5odG1sIGIvTGF5b3V0VGVz dHMvbWVkaWEvY29udHJvbHMtd2l0aG91dC1wcmVsb2FkLmh0bWwKaW5kZXggOTViMzUzMTQyMzli MWY1YTcyODM2OWZhOWVkZGNiMGJjN2E5ZDNhZC4uNTY3NThhMjQ0MTMwYWYxMzAzMDc5YmY0YzYw NWZmMzEwMDI3MTIwOCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvbWVkaWEvY29udHJvbHMtd2l0 aG91dC1wcmVsb2FkLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvbWVkaWEvY29udHJvbHMtd2l0aG91 dC1wcmVsb2FkLmh0bWwKQEAgLTUsMTMgKzUsMjIgQEAKICAgICAgICAgICAgIGlmICh3aW5kb3cu bGF5b3V0VGVzdENvbnRyb2xsZXIpCiAgICAgICAgICAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xs ZXIud2FpdFVudGlsRG9uZSgpOwogCisgICAgICAgICAgICB2YXIgdmlkZW87CisKICAgICAgICAg ICAgIGZ1bmN0aW9uIHN0YXJ0KCkKICAgICAgICAgICAgIHsKICAgICAgICAgICAgICAgICBzZXRT cmNCeVRhZ05hbWUoInZpZGVvIiwgZmluZE1lZGlhRmlsZSgidmlkZW8iLCAiY29udGVudC90ZXN0 IikpOwogICAgICAgICAgICAgICAgIHZpZGVvID0gZG9jdW1lbnQuZ2V0RWxlbWVudHNCeVRhZ05h bWUoJ3ZpZGVvJylbMF07CiAgICAgICAgICAgICAgICAgdmlkZW8ubG9hZCgpOwogICAgICAgICAg ICAgICAgIHZpZGVvLnBsYXkoKTsKLSAgICAgICAgICAgICAgICB2aWRlby5hZGRFdmVudExpc3Rl bmVyKCJjYW5wbGF5dGhyb3VnaCIsIGZpbmlzaCk7CisgICAgICAgICAgICAgICAgdmlkZW8uYWRk RXZlbnRMaXN0ZW5lcigiY2FucGxheXRocm91Z2giLCBjYW5QbGF5VGhyb3VnaCk7CisgICAgICAg ICAgICB9CisKKyAgICAgICAgICAgIGZ1bmN0aW9uIGNhblBsYXlUaHJvdWdoKCkKKyAgICAgICAg ICAgIHsKKyAgICAgICAgICAgICAgICAvLyBFbnN1cmUgdGhhdCB0aGUgZnJhbWUgaXMgYWx3YXlz IHRoZSBzYW1lIGluIHBpeGVsIHJlc3VsdC4KKyAgICAgICAgICAgICAgICB2aWRlby5hZGRFdmVu dExpc3RlbmVyKCJzZWVrZWQiLCBmaW5pc2gpOworICAgICAgICAgICAgICAgIHZpZGVvLmN1cnJl bnRUaW1lID0gMDsKICAgICAgICAgICAgIH0KIAogICAgICAgICAgICAgZnVuY3Rpb24gZmluaXNo KCkK