56486 2011-03-16 13:43:21 -0700 [Qt] HTML5 Drag and Drop demos not working 2011-04-11 07:53:04 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 58206 1 aparna.nand benjamin benjamin ragner.magalhaes oldest_to_newest 368504 0 aparna.nand 2011-03-16 13:43:21 -0700 Steps to reproduce the problem: 1. Open QtTestBrowser or a sample QWebView program which does (QWebView view; view.show(); view.load(QUrl("any urls given below")); 2. Load any of the URLs - http://html5demos.com/drag, http://html5demos.com/drag-anything, http://shapeshed.com/examples/drag-and-drop/, http://html5tutorial.net/examples/html5-drag-and-drop.html or other popular demos for html5 D&D. 3. Follow the instructions given in the url. All the URLs allow dragging of some content and dropping it off in designated area. Expected results: Drag and drop works fine as stated in the URL Actual result: Drop is not working as mentioned in the url. Unable to drop the content. 379526 1 88223 benjamin 2011-04-05 07:04:33 -0700 Created attachment 88223 Patch 379527 2 benjamin 2011-04-05 07:05:29 -0700 Covered by existing tests but the DRT does not yet have support for Drag and Drop unfortunatelly. 379532 3 benjamin 2011-04-05 07:13:26 -0700 *** Bug 52601 has been marked as a duplicate of this bug. *** 379686 4 aparna.nand 2011-04-05 09:58:43 -0700 This fix does not solve the problem with all D&D urls mentioned below. http://html5tutorial.net/examples/html5-drag-and-drop.html example still fails with this fix. I have been working to fix the issue with that. Analysis: 1. For html5 D&D, preventDefault is used to allow dropping in dragOver. addEvent(bin, 'dragover', function (e) { if (e.preventDefault) e.preventDefault(); // allows us to drop this.className = 'over'; e.dataTransfer.dropEffect = 'copy'; alert('Hahaha'); return false; }); 2. In some implementations it returns false instead of calling preventDefault (IE expects return false) to allow dropping. addEvent(bin, 'dragover', function (e) { this.className = 'over'; e.dataTransfer.dropEffect = 'copy'; alert('Hahaha'); return false; //allows us to drop }); 3. If preventDefault is called on the event, then m_defaultPrevented is set to true and droppping succeeds in webkit. 4. So we need to set, m_defaultPrevented even when false is returned (as in step 2) to let dropping succeed. 5. setReturnValue of Event.h needs to be called. Working on a fix for this. 379696 5 aparna.nand 2011-04-05 10:07:55 -0700 Missed mentioning - Patch given by Benjamin is required, in addition to it we need to make changes mentioned in comment#4. 382401 6 88223 kling 2011-04-08 11:26:30 -0700 Comment on attachment 88223 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=88223&action=review r=me > Source/WebKit/qt/ChangeLog:12 > + what action should take place. To adtop this behavior for Qt, we always accept drag enter events Typo, s/adtop/adopt/ 383166 7 benjamin 2011-04-11 07:53:04 -0700 Committed r83442: <http://trac.webkit.org/changeset/83442> 88223 2011-04-05 07:04:33 -0700 2011-04-08 11:26:30 -0700 Patch 56486.diff text/plain 1539 benjamin ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvcXQvQXBpL3F3ZWJwYWdlLmNwcCBiL1NvdXJjZS9X ZWJLaXQvcXQvQXBpL3F3ZWJwYWdlLmNwcAppbmRleCBhYzFkNTYyLi5iNWQ1OTIyIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0L3F0L0FwaS9xd2VicGFnZS5jcHAKKysrIGIvU291cmNlL1dlYktp dC9xdC9BcGkvcXdlYnBhZ2UuY3BwCkBAIC05NzksOCArOTc5LDcgQEAgdm9pZCBRV2ViUGFnZVBy aXZhdGU6OmRyYWdFbnRlckV2ZW50KFQqIGV2KQogICAgICAgICAgICAgUUN1cnNvcjo6cG9zKCks IGRyb3BBY3Rpb25Ub0RyYWdPcChldi0+cG9zc2libGVBY3Rpb25zKCkpKTsKICAgICBRdDo6RHJv cEFjdGlvbiBhY3Rpb24gPSBkcmFnT3BUb0Ryb3BBY3Rpb24ocGFnZS0+ZHJhZ0NvbnRyb2xsZXIo KS0+ZHJhZ0VudGVyZWQoJmRyYWdEYXRhKSk7CiAgICAgZXYtPnNldERyb3BBY3Rpb24oYWN0aW9u KTsKLSAgICBpZiAoYWN0aW9uICE9IFF0OjpJZ25vcmVBY3Rpb24pCi0gICAgICAgIGV2LT5hY2Nl cHRQcm9wb3NlZEFjdGlvbigpOworICAgIGV2LT5hY2NlcHRQcm9wb3NlZEFjdGlvbigpOwogI2Vu ZGlmCiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nIGIvU291cmNl L1dlYktpdC9xdC9DaGFuZ2VMb2cKaW5kZXggNzNhYTBhMy4uNmJiNDU0NCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9xdC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9xdC9DaGFuZ2VM b2cKQEAgLTEsMyArMSwyMCBAQAorMjAxMS0wNC0wNSAgQmVuamFtaW4gUG91bGFpbiAgPGJlbmph bWluLnBvdWxhaW5Abm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFtRdF0gSFRNTDUgRHJhZyBhbmQgRHJvcCBkZW1vcyBub3Qgd29ya2lu ZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTY0ODYK KworICAgICAgICBIYW5kbGluZyB0aGUgZHJvcCB3aXRoIEphdmFTY3JpcHQgd2FzIG5vdCB3b3Jr aW5nIHdpdGggUXQgYmVjYXVzZSBpZiB0aGUgYWN0aW9uIGlzIGlnbm9yZWQKKyAgICAgICAgaW4g cmVzcG9uc2UgdG8gRHJhZ0VudGVyLCBubyBmdXJ0aGVyIGV2ZW50cyBhcmUgc2VudCB0byB0aGUg dmlldy4KKworICAgICAgICBEcmFnIGFuZCBkcm9wIGlzIGRlZmluZWQgYW5kIHVzZWQgZGlmZmVy ZW50bHkgYnkgd2VicGFnZXMuIFRoZSBkcmFnIG1vdmUgZXZlbnRzIGFyZSBkZXRlcm1pbmluZwor ICAgICAgICB3aGF0IGFjdGlvbiBzaG91bGQgdGFrZSBwbGFjZS4gVG8gYWR0b3AgdGhpcyBiZWhh dmlvciBmb3IgUXQsIHdlIGFsd2F5cyBhY2NlcHQgZHJhZyBlbnRlciBldmVudHMKKyAgICAgICAg b24gdGhlIHdpZGdldC4KKworICAgICAgICAqIEFwaS9xd2VicGFnZS5jcHA6CisgICAgICAgIChR V2ViUGFnZVByaXZhdGU6OmRyYWdFbnRlckV2ZW50KToKKwogMjAxMS0wNC0wNCAgQ2hhbmcgU2h1 ICA8Y3NodUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFJ5b3N1a2UgTml3YS4K