56481 2011-03-16 13:16:34 -0700 fix stroked text drawing in skia 2011-03-16 17:49:29 -0700 1 1 1 Unclassified WebKit Text 528+ (Nightly build) PC Windows 7 RESOLVED FIXED P2 Normal --- 1 reed webkit-unassigned abarth commit-queue eric jamesr reed webkit.review.bot oldest_to_newest 368482 0 reed 2011-03-16 13:16:34 -0700 When we draw text via skia, we need to reestablish the typeface/textsize/encoding when we draw the stroke layer. 368485 1 85961 reed 2011-03-16 13:21:17 -0700 Created attachment 85961 patch for 56481 368516 2 85961 jamesr 2011-03-16 13:55:24 -0700 Comment on attachment 85961 patch for 56481 R=me. Would you like commit-queue+ as well? (set commit-queue? on the patch or use the --request-commit flag to webkit-patch upload to request this in the future). Also, please try to upload patches from the root of the WebKit try and not from within the Source/ directory in the future. 368637 3 85961 commit-queue 2011-03-16 16:46:37 -0700 Comment on attachment 85961 patch for 56481 Clearing flags on attachment: 85961 Committed r81290: <http://trac.webkit.org/changeset/81290> 368638 4 commit-queue 2011-03-16 16:46:41 -0700 All reviewed patches have been landed. Closing bug. 368688 5 webkit.review.bot 2011-03-16 17:49:29 -0700 http://trac.webkit.org/changeset/81290 might have broken Windows 7 Release (Tests) The following tests are not passing: fast/events/popup-blocking-timers.html 85961 2011-03-16 13:21:17 -0700 2011-03-16 16:46:37 -0700 patch for 56481 stroketext.diff text/plain 1862 reed SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA4MTI3MykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTEtMDMtMTYgIE1pa2UgUmVlZCAgPHJlZWRAZ29vZ2xlLmNvbT4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZWVzdGFi bGlzaCB0eXBlZmFjZS9zaXplL2VuY29kaW5nIHdoZW4gZHJhd2luZyBzdHJva2VkIHRleHQKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU2NDgxCisKKyAg ICAgICAgTm8gbmV3IHRlc3RzLiBMYXlvdXRUZXN0cy9zdmcvY3NzL2NvbXBvc2l0ZS1zaGFkb3ct dGV4dC5zdmcKKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3NraWEvU2tpYUZvbnRXaW4u Y3BwOgorICAgICAgICAoV2ViQ29yZTo6cGFpbnRTa2lhVGV4dCk6CisKIDIwMTEtMDMtMTYgIENz YWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4KIAogICAgICAgICBbUXRdIEJ1aWxk Zml4IGFmdGVyIHI4MTIzMC4KSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9T a2lhRm9udFdpbi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9z a2lhL1NraWFGb250V2luLmNwcAkocmV2aXNpb24gODEyMjEpCisrKyBXZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL3NraWEvU2tpYUZvbnRXaW4uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zODAsNiAr MzgwLDExIEBAIGJvb2wgcGFpbnRTa2lhVGV4dChHcmFwaGljc0NvbnRleHQqIGNvbnQKICAgICAg ICAgcGFpbnQucmVzZXQoKTsKICAgICAgICAgcGxhdGZvcm1Db250ZXh0LT5zZXR1cFBhaW50Rm9y U3Ryb2tpbmcoJnBhaW50LCAwLCAwKTsKICAgICAgICAgcGFpbnQuc2V0RmxhZ3MoU2tQYWludDo6 a0FudGlBbGlhc19GbGFnKTsKKyNpZiBFTkFCTEUoU0tJQV9URVhUKQorICAgICAgICBwYWludC5z ZXRUZXh0RW5jb2RpbmcoU2tQYWludDo6a0dseXBoSURfVGV4dEVuY29kaW5nKTsKKyAgICAgICAg c2V0dXBQYWludEZvckZvbnQoaGZvbnQsICZwYWludCk7CisjZW5kaWYKKwogICAgICAgICBpZiAo ZGlkRmlsbCkgewogICAgICAgICAgICAgLy8gSWYgdGhlcmUgaXMgYSBzaGFkb3cgYW5kIHdlIGZp bGxlZCBhYm92ZSwgdGhlcmUgd2lsbCBhbHJlYWR5IGJlCiAgICAgICAgICAgICAvLyBhIHNoYWRv dy4gV2UgZG9uJ3Qgd2FudCB0byBkcmF3IGl0IGFnYWluIG9yIGl0IHdpbGwgYmUgdG9vIGRhcmsK QEAgLTM5MCw3ICszOTUsNyBAQCBib29sIHBhaW50U2tpYVRleHQoR3JhcGhpY3NDb250ZXh0KiBj b250CiAgICAgICAgICAgICAvLyB0aGluZyB3b3VsZCBiZSB0byBkcmF3IHRvIGEgbmV3IGxheWVy IGFuZCB0aGVuIGRyYXcgdGhhdCBsYXllcgogICAgICAgICAgICAgLy8gd2l0aCBhIHNoYWRvdy4g QnV0IHRoaXMgaXMgYSBsb3Qgb2YgZXh0cmEgd29yayBmb3Igc29tZXRoaW5nCiAgICAgICAgICAg ICAvLyB0aGF0IGlzbid0IG5vcm1hbGx5IGFuIGlzc3VlLgotICAgICAgICAgICAgU2tTYWZlVW5y ZWYocGFpbnQuc2V0TG9vcGVyKDApKTsKKyAgICAgICAgICAgIHBhaW50LnNldExvb3BlcigwKTsK ICAgICAgICAgfQogCiAgICAgICAgIGlmICghc2tpYURyYXdUZXh0KGhmb250LCBkYywgcGxhdGZv cm1Db250ZXh0LT5jYW52YXMoKSwgKm9yaWdpbiwgJnBhaW50LAo=