<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>56462</bug_id>
          
          <creation_ts>2011-03-16 08:12:16 -0700</creation_ts>
          <short_desc>Implement OBJC_CLASS macro in WebCore/config.h</short_desc>
          <delta_ts>2012-01-17 21:57:53 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Mac</rep_platform>
          <op_sys>OS X 10.6</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>DUPLICATE</resolution>
          <dup_id>76485</dup_id>
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="David Kilzer (:ddkilzer)">ddkilzer</reporter>
          <assigned_to name="David Kilzer (:ddkilzer)">ddkilzer</assigned_to>
          <cc>andersca</cc>
    
    <cc>cmarrin</cc>
    
    <cc>dino</cc>
    
    <cc>sam</cc>
    
    <cc>simon.fraser</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>368332</commentid>
    <comment_count>0</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2011-03-16 08:12:16 -0700</bug_when>
    <thetext>The WebKit2/config.h header has the following OBJC_CLASS macro defined:

#ifdef __OBJC__
#define OBJC_CLASS @class
#else
#define OBJC_CLASS class
#endif

This makes it possible to declare classes once for both Obj-C[++] and C++ source.  It would remove over 20 lines of declarations in Source/WebCore/platform/mac/WebCoreSystemInterface.h and other headers where both types must be declared.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>368358</commentid>
    <comment_count>1</comment_count>
    <who name="Anders Carlsson">andersca</who>
    <bug_when>2011-03-16 09:50:43 -0700</bug_when>
    <thetext>Maybe we could even put it in wtf/Platform.h ?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>369056</commentid>
    <comment_count>2</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2011-03-17 08:38:20 -0700</bug_when>
    <thetext>(In reply to comment #1)
&gt; Maybe we could even put it in wtf/Platform.h ?

I found that I had to add OBJC_CLASS to WebKitPrefix.h because of its use in all of the WebCore headers, so I think that moving it to Platform.h would cut down on the duplication between projects.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>537621</commentid>
    <comment_count>3</comment_count>
    <who name="Sam Weinig">sam</who>
    <bug_when>2012-01-17 21:57:53 -0800</bug_when>
    <thetext>

*** This bug has been marked as a duplicate of bug 76485 ***</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>