56444 2011-03-15 20:59:17 -0700 Add support for Sun Studio 12 compiler on Solaris 2011-03-17 13:07:35 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC Other RESOLVED FIXED P2 Normal --- 0 bentaylor.solx86 webkit-unassigned commit-queue oldest_to_newest 368162 0 bentaylor.solx86 2011-03-15 20:59:17 -0700 Adding support for Sun Studio 12 compiler on Solaris 10. This is a derivitive of the first of 16 patches from the bug in https://bugs.webkit.org/show_bug.cgi?id=24932. The other parts of the original patch have already been folded and transformed since the origination of this patch. 368163 1 85903 bentaylor.solx86 2011-03-15 21:04:49 -0700 Created attachment 85903 Proposed patch which compiles correctly in qt-4.7.1 with webkit enabled on Solaris 10 with SS12 C++ compiler This patch is what is remaining uncommited to the webkit source, from the patch 1 of 16 from bug https://bugs.webkit.org/show_bug.cgi?24932 originally done by Thiago Macierira. It simply adds support for the Sun Studio Compiler. 368394 2 85903 ap 2011-03-16 11:06:07 -0700 Comment on attachment 85903 Proposed patch which compiles correctly in qt-4.7.1 with webkit enabled on Solaris 10 with SS12 C++ compiler View in context: https://bugs.webkit.org/attachment.cgi?id=85903&action=review > Source/JavaScriptCore/ChangeLog:6 > + Add a COMPILER(SUNCC) define for Sun Studio 12. Streamlined patch > + 1 of 16 originally from https://bugs.webkit.org/show_bug.cgi?id=24932 You need to provide an URL of this bug, not some other one. Doesn't matter all that much in this particular case, because there isn't a lot to look for in this bug. 368399 3 bentaylor.solx86 2011-03-16 11:08:42 -0700 Happy to resubmit with a corrected ChangeLog. Let me know. 368427 4 85949 bentaylor.solx86 2011-03-16 11:37:29 -0700 Created attachment 85949 Updated patch which compiles correctly in qt-4.7.1 with webkit enabled on Solaris 10 with SS12 C++ compiler Updated ChangeLog to correctly identify this bug and to also identify the derivation of the patch. 369155 5 85949 ap 2011-03-17 10:52:58 -0700 Comment on attachment 85949 Updated patch which compiles correctly in qt-4.7.1 with webkit enabled on Solaris 10 with SS12 C++ compiler Due to an e-mail exchange, I'm assuming that you intended to mark this for review. 369238 6 commit-queue 2011-03-17 13:04:58 -0700 The commit-queue encountered the following flaky tests while processing attachment 85949: http/tests/inspector/network/network-size.html bug 56581 (author: pfeldman@chromium.org) The commit-queue is continuing to process your patch. 369241 7 85949 commit-queue 2011-03-17 13:07:30 -0700 Comment on attachment 85949 Updated patch which compiles correctly in qt-4.7.1 with webkit enabled on Solaris 10 with SS12 C++ compiler Clearing flags on attachment: 85949 Committed r81379: <http://trac.webkit.org/changeset/81379> 369242 8 commit-queue 2011-03-17 13:07:35 -0700 All reviewed patches have been landed. Closing bug. 85903 2011-03-15 21:04:49 -0700 2011-03-16 11:37:29 -0700 Proposed patch which compiles correctly in qt-4.7.1 with webkit enabled on Solaris 10 with SS12 C++ compiler webkit-bug-56444-support_for_SunStudio12CC_on_Solaris.diff text/plain 1137 bentaylor.solx86 SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gODEyMTMpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAK KzIwMTEtMDMtMTUgIEJlbiBUYXlsb3IgIDxiZW50YXlsb3Iuc29seDg2QGdtYWlsLmNvbT4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgYSBDT01Q SUxFUihTVU5DQykgZGVmaW5lIGZvciBTdW4gU3R1ZGlvIDEyLiBTdHJlYW1saW5lZCBwYXRjaAor ICAgICAgICAxIG9mIDE2IG9yaWdpbmFsbHkgZnJvbSBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjQ5MzIKKworICAgICAgICAqIHd0Zi9QbGF0Zm9ybS5oOgorCiAyMDEx LTAzLTE1ICBHZW9mZnJleSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2 aWV3ZWQgYnkgT2xpdmVyIEh1bnQuCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL1Bs YXRmb3JtLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9QbGF0Zm9y bS5oCShyZXZpc2lvbiA4MTE2NCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvUGxhdGZv cm0uaAkod29ya2luZyBjb3B5KQpAQCAtMTE0LDYgKzExNCwxMSBAQAogI2RlZmluZSBXVEZfQ09N UElMRVJfSU5URUwgMQogI2VuZGlmCiAKKy8qIENPTVBJTEVSKFNVTkNDKSAqLworI2lmIGRlZmlu ZWQoX19TVU5QUk9fQ0MpIHx8IGRlZmluZWQoX19TVU5QUk9fQykKKyNkZWZpbmUgV1RGX0NPTVBJ TEVSX1NVTkNDIDEKKyNlbmRpZgorCiAvKiA9PT09IENQVSgpIC0gdGhlIHRhcmdldCBDUFUgYXJj aGl0ZWN0dXJlID09PT0gKi8KIAogLyogVGhpcyBhbHNvIGRlZmluZXMgQ1BVKEJJR19FTkRJQU4p IG9yIENQVShNSURETEVfRU5ESUFOKSBvciBuZWl0aGVyLCBhcyBhcHByb3ByaWF0ZS4gKi8K 85949 2011-03-16 11:37:29 -0700 2011-03-17 13:07:30 -0700 Updated patch which compiles correctly in qt-4.7.1 with webkit enabled on Solaris 10 with SS12 C++ compiler webkit-bug-56444-JaveScriptCore-Platform.h.diff text/plain 1191 bentaylor.solx86 SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gODEyMTMpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAK KzIwMTEtMDMtMTUgIEJlbiBUYXlsb3IgIDxiZW50YXlsb3Iuc29seDg2QGdtYWlsLmNvbT4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgYSBDT01Q SUxFUihTVU5DQykgZGVmaW5lIGZvciBTdW4gU3R1ZGlvIDEyLiAKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpPzU2NDQ0CisgICAgICAgIGRlcml2ZWQgZnJvbSBw YXRjaCAxIG9mIDE2IG9yaWdpbmFsbHkgZnJvbSBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjQ5MzIKKworICAgICAgICAqIHd0Zi9QbGF0Zm9ybS5oOgorCiAyMDExLTAz LTE1ICBHZW9mZnJleSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgT2xpdmVyIEh1bnQuCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL1BsYXRm b3JtLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9QbGF0Zm9ybS5o CShyZXZpc2lvbiA4MTE2NCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvUGxhdGZvcm0u aAkod29ya2luZyBjb3B5KQpAQCAtMTE0LDYgKzExNCwxMSBAQAogI2RlZmluZSBXVEZfQ09NUElM RVJfSU5URUwgMQogI2VuZGlmCiAKKy8qIENPTVBJTEVSKFNVTkNDKSAqLworI2lmIGRlZmluZWQo X19TVU5QUk9fQ0MpIHx8IGRlZmluZWQoX19TVU5QUk9fQykKKyNkZWZpbmUgV1RGX0NPTVBJTEVS X1NVTkNDIDEKKyNlbmRpZgorCiAvKiA9PT09IENQVSgpIC0gdGhlIHRhcmdldCBDUFUgYXJjaGl0 ZWN0dXJlID09PT0gKi8KIAogLyogVGhpcyBhbHNvIGRlZmluZXMgQ1BVKEJJR19FTkRJQU4pIG9y IENQVShNSURETEVfRU5ESUFOKSBvciBuZWl0aGVyLCBhcyBhcHByb3ByaWF0ZS4gKi8K