56428 2011-03-15 16:50:35 -0700 Removed some more deprecated / unsafe append 2011-03-15 23:57:00 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 ggaren ggaren abarth eric webkit.review.bot oldest_to_newest 368040 0 ggaren 2011-03-15 16:50:35 -0700 Removed some more deprecated / unsafe append 368041 1 85875 ggaren 2011-03-15 16:53:00 -0700 Created attachment 85875 Patch 368043 2 ggaren 2011-03-15 16:54:11 -0700 Committed r81193: <http://trac.webkit.org/changeset/81193> 368227 3 webkit.review.bot 2011-03-15 23:57:00 -0700 http://trac.webkit.org/changeset/81193 might have broken WinCE Release (Build) 85875 2011-03-15 16:53:00 -0700 2011-03-15 16:53:43 -0700 Patch bug-56428-20110315165300.patch text/plain 7851 ggaren SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gODExOTIpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMzEgQEAK KzIwMTEtMDMtMTUgIEdlb2ZmcmV5IEdhcmVuICA8Z2dhcmVuQGFwcGxlLmNvbT4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmVkIHNvbWUgbW9y ZSBkZXByZWNhdGVkIC8gdW5zYWZlIGFwcGVuZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTY0MjgKKworICAgICAgICAqIGNvbGxlY3Rvci9oYW5kbGVz L0hhbmRsZVN0YWNrLmNwcDoKKyAgICAgICAgKEpTQzo6SGFuZGxlU3RhY2s6Om1hcmspOgorICAg ICAgICAqIGNvbGxlY3Rvci9oYW5kbGVzL0hhbmRsZVN0YWNrLmg6IE1hcmsgdGhlIGhhbmRsZSBz dGFjayB1c2luZyBhIEhlYXBSb290CisgICAgICAgIG1hcmtlciwgc2luY2UgaXQncyBhIGhlYXAg cm9vdC4KKyAgICAgICAgCisgICAgICAgICogcnVudGltZS9BcmdMaXN0LmNwcDoKKyAgICAgICAg KEpTQzo6TWFya2VkQXJndW1lbnRCdWZmZXI6Om1hcmtMaXN0cyk6CisgICAgICAgIChKU0M6Ok1h cmtlZEFyZ3VtZW50QnVmZmVyOjpzbG93QXBwZW5kKToKKyAgICAgICAgKiBydW50aW1lL0FyZ0xp c3QuaDogRGl0dG8uCisKKyAgICAgICAgKiBydW50aW1lL0hlYXAuY3BwOgorICAgICAgICAoSlND OjpIZWFwOjptYXJrUm9vdHMpOiBBZGRlZCBhIG1hcmsgY2FsbCBmb3IgbWFya2luZyB0aGUgaGFu ZGxlIHN0YWNrLgorICAgICAgICBJdCBzZWVtcyBsaWtlIE9saXZlciBmb3Jnb3QgdGhpcyBpbiBo aXMgbGFzdCBwYXRjaC4gKCEpCisKKyAgICAgICAgKiBydW50aW1lL01hcmtTdGFjay5oOiBSZW1v dmVkIGFwcGVuZFNsb3RzLCBzaW5jZSBpdCB3b3VsZCBhbGxvdyBhbgorICAgICAgICBvYmplY3Qg dG8gZW1iZWQgSlNWYWx1ZXMgZGlyZWN0bHkgaW5zdGVhZCBvZiB1c2luZyBXcml0ZUJhcnJpZXIu CisKKyAgICAgICAgKEpTQzo6TWFya1N0YWNrOjphcHBlbmQpOiBBZGRlZCBhIHByaXZhdGUgYXBw ZW5kIGZvciBhIGxpc3Qgb2YgdmFsdWVzLgorCisgICAgICAgIChKU0M6OkhlYXBSb290TWFya2Vy OjptYXJrKTogQWNjZXNzIHRvIHRoZSBhYm92ZS4KKwogMjAxMS0wMy0xNSAgR2VvZmZyZXkgR2Fy ZW4gIDxnZ2FyZW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE9saXZlciBIdW50 LgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2NvbGxlY3Rvci9oYW5kbGVzL0hhbmRsZVN0 YWNrLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvY29sbGVjdG9yL2hh bmRsZXMvSGFuZGxlU3RhY2suY3BwCShyZXZpc2lvbiA4MTE5MSkKKysrIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9jb2xsZWN0b3IvaGFuZGxlcy9IYW5kbGVTdGFjay5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTM5LDcgKzM5LDcgQEAgSGFuZGxlU3RhY2s6OkhhbmRsZVN0YWNrKCkKICAgICBncm93KCk7 CiB9CiAKLXZvaWQgSGFuZGxlU3RhY2s6Om1hcmsoTWFya1N0YWNrJiBtYXJrU3RhY2spCit2b2lk IEhhbmRsZVN0YWNrOjptYXJrKEhlYXBSb290TWFya2VyJiBoZWFwUm9vdE1hcmtlcikKIHsKICAg ICBjb25zdCBWZWN0b3I8SGFuZGxlU2xvdD4mIGJsb2NrcyA9IG1fYmxvY2tTdGFjay5ibG9ja3Mo KTsKICAgICBzaXplX3QgYmxvY2tMZW5ndGggPSBtX2Jsb2NrU3RhY2suYmxvY2tMZW5ndGg7CkBA IC00NywxMCArNDcsMTAgQEAgdm9pZCBIYW5kbGVTdGFjazo6bWFyayhNYXJrU3RhY2smIG1hcmtT dAogICAgIGludCBlbmQgPSBibG9ja3Muc2l6ZSgpIC0gMTsKICAgICBmb3IgKGludCBpID0gMDsg aSA8IGVuZDsgKytpKSB7CiAgICAgICAgIEhhbmRsZVNsb3QgYmxvY2sgPSBibG9ja3NbaV07Ci0g ICAgICAgIG1hcmtTdGFjay5hcHBlbmRTbG90cyhibG9jaywgYmxvY2tMZW5ndGgpOworICAgICAg ICBoZWFwUm9vdE1hcmtlci5tYXJrKGJsb2NrLCBibG9ja0xlbmd0aCk7CiAgICAgfQogICAgIEhh bmRsZVNsb3QgYmxvY2sgPSBibG9ja3NbZW5kXTsKLSAgICBtYXJrU3RhY2suYXBwZW5kU2xvdHMo YmxvY2ssIG1fZnJhbWUubV9uZXh0IC0gYmxvY2spOworICAgIGhlYXBSb290TWFya2VyLm1hcmso YmxvY2ssIG1fZnJhbWUubV9uZXh0IC0gYmxvY2spOwogfQogCiB2b2lkIEhhbmRsZVN0YWNrOjpn cm93KCkKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9jb2xsZWN0b3IvaGFuZGxlcy9IYW5k bGVTdGFjay5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9jb2xsZWN0b3Iv aGFuZGxlcy9IYW5kbGVTdGFjay5oCShyZXZpc2lvbiA4MTE5MSkKKysrIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9jb2xsZWN0b3IvaGFuZGxlcy9IYW5kbGVTdGFjay5oCSh3b3JraW5nIGNvcHkpCkBA IC0zNSw3ICszNSw3IEBACiBuYW1lc3BhY2UgSlNDIHsKIAogY2xhc3MgTG9jYWxTY29wZTsKLWNs YXNzIE1hcmtTdGFjazsKK2NsYXNzIEhlYXBSb290TWFya2VyOwogCiBjbGFzcyBIYW5kbGVTdGFj ayB7CiBwdWJsaWM6CkBAIC01Miw3ICs1Miw3IEBAIHB1YmxpYzoKIAogICAgIEhhbmRsZVNsb3Qg cHVzaCgpOwogCi0gICAgdm9pZCBtYXJrKE1hcmtTdGFjayYpOworICAgIHZvaWQgbWFyayhIZWFw Um9vdE1hcmtlciYpOwogCiBwcml2YXRlOgogICAgIHZvaWQgZ3JvdygpOwpJbmRleDogU291cmNl L0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvQXJnTGlzdC5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvQXJnTGlzdC5jcHAJKHJldmlzaW9uIDgxMTkxKQorKysg U291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvQXJnTGlzdC5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTM5LDEyICszOSwxMiBAQCB2b2lkIEFyZ0xpc3Q6OmdldFNsaWNlKGludCBzdGFydEluZGV4 LCBBCiAgICAgcmVzdWx0ID0gQXJnTGlzdChtX2FyZ3MgKyBzdGFydEluZGV4LCBtX2FyZ0NvdW50 IC0gc3RhcnRJbmRleCk7CiB9CiAKLXZvaWQgTWFya2VkQXJndW1lbnRCdWZmZXI6Om1hcmtMaXN0 cyhNYXJrU3RhY2smIG1hcmtTdGFjaywgTGlzdFNldCYgbWFya1NldCkKK3ZvaWQgTWFya2VkQXJn dW1lbnRCdWZmZXI6Om1hcmtMaXN0cyhIZWFwUm9vdE1hcmtlciYgaGVhcFJvb3RNYXJrZXIsIExp c3RTZXQmIG1hcmtTZXQpCiB7CiAgICAgTGlzdFNldDo6aXRlcmF0b3IgZW5kID0gbWFya1NldC5l bmQoKTsKICAgICBmb3IgKExpc3RTZXQ6Oml0ZXJhdG9yIGl0ID0gbWFya1NldC5iZWdpbigpOyBp dCAhPSBlbmQ7ICsraXQpIHsKICAgICAgICAgTWFya2VkQXJndW1lbnRCdWZmZXIqIGxpc3QgPSAq aXQ7Ci0gICAgICAgIG1hcmtTdGFjay5kZXByZWNhdGVkQXBwZW5kVmFsdWVzKGxpc3QtPm1fYnVm ZmVyLCBsaXN0LT5tX3NpemUpOworICAgICAgICBoZWFwUm9vdE1hcmtlci5tYXJrKHJlaW50ZXJw cmV0X2Nhc3Q8SlNWYWx1ZSo+KGxpc3QtPm1fYnVmZmVyKSwgbGlzdC0+bV9zaXplKTsKICAgICB9 CiB9CiAKQEAgLTU2LDggKzU2LDggQEAgdm9pZCBNYXJrZWRBcmd1bWVudEJ1ZmZlcjo6c2xvd0Fw cGVuZChKUwogICAgIC8vIG91ciBWZWN0b3IncyBpbmxpbmUgY2FwYWNpdHksIHRob3VnaCwgb3Vy IHZhbHVlcyBtb3ZlIHRvIHRoZSAKICAgICAvLyBoZWFwLCB3aGVyZSB0aGV5IGRvIG5lZWQgZXhw bGljaXQgbWFya2luZy4KICAgICBpZiAoIW1fbWFya1NldCkgewotICAgICAgICAvLyBXZSBjYW4g b25seSByZWdpc3RlciBmb3IgZXhwbGljaXQgbWFya2luZyBvbmNlIHdlIGtub3cgd2hpY2ggaGVh cAotICAgICAgICAvLyBpcyB0aGUgY3VycmVudCBvbmUsIGkuZS4sIHdoZW4gYSBub24taW1tZWRp YXRlIHZhbHVlIGlzIGFwcGVuZGVkLgorICAgICAgICAvLyBGSVhNRTogRXZlbiBpZiB2IGlzIG5v dCBhIEpTQ2VsbCosIGlmIHByZXZpb3VzIHZhbHVlcyBpbiB0aGUgYnVmZmVyCisgICAgICAgIC8v IGFyZSwgdGhlbiB0aGV5IHdvbid0IGJlIG1hcmtlZCEKICAgICAgICAgaWYgKEhlYXAqIGhlYXAg PSBIZWFwOjpoZWFwKHYpKSB7CiAgICAgICAgICAgICBMaXN0U2V0JiBtYXJrU2V0ID0gaGVhcC0+ bWFya0xpc3RTZXQoKTsKICAgICAgICAgICAgIG1hcmtTZXQuYWRkKHRoaXMpOwpJbmRleDogU291 cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvQXJnTGlzdC5oCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0FyZ0xpc3QuaAkocmV2aXNpb24gODExOTEpCisrKyBT b3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9BcmdMaXN0LmgJKHdvcmtpbmcgY29weSkKQEAg LTE0MSw3ICsxNDEsNyBAQCBuYW1lc3BhY2UgSlNDIHsKICAgICAgICAgY29uc3RfaXRlcmF0b3Ig YmVnaW4oKSBjb25zdCB7IHJldHVybiBtX2J1ZmZlcjsgfQogICAgICAgICBjb25zdF9pdGVyYXRv ciBlbmQoKSBjb25zdCB7IHJldHVybiBtX2J1ZmZlciArIG1fc2l6ZTsgfQogCi0gICAgICAgIHN0 YXRpYyB2b2lkIG1hcmtMaXN0cyhNYXJrU3RhY2smLCBMaXN0U2V0Jik7CisgICAgICAgIHN0YXRp YyB2b2lkIG1hcmtMaXN0cyhIZWFwUm9vdE1hcmtlciYsIExpc3RTZXQmKTsKIAogICAgIHByaXZh dGU6CiAgICAgICAgIHZvaWQgc2xvd0FwcGVuZChKU1ZhbHVlKTsKSW5kZXg6IFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9ydW50aW1lL0hlYXAuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9ydW50aW1lL0hlYXAuY3BwCShyZXZpc2lvbiA4MTE5MSkKKysrIFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9ydW50aW1lL0hlYXAuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMjcsMTIgKzIy NywxMyBAQCB2b2lkIEhlYXA6Om1hcmtSb290cygpCiAgICAgbWFya1N0YWNrLmRyYWluKCk7CiAK ICAgICBpZiAobV9tYXJrTGlzdFNldCAmJiBtX21hcmtMaXN0U2V0LT5zaXplKCkpCi0gICAgICAg IE1hcmtlZEFyZ3VtZW50QnVmZmVyOjptYXJrTGlzdHMobWFya1N0YWNrLCAqbV9tYXJrTGlzdFNl dCk7CisgICAgICAgIE1hcmtlZEFyZ3VtZW50QnVmZmVyOjptYXJrTGlzdHMoaGVhcFJvb3RNYXJr ZXIsICptX21hcmtMaXN0U2V0KTsKICAgICBpZiAobV9nbG9iYWxEYXRhLT5leGNlcHRpb24pCiAg ICAgICAgIGhlYXBSb290TWFya2VyLm1hcmsoJm1fZ2xvYmFsRGF0YS0+ZXhjZXB0aW9uKTsKICAg ICBtYXJrU3RhY2suZHJhaW4oKTsKIAogICAgIG1faGFuZGxlSGVhcC5tYXJrU3Ryb25nSGFuZGxl cyhtYXJrU3RhY2spOworICAgIG1faGFuZGxlU3RhY2subWFyayhoZWFwUm9vdE1hcmtlcik7CiAK ICAgICAvLyBNYXJrIHRoZSBzbWFsbCBzdHJpbmdzIGNhY2hlIGxhc3QsIHNpbmNlIGl0IHdpbGwg Y2xlYXIgaXRzZWxmIGlmIG5vdGhpbmcKICAgICAvLyBlbHNlIGhhcyBtYXJrZWQgaXQuCkluZGV4 OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9NYXJrU3RhY2suaAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9NYXJrU3RhY2suaAkocmV2aXNpb24gODEx OTEpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9NYXJrU3RhY2suaAkod29ya2lu ZyBjb3B5KQpAQCAtNzIsMTIgKzcyLDYgQEAgbmFtZXNwYWNlIEpTQyB7CiAgICAgICAgICAgICAg ICAgbV9tYXJrU2V0cy5hcHBlbmQoTWFya1NldCh2YWx1ZXMsIHZhbHVlcyArIGNvdW50LCBwcm9w ZXJ0aWVzKSk7CiAgICAgICAgIH0KICAgICAgICAgCi0gICAgICAgIHZvaWQgYXBwZW5kU2xvdHMo SGFuZGxlU2xvdCB2YWx1ZXMsIHNpemVfdCBjb3VudCwgTWFya1NldFByb3BlcnRpZXMgcHJvcGVy dGllcyA9IE5vTnVsbFZhbHVlcykKLSAgICAgICAgewotICAgICAgICAgICAgaWYgKGNvdW50KQot ICAgICAgICAgICAgICAgIG1fbWFya1NldHMuYXBwZW5kKE1hcmtTZXQodmFsdWVzLCB2YWx1ZXMg KyBjb3VudCwgcHJvcGVydGllcykpOwotICAgICAgICB9Ci0KICAgICAgICAgdm9pZCBhcHBlbmQo Q29uc2VydmF0aXZlUm9vdHMmIGNvbnNlcnZhdGl2ZVJvb3RzKQogICAgICAgICB7CiAgICAgICAg ICAgICBKU0NlbGwqKiByb290cyA9IGNvbnNlcnZhdGl2ZVJvb3RzLnJvb3RzKCk7CkBAIC05OCw2 ICs5Miw3IEBAIG5hbWVzcGFjZSBKU0MgewogICAgIHByaXZhdGU6CiAgICAgICAgIGZyaWVuZCBj bGFzcyBIZWFwUm9vdE1hcmtlcjsgLy8gQWxsb3dlZCB0byBtYXJrIGEgSlNWYWx1ZSogb3IgSlND ZWxsKiogZGlyZWN0bHkuCiAgICAgICAgIHZvaWQgYXBwZW5kKEpTVmFsdWUqKTsKKyAgICAgICAg dm9pZCBhcHBlbmQoSlNWYWx1ZSosIHNpemVfdCBjb3VudCk7CiAgICAgICAgIHZvaWQgYXBwZW5k KEpTQ2VsbCoqKTsKIAogICAgICAgICB2b2lkIGludGVybmFsQXBwZW5kKEpTQ2VsbCopOwpAQCAt MjE2LDYgKzIxMSwxMyBAQCBuYW1lc3BhY2UgSlNDIHsKICNlbmRpZgogICAgIH07CiAKKyAgICBp bmxpbmUgdm9pZCBNYXJrU3RhY2s6OmFwcGVuZChKU1ZhbHVlKiBzbG90LCBzaXplX3QgY291bnQp CisgICAgeworICAgICAgICBpZiAoIWNvdW50KQorICAgICAgICAgICAgcmV0dXJuOworICAgICAg ICBtX21hcmtTZXRzLmFwcGVuZChNYXJrU2V0KHNsb3QsIHNsb3QgKyBjb3VudCwgTm9OdWxsVmFs dWVzKSk7CisgICAgfQorCiAgICAgLy8gUHJpdmlsZWdlZCBjbGFzcyBmb3IgbWFya2luZyBKU1Zh bHVlcyBkaXJlY3RseS4gSXQgaXMgb25seSBzYWZlIHRvIHVzZQogICAgIC8vIHRoaXMgY2xhc3Mg dG8gbWFyayBkaXJlY3QgaGVhcCByb290cyB0aGF0IGFyZSBtYXJrZWQgZHVyaW5nIGV2ZXJ5IEdD IHBhc3MuCiAgICAgLy8gQWxsIG90aGVyIHJlZmVyZW5jZXMgc2hvdWxkIGJlIHdyYXBwZWQgaW4g V3JpdGVCYXJyaWVycyBhbmQgbWFya2VkIHRocm91Z2gKQEAgLTIyNyw2ICsyMjksNyBAQCBuYW1l c3BhY2UgSlNDIHsKICAgICAgICAgCiAgICAgcHVibGljOgogICAgICAgICB2b2lkIG1hcmsoSlNW YWx1ZSopOworICAgICAgICB2b2lkIG1hcmsoSlNWYWx1ZSosIHNpemVfdCk7CiAgICAgICAgIHZv aWQgbWFyayhKU1N0cmluZyoqKTsKICAgICAgICAgdm9pZCBtYXJrKEpTQ2VsbCoqKTsKIApAQCAt MjQ0LDYgKzI0NywxMSBAQCBuYW1lc3BhY2UgSlNDIHsKICAgICAgICAgbV9tYXJrU3RhY2suYXBw ZW5kKHNsb3QpOwogICAgIH0KIAorICAgIGlubGluZSB2b2lkIEhlYXBSb290TWFya2VyOjptYXJr KEpTVmFsdWUqIHNsb3QsIHNpemVfdCBjb3VudCkKKyAgICB7CisgICAgICAgIG1fbWFya1N0YWNr LmFwcGVuZChzbG90LCBjb3VudCk7CisgICAgfQorCiAgICAgaW5saW5lIHZvaWQgSGVhcFJvb3RN YXJrZXI6Om1hcmsoSlNTdHJpbmcqKiBzbG90KQogICAgIHsKICAgICAgICAgbV9tYXJrU3RhY2su YXBwZW5kKHJlaW50ZXJwcmV0X2Nhc3Q8SlNDZWxsKio+KHNsb3QpKTsK