56416 2011-03-15 14:34:07 -0700 Add script to convert a patch to a prettypatch and show in the default browser 2011-03-16 00:04:19 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 sam sam abarth eric webkit.review.bot oldest_to_newest 367947 0 sam 2011-03-15 14:34:07 -0700 Add script to convert a patch to a prettypatch and show in the default browser 367950 1 85860 sam 2011-03-15 14:35:22 -0700 Created attachment 85860 Patch 368010 2 85860 darin 2011-03-15 15:56:43 -0700 Comment on attachment 85860 Patch Calling it pretty-diff makes it sound like a diff tool. Maybe you could name it some way that makes it clear that its input is a “patch” or “diff” rather than making it seem like the tool is a “diff” tool. 368115 3 sam 2011-03-15 18:20:06 -0700 Landed as show-pretty-diff in r81206. 368238 4 webkit.review.bot 2011-03-15 23:57:53 -0700 http://trac.webkit.org/changeset/81206 might have broken WinCE Release (Build) 368242 5 eric 2011-03-16 00:04:19 -0700 webkit-patch pretty-diff already knows how to show the current diff as a pretty diff. But it's always good to have more tools. :) 85860 2011-03-15 14:35:22 -0700 2011-03-15 15:56:43 -0700 Patch bug-56416-20110315143521.patch text/plain 3957 sam SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDgxMTc0KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTcgQEAKKzIwMTEtMDMtMTUgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgc2NyaXB0IHRv IGNvbnZlcnQgYSBwYXRjaCB0byBhIHByZXR0eXBhdGNoIGFuZCBzaG93IGluIHRoZSBkZWZhdWx0 IGJyb3dzZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTU2NDE2CisKKyAgICAgICAgVGhpcyBjYW4gYmUgdXNlZCBlaXRoZXIgbGlrZQorICAgICAgICAg ICAgJCBzdm4tY3JlYXRlLXBhdGNoIHwgcHJldHR5LWRpZmYKKyAgICAgICAgb3IKKyAgICAgICAg ICAgICQgcHJldHR5LWRpZmYgcGF0Y2guZGlmZgorCisgICAgICAgICogU2NyaXB0cy9wcmV0dHkt ZGlmZjogQWRkZWQuCisKIDIwMTEtMDMtMTUgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFw cGxlLmNvbT4KIAogICAgICAgICBUcnkgdG8gZml4IHRoZSBXaW5kb3dzIGJ1aWxkLgpJbmRleDog VG9vbHMvU2NyaXB0cy9wcmV0dHktZGlmZgo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3By ZXR0eS1kaWZmCShyZXZpc2lvbiAwKQorKysgVG9vbHMvU2NyaXB0cy9wcmV0dHktZGlmZgkocmV2 aXNpb24gMCkKQEAgLTAsMCArMSw3NyBAQAorIyEvdXNyL2Jpbi9wZXJsIC13CisKKyMgQ29weXJp Z2h0IChDKSAyMDExIEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyMKKyMgUmVkaXN0 cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRo b3V0CisjIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xs b3dpbmcgY29uZGl0aW9ucworIyBhcmUgbWV0OgorIyAxLiBSZWRpc3RyaWJ1dGlvbnMgb2Ygc291 cmNlIGNvZGUgbXVzdCByZXRhaW4gdGhlIGFib3ZlIGNvcHlyaWdodAorIyAgICBub3RpY2UsIHRo aXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93aW5nIGRpc2NsYWltZXIuCisjIDIu IFJlZGlzdHJpYnV0aW9ucyBpbiBiaW5hcnkgZm9ybSBtdXN0IHJlcHJvZHVjZSB0aGUgYWJvdmUg Y29weXJpZ2h0CisjICAgIG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBm b2xsb3dpbmcgZGlzY2xhaW1lciBpbiB0aGUKKyMgICAgZG9jdW1lbnRhdGlvbiBhbmQvb3Igb3Ro ZXIgbWF0ZXJpYWxzIHByb3ZpZGVkIHdpdGggdGhlIGRpc3RyaWJ1dGlvbi4KKyMKKyMgVEhJUyBT T0ZUV0FSRSBJUyBQUk9WSURFRCBCWSBBUFBMRSBJTkMuIEFORCBJVFMgQ09OVFJJQlVUT1JTIGBg QVMgSVMnJworIyBBTkQgQU5ZIEVYUFJFU1MgT1IgSU1QTElFRCBXQVJSQU5USUVTLCBJTkNMVURJ TkcsIEJVVCBOT1QgTElNSVRFRCBUTywKKyMgVEhFIElNUExJRUQgV0FSUkFOVElFUyBPRiBNRVJD SEFOVEFCSUxJVFkgQU5EIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUgorIyBQVVJQT1NFIEFSRSBE SVNDTEFJTUVELiBJTiBOTyBFVkVOVCBTSEFMTCBBUFBMRSBJTkMuIE9SIElUUyBDT05UUklCVVRP UlMKKyMgQkUgTElBQkxFIEZPUiBBTlkgRElSRUNULCBJTkRJUkVDVCwgSU5DSURFTlRBTCwgU1BF Q0lBTCwgRVhFTVBMQVJZLCBPUgorIyBDT05TRVFVRU5USUFMIERBTUFHRVMgKElOQ0xVRElORywg QlVUIE5PVCBMSU1JVEVEIFRPLCBQUk9DVVJFTUVOVCBPRgorIyBTVUJTVElUVVRFIEdPT0RTIE9S IFNFUlZJQ0VTOyBMT1NTIE9GIFVTRSwgREFUQSwgT1IgUFJPRklUUzsgT1IgQlVTSU5FU1MKKyMg SU5URVJSVVBUSU9OKSBIT1dFVkVSIENBVVNFRCBBTkQgT04gQU5ZIFRIRU9SWSBPRiBMSUFCSUxJ VFksIFdIRVRIRVIgSU4KKyMgQ09OVFJBQ1QsIFNUUklDVCBMSUFCSUxJVFksIE9SIFRPUlQgKElO Q0xVRElORyBORUdMSUdFTkNFIE9SIE9USEVSV0lTRSkKKyMgQVJJU0lORyBJTiBBTlkgV0FZIE9V VCBPRiBUSEUgVVNFIE9GIFRISVMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRgorIyBUSEUg UE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1BR0UuCisKK3VzZSBzdHJpY3Q7Cit1c2UgRmluZEJpbjsK K3VzZSBGaWxlOjpUZW1wIHF3KHRlbXBmaWxlKTsKK3VzZSBsaWIgJEZpbmRCaW46OkJpbjsKK3Vz ZSB3ZWJraXRkaXJzOworCitteSAkaW5wdXRQYXRoID0gIiI7CitpZiAoJEFSR1ZbMF0pIHsKKyAg ICAkaW5wdXRQYXRoID0gJEFSR1ZbMF0KK30gZWxzZSB7CisgICAgIyBDcmVhdGUgYSB0ZW1wb3Jh cnkgZmlsZSBmb3IgU1RESU4uCisgICAgIyBGSVhNRTogV2UgY2FuIHByb2JhYmx5IGF2b2lkIHB1 dHRpbmcgdGhpcyBvbiB0aGUgZGlzayBieSBkaXJlY3RseSBwaXBpbmcKKyAgICAjIHRvIHByZXR0 aWZ5LnJiIHZpYSBJUEM6Ok9wZW4yLgorICAgIG15ICRpbnB1dFRlbXBGaWxlSGFuZGxlOworICAg ICgkaW5wdXRUZW1wRmlsZUhhbmRsZSwgJGlucHV0UGF0aCkgPSB0ZW1wZmlsZSgKKyAgICAgICAg ImlucHV0dGVtcC1YWFhYWFhYWCIsCisgICAgICAgIERJUiA9PiBGaWxlOjpTcGVjLT50bXBkaXIo KSwKKyAgICAgICAgU1VGRklYID0+ICIuZGlmZiIsCisgICAgICAgIFVOTElOSyA9PiAwLAorICAg ICk7CisKKyAgICB3aGlsZSAoPFNURElOPikgeworICAgICAgICBwcmludCAkaW5wdXRUZW1wRmls ZUhhbmRsZSAkXzsKKyAgICB9CisKKyAgICBjbG9zZSgkaW5wdXRUZW1wRmlsZUhhbmRsZSk7Cit9 CisKKyMgQ3JlYXRlIGEgdGVtcG9yYXJ5IGZpbGUgZm9yIHByZXR0aWZpZWQgcGF0Y2guCitteSAo JHByZXR0eWRpZmZGaWxlSGFuZGxlLCAkcHJldHR5ZGlmZlBhdGgpID0gdGVtcGZpbGUoCisgICAg InByZXR0eWRpZmYtWFhYWFhYWFgiLAorICAgIERJUiA9PiBGaWxlOjpTcGVjLT50bXBkaXIoKSwK KyAgICBTVUZGSVggPT4gIi5odG1sIiwKKyAgICBVTkxJTksgPT4gMCwKKyk7CitjbG9zZSgkcHJl dHR5ZGlmZkZpbGVIYW5kbGUpOworCitteSAkcHJldHR5UGF0Y2hEaXIgPSBzb3VyY2VEaXIoKSAu ICIvV2Vic2l0ZXMvYnVncy53ZWJraXQub3JnL1ByZXR0eVBhdGNoLyI7CitteSAkcHJldHR5UGF0 Y2hUb29sID0gc291cmNlRGlyKCkgLiAiL1dlYnNpdGVzL2J1Z3Mud2Via2l0Lm9yZy9QcmV0dHlQ YXRjaC9wcmV0dGlmeS5yYiI7CisKK215ICRwYXRoVG9QcmV0dGlmeSA9ICJydWJ5IC1JICIgLiBz b3VyY2VEaXIoKSAuICIvV2Vic2l0ZXMvYnVncy53ZWJraXQub3JnL1ByZXR0eVBhdGNoLyAiIC4g c291cmNlRGlyKCkgLiAiL1dlYnNpdGVzL2J1Z3Mud2Via2l0Lm9yZy9QcmV0dHlQYXRjaC9wcmV0 dGlmeS5yYiI7CitzeXN0ZW0gIiRwYXRoVG9QcmV0dGlmeSAkaW5wdXRQYXRoID4gJHByZXR0eWRp ZmZQYXRoIjsKKworaWYgKGlzQXBwbGVNYWNXZWJLaXQoKSkgeworICAgIHN5c3RlbSAib3BlbiIs ICRwcmV0dHlkaWZmUGF0aDsKK30gZWxzaWYgKGlzQ3lnd2luKCkpIHsKKyAgICBzeXN0ZW0gImN5 Z3N0YXJ0IiwkcHJldHR5ZGlmZlBhdGg7Cit9IGVsc2lmIChpc1dpbmRvd3MoKSkgeworICAgIHN5 c3RlbSAic3RhcnQiLCAkcHJldHR5ZGlmZlBhdGg7Cit9IGVsc2UgeworICAgIHByaW50ICJDcmVh dGVkIHByZXR0eS1kaWZmIGF0ICIgLiAkcHJldHR5ZGlmZlBhdGggLiAiLiI7Cit9CgpQcm9wZXJ0 eSBjaGFuZ2VzIG9uOiBUb29scy9TY3JpcHRzL3ByZXR0eS1kaWZmCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KQWRkZWQ6 IHN2bjpleGVjdXRhYmxlCiAgICsgKgoK