56410 2011-03-15 13:44:12 -0700 EventHandler needs cleanup 2011-05-04 20:08:40 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) All All NEW P2 Enhancement --- 58470 59553 59555 59556 58472 58503 59580 59835 59837 60200 60228 1 rniwa webkit-unassigned ap cmarcelo dglazkov sam oldest_to_newest 367922 0 rniwa 2011-03-15 13:44:12 -0700 EventHandler has many duplicated code and long functions. This entire class needs to be refactored and cleaned up. 370223 1 sam 2011-03-20 12:00:04 -0700 If we are going to undertake cleaning up EventHandler, which is an extremely laudable goal and needs to be done, we should consider making some changes to its design as well. For instance, does it really need to be per-frame, or can we make it per Page? 371567 2 rniwa 2011-03-22 12:44:20 -0700 (In reply to comment #1) > If we are going to undertake cleaning up EventHandler, which is an extremely laudable goal and needs to be done, we should consider making some changes to its design as well. For instance, does it really need to be per-frame, or can we make it per Page? It does store some states so we'll be changing the behavior if we're moving it to Page-level. I guess we'll need to investigate per feature basis. It might even be that we need two separate classes for Page-level and Frame-level states. 374039 3 dglazkov 2011-03-26 21:20:56 -0700 Some of the bits from EventHandler should be moved to EventDispatcher, which is being birthed in bug 57168.