56403 2011-03-15 13:02:17 -0700 [GStreamer] There is no need to set the state of the pipeline to playing, HTMLMediaElement will do it. 2011-03-16 03:44:43 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 menard menard commit-queue gustavo mrobinson pnormand oldest_to_newest 367873 0 menard 2011-03-15 13:02:17 -0700 In case of a seek on a live pipeline there is no need to call gst_element_set_state(m_playBin, GST_STATE_PLAYING); As soon as HTMLMediaElement::updatePlayState() is called (like when the data comes in) the playback will be relaunched i.e the pause() made when beginScrubbing is done is just internal. 367875 1 85845 menard 2011-03-15 13:07:30 -0700 Created attachment 85845 Proposed patch. 368004 2 85845 mrobinson 2011-03-15 15:52:34 -0700 Comment on attachment 85845 Proposed patch. Looks good to me, but I'd like Philippe to take a look at this as well before you land it. 368261 3 85845 pnormand 2011-03-16 01:49:08 -0700 Comment on attachment 85845 Proposed patch. Yep I discussed about this patch with Alexis, I tested it on GTK, no regression spotted! 368276 4 commit-queue 2011-03-16 03:37:08 -0700 The commit-queue encountered the following flaky tests while processing attachment 85845: transitions/interrupted-accelerated-transition.html bug 56242 (authors: simon.fraser@apple.com and tonyg@chromium.org) The commit-queue is continuing to process your patch. 368278 5 85845 commit-queue 2011-03-16 03:44:39 -0700 Comment on attachment 85845 Proposed patch. Clearing flags on attachment: 85845 Committed r81234: <http://trac.webkit.org/changeset/81234> 368279 6 commit-queue 2011-03-16 03:44:43 -0700 All reviewed patches have been landed. Closing bug. 85845 2011-03-15 13:07:30 -0700 2011-03-16 03:44:39 -0700 Proposed patch. patch.diff text/plain 2053 menard ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3ZTdjZjNmLi4yNWYwZjlhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTEtMDMtMTUgIEFsZXhpcyBNZW5hcmQgIDxhbGV4aXMubWVuYXJkQG9wZW5ib3NzYS5v cmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dT dHJlYW1lcl0gVGhlcmUgaXMgbm8gbmVlZCB0byBzZXQgdGhlIHN0YXRlIG9mIHRoZSBwaXBlbGlu ZSB0byBwbGF5aW5nLCBIVE1MTWVkaWFFbGVtZW50IHdpbGwgZG8gaXQuCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NjQwMworCisgICAgICAgIEluIGNh c2Ugb2YgYSBzZWVrIG9uIGEgbGl2ZSBwaXBlbGluZSB0aGVyZSBpcyBubyBuZWVkIHRvIGNhbGwg Z3N0X2VsZW1lbnRfc2V0X3N0YXRlKG1fcGxheUJpbiwgR1NUX1NUQVRFX1BMQVlJTkcpOworICAg ICAgICBBcyBzb29uIGFzIEhUTUxNZWRpYUVsZW1lbnQ6OnVwZGF0ZVBsYXlTdGF0ZSgpIGlzIGNh bGxlZCAobGlrZSB3aGVuIHRoZSBkYXRhIGNvbWVzIGluKSB0aGUgcGxheWJhY2sgd2lsbCBiZSBy ZWxhdW5jaGVkCisgICAgICAgIGkuZSB0aGUgcGF1c2UoKSBtYWRlIHdoZW4gYmVnaW5TY3J1YmJp bmcgaXMgZG9uZSBpcyBqdXN0IGludGVybmFsLgorCisgICAgICAgIE5vIG5ldyB0ZXN0czogVmVy aWZpZWQgbWFudWFsbHkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIv TWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlh UGxheWVyUHJpdmF0ZUdTdHJlYW1lcjo6dXBkYXRlU3RhdGVzKToKKwogMjAxMS0wMy0xNSAgU2Vy Z2lvIFZpbGxhciBTZW5pbiAgPHN2aWxsYXJAaWdhbGlhLmNvbT4KIAogICAgICAgICBSZXZpZXdl ZCBieSBYYW4gTG9wZXouCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3Ry ZWFtZXIuY3BwCmluZGV4IDM3NjNlZjcuLjcyNjM5YjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFt ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9N ZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwCkBAIC0xMDQ2LDE1ICsxMDQ2LDkgQEAgdm9p ZCBNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXI6OnVwZGF0ZVN0YXRlcygpCiAgICAgICAgIGlm ICghbV9pc1N0cmVhbWluZyAmJiAhbV9idWZmZXJpbmcpCiAgICAgICAgICAgICByZXR1cm47CiAK LSAgICAgICAgLy8gUmVzdW1lIHBsYXliYWNrIGlmIGEgc2VlayB3YXMgcGVyZm9ybWVkIGluIGEg bGl2ZSBwaXBlbGluZQotICAgICAgICAvLyBvciBkdXJpbmcgcHJvZ3Jlc3NpdmUgZG93bmxvYWQu IFRoYXQgc2Vjb25kIHVzZS1jYXNlCi0gICAgICAgIC8vIGhhcHBlbnMgd2hlbiB0aGUgc2VlayBp cyBwZXJmb3JtZWQgdG8gYSByZWdpb24gb2YgdGhlIG1lZGlhCi0gICAgICAgIC8vIHRoYXQgaGFz bid0IGJlZW4gZG93bmxvYWRlZCB5ZXQuCiAgICAgICAgIGlmIChtX3NlZWtpbmcpIHsKICAgICAg ICAgICAgIHNob3VsZFVwZGF0ZUFmdGVyU2VlayA9IHRydWU7CiAgICAgICAgICAgICBtX3NlZWtp bmcgPSBmYWxzZTsKLSAgICAgICAgICAgIGlmIChtX3BhdXNlZCkKLSAgICAgICAgICAgICAgICBn c3RfZWxlbWVudF9zZXRfc3RhdGUobV9wbGF5QmluLCBHU1RfU1RBVEVfUExBWUlORyk7CiAgICAg ICAgIH0KICAgICAgICAgYnJlYWs7CiAgICAgY2FzZSBHU1RfU1RBVEVfQ0hBTkdFX0ZBSUxVUkU6 Cg==