56381 2011-03-15 09:27:52 -0700 Objective-C classes should be typedef-ed as structs (not void*) in C++ 2011-03-16 08:01:59 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 ddkilzer ddkilzer andersca cmarrin simon.fraser zwarich oldest_to_newest 367702 0 85816 ddkilzer 2011-03-15 09:27:52 -0700 Created attachment 85816 Patch Reviewed by NOBODY (OOPS!). Typedef-ing Objective-C classes as void* for pure C++ makes it easier for bugs to creep in because compilers can't do any type checking for void pointers. * platform/graphics/GraphicsContext3D.h: Changed typedef declarations for CALayer and WebGLLayer from void* to structs. (WebCore::GraphicsContext3D::platformLayer): Changed static_cast<CALayer*> to reinterpret_cast<CALayer*> now that CALayer and WebGLLayer are not void pointers. * platform/graphics/GraphicsLayer.h: Changed typedef declaration for PlatformLayer from void* to struct CALayer. * platform/graphics/ca/PlatformCAAnimation.h: Changed typedef declaration for CAPropertyAnimation from void* to a struct. Extracted typdef for PlatformAnimationRef. --- 4 files changed, 27 insertions(+), 7 deletions(-) 367806 1 ddkilzer 2011-03-15 11:24:49 -0700 Committed r81156: <http://trac.webkit.org/changeset/81156> 367951 2 ddkilzer 2011-03-15 14:35:30 -0700 (In reply to comment #1) > Committed r81156: <http://trac.webkit.org/changeset/81156> This broke building WebKit with clang. Anders is working on a fix. 367955 3 ddkilzer 2011-03-15 14:38:13 -0700 (In reply to comment #2) > (In reply to comment #1) > > Committed r81156: <http://trac.webkit.org/changeset/81156> > > This broke building WebKit with clang. Anders is working on a fix. Fixed in r81172. <http://trac.webkit.org/changeset/81172> 368329 4 ddkilzer 2011-03-16 08:01:59 -0700 (In reply to comment #3) > (In reply to comment #2) > > (In reply to comment #1) > > > Committed r81156: <http://trac.webkit.org/changeset/81156> > > > > This broke building WebKit with clang. Anders is working on a fix. > > Fixed in r81172. <http://trac.webkit.org/changeset/81172> Clean-up in r81242. <http://trac.webkit.org/changeset/81242> 85816 2011-03-15 09:27:52 -0700 2011-03-15 10:22:49 -0700 Patch 20110315092751.patch text/plain 3846 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogODExMzYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBkNjk3OGQ1MDRkYWJhNDlj ZWJmOWYxOGI0ZTExNWY0OTQwYzFkYjcyLi4yZmQ4N2I4NzEwMDBmMTdiZjA2YWE2ZmVlNjc3YmU1 ZDRjMDg4NDVlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQgQEAKKzIwMTEtMDMtMTUgIERhdmlk IEtpbHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KKworICAgICAgICBPYmplY3RpdmUtQyBjbGFz c2VzIHNob3VsZCBiZSB0eXBlZGVmLWVkIGFzIHN0cnVjdHMgKG5vdCB2b2lkKikgaW4gQysrCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVHlwZWRlZi1p bmcgT2JqZWN0aXZlLUMgY2xhc3NlcyBhcyB2b2lkKiBmb3IgcHVyZSBDKysgbWFrZXMgaXQKKyAg ICAgICAgZWFzaWVyIGZvciBidWdzIHRvIGNyZWVwIGluIGJlY2F1c2UgY29tcGlsZXJzIGNhbid0 IGRvIGFueSB0eXBlCisgICAgICAgIGNoZWNraW5nIGZvciB2b2lkIHBvaW50ZXJzLgorCisgICAg ICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NDb250ZXh0M0QuaDogQ2hhbmdlZCB0eXBl ZGVmCisgICAgICAgIGRlY2xhcmF0aW9ucyBmb3IgQ0FMYXllciBhbmQgV2ViR0xMYXllciBmcm9t IHZvaWQqIHRvIHN0cnVjdHMuCisgICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0NvbnRleHQzRDo6 cGxhdGZvcm1MYXllcik6IENoYW5nZWQKKyAgICAgICAgc3RhdGljX2Nhc3Q8Q0FMYXllcio+IHRv IHJlaW50ZXJwcmV0X2Nhc3Q8Q0FMYXllcio+IG5vdyB0aGF0CisgICAgICAgIENBTGF5ZXIgYW5k IFdlYkdMTGF5ZXIgYXJlIG5vdCB2b2lkIHBvaW50ZXJzLgorICAgICAgICAqIHBsYXRmb3JtL2dy YXBoaWNzL0dyYXBoaWNzTGF5ZXIuaDogQ2hhbmdlZCB0eXBlZGVmIGRlY2xhcmF0aW9uCisgICAg ICAgIGZvciBQbGF0Zm9ybUxheWVyIGZyb20gdm9pZCogdG8gc3RydWN0IENBTGF5ZXIuCisgICAg ICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2EvUGxhdGZvcm1DQUFuaW1hdGlvbi5oOiBDaGFuZ2Vk IHR5cGVkZWYKKyAgICAgICAgZGVjbGFyYXRpb24gZm9yIENBUHJvcGVydHlBbmltYXRpb24gZnJv bSB2b2lkKiB0byBhIHN0cnVjdC4KKyAgICAgICAgRXh0cmFjdGVkIHR5cGRlZiBmb3IgUGxhdGZv cm1BbmltYXRpb25SZWYuCisKIDIwMTEtMDMtMTIgIFBhdmVsIFBvZGl2aWxvdiAgPHBvZGl2aWxv dkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgWXVyeSBTZW1pa2hhdHNreS4K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzQ29u dGV4dDNELmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRl eHQzRC5oCmluZGV4IGE5ZGI2NTBiMDA5NmM3MWIwMGJjNTBhOWY1N2EwZDVkMjA3OTZhOTEuLjk3 NzI3ODBmNzg1YzRkNGZjMGJlNzgzZmM1MTA5OGM0OTc0NWU3ODIgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzQ29udGV4dDNELmgKKysrIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NDb250ZXh0M0QuaApAQCAtNTEs OCArNTEsOCBAQAogQGNsYXNzIENBTGF5ZXI7CiBAY2xhc3MgV2ViR0xMYXllcjsKICNlbHNlCi10 eXBlZGVmIHZvaWQqIENBTGF5ZXI7Ci10eXBlZGVmIHZvaWQqIFdlYkdMTGF5ZXI7Cit0eXBlZGVm IHN0cnVjdCBDQUxheWVyIENBTGF5ZXI7Cit0eXBlZGVmIHN0cnVjdCBXZWJHTExheWVyIFdlYkdM TGF5ZXI7CiAjZW5kaWYKICNlbGlmIFBMQVRGT1JNKFFUKQogUVRfQkVHSU5fTkFNRVNQQUNFCkBA IC00NTAsNyArNDUwLDcgQEAgcHVibGljOgogI2lmIFBMQVRGT1JNKE1BQykKICAgICBQbGF0Zm9y bUdyYXBoaWNzQ29udGV4dDNEIHBsYXRmb3JtR3JhcGhpY3NDb250ZXh0M0QoKSBjb25zdCB7IHJl dHVybiBtX2NvbnRleHRPYmo7IH0KICAgICBQbGF0Zm9ybTNET2JqZWN0IHBsYXRmb3JtVGV4dHVy ZSgpIGNvbnN0IHsgcmV0dXJuIG1fdGV4dHVyZTsgfQotICAgIENBTGF5ZXIqIHBsYXRmb3JtTGF5 ZXIoKSBjb25zdCB7IHJldHVybiBzdGF0aWNfY2FzdDxDQUxheWVyKj4obV93ZWJHTExheWVyLmdl dCgpKTsgfQorICAgIENBTGF5ZXIqIHBsYXRmb3JtTGF5ZXIoKSBjb25zdCB7IHJldHVybiByZWlu dGVycHJldF9jYXN0PENBTGF5ZXIqPihtX3dlYkdMTGF5ZXIuZ2V0KCkpOyB9CiAjZWxpZiBQTEFU Rk9STShDSFJPTUlVTSkKICAgICBQbGF0Zm9ybUdyYXBoaWNzQ29udGV4dDNEIHBsYXRmb3JtR3Jh cGhpY3NDb250ZXh0M0QoKSBjb25zdDsKICAgICBQbGF0Zm9ybTNET2JqZWN0IHBsYXRmb3JtVGV4 dHVyZSgpIGNvbnN0OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvR3JhcGhpY3NMYXllci5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3Jh cGhpY3NMYXllci5oCmluZGV4IDQ4NmI2OWFmZmJlNjM0YTU5NWI5MjU1YTgzYWFkMDY4NzU1ZmNj MWYuLmY1MzRiODRhYzVlOWNjZTViN2ViYTViMDZhMmExMzZlMGI1YmM4NTYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzTGF5ZXIuaAorKysgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0xheWVyLmgKQEAgLTUwLDcg KzUwLDcgQEAKIEBjbGFzcyBDQUxheWVyOwogdHlwZWRlZiBDQUxheWVyIFBsYXRmb3JtTGF5ZXI7 CiAjZWxzZQotdHlwZWRlZiB2b2lkKiBQbGF0Zm9ybUxheWVyOwordHlwZWRlZiBzdHJ1Y3QgQ0FM YXllciBQbGF0Zm9ybUxheWVyOwogI2VuZGlmCiAjZWxpZiBQTEFURk9STShXSU4pCiB0eXBlZGVm IHN0cnVjdCBfQ0FDRkxheWVyIFBsYXRmb3JtTGF5ZXI7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYS9QbGF0Zm9ybUNBQW5pbWF0aW9uLmggYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYS9QbGF0Zm9ybUNBQW5pbWF0aW9uLmgKaW5kZXgg YTg1MjhmZDlkY2U0YjcyYjdhYWE0MjUyNjhhYTUyZTcxOTcxNDk3Yi4uOWNkM2UyYmM5NzkwODBl MzllNTJlOGQ3ZTA5MWU0NTM0NjZjNTc0NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvY2EvUGxhdGZvcm1DQUFuaW1hdGlvbi5oCisrKyBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhL1BsYXRmb3JtQ0FBbmltYXRpb24uaApAQCAtMzgsMTEg KzM4LDEwIEBACiAjaWYgUExBVEZPUk0oTUFDKQogI2lmZGVmIF9fT0JKQ19fCiBAY2xhc3MgQ0FQ cm9wZXJ0eUFuaW1hdGlvbjsKLXR5cGVkZWYgQ0FQcm9wZXJ0eUFuaW1hdGlvbiogUGxhdGZvcm1B bmltYXRpb25SZWY7CiAjZWxzZQotdHlwZWRlZiB2b2lkKiBDQVByb3BlcnR5QW5pbWF0aW9uOyAv LyBTbyB0aGUgbV9hbmltYXRpb24gZGVjbGFyYXRpb24gd29ya3MKLXR5cGVkZWYgdm9pZCogUGxh dGZvcm1BbmltYXRpb25SZWY7Cit0eXBlZGVmIHN0cnVjdCBDQVByb3BlcnR5QW5pbWF0aW9uIENB UHJvcGVydHlBbmltYXRpb247CiAjZW5kaWYKK3R5cGVkZWYgQ0FQcm9wZXJ0eUFuaW1hdGlvbiog UGxhdGZvcm1BbmltYXRpb25SZWY7CiAjZWxpZiBQTEFURk9STShXSU4pCiB0eXBlZGVmIHN0cnVj dCBfQ0FDRkFuaW1hdGlvbiogQ0FDRkFuaW1hdGlvblJlZjsKIHR5cGVkZWYgQ0FDRkFuaW1hdGlv blJlZiBQbGF0Zm9ybUFuaW1hdGlvblJlZjsK