56374 2011-03-15 07:48:15 -0700 HTMLMediaElement::mediaPlayerPlaybackStateChanged should not change the "public" state of the element if it's an internal pause for example. 2011-05-04 12:59:48 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 menard menard commit-queue eric.carlson vestbo oldest_to_newest 367658 0 menard 2011-03-15 07:48:15 -0700 In case of an internal pause (i.e. it's not reflected in the DOM) the callback HTMLMediaElement::mediaPlayerPlaybackStateChanged should not change the state of the element. We should not call playInternal or pauseInternal because they can change the status of the element. 367659 1 85804 menard 2011-03-15 07:51:16 -0700 Created attachment 85804 Proposed patch. 367663 2 85805 menard 2011-03-15 08:01:58 -0700 Created attachment 85805 updated Changelog. 367755 3 85805 commit-queue 2011-03-15 10:32:44 -0700 Comment on attachment 85805 updated Changelog. Clearing flags on attachment: 85805 Committed r81145: <http://trac.webkit.org/changeset/81145> 367756 4 commit-queue 2011-03-15 10:32:47 -0700 All reviewed patches have been landed. Closing bug. 85804 2011-03-15 07:51:16 -0700 2011-03-15 08:01:58 -0700 Proposed patch. patch.diff text/plain 1359 menard ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBhMTQ4ZDU2Li41ZTlmNmJhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTEtMDMtMTUgIEFsZXhpcyBNZW5hcmQgIDxhbGV4aXMubWVuYXJkQG9wZW5ib3NzYS5v cmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSFRN TE1lZGlhRWxlbWVudDo6bWVkaWFQbGF5ZXJQbGF5YmFja1N0YXRlQ2hhbmdlZCBzaG91bGQgbm90 IGNoYW5nZSB0aGUgInB1YmxpYyIgc3RhdGUgb2YgdGhlIGVsZW1lbnQKKyAgICAgICAgaWYgaXQn cyBhbiBpbnRlcm5hbCBwYXVzZSBmb3IgZXhhbXBsZS4gICAgICAgCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NjM3NAorCisgICAgICAgIEluIGNhc2Ug b2YgYW4gaW50ZXJuYWwgcGF1c2UsIHRoZSBjYWxsYmFjayBmcm9tIHRoZSBtZWRpYXBsYXllciBz aG91bGQgYmUgaWdub3JlZCB0byBhdm9pZCByZWZsZWN0aW5nIHRoZQorICAgICAgICBjaGFuZ2Ug aW50byB0aGUgRE9NLiAgICAgICAgCisKKyAgICAgICAgKiBodG1sL0hUTUxNZWRpYUVsZW1lbnQu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTE1lZGlhRWxlbWVudDo6bWVkaWFQbGF5ZXJQbGF5 YmFja1N0YXRlQ2hhbmdlZCk6CisKIDIwMTEtMDMtMTUgIENocmlzIE11bWZvcmQgIDxjaHJpcy5t dW1mb3JkQHBhbG0uY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gQmFydGguCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwIGIvU291cmNl L1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcAppbmRleCA0MWFkNjVkLi4zNjkxNTdl IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAKQEAgLTE5MjAsNyAr MTkyMCw3IEBAIHZvaWQgSFRNTE1lZGlhRWxlbWVudDo6bWVkaWFQbGF5ZXJQbGF5YmFja1N0YXRl Q2hhbmdlZChNZWRpYVBsYXllciopCiB7CiAgICAgTE9HKE1lZGlhLCAiSFRNTE1lZGlhRWxlbWVu dDo6bWVkaWFQbGF5ZXJQbGF5YmFja1N0YXRlQ2hhbmdlZCIpOwogCi0gICAgaWYgKCFtX3BsYXll cikKKyAgICBpZiAoIW1fcGxheWVyIHx8IG1fcGF1c2VkSW50ZXJuYWwpCiAgICAgICAgIHJldHVy bjsKIAogICAgIGJlZ2luUHJvY2Vzc2luZ01lZGlhUGxheWVyQ2FsbGJhY2soKTsK 85805 2011-03-15 08:01:58 -0700 2011-03-15 10:32:44 -0700 updated Changelog. patch.diff text/plain 1388 menard ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBhMTQ4ZDU2Li44MGM2ZGY2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTEtMDMtMTUgIEFsZXhpcyBNZW5hcmQgIDxhbGV4aXMubWVuYXJkQG9wZW5ib3NzYS5v cmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSFRN TE1lZGlhRWxlbWVudDo6bWVkaWFQbGF5ZXJQbGF5YmFja1N0YXRlQ2hhbmdlZCBzaG91bGQgbm90 IGNoYW5nZSB0aGUgInB1YmxpYyIgc3RhdGUgb2YgdGhlIGVsZW1lbnQKKyAgICAgICAgaWYgaXQn cyBhbiBpbnRlcm5hbCBwYXVzZSBmb3IgZXhhbXBsZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU2Mzc0CisKKyAgICAgICAgSW4gY2FzZSBvZiBhbiBp bnRlcm5hbCBwYXVzZSwgdGhlIGNhbGxiYWNrIGZyb20gdGhlIG1lZGlhcGxheWVyIHNob3VsZCBi ZSBpZ25vcmVkIHRvIGF2b2lkIHJlZmxlY3RpbmcgdGhlCisgICAgICAgIGNoYW5nZSBpbnRvIHRo ZSBET00uCisKKyAgICAgICAgTm8gbmV3IHRlc3RzOiBWZXJpZmllZCBtYW51YWxseS4KKworICAg ICAgICAqIGh0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1M TWVkaWFFbGVtZW50OjptZWRpYVBsYXllclBsYXliYWNrU3RhdGVDaGFuZ2VkKToKKwogMjAxMS0w My0xNSAgQ2hyaXMgTXVtZm9yZCAgPGNocmlzLm11bWZvcmRAcGFsbS5jb20+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwv SFRNTE1lZGlhRWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1l bnQuY3BwCmluZGV4IDQxYWQ2NWQuLjM2OTE1N2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1M TWVkaWFFbGVtZW50LmNwcApAQCAtMTkyMCw3ICsxOTIwLDcgQEAgdm9pZCBIVE1MTWVkaWFFbGVt ZW50OjptZWRpYVBsYXllclBsYXliYWNrU3RhdGVDaGFuZ2VkKE1lZGlhUGxheWVyKikKIHsKICAg ICBMT0coTWVkaWEsICJIVE1MTWVkaWFFbGVtZW50OjptZWRpYVBsYXllclBsYXliYWNrU3RhdGVD aGFuZ2VkIik7CiAKLSAgICBpZiAoIW1fcGxheWVyKQorICAgIGlmICghbV9wbGF5ZXIgfHwgbV9w YXVzZWRJbnRlcm5hbCkKICAgICAgICAgcmV0dXJuOwogCiAgICAgYmVnaW5Qcm9jZXNzaW5nTWVk aWFQbGF5ZXJDYWxsYmFjaygpOwo=