56370 2011-03-15 03:28:15 -0700 [GStreamer] http/tests/media/video-play-stall-before-meta-data.html fails 2011-03-16 10:25:31 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 pnormand webkit-unassigned eric.carlson joepeck oldest_to_newest 367597 0 pnormand 2011-03-15 03:28:15 -0700 Diff: --- /home/slave/webkitgtk/gtk-linux-64-debug/build/layout-test-results/http/tests/media/video-play-stall-before-meta-data-expected.txt 2011-03-15 03:05:36.457251353 -0700 +++ /home/slave/webkitgtk/gtk-linux-64-debug/build/layout-test-results/http/tests/media/video-play-stall-before-meta-data-actual.txt 2011-03-15 03:05:36.457251353 -0700 @@ -2,7 +2,6 @@ EVENT(beforeload) EVENT(loadstart) -EVENT(stalled) EVENT(window.onload) END OF TEST I think the test fails because our player errors out and resets its network state too early, preventing HTMLMediaElement::progressEventTimerFired to emit the stalled event. I'll skip the test on GTK for now and work on a fix for this issue. 367601 1 pnormand 2011-03-15 03:38:00 -0700 Skipped in http://trac.webkit.org/changeset/81125 367619 2 85796 pnormand 2011-03-15 04:54:34 -0700 Created attachment 85796 proposed patch 368264 3 pnormand 2011-03-16 01:57:28 -0700 Committed r81229: <http://trac.webkit.org/changeset/81229> 368371 4 joepeck 2011-03-16 10:25:31 -0700 Thanks for fixing this Philippe. I didn't even notice it failed on gtk. 85796 2011-03-15 04:54:34 -0700 2011-03-15 07:49:13 -0700 proposed patch proposed-patch.patch text/plain 3611 pnormand RnJvbSBmMzYzYjE2ZDk1ZGE2ZTQyMTcwZWM1NjY3ZDdhMDA2NzRkYTU4OGNlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBUdWUsIDE1IE1hciAyMDExIDEyOjM5OjA4ICswMTAwClN1YmplY3Q6IFtQQVRDSF0g cHJvcG9zZWQgcGF0Y2gKCi0tLQogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgfCAgICA5ICsrKysrKysrKwogTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3Rr L1NraXBwZWQgICAgICAgICAgICAgICAgICAgfCAgICAzIC0tLQogU291cmNlL1dlYkNvcmUvQ2hh bmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDEyICsrKysrKysrKysrKwogLi4u L2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwICAgICAgfCAgICA3ICsr KysrKysKIDQgZmlsZXMgY2hhbmdlZCwgMjggaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkK CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKaW5kZXggZjFkZjJiMi4uZWMxOTVmZCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdl TG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE0IEBACiAyMDExLTAz LTE1ICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KIAorICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbR1N0cmVhbWVyXSBodHRwL3Rl c3RzL21lZGlhL3ZpZGVvLXBsYXktc3RhbGwtYmVmb3JlLW1ldGEtZGF0YS5odG1sIGZhaWxzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NjM3MAorCisg ICAgICAgICogcGxhdGZvcm0vZ3RrL1NraXBwZWQ6IFVuc2tpcCBmaXhlZCB0ZXN0LgorCisyMDEx LTAzLTE1ICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKwogICAgICAg ICBVbnJldmlld2VkLCBza2lwIGZhaWxpbmcgbWVkaWEgdGVzdCBvbiBHVEsuCiAKICAgICAgICAg KiBwbGF0Zm9ybS9ndGsvU2tpcHBlZDoKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3Jt L2d0ay9Ta2lwcGVkIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1NraXBwZWQKaW5kZXggMDI4 ZWU4Zi4uNjk0ODc1NiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1NraXBw ZWQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1NraXBwZWQKQEAgLTQ5OCw5ICs0OTgs NiBAQCBodHRwL3Rlc3RzL2xvYWRpbmcvZ21haWwtYXNzZXJ0LW9uLWxvYWQuaHRtbAogaHR0cC90 ZXN0cy9sb2FkaW5nL3JlZGlyZWN0LXdpdGgtbm8tbG9jYXRpb24tY3Jhc2guaHRtbAogaHR0cC90 ZXN0cy9sb2FkaW5nL3RleHQtY29udGVudC10eXBlLXdpdGgtYmluYXJ5LWV4dGVuc2lvbi5odG1s CiAKLSMgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU2MzcwCi1odHRw L3Rlc3RzL21lZGlhL3ZpZGVvLXBsYXktc3RhbGwtYmVmb3JlLW1ldGEtZGF0YS5odG1sCi0KIGh0 dHAvdGVzdHMvbWVkaWEvdmlkZW8tcGxheS1zdGFsbC1zZWVrLmh0bWwKIGh0dHAvdGVzdHMvbWVk aWEvdmlkZW8tcGxheS1zdGFsbC5odG1sCiBodHRwL3Rlc3RzL21lZGlhL3ZpZGVvLXNlZWthYmxl LXN0YWxsLmh0bWwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBhMTQ4ZDU2Li41NDkxNGMwIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTEtMDMtMTUgIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBp Z2FsaWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFtHU3RyZWFtZXJdIGh0dHAvdGVzdHMvbWVkaWEvdmlkZW8tcGxheS1zdGFsbC1iZWZvcmUt bWV0YS1kYXRhLmh0bWwgZmFpbHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTU2MzcwCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFt ZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Om1l ZGlhUGxheWVyUHJpdmF0ZU1lc3NhZ2VDYWxsYmFjayk6IExldCB0aGUKKyAgICAgICAgbWVkaWFQ bGF5ZXJDbGllbnQgaGFuZGxlIHRoZSBzdHJlYW0gZXJyb3IsIGluIHRoaXMgY2FzZSB0aGUKKyAg ICAgICAgSFRNTE1lZGlhRWxlbWVudCB3aWxsIGVtaXQgYSBzdGFsbGVkIGV2ZW50LgorCiAyMDEx LTAzLTE1ICBDaHJpcyBNdW1mb3JkICA8Y2hyaXMubXVtZm9yZEBwYWxtLmNvbT4KIAogICAgICAg ICBSZXZpZXdlZCBieSBBZGFtIEJhcnRoLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQ cml2YXRlR1N0cmVhbWVyLmNwcAppbmRleCAzNzYzZWY3Li40YmE4NDNkIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2 YXRlR1N0cmVhbWVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9n c3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcApAQCAtMTE3LDYgKzExNywx MyBAQCBnYm9vbGVhbiBtZWRpYVBsYXllclByaXZhdGVNZXNzYWdlQ2FsbGJhY2soR3N0QnVzKiBi dXMsIEdzdE1lc3NhZ2UqIG1lc3NhZ2UsIGdwbwogICAgICAgICAgICAgfHwgZXJyLT5jb2RlID09 IEdTVF9SRVNPVVJDRV9FUlJPUl9OT1RfRk9VTkQpCiAgICAgICAgICAgICBlcnJvciA9IE1lZGlh UGxheWVyOjpGb3JtYXRFcnJvcjsKICAgICAgICAgZWxzZSBpZiAoZXJyLT5kb21haW4gPT0gR1NU X1NUUkVBTV9FUlJPUikgeworICAgICAgICAgICAgLy8gTGV0IHRoZSBtZWRpYVBsYXllckNsaWVu dCBoYW5kbGUgdGhlIHN0cmVhbSBlcnJvciwgaW4KKyAgICAgICAgICAgIC8vIHRoaXMgY2FzZSB0 aGUgSFRNTE1lZGlhRWxlbWVudCB3aWxsIGVtaXQgYSBzdGFsbGVkCisgICAgICAgICAgICAvLyBl dmVudC4KKyAgICAgICAgICAgIGlmIChlcnItPmNvZGUgPT0gR1NUX1NUUkVBTV9FUlJPUl9UWVBF X05PVF9GT1VORCkgeworICAgICAgICAgICAgICAgIExPR19WRVJCT1NFKE1lZGlhLCAiRGVjb2Rl IGVycm9yLCBsZXQgdGhlIE1lZGlhIGVsZW1lbnQgZW1pdCBhIHN0YWxsZWQgZXZlbnQuIik7Cisg ICAgICAgICAgICAgICAgYnJlYWs7CisgICAgICAgICAgICB9CiAgICAgICAgICAgICBlcnJvciA9 IE1lZGlhUGxheWVyOjpEZWNvZGVFcnJvcjsKICAgICAgICAgICAgIGF0dGVtcHROZXh0TG9jYXRp b24gPSB0cnVlOwogICAgICAgICB9IGVsc2UgaWYgKGVyci0+ZG9tYWluID09IEdTVF9SRVNPVVJD RV9FUlJPUikKLS0gCjEuNy40LjE=