56366 2011-03-15 01:41:32 -0700 [GTK] media/audio-repaint.html times out again 2011-03-16 02:00:53 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 pnormand webkit-unassigned eric.carlson jer.noble mrobinson oldest_to_newest 367556 0 pnormand 2011-03-15 01:41:32 -0700 This time because the seek can be performed while the audio element ready state is HAVE_NOTHING, which throws an INVALID_STATE_ERR exception... The test should wait the elements are playing before attempting the seek... 367559 1 85787 pnormand 2011-03-15 01:57:52 -0700 Created attachment 85787 proposed patch 367560 2 pnormand 2011-03-15 01:59:21 -0700 Thou shall not use setTimeout() in media tests. :P 367654 3 eric.carlson 2011-03-15 07:36:13 -0700 (In reply to comment #2) > Thou shall not use setTimeout() in media tests. :P Amen! 368267 4 pnormand 2011-03-16 02:00:53 -0700 Committed r81231: <http://trac.webkit.org/changeset/81231> 85787 2011-03-15 01:57:52 -0700 2011-03-15 07:35:50 -0700 proposed patch proposed-patch.patch text/plain 3440 pnormand RnJvbSAzYzYzNjE3YjA4Y2VmNmQzMGQxNWFmZGI4NzZhMTU4ZjU5ZWU5YmQ0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBUdWUsIDE1IE1hciAyMDExIDA5OjU4OjUyICswMTAwClN1YmplY3Q6IFtQQVRDSF0g cHJvcG9zZWQgcGF0Y2gKCi0tLQogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nICAgICAgICAgICAgICAg IHwgICAxMyArKysrKysrKysrKysKIExheW91dFRlc3RzL21lZGlhL2F1ZGlvLXJlcGFpbnQuaHRt bCB8ICAgMzUgKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tCiAyIGZpbGVzIGNoYW5n ZWQsIDI5IGluc2VydGlvbnMoKyksIDE5IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBkNTc4ZGI4Li4z YTQ3YjJmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDMtMTUgIFBoaWxpcHBlIE5vcm1h bmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFtHVEtdIG1lZGlhL2F1ZGlvLXJlcGFpbnQuaHRtbCB0aW1lcyBv dXQgYWdhaW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTU2MzY2CisKKyAgICAgICAgUmV3cm90ZSB0aGUgdGVzdCB0byBhdm9pZCBhIHRpbWVyIGFuZCBh dHRlbXB0IHRoZSBzZWVrIG9uIG1lZGlhCisgICAgICAgIGVsZW1lbnRzIG9ubHkgYWZ0ZXIgd2Ug YXJlIHN1cmUgcGxheWJhY2sgc3RhcnRlZCB0byBhdm9pZCBhbgorICAgICAgICBJTlZBTElEX1NU QVRFX0VSUiBleGNlcHRpb24uCisKKyAgICAgICAgKiBtZWRpYS9hdWRpby1yZXBhaW50Lmh0bWw6 CisKIDIwMTEtMDMtMTQgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAg ICAgQW5vdGhlciBDaHJvbWl1bSByZWJhc2VsaW5lIGZvciByODEwOTUuCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9tZWRpYS9hdWRpby1yZXBhaW50Lmh0bWwgYi9MYXlvdXRUZXN0cy9tZWRpYS9h dWRpby1yZXBhaW50Lmh0bWwKaW5kZXggZTdlYTA4YS4uNWNhNjlmOCAxMDA2NDQKLS0tIGEvTGF5 b3V0VGVzdHMvbWVkaWEvYXVkaW8tcmVwYWludC5odG1sCisrKyBiL0xheW91dFRlc3RzL21lZGlh L2F1ZGlvLXJlcGFpbnQuaHRtbApAQCAtMSwxMSArMSwxMSBAQAotPGJvZHkgb25sb2FkPSJib2R5 TG9hZGVkKCkiPgorPGJvZHk+CiA8cD4KICAgICBUaGlzIHRlc3RzIHRoYXQgaW4gYSBodG1sIGRv Y3VtZW50IHdpdGggaW5saW5lIGF1ZGlvIGNvbnRlbnQsIHRoZSBtZWRpYSBlbGVtZW50IHJlcGFp bnRzIGNvcnJlY3RseQogICAgIHdoaWxlIHBsYXlpbmcuCiA8L3A+Ci08YXVkaW8gY29udHJvbHMg YXV0b3BsYXkgc3JjPSJjb250ZW50L3NpbGVuY2Uud2F2Ij48L2F1ZGlvPjxici8+Ci08YXVkaW8g Y29udHJvbHMgYXV0b3BsYXkgc3JjPSJjb250ZW50L3NpbGVuY2Uud2F2IiBzdHlsZT0ibWFyZ2lu LWJvdHRvbToyNXB4OyAtd2Via2l0LWJveC1yZWZsZWN0OmJlbG93OyI+PC9hdWRpbz48YnIvPgot PGF1ZGlvIGNvbnRyb2xzIGF1dG9wbGF5IHNyYz0iY29udGVudC9zaWxlbmNlLndhdiIgc3R5bGU9 Im1hcmdpbjoyN3B4IDA7IC13ZWJraXQtdHJhbnNmb3JtOiByb3RhdGUoMTVkZWcpOyI+PC9hdWRp bz48YnI+Cis8YXVkaW8gY29udHJvbHMgYXV0b3BsYXkgb25wbGF5aW5nPSJwbGF5aW5nKDApIiBz cmM9ImNvbnRlbnQvc2lsZW5jZS53YXYiPjwvYXVkaW8+PGJyLz4KKzxhdWRpbyBjb250cm9scyBh dXRvcGxheSBvbnBsYXlpbmc9InBsYXlpbmcoMSkiIHNyYz0iY29udGVudC9zaWxlbmNlLndhdiIg c3R5bGU9Im1hcmdpbi1ib3R0b206MjVweDsgLXdlYmtpdC1ib3gtcmVmbGVjdDpiZWxvdzsiPjwv YXVkaW8+PGJyLz4KKzxhdWRpbyBjb250cm9scyBhdXRvcGxheSBvbnBsYXlpbmc9InBsYXlpbmco MikiIHNyYz0iY29udGVudC9zaWxlbmNlLndhdiIgc3R5bGU9Im1hcmdpbjoyN3B4IDA7IC13ZWJr aXQtdHJhbnNmb3JtOiByb3RhdGUoMTVkZWcpOyI+PC9hdWRpbz48YnI+CiA8c2NyaXB0PgogICAg IGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCiAgICAgICAgIGxheW91dFRlc3RDb250 cm9sbGVyLndhaXRVbnRpbERvbmUoKTsKQEAgLTEzLDIwICsxMywxNyBAQAogICAgIGlmICh3aW5k b3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCiAgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLmRp c3BsYXkoKTsKIAotICAgIGZ1bmN0aW9uIGJvZHlMb2FkZWQoKSB7Ci0gICAgICAgIHNldFRpbWVv dXQoZnVuY3Rpb24oKXsKLSAgICAgICAgICAgIHZhciBhdWRpb0VsZW1lbnRzID0gZG9jdW1lbnQu Z2V0RWxlbWVudHNCeVRhZ05hbWUoJ2F1ZGlvJyk7Ci0gICAgICAgICAgICB2YXIgY291bnQgPSBh dWRpb0VsZW1lbnRzLmxlbmd0aDsKLSAgICAgICAgICAgIGZvciAoaSA9IDA7IGkgPCBjb3VudDsg KytpKSB7Ci0gICAgICAgICAgICAgICAgdmFyIGF1ZGlvID0gYXVkaW9FbGVtZW50c1tpXTsKLSAg ICAgICAgICAgICAgICBhdWRpby5wYXVzZSgpOwotICAgICAgICAgICAgICAgIGF1ZGlvLmFkZEV2 ZW50TGlzdGVuZXIoInNlZWtlZCIsIGZ1bmN0aW9uKCkgewotICAgICAgICAgICAgICAgICAgICBp ZiAoIS0tY291bnQgJiYgd2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQotICAgICAgICAgICAg ICAgICAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIubm90aWZ5RG9uZSgpOwotICAgICAgICAg ICAgICAgIH0sIHRydWUpOwotICAgICAgICAgICAgICAgIGF1ZGlvLmN1cnJlbnRUaW1lID0gYXVk aW8uZHVyYXRpb24gKiAwLjUwOwotICAgICAgICAgICAgfQotICAgICAgICB9LCAxMDApOworICAg IHZhciBjb3VudCA9IDM7CisgICAgdmFyIGF1ZGlvRWxlbWVudHMgPSBkb2N1bWVudC5nZXRFbGVt ZW50c0J5VGFnTmFtZSgnYXVkaW8nKTsKKworICAgIGZ1bmN0aW9uIHBsYXlpbmcoaSkgeworICAg ICAgICB2YXIgYXVkaW8gPSBhdWRpb0VsZW1lbnRzW2ldOworICAgICAgICBhdWRpby5wYXVzZSgp OworICAgICAgICBhdWRpby5hZGRFdmVudExpc3RlbmVyKCJzZWVrZWQiLCBmdW5jdGlvbigpIHsK KyAgICAgICAgaWYgKCEtLWNvdW50ICYmIHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKKyAg ICAgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLm5vdGlmeURvbmUoKTsKKyAgICAgICAgfSwg dHJ1ZSk7CisgICAgICAgIGF1ZGlvLmN1cnJlbnRUaW1lID0gYXVkaW8uZHVyYXRpb24gKiAwLjUw OwogICAgIH0KIDwvc2NyaXB0PgotPC9ib2R5PgpcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUK KzwvYm9keT4KLS0gCjEuNy40LjE=