56364 2011-03-14 23:57:16 -0700 Remove WebInputElement::isEnabledFormControl() from Chromium WebKit API 2011-03-21 20:06:42 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 isherman isherman commit-queue dglazkov fishd isherman jamesr webkit.review.bot oldest_to_newest 367540 0 isherman 2011-03-14 23:57:16 -0700 Remove WebInputElement::isEnabledFormControl() from Chromium WebKit API 367541 1 85782 isherman 2011-03-14 23:58:09 -0700 Created attachment 85782 Patch 367542 2 webkit.review.bot 2011-03-15 00:05:54 -0700 Attachment 85782 did not build on chromium: Build output: http://queues.webkit.org/results/8174522 367547 3 isherman 2011-03-15 00:40:36 -0700 (In reply to comment #2) > Attachment 85782 [details] did not build on chromium: > Build output: http://queues.webkit.org/results/8174522 The file that's triggering this compile error is stale -- it doesn't exist anymore in the Chromium repository as of crrev.com/77840 Adam Barth suggested that I should update the Source/WebKit/chromium/DEPS file, but Dave Levin mentioned that this file can't be rolled right now due to a potentially inadvertently added dependency. So... guess I'll just wait for now and let that get sorted out =) 369932 4 85782 eric 2011-03-18 15:03:22 -0700 Comment on attachment 85782 Patch Looks like cr-linux is sad? 369958 5 86227 isherman 2011-03-18 15:27:20 -0700 Created attachment 86227 Patch 369960 6 isherman 2011-03-18 15:28:06 -0700 Rebased; cr-linux should cheer right up 370969 7 isherman 2011-03-21 15:57:41 -0700 Ping :) 370978 8 86227 jamesr 2011-03-21 16:06:59 -0700 Comment on attachment 86227 Patch I always like removing API! 371160 9 86227 commit-queue 2011-03-21 20:06:39 -0700 Comment on attachment 86227 Patch Clearing flags on attachment: 86227 Committed r81637: <http://trac.webkit.org/changeset/81637> 371161 10 commit-queue 2011-03-21 20:06:42 -0700 All reviewed patches have been landed. Closing bug. 85782 2011-03-14 23:58:09 -0700 2011-03-18 15:27:17 -0700 Patch bug-56364-20110314235807.patch text/plain 2228 isherman U3VidmVyc2lvbiBSZXZpc2lvbjogODEwMTIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg YjFlMzk2NDYyNjcxZDE1NjI5YWMyMGM0ZDAyNTc5NjZlOWQwNmZkNC4uZTFkYzI1MjE3ZDBhMjIx ZDJhMjhkYTc2MTBkNjc5NjlmNjk3OTEzMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxNCBAQAorMjAxMS0wMy0xNCAgSWx5YSBTaGVybWFuICA8aXNoZXJtYW5AY2hyb21p dW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFJlbW92ZSBXZWJJbnB1dEVsZW1lbnQ6OmlzRW5hYmxlZEZvcm1Db250cm9sKCkgZnJvbSBDaHJv bWl1bSBXZWJLaXQgQVBJLgorICAgICAgICBDbGllbnRzIHNob3VsZCBpbnN0ZWFkIGNhbGwgaW50 byBXZWJGb3JtQ29udHJvbEVsZW1lbnQ6OmlzRW5hYmxlZCgpLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTYzNjQKKworICAgICAgICAqIHB1YmxpYy9X ZWJJbnB1dEVsZW1lbnQuaDogUmVtb3ZlZCBpc0VuYWJsZWRGb3JtQ29udHJvbCgpLgorICAgICAg ICAqIHNyYy9XZWJJbnB1dEVsZW1lbnQuY3BwOiBSZW1vdmVkIGlzRW5hYmxlZEZvcm1Db250cm9s KCkuCisKIDIwMTEtMDMtMTEgIERhdmlkIExldmluICA8bGV2aW5AY2hyb21pdW0ub3JnPgogCiAg ICAgICAgIFJvbGxvdXQgdGhlIGNocm9taXVtIGRlcHMgcm9sbCBhcyBpdCBhZGRzIGEgZGVwZW5k ZW5jeSBvbiBhIGhlYWRlcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJs aWMvV2ViSW5wdXRFbGVtZW50LmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJJ bnB1dEVsZW1lbnQuaAppbmRleCAxZjA4MzZiZjg3ZDRhMWY0ZWY0YzU5N2U3MzU1MjllYzVmMjMx NDZiLi44M2MyNDg0NjQ1NzM1MjFlMGViODI3ZjBjZDQzNDAzMGU4M2QxOWY1IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJJbnB1dEVsZW1lbnQuaAorKysgYi9T b3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJJbnB1dEVsZW1lbnQuaApAQCAtNjEsNyAr NjEsNiBAQCBuYW1lc3BhY2UgV2ViS2l0IHsKICAgICAgICAgV0VCS0lUX0FQSSBib29sIGlzSW1h Z2VCdXR0b24oKSBjb25zdDsKICAgICAgICAgV0VCS0lUX0FQSSBib29sIGF1dG9Db21wbGV0ZSgp IGNvbnN0OwogICAgICAgICBXRUJLSVRfQVBJIGJvb2wgaXNSZWFkT25seSgpIGNvbnN0OwotICAg ICAgICBXRUJLSVRfQVBJIGJvb2wgaXNFbmFibGVkRm9ybUNvbnRyb2woKSBjb25zdDsKICAgICAg ICAgV0VCS0lUX0FQSSBpbnQgbWF4TGVuZ3RoKCkgY29uc3Q7CiAgICAgICAgIFdFQktJVF9BUEkg Ym9vbCBpc0FjdGl2YXRlZFN1Ym1pdCgpIGNvbnN0OwogICAgICAgICBXRUJLSVRfQVBJIHZvaWQg c2V0QWN0aXZhdGVkU3VibWl0KGJvb2wpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9zcmMvV2ViSW5wdXRFbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3Jj L1dlYklucHV0RWxlbWVudC5jcHAKaW5kZXggY2JlMjA1OTBlYTM2NjQyYjQ0YTU3YmU0MzAxOGIz Njk5NjQ0NzY1ZS4uYzMxNWNiYjNiMmViZTZmNmEwMGY1NjQ2NGFiYjY5NmUwNjEzN2IwOSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViSW5wdXRFbGVtZW50LmNwcAor KysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJJbnB1dEVsZW1lbnQuY3BwCkBAIC03 MCwxMSArNzAsNiBAQCBib29sIFdlYklucHV0RWxlbWVudDo6aXNSZWFkT25seSgpIGNvbnN0CiAg ICAgcmV0dXJuIGNvbnN0VW53cmFwPEhUTUxJbnB1dEVsZW1lbnQ+KCktPnJlYWRPbmx5KCk7CiB9 CiAKLWJvb2wgV2ViSW5wdXRFbGVtZW50Ojppc0VuYWJsZWRGb3JtQ29udHJvbCgpIGNvbnN0Ci17 Ci0gICAgcmV0dXJuIGNvbnN0VW53cmFwPEhUTUxJbnB1dEVsZW1lbnQ+KCktPmlzRW5hYmxlZEZv cm1Db250cm9sKCk7Ci19Ci0KIGludCBXZWJJbnB1dEVsZW1lbnQ6Om1heExlbmd0aCgpIGNvbnN0 CiB7CiAgICAgcmV0dXJuIGNvbnN0VW53cmFwPEhUTUxJbnB1dEVsZW1lbnQ+KCktPm1heExlbmd0 aCgpOwo= 86227 2011-03-18 15:27:20 -0700 2011-03-21 20:06:39 -0700 Patch bug-56364-20110318152719.patch text/plain 2194 isherman U3VidmVyc2lvbiBSZXZpc2lvbjogODE1MTUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg ODYwNjMzZWUzZmYyMDAxMzg4MDRiOGMyMTRhMmRkMDdhZmVjNjM1Yy4uZGJjOGRmNjAwMGViYWY2 ZDBlMzZlMGI0ZTY2N2M3ZWNjMzAxZDk3YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxNCBAQAorMjAxMS0wMy0xOCAgSWx5YSBTaGVybWFuICA8aXNoZXJtYW5AY2hyb21p dW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFJlbW92ZSBXZWJJbnB1dEVsZW1lbnQ6OmlzRW5hYmxlZEZvcm1Db250cm9sKCkgZnJvbSBDaHJv bWl1bSBXZWJLaXQgQVBJCisgICAgICAgIENsaWVudHMgc2hvdWxkIGluc3RlYWQgY2FsbCBpbnRv IFdlYkZvcm1Db250cm9sRWxlbWVudDo6aXNFbmFibGVkKCkuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NjM2NAorCisgICAgICAgICogcHVibGljL1dl YklucHV0RWxlbWVudC5oOiBSZW1vdmVkIGlzRW5hYmxlZEZvcm1Db250cm9sKCkuCisgICAgICAg ICogc3JjL1dlYklucHV0RWxlbWVudC5jcHA6IFJlbW92ZWQgaXNFbmFibGVkRm9ybUNvbnRyb2wo KS4KKwogMjAxMS0wMy0xOCAgVG9ueSBDaGFuZyAgPHRvbnlAY2hyb21pdW0ub3JnPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IEVyaWMgU2VpZGVsLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9j aHJvbWl1bS9wdWJsaWMvV2ViSW5wdXRFbGVtZW50LmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVt L3B1YmxpYy9XZWJJbnB1dEVsZW1lbnQuaAppbmRleCAxZjIwMTg3MjdkMTcyNWNiYTQ5YWE2M2Ix MGEyZTgyNjJiZTdkYTU3Li4zYWU2NTc4OTdiM2FkNWQyNjE4ZGViNGZlOTAyZmE3NDZjZWFjZjc2 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJJbnB1dEVsZW1l bnQuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJJbnB1dEVsZW1lbnQu aApAQCAtNjAsNyArNjAsNiBAQCBuYW1lc3BhY2UgV2ViS2l0IHsKICAgICAgICAgV0VCS0lUX0FQ SSBib29sIGlzUGFzc3dvcmRGaWVsZCgpIGNvbnN0OwogICAgICAgICBXRUJLSVRfQVBJIGJvb2wg aXNJbWFnZUJ1dHRvbigpIGNvbnN0OwogICAgICAgICBXRUJLSVRfQVBJIGJvb2wgYXV0b0NvbXBs ZXRlKCkgY29uc3Q7Ci0gICAgICAgIFdFQktJVF9BUEkgYm9vbCBpc0VuYWJsZWRGb3JtQ29udHJv bCgpIGNvbnN0OwogICAgICAgICBXRUJLSVRfQVBJIGludCBtYXhMZW5ndGgoKSBjb25zdDsKICAg ICAgICAgV0VCS0lUX0FQSSBib29sIGlzQWN0aXZhdGVkU3VibWl0KCkgY29uc3Q7CiAgICAgICAg IFdFQktJVF9BUEkgdm9pZCBzZXRBY3RpdmF0ZWRTdWJtaXQoYm9vbCk7CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJJbnB1dEVsZW1lbnQuY3BwIGIvU291cmNlL1dl YktpdC9jaHJvbWl1bS9zcmMvV2ViSW5wdXRFbGVtZW50LmNwcAppbmRleCBiNmNmN2NlMzk5MGQ0 NzFjZjg5MzA2MmU3OTA2MzJiMGFmMTllYzU1Li4zNDQ4YmI2YjMyODA2ZGI3YWRkMTRhMjZlMTA3 NWIzYWU2MTY0NGY2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJJ bnB1dEVsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYklucHV0 RWxlbWVudC5jcHAKQEAgLTY1LDExICs2NSw2IEBAIGJvb2wgV2ViSW5wdXRFbGVtZW50OjphdXRv Q29tcGxldGUoKSBjb25zdAogICAgIHJldHVybiBjb25zdFVud3JhcDxIVE1MSW5wdXRFbGVtZW50 PigpLT5hdXRvQ29tcGxldGUoKTsKIH0KIAotYm9vbCBXZWJJbnB1dEVsZW1lbnQ6OmlzRW5hYmxl ZEZvcm1Db250cm9sKCkgY29uc3QKLXsKLSAgICByZXR1cm4gY29uc3RVbndyYXA8SFRNTElucHV0 RWxlbWVudD4oKS0+aXNFbmFibGVkRm9ybUNvbnRyb2woKTsKLX0KLQogaW50IFdlYklucHV0RWxl bWVudDo6bWF4TGVuZ3RoKCkgY29uc3QKIHsKICAgICByZXR1cm4gY29uc3RVbndyYXA8SFRNTElu cHV0RWxlbWVudD4oKS0+bWF4TGVuZ3RoKCk7Cg==