56360 2011-03-14 20:42:19 -0700 loader/reload-subresource-when-type-changes.html might be flaky 2011-04-11 20:58:11 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 wangxianzhu webkit-unassigned abarth ap commit-queue gavinp tonyg oldest_to_newest 367479 0 wangxianzhu 2011-03-14 20:42:19 -0700 In loader/reload-subresource-when-type-changes.html: <link rel="prefetch" href="resources/image1.png"> <img src="resources/image1.png" onerror="log('LOAD ERROR - FAIL 2 of 3)" onload="checkLoadedImage(event, 2)"> <script src="resources/image2.png"></script> <img src="resources/image2.png" onerror="log('LOAD ERROR - FAIL 2 of 3)" onload="checkLoadedImage(event, 3)"> Because the last two images might be loaded asynchronously, onload of the third image might be triggered before that of the second image, thus the actual result might be: PASS 3 of 3 PASS 2 of 3 The situation might not happen in normal test environment because the images are all accessed as local files. However, in an environment with slow access (such as NFS, or tests accessed through HTTP), this might happen. 367490 1 85768 wangxianzhu 2011-03-14 21:11:33 -0700 Created attachment 85768 patch 367917 2 gavinp 2011-03-15 13:38:52 -0700 Good catch, and it looks good to me. I like that you save expectations. I'm not a reviewer though. Can I recommend ap or abarth peek at this to r+ it for you? 368108 3 wangxianzhu 2011-03-15 18:07:03 -0700 (In reply to comment #2) > Good catch, and it looks good to me. I like that you save expectations. > > I'm not a reviewer though. Can I recommend ap or abarth peek at this to r+ it for you? Sure. Thanks! 374963 4 wangxianzhu 2011-03-28 20:07:21 -0700 ping... 383039 5 wangxianzhu 2011-04-10 23:15:53 -0700 ping... 383781 6 85768 tonyg 2011-04-11 20:04:11 -0700 Comment on attachment 85768 patch View in context: https://bugs.webkit.org/attachment.cgi?id=85768&action=review > LayoutTests/ChangeLog:6 > + https://bugs.webkit.org/show_bug.cgi?id=56360 You have good information in the first comment of the bug about why and how this fails. Usually it is best practice to put that information in the ChangeLog so that when people go back to understand why things are the way they are they can see it here instead of having to wade through the bug. 383789 7 89151 wangxianzhu 2011-04-11 20:29:09 -0700 Created attachment 89151 patch with updated ChangeLog 383799 8 89151 commit-queue 2011-04-11 20:58:03 -0700 Comment on attachment 89151 patch with updated ChangeLog Clearing flags on attachment: 89151 Committed r83554: <http://trac.webkit.org/changeset/83554> 383800 9 commit-queue 2011-04-11 20:58:11 -0700 All reviewed patches have been landed. Closing bug. 85768 2011-03-14 21:11:33 -0700 2011-04-11 20:29:09 -0700 patch patch56360 text/plain 2082 wangxianzhu SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDgxMTAzKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDMtMTQgIFhpYW56aHUgV2FuZyAgPHdh bmd4aWFuemh1QGdvb2dsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgbG9hZGVyL3JlbG9hZC1zdWJyZXNvdXJjZS13aGVuLXR5cGUtY2hhbmdl cy5odG1sIG1pZ2h0IGJlIGZsYWt5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD01NjM2MAorCisgICAgICAgICogbG9hZGVyL3JlbG9hZC1zdWJyZXNvdXJj ZS13aGVuLXR5cGUtY2hhbmdlcy5odG1sOgorICAgICAgICAqIGxvYWRlci9yZXNvdXJjZXMvcmVs b2FkLXN1YnJlc291cmNlLXdoZW4tdHlwZS1jaGFuZ2VzLmpzOgorCiAyMDExLTAzLTEzICBNT1JJ VEEgSGFqaW1lICA8bW9ycml0YUBnb29nbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFRv bnkgQ2hhbmcuCkluZGV4OiBMYXlvdXRUZXN0cy9sb2FkZXIvcmVsb2FkLXN1YnJlc291cmNlLXdo ZW4tdHlwZS1jaGFuZ2VzLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvbG9hZGVyL3Jl bG9hZC1zdWJyZXNvdXJjZS13aGVuLXR5cGUtY2hhbmdlcy5odG1sCShyZXZpc2lvbiA4MTAzMykK KysrIExheW91dFRlc3RzL2xvYWRlci9yZWxvYWQtc3VicmVzb3VyY2Utd2hlbi10eXBlLWNoYW5n ZXMuaHRtbAkod29ya2luZyBjb3B5KQpAQCAtMTYsMTIgKzE2LDIzIEBAIGZ1bmN0aW9uIGxvZyhz dHJpbmcpCiAgICAgbG9nRGl2LmFwcGVuZENoaWxkKGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImJy IikpOwogfQogCit2YXIgbG9hZGVkID0gMDsKK3ZhciBtZXNzYWdlcyA9IFtdOworCiBmdW5jdGlv biBjaGVja0xvYWRlZEltYWdlKGV2ZW50LCB0ZXN0TnVtYmVyKSB7CiAgICAgdmFyIGltYWdlV2lk dGggPSBldmVudC50YXJnZXQud2lkdGg7CiAgICAgaWYgKGltYWdlV2lkdGggPT0gMjUpCi0gICAg ICAgIGxvZygiUEFTUyAiICsgdGVzdE51bWJlciArICIgb2YgMyIpOworICAgICAgICByZXNvdXJj ZUxvYWRlZCgiUEFTUyAiLCB0ZXN0TnVtYmVyKTsKICAgICBlbHNlCi0gICAgICAgIGxvZygiSU1B R0UgU0laRSAiICsgaW1hZ2VXaWR0aCArICIgRkFJTCAtICIgKyB0ZXN0TnVtYmVyICsgIiBvZiAy Iik7CisgICAgICAgIHJlc291cmNlTG9hZGVkKCJJTUFHRSBTSVpFICIgKyBpbWFnZVdpZHRoICsg IiBGQUlMIC0gIiwgdGVzdE51bWJlcik7Cit9CisKK2Z1bmN0aW9uIHJlc291cmNlTG9hZGVkKG1l c3NhZ2UsIHRlc3ROdW1iZXIpIHsKKyAgICBtZXNzYWdlc1t0ZXN0TnVtYmVyXSA9IG1lc3NhZ2Ug KyB0ZXN0TnVtYmVyICsgIiBvZiAzIjsKKyAgICBpZiAoKytsb2FkZWQgPT0gMykgeworICAgICAg ICBmb3IgKHZhciBpID0gMTsgaSA8PSAzOyBpKyspCisgICAgICAgICAgICBsb2cobWVzc2FnZXNb aV0pOworICAgIH0KIH0KIDwvc2NyaXB0PgogCkluZGV4OiBMYXlvdXRUZXN0cy9sb2FkZXIvcmVz b3VyY2VzL3JlbG9hZC1zdWJyZXNvdXJjZS13aGVuLXR5cGUtY2hhbmdlcy5qcwo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBMYXlvdXRUZXN0cy9sb2FkZXIvcmVzb3VyY2VzL3JlbG9hZC1zdWJyZXNvdXJjZS13aGVu LXR5cGUtY2hhbmdlcy5qcwkocmV2aXNpb24gODEwMzMpCisrKyBMYXlvdXRUZXN0cy9sb2FkZXIv cmVzb3VyY2VzL3JlbG9hZC1zdWJyZXNvdXJjZS13aGVuLXR5cGUtY2hhbmdlcy5qcwkod29ya2lu ZyBjb3B5KQpAQCAtMSwyICsxLDIgQEAKIGNsZWFyTG9nKCk7Ci1sb2coIlBBU1MgMSBvZiAzIik7 CityZXNvdXJjZUxvYWRlZCgiUEFTUyAiLCAxKTsK 89151 2011-04-11 20:29:09 -0700 2011-04-11 20:58:03 -0700 patch with updated ChangeLog patch56360 text/plain 2283 wangxianzhu SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDgzNTQ5KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDQtMTEgIFhpYW56aHUgV2FuZyAgPHdh bmd4aWFuemh1QGdvb2dsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgbG9hZGVyL3JlbG9hZC1zdWJyZXNvdXJjZS13aGVuLXR5cGUtY2hhbmdl cy5odG1sIG1pZ2h0IGJlIGZsYWt5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD01NjM2MAorCisgICAgICAgIE9ubG9hZCBvZiB0aGUgdGhpcmQgaW1hZ2Ug bWlnaHQgYmUgdHJpZ2dlcmVkIGJlZm9yZSB0aGF0IG9mIHRoZSBzZWNvbmQgaW1hZ2UuCisgICAg ICAgIFRoaXMgbWlnaHQgYWhwcGVuIGluIGVudmlyb25tZW50IHdpdGggc2xvdyBhY2Nlc3MgKHN1 Y2ggYXMgTkZTLCBvciB0ZXN0cworICAgICAgICBhY2Nlc3NlZCB0aHJvdWdoIEhUVFApLgorCisg ICAgICAgICogbG9hZGVyL3JlbG9hZC1zdWJyZXNvdXJjZS13aGVuLXR5cGUtY2hhbmdlcy5odG1s OgorICAgICAgICAqIGxvYWRlci9yZXNvdXJjZXMvcmVsb2FkLXN1YnJlc291cmNlLXdoZW4tdHlw ZS1jaGFuZ2VzLmpzOgorCiAyMDExLTA0LTExICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQu b3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFRvbnkgQ2hhbmcuCkluZGV4OiBMYXlvdXRUZXN0 cy9sb2FkZXIvcmVsb2FkLXN1YnJlc291cmNlLXdoZW4tdHlwZS1jaGFuZ2VzLmh0bWwKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gTGF5b3V0VGVzdHMvbG9hZGVyL3JlbG9hZC1zdWJyZXNvdXJjZS13aGVuLXR5cGUt Y2hhbmdlcy5odG1sCShyZXZpc2lvbiA4MzU0OSkKKysrIExheW91dFRlc3RzL2xvYWRlci9yZWxv YWQtc3VicmVzb3VyY2Utd2hlbi10eXBlLWNoYW5nZXMuaHRtbAkod29ya2luZyBjb3B5KQpAQCAt MTYsMTIgKzE2LDIzIEBAIGZ1bmN0aW9uIGxvZyhzdHJpbmcpCiAgICAgbG9nRGl2LmFwcGVuZENo aWxkKGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImJyIikpOwogfQogCit2YXIgbG9hZGVkID0gMDsK K3ZhciBtZXNzYWdlcyA9IFtdOworCiBmdW5jdGlvbiBjaGVja0xvYWRlZEltYWdlKGV2ZW50LCB0 ZXN0TnVtYmVyKSB7CiAgICAgdmFyIGltYWdlV2lkdGggPSBldmVudC50YXJnZXQud2lkdGg7CiAg ICAgaWYgKGltYWdlV2lkdGggPT0gMjUpCi0gICAgICAgIGxvZygiUEFTUyAiICsgdGVzdE51bWJl ciArICIgb2YgMyIpOworICAgICAgICByZXNvdXJjZUxvYWRlZCgiUEFTUyAiLCB0ZXN0TnVtYmVy KTsKICAgICBlbHNlCi0gICAgICAgIGxvZygiSU1BR0UgU0laRSAiICsgaW1hZ2VXaWR0aCArICIg RkFJTCAtICIgKyB0ZXN0TnVtYmVyICsgIiBvZiAyIik7CisgICAgICAgIHJlc291cmNlTG9hZGVk KCJJTUFHRSBTSVpFICIgKyBpbWFnZVdpZHRoICsgIiBGQUlMIC0gIiwgdGVzdE51bWJlcik7Cit9 CisKK2Z1bmN0aW9uIHJlc291cmNlTG9hZGVkKG1lc3NhZ2UsIHRlc3ROdW1iZXIpIHsKKyAgICBt ZXNzYWdlc1t0ZXN0TnVtYmVyXSA9IG1lc3NhZ2UgKyB0ZXN0TnVtYmVyICsgIiBvZiAzIjsKKyAg ICBpZiAoKytsb2FkZWQgPT0gMykgeworICAgICAgICBmb3IgKHZhciBpID0gMTsgaSA8PSAzOyBp KyspCisgICAgICAgICAgICBsb2cobWVzc2FnZXNbaV0pOworICAgIH0KIH0KIDwvc2NyaXB0Pgog CkluZGV4OiBMYXlvdXRUZXN0cy9sb2FkZXIvcmVzb3VyY2VzL3JlbG9hZC1zdWJyZXNvdXJjZS13 aGVuLXR5cGUtY2hhbmdlcy5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9sb2FkZXIvcmVz b3VyY2VzL3JlbG9hZC1zdWJyZXNvdXJjZS13aGVuLXR5cGUtY2hhbmdlcy5qcwkocmV2aXNpb24g ODM1NDkpCisrKyBMYXlvdXRUZXN0cy9sb2FkZXIvcmVzb3VyY2VzL3JlbG9hZC1zdWJyZXNvdXJj ZS13aGVuLXR5cGUtY2hhbmdlcy5qcwkod29ya2luZyBjb3B5KQpAQCAtMSwyICsxLDIgQEAKIGNs ZWFyTG9nKCk7Ci1sb2coIlBBU1MgMSBvZiAzIik7CityZXNvdXJjZUxvYWRlZCgiUEFTUyAiLCAx KTsK