56354 2011-03-14 19:14:34 -0700 Web Inspector: empty, non-functional window 2011-03-28 22:09:01 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) Mac (Intel) OS X 10.6 RESOLVED FIXED P2 Normal --- 0 opendarwin webkit-unassigned apavlov bweinstein commit-queue joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 367442 0 opendarwin 2011-03-14 19:14:34 -0700 I'm using a Debug build of WebKit svn r81082 on Mac OS X 10.6.6, Safari 5.0.4. When I load a web page and open the web inspector, the inspector is just an empty window. There's a search field and buttons, but nothing does anything. When I open "WebKit/WebKitBuild/Debug/WebCore.framework/Versions/A/Resources/inspector/inspector.html" in Safari running the system WebKit, Safari's normal web inspector Console gives this error: TypeError: Result of expression 'this.classList' [undefined] is not an object. 367443 1 opendarwin 2011-03-14 19:15:09 -0700 Joe Peck said it's probably the result of https://bugs.webkit.org/show_bug.cgi?id=56096 367495 2 opendarwin 2011-03-14 21:35:01 -0700 Actually, I can reproduce this bug with svn r80830, so it wasn't broken in 80831. 367507 3 joepeck 2011-03-14 22:15:14 -0700 Oh, that makes sense if classList was not available in Safari 5.0.4. I thought it was. 367531 4 opendarwin 2011-03-14 23:21:51 -0700 The cause is actually http://trac.webkit.org/changeset/70622/trunk along with associated build fixes http://trac.webkit.org/changeset/70623/trunk and http://trac.webkit.org/changeset/70633/trunk To reproduce: defaults write com.apple.Safari WebKitLocalStorageEnabledPreferenceKey -bool false The file "WebKit/Source/WebCore/inspector/front-end/Settings.js" needs to check "window.localStorage != null" before using it. 367533 5 pfeldman 2011-03-14 23:24:37 -0700 > To reproduce: > defaults write com.apple.Safari WebKitLocalStorageEnabledPreferenceKey -bool false why would you do this? 367631 6 opendarwin 2011-03-15 05:49:08 -0700 (In reply to comment #5) > > To reproduce: > > defaults write com.apple.Safari WebKitLocalStorageEnabledPreferenceKey -bool false > > why would you do this? LOL. Why wouldn't I do it? Why do people disable cookies? :-) 372753 7 86759 opendarwin 2011-03-24 05:38:24 -0700 Created attachment 86759 Patch 372956 8 86759 pfeldman 2011-03-24 11:17:54 -0700 Comment on attachment 86759 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=86759&action=review Thanks for fixing this. I have to put r- for the poor email in the changelog + nit on the null comparison. > Source/WebCore/ChangeLog:1 > +2011-03-24 Jeff Johnson <lapcatsoftware.com> This should contain your email. > Source/WebCore/inspector/front-end/Settings.js:117 > + if (window.localStorage === null) I'd rather use window.localStorage == null in order to allow undefined value. Have you checked that localStorage is null both for v8 and jsc bindings? 373103 9 opendarwin 2011-03-24 14:31:55 -0700 (In reply to comment #8) > (From update of attachment 86759 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=86759&action=review > > Thanks for fixing this. I have to put r- for the poor email in the changelog + nit on the null comparison. > > > Source/WebCore/ChangeLog:1 > > +2011-03-24 Jeff Johnson <lapcatsoftware.com> > > This should contain your email. I actually left the full address out on purpose, because after my last patch, which did contain an email address, I started receiving a ton of spam at that address, whereas I had never received spam at that address before. Is there some way I can leave out the email? I'd rather be anonymous than spammed. ;-) > > Source/WebCore/inspector/front-end/Settings.js:117 > > + if (window.localStorage === null) > > I'd rather use window.localStorage == null in order to allow undefined value. Have you checked that localStorage is null both for v8 and jsc bindings? I don't think there would be a difference between V8 and JSC, because the value comes from DOMWindow::sessionStorage(): https://trac.webkit.org/browser/trunk/Source/WebCore/page/DOMWindow.cpp That said, I'm not opposed to switching operators if you prefer. I should also note that I've filed this related bug: https://bugs.webkit.org/show_bug.cgi?id=56703 If the linked bug is implemented, then we'd need to wrap a try around the check as opposed to (or in addition to) checking for null. However, I'd rather fix the web inspector now and possibly revise it later if and when the SECURITY_ERR change is implemented. I don't know how much opposition there would be to throwing a SECURITY_ERR. 373110 10 opendarwin 2011-03-24 14:43:24 -0700 Typo in the above, I meant DOMWindow::localStorage rather than DOMWindow::sessionStorage. 373414 11 pfeldman 2011-03-25 02:37:36 -0700 http://www.webkit.org/coding/contributing.html#changelogs claims there should be an email. I'd rather not violate it. I see opendarwin at lapcatsoftware.com in the comments titles, so it is already available to the spammers... > I don't think there would be a difference between V8 and JSC, because the value comes from DOMWindow::sessionStorage(): > > https://trac.webkit.org/browser/trunk/Source/WebCore/page/DOMWindow.cpp It is wrapped in the VM-specific JavaScript bindings, but it looks like both engines behave the same way. However, I suspect that compiling WebKit without ENABLE_DOM_STORAGE would result in window.localStorage being undefined, so == is better. > > https://bugs.webkit.org/show_bug.cgi?id=56703 > > If the linked bug is implemented, then we'd need to wrap a try around the check as opposed to (or in addition to) checking for null. However, I'd rather fix the web inspector now and possibly revise it later if and when the SECURITY_ERR change is implemented. I don't know how much opposition there would be to throwing a SECURITY_ERR. Yes, lets keep them separate. 373476 12 86930 opendarwin 2011-03-25 06:28:58 -0700 Created attachment 86930 Patch 374996 13 86930 commit-queue 2011-03-28 22:08:56 -0700 Comment on attachment 86930 Patch Clearing flags on attachment: 86930 Committed r82191: <http://trac.webkit.org/changeset/82191> 374997 14 commit-queue 2011-03-28 22:09:01 -0700 All reviewed patches have been landed. Closing bug. 86759 2011-03-24 05:38:24 -0700 2011-03-25 06:28:54 -0700 Patch bug-56354-20110324073822.patch text/plain 2240 opendarwin U3VidmVyc2lvbiBSZXZpc2lvbjogODE4NjAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBkMDdhZmEzZTFhOTY1OGU3 ODNmMTM1MDQ3ZTcyNzdmYTEyZTU5Yzg2Li5kZjgzMzdhMjU4MDE3YTRhOWFhYzQ2NTkzZThiYzZj MTA1MGE4ODRkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMDMtMjQgIEplZmYg Sm9obnNvbiAgPGxhcGNhdHNvZnR3YXJlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBlbXB0eSwgbm9uLWZ1bmN0aW9u YWwgd2luZG93CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD01NjM1NAorCisgICAgICAgIENoZWNrIHdoZXRoZXIgRE9NIGxvY2FsIHN0b3JhZ2UgaXMgZW5h YmxlZAorICAgICAgICBiZWZvcmUgYXR0ZW1wdGluZyB0byBhY2Nlc3Mgd2luZG93LmxvY2FsU3Rv cmFnZS4KKworICAgICAgICBObyBuZXcgdGVzdHMuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJv bnQtZW5kL1NldHRpbmdzLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlNldHRpbmdzLnByb3Rv dHlwZS5maW5kU2V0dGluZ0ZvckFsbFByb2plY3RzKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5T ZXR0aW5ncy5wcm90b3R5cGUuX2dldCk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuU2V0dGluZ3Mu cHJvdG90eXBlLl9zZXQpOgorCiAyMDExLTAzLTExICBTdGV2ZSBCbG9jayAgPHN0ZXZlYmxvY2tA Z29vZ2xlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBKZXJlbXkgT3Jsb3cuCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1NldHRpbmdzLmpzIGIvU291 cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TZXR0aW5ncy5qcwppbmRleCA1MWJkMmFh ZWNjZmJjMzU3OWRiODkwNTdhNGNkZTg0N2I4OTQwZTY4Li44OTdmMjE3ZTA3MzUzZDFmY2Q0ZWZj YmE2YjU2YmFjNDE1YzE4OWIxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3Iv ZnJvbnQtZW5kL1NldHRpbmdzLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9u dC1lbmQvU2V0dGluZ3MuanMKQEAgLTExNCw2ICsxMTQsOSBAQCBXZWJJbnNwZWN0b3IuU2V0dGlu Z3MucHJvdG90eXBlID0gewogICAgIGZpbmRTZXR0aW5nRm9yQWxsUHJvamVjdHM6IGZ1bmN0aW9u KGtleSkKICAgICB7CiAgICAgICAgIHZhciByZXN1bHQgPSB7fTsKKyAgICAgICAgaWYgKHdpbmRv dy5sb2NhbFN0b3JhZ2UgPT09IG51bGwpCisgICAgICAgICAgICByZXR1cm4gcmVzdWx0OworCiAg ICAgICAgIHZhciByZWdleHAgPSAiXiIgKyBrZXkgKyAiOiguKikiOwogICAgICAgICBmb3IgKHZh ciBpID0gMDsgaSA8IHdpbmRvdy5sb2NhbFN0b3JhZ2UubGVuZ3RoOyArK2kpIHsKICAgICAgICAg ICAgIHZhciBmdWxsS2V5ID0gIHdpbmRvdy5sb2NhbFN0b3JhZ2Uua2V5KGkpOwpAQCAtMTMxLDcg KzEzNCw3IEBAIFdlYkluc3BlY3Rvci5TZXR0aW5ncy5wcm90b3R5cGUgPSB7CiAKICAgICBfZ2V0 OiBmdW5jdGlvbihrZXksIGRlZmF1bHRWYWx1ZSkKICAgICB7Ci0gICAgICAgIGlmIChrZXkgaW4g d2luZG93LmxvY2FsU3RvcmFnZSkgeworICAgICAgICBpZiAod2luZG93LmxvY2FsU3RvcmFnZSAh PT0gbnVsbCAmJiBrZXkgaW4gd2luZG93LmxvY2FsU3RvcmFnZSkgewogICAgICAgICAgICAgdHJ5 IHsKICAgICAgICAgICAgICAgICByZXR1cm4gSlNPTi5wYXJzZSh3aW5kb3cubG9jYWxTdG9yYWdl W2tleV0pOwogICAgICAgICAgICAgfSBjYXRjaChlKSB7CkBAIC0xNDMsNyArMTQ2LDggQEAgV2Vi SW5zcGVjdG9yLlNldHRpbmdzLnByb3RvdHlwZSA9IHsKIAogICAgIF9zZXQ6IGZ1bmN0aW9uKGtl eSwgdmFsdWUpCiAgICAgewotICAgICAgICB3aW5kb3cubG9jYWxTdG9yYWdlW2tleV0gPSBKU09O LnN0cmluZ2lmeSh2YWx1ZSk7CisgICAgICAgIGlmICh3aW5kb3cubG9jYWxTdG9yYWdlICE9PSBu dWxsKQorICAgICAgICAgICAgd2luZG93LmxvY2FsU3RvcmFnZVtrZXldID0gSlNPTi5zdHJpbmdp ZnkodmFsdWUpOwogICAgIH0sCiAKICAgICBfZ2V0UHJvamVjdFNldHRpbmc6IGZ1bmN0aW9uKGtl eSwgZGVmYXVsdFZhbHVlKQo= 86930 2011-03-25 06:28:58 -0700 2011-03-28 22:08:56 -0700 Patch bug-56354-20110325082857.patch text/plain 2248 opendarwin U3VidmVyc2lvbiBSZXZpc2lvbjogODE4NjAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBkMDdhZmEzZTFhOTY1OGU3 ODNmMTM1MDQ3ZTcyNzdmYTEyZTU5Yzg2Li5lNTUyNmQ0OWE2NDZiM2E0ZjMyZjU0MDQwM2EyMTZk MTI4ZTk1NGRmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMDMtMjUgIEplZmYg Sm9obnNvbiAgPG9wZW5kYXJ3aW5AbGFwY2F0c29mdHdhcmUuY29tPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IGVtcHR5LCBu b24tZnVuY3Rpb25hbCB3aW5kb3cKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTU2MzU0CisKKyAgICAgICAgQ2hlY2sgd2hldGhlciBET00gbG9jYWwgc3Rv cmFnZSBpcyBlbmFibGVkCisgICAgICAgIGJlZm9yZSBhdHRlbXB0aW5nIHRvIGFjY2VzcyB3aW5k b3cubG9jYWxTdG9yYWdlLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4KKworICAgICAgICAqIGlu c3BlY3Rvci9mcm9udC1lbmQvU2V0dGluZ3MuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuU2V0 dGluZ3MucHJvdG90eXBlLmZpbmRTZXR0aW5nRm9yQWxsUHJvamVjdHMpOgorICAgICAgICAoV2Vi SW5zcGVjdG9yLlNldHRpbmdzLnByb3RvdHlwZS5fZ2V0KToKKyAgICAgICAgKFdlYkluc3BlY3Rv ci5TZXR0aW5ncy5wcm90b3R5cGUuX3NldCk6CisKIDIwMTEtMDMtMTEgIFN0ZXZlIEJsb2NrICA8 c3RldmVibG9ja0Bnb29nbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEplcmVteSBPcmxv dy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU2V0dGlu Z3MuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1NldHRpbmdzLmpzCmlu ZGV4IDUxYmQyYWFlY2NmYmMzNTc5ZGI4OTA1N2E0Y2RlODQ3Yjg5NDBlNjguLjk5OTVjYTI4N2Zl ZGY5NGM5ODEyMDNiZDFiOTcxNmE0ODhlYTJhMTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2luc3BlY3Rvci9mcm9udC1lbmQvU2V0dGluZ3MuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5z cGVjdG9yL2Zyb250LWVuZC9TZXR0aW5ncy5qcwpAQCAtMTE0LDYgKzExNCw5IEBAIFdlYkluc3Bl Y3Rvci5TZXR0aW5ncy5wcm90b3R5cGUgPSB7CiAgICAgZmluZFNldHRpbmdGb3JBbGxQcm9qZWN0 czogZnVuY3Rpb24oa2V5KQogICAgIHsKICAgICAgICAgdmFyIHJlc3VsdCA9IHt9OworICAgICAg ICBpZiAod2luZG93LmxvY2FsU3RvcmFnZSA9PSBudWxsKQorICAgICAgICAgICAgcmV0dXJuIHJl c3VsdDsKKwogICAgICAgICB2YXIgcmVnZXhwID0gIl4iICsga2V5ICsgIjooLiopIjsKICAgICAg ICAgZm9yICh2YXIgaSA9IDA7IGkgPCB3aW5kb3cubG9jYWxTdG9yYWdlLmxlbmd0aDsgKytpKSB7 CiAgICAgICAgICAgICB2YXIgZnVsbEtleSA9ICB3aW5kb3cubG9jYWxTdG9yYWdlLmtleShpKTsK QEAgLTEzMSw3ICsxMzQsNyBAQCBXZWJJbnNwZWN0b3IuU2V0dGluZ3MucHJvdG90eXBlID0gewog CiAgICAgX2dldDogZnVuY3Rpb24oa2V5LCBkZWZhdWx0VmFsdWUpCiAgICAgewotICAgICAgICBp ZiAoa2V5IGluIHdpbmRvdy5sb2NhbFN0b3JhZ2UpIHsKKyAgICAgICAgaWYgKHdpbmRvdy5sb2Nh bFN0b3JhZ2UgIT0gbnVsbCAmJiBrZXkgaW4gd2luZG93LmxvY2FsU3RvcmFnZSkgewogICAgICAg ICAgICAgdHJ5IHsKICAgICAgICAgICAgICAgICByZXR1cm4gSlNPTi5wYXJzZSh3aW5kb3cubG9j YWxTdG9yYWdlW2tleV0pOwogICAgICAgICAgICAgfSBjYXRjaChlKSB7CkBAIC0xNDMsNyArMTQ2 LDggQEAgV2ViSW5zcGVjdG9yLlNldHRpbmdzLnByb3RvdHlwZSA9IHsKIAogICAgIF9zZXQ6IGZ1 bmN0aW9uKGtleSwgdmFsdWUpCiAgICAgewotICAgICAgICB3aW5kb3cubG9jYWxTdG9yYWdlW2tl eV0gPSBKU09OLnN0cmluZ2lmeSh2YWx1ZSk7CisgICAgICAgIGlmICh3aW5kb3cubG9jYWxTdG9y YWdlICE9IG51bGwpCisgICAgICAgICAgICB3aW5kb3cubG9jYWxTdG9yYWdlW2tleV0gPSBKU09O LnN0cmluZ2lmeSh2YWx1ZSk7CiAgICAgfSwKIAogICAgIF9nZXRQcm9qZWN0U2V0dGluZzogZnVu Y3Rpb24oa2V5LCBkZWZhdWx0VmFsdWUpCg==