56347 2011-03-14 17:58:25 -0700 WebKit should reset the click count when a new page loads. 2024-05-15 06:24:37 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All NEW InRadar, LayoutTestFailure P1 Normal --- 61319 61633 1 luiz webkit-unassigned ap aroben bfulgham dglazkov rniwa sam skortzy82 oldest_to_newest 367396 0 luiz 2011-03-14 17:58:25 -0700 Some tests are failing in Windows apparently because clicks in sequential tests are sometimes counted as double clicks. 367406 1 luiz 2011-03-14 18:16:46 -0700 The following tests were skipped in Windows: fast/html/details-add-summary-1-and-click.html fast/html/details-add-summary-2-and-click.html fast/html/details-add-summary-3-and-click.html fast/html/details-add-summary-4-and-click.html fast/html/details-add-summary-5-and-click.html fast/html/details-add-summary-6-and-click.html fast/html/details-add-summary-7-and-click.html fast/html/details-add-summary-8-and-click.html fast/html/details-add-summary-9-and-click.html fast/html/details-add-summary-10-and-click.html fast/html/details-remove-summary-1-and-click.html fast/html/details-remove-summary-2-and-click.html fast/html/details-remove-summary-3-and-click.html fast/html/details-remove-summary-4-and-click.html fast/html/details-remove-summary-5-and-click.html fast/html/details-remove-summary-6-and-click.html 384338 2 jberlin 2011-04-12 13:57:31 -0700 <rdar://problem/9273891> 408947 3 aroben 2011-05-24 10:04:48 -0700 In WebKit1, WebView::handleMouseEvent has a globalClickCount variable that is responsible for this. In WebKit2, WebEventFactor.cpp has a clickCount function that stores a gLastClickCount variable. 411588 4 95201 aroben 2011-05-27 11:37:34 -0700 Created attachment 95201 Work-in-progress patch for WebKit1 Here's a work-in-progress patch for WebKit1. It doesn't try to fix WebKit2. 480352 5 rniwa 2011-10-07 15:39:51 -0700 *** Bug 61633 has been marked as a duplicate of this bug. *** 480354 6 rniwa 2011-10-07 15:42:25 -0700 This is causing Windows port to lose a significant test coverage. We need to fix it ASAP. 982012 7 bfulgham 2014-02-18 11:30:46 -0800 This no longer seems to be a problem on Windows; all of these tests pass. Perhaps this is because WK2 is no longer used on Windows? 95201 2011-05-27 11:37:34 -0700 2011-05-27 11:37:34 -0700 Work-in-progress patch for WebKit1 wip.patch text/plain 6851 aroben ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvd2luL1dlYkNvcmVTdXBwb3J0L1dlYkZyYW1lTG9h ZGVyQ2xpZW50LmNwcCBiL1NvdXJjZS9XZWJLaXQvd2luL1dlYkNvcmVTdXBwb3J0L1dlYkZyYW1l TG9hZGVyQ2xpZW50LmNwcAppbmRleCAzM2U1MGM5Li4yMWYxMmJiIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L3dpbi9XZWJDb3JlU3VwcG9ydC9XZWJGcmFtZUxvYWRlckNsaWVudC5jcHAKKysr IGIvU291cmNlL1dlYktpdC93aW4vV2ViQ29yZVN1cHBvcnQvV2ViRnJhbWVMb2FkZXJDbGllbnQu Y3BwCkBAIC0zOTcsNiArMzk3LDcgQEAgdm9pZCBXZWJGcmFtZUxvYWRlckNsaWVudDo6ZGlzcGF0 Y2hEaWRDb21taXRMb2FkKCkKICAgICBDT01QdHI8SVdlYkZyYW1lTG9hZERlbGVnYXRlPiBmcmFt ZUxvYWREZWxlZ2F0ZTsKICAgICBpZiAoU1VDQ0VFREVEKHdlYlZpZXctPmZyYW1lTG9hZERlbGVn YXRlKCZmcmFtZUxvYWREZWxlZ2F0ZSkpKQogICAgICAgICBmcmFtZUxvYWREZWxlZ2F0ZS0+ZGlk Q29tbWl0TG9hZEZvckZyYW1lKHdlYlZpZXcsIG1fd2ViRnJhbWUpOworICAgIHdlYlZpZXctPmRp ZENvbW1pdExvYWRGb3JGcmFtZShtX3dlYkZyYW1lKTsKIH0KIAogdm9pZCBXZWJGcmFtZUxvYWRl ckNsaWVudDo6ZGlzcGF0Y2hEaWRGaW5pc2hEb2N1bWVudExvYWQoKQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdC93aW4vV2ViVmlldy5jcHAgYi9Tb3VyY2UvV2ViS2l0L3dpbi9XZWJWaWV3LmNw cAppbmRleCBmNzcxMzNjLi43MzhkMzY5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L3dpbi9X ZWJWaWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L3dpbi9XZWJWaWV3LmNwcApAQCAtMTA4LDcg KzEwOCw2IEBACiAjaW5jbHVkZSA8V2ViQ29yZS9QYWdlQ2FjaGUuaD4KICNpbmNsdWRlIDxXZWJD b3JlL1BhZ2VHcm91cC5oPgogI2luY2x1ZGUgPFdlYkNvcmUvUGxhdGZvcm1LZXlib2FyZEV2ZW50 Lmg+Ci0jaW5jbHVkZSA8V2ViQ29yZS9QbGF0Zm9ybU1vdXNlRXZlbnQuaD4KICNpbmNsdWRlIDxX ZWJDb3JlL1BsYXRmb3JtV2hlZWxFdmVudC5oPgogI2luY2x1ZGUgPFdlYkNvcmUvUGx1Z2luRGF0 YS5oPgogI2luY2x1ZGUgPFdlYkNvcmUvUGx1Z2luRGF0YWJhc2UuaD4KQEAgLTMzNyw2ICszMzYs OSBAQCBXZWJWaWV3OjpXZWJWaWV3KCkKICAgICAsIG1fdmlld1dpbmRvdygwKQogICAgICwgbV9t YWluRnJhbWUoMCkKICAgICAsIG1fcGFnZSgwKQorICAgICwgbV9jbGlja0NvdW50KDApCisgICAg LCBtX2xhc3RNb3VzZUJ1dHRvbihOb0J1dHRvbikKKyAgICAsIG1fbGFzdE1vdXNlRG93blRpbWUo MCkKICAgICAsIG1faGFzQ3VzdG9tRHJvcFRhcmdldChmYWxzZSkKICAgICAsIG1fdXNlQmFja0Zv cndhcmRMaXN0KHRydWUpCiAgICAgLCBtX3VzZXJBZ2VudE92ZXJyaWRkZW4oZmFsc2UpCkBAIC0x NDQxLDExICsxNDQzLDYgQEAgdm9pZCBXZWJWaWV3OjpwZXJmb3JtQ29udGV4dE1lbnVBY3Rpb24o V1BBUkFNIHdQYXJhbSwgTFBBUkFNIGxQYXJhbSwgYm9vbCBieVBvc2kKIAogYm9vbCBXZWJWaWV3 OjpoYW5kbGVNb3VzZUV2ZW50KFVJTlQgbWVzc2FnZSwgV1BBUkFNIHdQYXJhbSwgTFBBUkFNIGxQ YXJhbSkKIHsKLSAgICBzdGF0aWMgTE9ORyBnbG9iYWxDbGlja0NvdW50OwotICAgIHN0YXRpYyBJ bnRQb2ludCBnbG9iYWxQcmV2UG9pbnQ7Ci0gICAgc3RhdGljIE1vdXNlQnV0dG9uIGdsb2JhbFBy ZXZCdXR0b247Ci0gICAgc3RhdGljIExPTkcgZ2xvYmFsUHJldk1vdXNlRG93blRpbWU7Ci0KICAg ICBpZiAobWVzc2FnZSA9PSBXTV9DQU5DRUxNT0RFKSB7CiAgICAgICAgIG1fcGFnZS0+bWFpbkZy YW1lKCktPmV2ZW50SGFuZGxlcigpLT5sb3N0TW91c2VDYXB0dXJlKCk7CiAgICAgICAgIHJldHVy biB0cnVlOwpAQCAtMTQ1OSw4ICsxNDU2LDggQEAgYm9vbCBXZWJWaWV3OjpoYW5kbGVNb3VzZUV2 ZW50KFVJTlQgbWVzc2FnZSwgV1BBUkFNIHdQYXJhbSwgTFBBUkFNIGxQYXJhbSkKIAogICAgIHNl dE1vdXNlQWN0aXZhdGVkKGZhbHNlKTsKIAotICAgIGJvb2wgaW5zaWRlVGhyZXNob2xkID0gYWJz KGdsb2JhbFByZXZQb2ludC54KCkgLSBtb3VzZUV2ZW50LnBvcygpLngoKSkgPCA6OkdldFN5c3Rl bU1ldHJpY3MoU01fQ1hET1VCTEVDTEspICYmCi0gICAgICAgICAgICAgICAgICAgICAgICAgICBh YnMoZ2xvYmFsUHJldlBvaW50LnkoKSAtIG1vdXNlRXZlbnQucG9zKCkueSgpKSA8IDo6R2V0U3lz dGVtTWV0cmljcyhTTV9DWURPVUJMRUNMSyk7CisgICAgYm9vbCBpbnNpZGVUaHJlc2hvbGQgPSBh YnMobV9sYXN0TW91c2VCdXR0b25Mb2NhdGlvbi54KCkgLSBtb3VzZUV2ZW50LnBvcygpLngoKSkg PCA6OkdldFN5c3RlbU1ldHJpY3MoU01fQ1hET1VCTEVDTEspICYmCisgICAgICAgICAgICAgICAg ICAgICAgICAgICBhYnMobV9sYXN0TW91c2VCdXR0b25Mb2NhdGlvbi55KCkgLSBtb3VzZUV2ZW50 LnBvcygpLnkoKSkgPCA6OkdldFN5c3RlbU1ldHJpY3MoU01fQ1lET1VCTEVDTEspOwogICAgIExP TkcgbWVzc2FnZVRpbWUgPSA6OkdldE1lc3NhZ2VUaW1lKCk7CiAKICAgICBib29sIGhhbmRsZWQg PSBmYWxzZTsKQEAgLTE0NzQsMjggKzE0NzEsMjggQEAgYm9vbCBXZWJWaWV3OjpoYW5kbGVNb3Vz ZUV2ZW50KFVJTlQgbWVzc2FnZSwgV1BBUkFNIHdQYXJhbSwgTFBBUkFNIGxQYXJhbSkKICAgICAg ICAgLy8gQWx3YXlzIHN0YXJ0IGNhcHR1cmluZyBldmVudHMgd2hlbiB0aGUgbW91c2UgZ29lcyBk b3duIGluIG91ciBIV05ELgogICAgICAgICA6OlNldENhcHR1cmUobV92aWV3V2luZG93KTsKIAot ICAgICAgICBpZiAoKChtZXNzYWdlVGltZSAtIGdsb2JhbFByZXZNb3VzZURvd25UaW1lKSA8IChM T05HKTo6R2V0RG91YmxlQ2xpY2tUaW1lKCkpICYmIAorICAgICAgICBpZiAoKChtZXNzYWdlVGlt ZSAtIG1fbGFzdE1vdXNlRG93blRpbWUpIDwgKExPTkcpOjpHZXREb3VibGVDbGlja1RpbWUoKSkg JiYgCiAgICAgICAgICAgICBpbnNpZGVUaHJlc2hvbGQgJiYKLSAgICAgICAgICAgIG1vdXNlRXZl bnQuYnV0dG9uKCkgPT0gZ2xvYmFsUHJldkJ1dHRvbikKLSAgICAgICAgICAgIGdsb2JhbENsaWNr Q291bnQrKzsKKyAgICAgICAgICAgIG1vdXNlRXZlbnQuYnV0dG9uKCkgPT0gbV9sYXN0TW91c2VC dXR0b24pCisgICAgICAgICAgICBtX2NsaWNrQ291bnQrKzsKICAgICAgICAgZWxzZQogICAgICAg ICAgICAgLy8gUmVzZXQgdGhlIGNsaWNrIGNvdW50LgotICAgICAgICAgICAgZ2xvYmFsQ2xpY2tD b3VudCA9IDE7Ci0gICAgICAgIGdsb2JhbFByZXZNb3VzZURvd25UaW1lID0gbWVzc2FnZVRpbWU7 Ci0gICAgICAgIGdsb2JhbFByZXZCdXR0b24gPSBtb3VzZUV2ZW50LmJ1dHRvbigpOwotICAgICAg ICBnbG9iYWxQcmV2UG9pbnQgPSBtb3VzZUV2ZW50LnBvcygpOworICAgICAgICAgICAgbV9jbGlj a0NvdW50ID0gMTsKKyAgICAgICAgbV9sYXN0TW91c2VEb3duVGltZSA9IG1lc3NhZ2VUaW1lOwor ICAgICAgICBtX2xhc3RNb3VzZUJ1dHRvbiA9IG1vdXNlRXZlbnQuYnV0dG9uKCk7CisgICAgICAg IG1fbGFzdE1vdXNlQnV0dG9uTG9jYXRpb24gPSBtb3VzZUV2ZW50LnBvcygpOwogICAgICAgICAK LSAgICAgICAgbW91c2VFdmVudC5zZXRDbGlja0NvdW50KGdsb2JhbENsaWNrQ291bnQpOworICAg ICAgICBtb3VzZUV2ZW50LnNldENsaWNrQ291bnQobV9jbGlja0NvdW50KTsKICAgICAgICAgaGFu ZGxlZCA9IG1fcGFnZS0+bWFpbkZyYW1lKCktPmV2ZW50SGFuZGxlcigpLT5oYW5kbGVNb3VzZVBy ZXNzRXZlbnQobW91c2VFdmVudCk7CiAgICAgfSBlbHNlIGlmIChtZXNzYWdlID09IFdNX0xCVVRU T05EQkxDTEsgfHwgbWVzc2FnZSA9PSBXTV9NQlVUVE9OREJMQ0xLIHx8IG1lc3NhZ2UgPT0gV01f UkJVVFRPTkRCTENMSykgewotICAgICAgICBnbG9iYWxDbGlja0NvdW50Kys7Ci0gICAgICAgIG1v dXNlRXZlbnQuc2V0Q2xpY2tDb3VudChnbG9iYWxDbGlja0NvdW50KTsKKyAgICAgICAgbV9jbGlj a0NvdW50Kys7CisgICAgICAgIG1vdXNlRXZlbnQuc2V0Q2xpY2tDb3VudChtX2NsaWNrQ291bnQp OwogICAgICAgICBoYW5kbGVkID0gbV9wYWdlLT5tYWluRnJhbWUoKS0+ZXZlbnRIYW5kbGVyKCkt PmhhbmRsZU1vdXNlUHJlc3NFdmVudChtb3VzZUV2ZW50KTsKICAgICB9IGVsc2UgaWYgKG1lc3Nh Z2UgPT0gV01fTEJVVFRPTlVQIHx8IG1lc3NhZ2UgPT0gV01fTUJVVFRPTlVQIHx8IG1lc3NhZ2Ug PT0gV01fUkJVVFRPTlVQKSB7Ci0gICAgICAgIC8vIFJlY29yZCB0aGUgZ2xvYmFsIHBvc2l0aW9u IGFuZCB0aGUgYnV0dG9uIG9mIHRoZSB1cC4KLSAgICAgICAgZ2xvYmFsUHJldkJ1dHRvbiA9IG1v dXNlRXZlbnQuYnV0dG9uKCk7Ci0gICAgICAgIGdsb2JhbFByZXZQb2ludCA9IG1vdXNlRXZlbnQu cG9zKCk7Ci0gICAgICAgIG1vdXNlRXZlbnQuc2V0Q2xpY2tDb3VudChnbG9iYWxDbGlja0NvdW50 KTsKKyAgICAgICAgLy8gUmVjb3JkIHRoZSBwb3NpdGlvbiBhbmQgdGhlIGJ1dHRvbiBvZiB0aGUg dXAuCisgICAgICAgIG1fbGFzdE1vdXNlQnV0dG9uID0gbW91c2VFdmVudC5idXR0b24oKTsKKyAg ICAgICAgbV9sYXN0TW91c2VCdXR0b25Mb2NhdGlvbiA9IG1vdXNlRXZlbnQucG9zKCk7CisgICAg ICAgIG1vdXNlRXZlbnQuc2V0Q2xpY2tDb3VudChtX2NsaWNrQ291bnQpOwogICAgICAgICBtX3Bh Z2UtPm1haW5GcmFtZSgpLT5ldmVudEhhbmRsZXIoKS0+aGFuZGxlTW91c2VSZWxlYXNlRXZlbnQo bW91c2VFdmVudCk7CiAgICAgICAgIDo6UmVsZWFzZUNhcHR1cmUoKTsKICAgICB9IGVsc2UgaWYg KG1lc3NhZ2UgPT0gV01fTU9VU0VMRUFWRSAmJiBtX21vdXNlT3V0VHJhY2tlcikgewpAQCAtMTUw Niw4ICsxNTAzLDggQEAgYm9vbCBXZWJWaWV3OjpoYW5kbGVNb3VzZUV2ZW50KFVJTlQgbWVzc2Fn ZSwgV1BBUkFNIHdQYXJhbSwgTFBBUkFNIGxQYXJhbSkKICAgICAgICAgaGFuZGxlZCA9IHRydWU7 CiAgICAgfSBlbHNlIGlmIChtZXNzYWdlID09IFdNX01PVVNFTU9WRSkgewogICAgICAgICBpZiAo IWluc2lkZVRocmVzaG9sZCkKLSAgICAgICAgICAgIGdsb2JhbENsaWNrQ291bnQgPSAwOwotICAg ICAgICBtb3VzZUV2ZW50LnNldENsaWNrQ291bnQoZ2xvYmFsQ2xpY2tDb3VudCk7CisgICAgICAg ICAgICBtX2NsaWNrQ291bnQgPSAwOworICAgICAgICBtb3VzZUV2ZW50LnNldENsaWNrQ291bnQo bV9jbGlja0NvdW50KTsKICAgICAgICAgaGFuZGxlZCA9IG1fcGFnZS0+bWFpbkZyYW1lKCktPmV2 ZW50SGFuZGxlcigpLT5tb3VzZU1vdmVkKG1vdXNlRXZlbnQpOwogICAgICAgICBpZiAoIW1fbW91 c2VPdXRUcmFja2VyKSB7CiAgICAgICAgICAgICBtX21vdXNlT3V0VHJhY2tlciA9IGFkb3B0UHRy KG5ldyBUUkFDS01PVVNFRVZFTlQpOwpAQCAtNjgzOCwzICs2ODM1LDEzIEBAIHZvaWQgV2ViVmll dzo6ZnVsbFNjcmVlbkNsaWVudEZvcmNlUmVwYWludCgpCiB9CiAKICNlbmRpZgorCit2b2lkIFdl YlZpZXc6OmRpZENvbW1pdExvYWRGb3JGcmFtZShXZWJGcmFtZSogZnJhbWUpCit7CisgICAgaWYg KGZyYW1lICE9IG1fbWFpbkZyYW1lKQorICAgICAgICByZXR1cm47CisgICAgbV9jbGlja0NvdW50 ID0gMDsKKyAgICBtX2xhc3RNb3VzZUJ1dHRvbkxvY2F0aW9uID0gSW50UG9pbnQoKTsKKyAgICBt X2xhc3RNb3VzZUJ1dHRvbiA9IE5vQnV0dG9uOworICAgIG1fbGFzdE1vdXNlRG93blRpbWUgPSAw OworfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC93aW4vV2ViVmlldy5oIGIvU291cmNlL1dl YktpdC93aW4vV2ViVmlldy5oCmluZGV4IDg3NjYyOGIuLmI4MTI2MGUgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvd2luL1dlYlZpZXcuaAorKysgYi9Tb3VyY2UvV2ViS2l0L3dpbi9XZWJWaWV3 LmgKQEAgLTM0LDYgKzM0LDcgQEAKICNpbmNsdWRlIDxXZWJDb3JlL0NPTVB0ci5oPgogI2luY2x1 ZGUgPFdlYkNvcmUvRHJhZ0FjdGlvbnMuaD4KICNpbmNsdWRlIDxXZWJDb3JlL0ludFJlY3QuaD4K KyNpbmNsdWRlIDxXZWJDb3JlL1BsYXRmb3JtTW91c2VFdmVudC5oPgogI2luY2x1ZGUgPFdlYkNv cmUvUmVmQ291bnRlZEdESUhhbmRsZS5oPgogI2luY2x1ZGUgPFdlYkNvcmUvU3VzcGVuZGFibGVU aW1lci5oPgogI2luY2x1ZGUgPFdlYkNvcmUvV2luZG93TWVzc2FnZUxpc3RlbmVyLmg+CkBAIC05 NjAsNiArOTYxLDggQEAgcHVibGljOgogICAgIFdlYkNvcmU6OkVsZW1lbnQqIGZ1bGxTY3JlZW5F bGVtZW50KCkgY29uc3QgeyByZXR1cm4gbV9mdWxsU2NyZWVuRWxlbWVudC5nZXQoKTsgfQogI2Vu ZGlmCiAKKyAgICB2b2lkIGRpZENvbW1pdExvYWRGb3JGcmFtZShXZWJGcmFtZSopOworCiBwcml2 YXRlOgogICAgIHZvaWQgc2V0Wm9vbU11bHRpcGxpZXIoZmxvYXQgbXVsdGlwbGllciwgYm9vbCBp c1RleHRPbmx5KTsKICAgICBmbG9hdCB6b29tTXVsdGlwbGllcihib29sIGlzVGV4dE9ubHkpOwpA QCAtMTA2Miw2ICsxMDY1LDExIEBAIHByb3RlY3RlZDoKICAgICBDT01QdHI8SVdlYlBsdWdpbkhh bHRlckRlbGVnYXRlPiBtX3BsdWdpbkhhbHRlckRlbGVnYXRlOwogICAgIENPTVB0cjxJV2ViR2Vv bG9jYXRpb25Qcm92aWRlcj4gbV9nZW9sb2NhdGlvblByb3ZpZGVyOwogCisgICAgTE9ORyBtX2Ns aWNrQ291bnQ7CisgICAgV2ViQ29yZTo6SW50UG9pbnQgbV9sYXN0TW91c2VCdXR0b25Mb2NhdGlv bjsKKyAgICBXZWJDb3JlOjpNb3VzZUJ1dHRvbiBtX2xhc3RNb3VzZUJ1dHRvbjsKKyAgICBMT05H IG1fbGFzdE1vdXNlRG93blRpbWU7CisKICAgICBib29sIG1fdXNlckFnZW50T3ZlcnJpZGRlbjsK ICAgICBib29sIG1fdXNlQmFja0ZvcndhcmRMaXN0OwogICAgIFdURjo6U3RyaW5nIG1fdXNlckFn ZW50Q3VzdG9tOwo=