56342 2011-03-14 16:02:50 -0700 Leaks Viewer shows recent builds in a strange order 2011-03-14 16:18:12 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 aroben aroben ddkilzer joepeck oldest_to_newest 367314 0 aroben 2011-03-14 16:02:50 -0700 Leaks Viewer shows recent builds in a strange order 367315 1 85735 aroben 2011-03-14 16:04:51 -0700 Created attachment 85735 Patch 367327 2 85735 joepeck 2011-03-14 16:14:50 -0700 Comment on attachment 85735 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=85735&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:80 > + if (a.revision < b.revision) > + return 1; > + if (b.revision < a.revision) > + return -1; > + return 0; How about: return a.revision - b.revision; 367330 3 joepeck 2011-03-14 16:15:29 -0700 > > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:80 > > + if (a.revision < b.revision) > > + return 1; > > + if (b.revision < a.revision) > > + return -1; > > + return 0; > > How about: return a.revision - b.revision; Re-reading that I think I have a and b reversed. 367332 4 aroben 2011-03-14 16:17:52 -0700 Darin and I independently came up with the same suggestion. I've fixed it. Thanks! 367333 5 aroben 2011-03-14 16:18:12 -0700 Committed r81075: <http://trac.webkit.org/changeset/81075> 85735 2011-03-14 16:04:51 -0700 2011-03-14 16:14:50 -0700 Patch bug-56342-20110314160451.patch text/plain 2079 aroben U3VidmVyc2lvbiBSZXZpc2lvbjogODEwNjgKZGlmZiAtLWdpdCBhL1Rvb2xzL0J1aWxkU2xhdmVT dXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL0xlYWtzVmlld2VyL1Jl Y2VudEJ1aWxkc0xvYWRlci5qcyBiL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtp dC5vcmctY29uZmlnL3B1YmxpY19odG1sL0xlYWtzVmlld2VyL1JlY2VudEJ1aWxkc0xvYWRlci5q cwppbmRleCBjYWMyOTAxNjc0ZGY2ZTg4MzUzZDgxMDQ4Yzg3NTFmZTY0YmZhZjliLi4wODE0MWRi OThkZjU3YjI3NmFjZDY4OTIxYTk3YzQxMGEwZDk1YTFkIDEwMDY0NAotLS0gYS9Ub29scy9CdWls ZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9MZWFrc1Zp ZXdlci9SZWNlbnRCdWlsZHNMb2FkZXIuanMKKysrIGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQv YnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvTGVha3NWaWV3ZXIvUmVjZW50QnVp bGRzTG9hZGVyLmpzCkBAIC03MSw2ICs3MSwxNCBAQCBSZWNlbnRCdWlsZHNMb2FkZXIucHJvdG90 eXBlID0gewogICAgICAgICAgICAgICAgICAgICB9CiAgICAgICAgICAgICAgICAgfQogICAgICAg ICAgICAgfSk7CisgICAgICAgICAgICAvLyBTb3J0IGRlc2NlbmRpbmcgYnkgcmV2aXNpb24uCisg ICAgICAgICAgICBidWlsZHMuc29ydChmdW5jdGlvbihhLCBiKSB7CisgICAgICAgICAgICAgICAg aWYgKGEucmV2aXNpb24gPCBiLnJldmlzaW9uKQorICAgICAgICAgICAgICAgICAgICByZXR1cm4g MTsKKyAgICAgICAgICAgICAgICBpZiAoYi5yZXZpc2lvbiA8IGEucmV2aXNpb24pCisgICAgICAg ICAgICAgICAgICAgIHJldHVybiAtMTsKKyAgICAgICAgICAgICAgICByZXR1cm4gMDsKKyAgICAg ICAgICAgIH0pOwogICAgICAgICAgICAgc2VsZi5fZGlkTG9hZFJlY2VudEJ1aWxkc0NhbGxiYWNr KGJ1aWxkcyk7CiAgICAgICAgIH0pOwogICAgIH0sCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VM b2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMWMzNjAyNWUwNjkxZmUxZjgzODQyYzcxZTVkNWFj YmEyNjhkZmExYS4uOGVkYWFlNGYwYmE2MjhhMmIyOGUxZGM3N2ZjN2Y4ZWEyZjFjNWI0OCAxMDA2 NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsx LDIwIEBACiAyMDExLTAzLTE0ICBBZGFtIFJvYmVuICA8YXJvYmVuQGFwcGxlLmNvbT4KIAorICAg ICAgICBTaG93IHRoZSBsaXN0IG9mIHJlY2VudCBsZWFreSBidWlsZHMgaW4gcmV2ZXJzZSBjaHJv bm9sb2dpY2FsIG9yZGVyCisKKyAgICAgICAgUHJldmlvdXNseSB0aGV5IHdlcmUgYmVpbmcgc2hv d24gaW4gYSBkZXRlcm1pbmlzdGljIGJ1dCBzdXJwcmlzaW5nIG9yZGVyIGJhc2VkIG9uCisgICAg ICAgIGxleGljb2dyYXBoaWNhbGx5IHNvcnRpbmcgdGhlIGJ1aWxkIG9mZnNldHMgKC0xLCAtMTAs IC0yLCAtMy4uLikuCisKKyAgICAgICAgRml4ZXMgPGh0dHA6Ly93ZWJraXQub3JnL2IvNTYzNDI+ IExlYWtzIFZpZXdlciBzaG93cyByZWNlbnQgYnVpbGRzIGluIGEgc3RyYW5nZSBvcmRlcgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogQnVpbGRTbGF2 ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvTGVha3NWaWV3ZXIv UmVjZW50QnVpbGRzTG9hZGVyLmpzOgorICAgICAgICAoUmVjZW50QnVpbGRzTG9hZGVyLnByb3Rv dHlwZS5zdGFydCk6IFNvcnQgdGhlIGJ1aWxkcyBieSByZXZpc2lvbiBiZWZvcmUgcGFzc2luZyB0 aGVtIHRvIG91cgorICAgICAgICBjYWxsYmFjay4KKworMjAxMS0wMy0xNCAgQWRhbSBSb2JlbiAg PGFyb2JlbkBhcHBsZS5jb20+CisKICAgICAgICAgU2hvdyBhIGxpc3Qgb2YgdXAgdG8gMTAgcmVj ZW50IGxlYWt5IGJ1aWxkcyB3aGVuIExlYWtzIFZpZXdlciBsb2FkcwogCiAgICAgICAgIEZpeGVz IDxodHRwOi8vd2Via2l0Lm9yZy9iLzU2MDQzPiBMZWFrcyBWaWV3ZXIgc2hvdWxkIHByZXNlbnQg YSBsaXN0IG9mIHJlY2VudCBidWlsZHMgdG8K