56337 2011-03-14 14:38:18 -0700 Enable -Werror on ANGLE 2011-05-04 11:14:31 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 56396 1 ddkilzer ddkilzer aroben cmarrin mrowe simon.fraser vangelis webkit.review.bot zmo oldest_to_newest 367240 0 ddkilzer 2011-03-14 14:38:18 -0700 We should enable -Werror on ANGLE to catch compiler issues. There are a few fixes for clang that must be addressed first. 367318 1 85736 ddkilzer 2011-03-14 16:09:04 -0700 Created attachment 85736 Patch 5/5: Enable -Werror on ANGLE Posting the last one first to make sure gcc-4.2/llvm-gcc-4.2 still builds with this change. 367319 2 85737 ddkilzer 2011-03-14 16:09:44 -0700 Created attachment 85737 Patch 1/5: Fix clang warning: ConstantUnion.h:56:17: warning: 7 enumeration values not handled in switch 367320 3 85738 ddkilzer 2011-03-14 16:10:15 -0700 Created attachment 85738 Patch 2/5: Fix clang warning: ParseHelper.cpp:264:13: warning: 8 enumeration values not handled in switch 367321 4 85739 ddkilzer 2011-03-14 16:10:44 -0700 Created attachment 85739 Patch 3/5: Fix clang warnings: Intermediate.cpp: warning: '&&' within '||' 367323 5 85740 ddkilzer 2011-03-14 16:11:14 -0700 Created attachment 85740 Patch 4/5: Fix clang warnings in PoolAlloc.cpp 367328 6 webkit.review.bot 2011-03-14 16:14:50 -0700 Attachment 85739 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/ThirdParty/ANGLE/ChangeLog', u'Sour..." exit_code: 1 Source/ThirdParty/ANGLE/src/compiler/Intermediate.cpp:1008: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] Source/ThirdParty/ANGLE/src/compiler/Intermediate.cpp:1020: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 367338 7 zmo 2011-03-14 16:30:55 -0700 This should be fixed upstream ANGLE. If you commit it here, after a ANGLE roll in the future, your change will be lost. I see you already filed a bug to ANGLE. Could you upload your patch there? Once it's reviewed and landed upstream, we can do another ANGLE roll in webkit. 367470 8 ddkilzer 2011-03-14 20:15:42 -0700 (In reply to comment #7) > This should be fixed upstream ANGLE. If you commit it here, after a ANGLE roll in the future, your change will be lost. > > I see you already filed a bug to ANGLE. Could you upload your patch there? Once it's reviewed and landed upstream, we can do another ANGLE roll in webkit. So you don't merge changes from ANGLE into WebKit--you just land new code and delete whatever local changes were made? 367471 9 ddkilzer 2011-03-14 20:19:47 -0700 (In reply to comment #7) > I see you already filed a bug to ANGLE. Could you upload your patch there? Once it's reviewed and landed upstream, we can do another ANGLE roll in webkit. I'll upload the patches upstream as well. 367472 10 85737 ddkilzer 2011-03-14 20:24:23 -0700 Comment on attachment 85737 Patch 1/5: Fix clang warning: ConstantUnion.h:56:17: warning: 7 enumeration values not handled in switch Upstream bug: <http://code.google.com/p/angleproject/issues/detail?id=124> 367473 11 85738 ddkilzer 2011-03-14 20:24:38 -0700 Comment on attachment 85738 Patch 2/5: Fix clang warning: ParseHelper.cpp:264:13: warning: 8 enumeration values not handled in switch Upstream bug: <http://code.google.com/p/angleproject/issues/detail?id=125> 367474 12 85739 ddkilzer 2011-03-14 20:24:53 -0700 Comment on attachment 85739 Patch 3/5: Fix clang warnings: Intermediate.cpp: warning: '&&' within '||' Upstream bug: <http://code.google.com/p/angleproject/issues/detail?id=126> 367475 13 85740 ddkilzer 2011-03-14 20:25:06 -0700 Comment on attachment 85740 Patch 4/5: Fix clang warnings in PoolAlloc.cpp Upstream bug: <http://code.google.com/p/angleproject/issues/detail?id=127> 367476 14 ddkilzer 2011-03-14 20:26:37 -0700 Patch 5/5 (Attachment 85736) is now blocked on the upstream patches landing, then ANGLE being updated. 367499 15 webkit.review.bot 2011-03-14 21:46:56 -0700 Attachment 85736 did not build on mac: Build output: http://queues.webkit.org/results/8175479 367561 16 85736 abarth 2011-03-15 02:00:24 -0700 Comment on attachment 85736 Patch 5/5: Enable -Werror on ANGLE I support this product and or service (assuming it builds). 367698 17 zmo 2011-03-15 09:18:59 -0700 (In reply to comment #8) > (In reply to comment #7) > > This should be fixed upstream ANGLE. If you commit it here, after a ANGLE roll in the future, your change will be lost. > > > > I see you already filed a bug to ANGLE. Could you upload your patch there? Once it's reviewed and landed upstream, we can do another ANGLE roll in webkit. > > So you don't merge changes from ANGLE into WebKit--you just land new code and delete whatever local changes were made? Yes. That's at least what we've done so far. 367837 18 ddkilzer 2011-03-15 11:59:18 -0700 (In reply to comment #14) > Patch 5/5 (Attachment 85736 [details]) is now blocked on the upstream patches landing, then ANGLE being updated. Filed Bug 56396 to update ANGLE to at least r575, which will pick up the necessary fixes to enable -Werror. 398089 19 ddkilzer 2011-05-04 11:13:45 -0700 Part 1 of 2: Committed r85761: <http://trac.webkit.org/changeset/85761> 398091 20 ddkilzer 2011-05-04 11:14:31 -0700 Part 2 of 2: Committed r85762: <http://trac.webkit.org/changeset/85762> 85736 2011-03-14 16:09:04 -0700 2011-03-15 02:00:24 -0700 Patch 5/5: Enable -Werror on ANGLE 0005-Part-5-of-5-http-webkit.org-b-56337-Enable-Werror-on.patch text/plain 1792 ddkilzer RnJvbSAwMDU3OTMzZDAxNWNmZjgyN2JlMzk2MDJlMThjMjk5Y2RhYzAxNjJiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEYXZpZCBLaWx6ZXIgPGRka2lsemVyQGFwcGxlLmNvbT4KRGF0 ZTogTW9uLCAxNCBNYXIgMjAxMSAxNDo0MDowOSAtMDcwMApTdWJqZWN0OiBbUEFUQ0ggNS81XSBQ YXJ0IDUgb2YgNTogPGh0dHA6Ly93ZWJraXQub3JnL2IvNTYzMzc+IEVuYWJsZSAtV2Vycm9yIG9u IEFOR0xFCgpSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCiogQ29uZmlndXJhdGlvbnMvQmFz ZS54Y2NvbmZpZzoKKEdDQ19UUkVBVF9XQVJOSU5HU19BU19FUlJPUlMpOiBTZXQgdG8gWUVTLgot LS0KIFNvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgIHwg ICAgOSArKysrKysrKysKIC4uLi9UaGlyZFBhcnR5L0FOR0xFL0NvbmZpZ3VyYXRpb25zL0Jhc2Uu eGNjb25maWcgIHwgICAgMiArLQogMiBmaWxlcyBjaGFuZ2VkLCAxMCBpbnNlcnRpb25zKCspLCAx IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5n ZUxvZyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxvZwppbmRleCA5NzkzYzI2Li41 YzJkZjQwIDEwMDY0NAotLS0gYS9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKKysr IGIvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTQgQEAKIDIw MTEtMDMtMTQgIERhdmlkIEtpbHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KIAorICAgICAgICBQ YXJ0IDUgb2YgNTogPGh0dHA6Ly93ZWJraXQub3JnL2IvNTYzMzc+IEVuYWJsZSAtV2Vycm9yIG9u IEFOR0xFCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBDb25maWd1cmF0aW9ucy9CYXNlLnhjY29uZmlnOgorICAgICAgICAoR0NDX1RSRUFUX1dBUk5J TkdTX0FTX0VSUk9SUyk6IFNldCB0byBZRVMuCisKKzIwMTEtMDMtMTQgIERhdmlkIEtpbHplciAg PGRka2lsemVyQGFwcGxlLmNvbT4KKwogICAgICAgICBGaXggY2xhbmcgd2FybmluZ3MgaW4gUG9v bEFsbG9jLmNwcAogCiAgICAgICAgIFBhcnQgNCBvZiA1OiA8aHR0cDovL3dlYmtpdC5vcmcvYi81 NjMzNz4gRW5hYmxlIC1XZXJyb3Igb24gQU5HTEUKZGlmZiAtLWdpdCBhL1NvdXJjZS9UaGlyZFBh cnR5L0FOR0xFL0NvbmZpZ3VyYXRpb25zL0Jhc2UueGNjb25maWcgYi9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9Db25maWd1cmF0aW9ucy9CYXNlLnhjY29uZmlnCmluZGV4IGMyNmJhYWQuLjE2YmI0 ZWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NvbmZpZ3VyYXRpb25zL0Jh c2UueGNjb25maWcKKysrIGIvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvQ29uZmlndXJhdGlvbnMv QmFzZS54Y2NvbmZpZwpAQCAtMTQsNyArMTQsNyBAQCBHQ0NfUFJFQ09NUElMRV9QUkVGSVhfSEVB REVSID0gTk87CiBHQ0NfSU5MSU5FU19BUkVfUFJJVkFURV9FWFRFUk4gPSBZRVM7CiBHQ0NfU1lN Qk9MU19QUklWQVRFX0VYVEVSTiA9IE5POwogR0NDX1RIUkVBRFNBRkVfU1RBVElDUyA9IE5POwot R0NDX1RSRUFUX1dBUk5JTkdTX0FTX0VSUk9SUyA9IE5POworR0NDX1RSRUFUX1dBUk5JTkdTX0FT X0VSUk9SUyA9IFlFUzsKIEdDQ19XQVJOX0FCT1VUX0RFUFJFQ0FURURfRlVOQ1RJT05TID0gTk87 CiBMSU5LRVJfRElTUExBWVNfTUFOR0xFRF9OQU1FUyA9IFlFUzsKIFBSRUJJTkRJTkcgPSBOTzsK LS0gCjEuNy4yLjEuMTU4LmdiZDNhOTcKCg== 85737 2011-03-14 16:09:44 -0700 2011-03-14 20:24:23 -0700 Patch 1/5: Fix clang warning: ConstantUnion.h:56:17: warning: 7 enumeration values not handled in switch 0001-Fix-clang-warning-ConstantUnion.h-56-17-warning-7-en.patch text/plain 3024 ddkilzer RnJvbSBkMDE3NjRkNTJiMWM0YzNmZDU5YTlkZDVhNTYxMmJiZDRjOGQ2Y2ZjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEYXZpZCBLaWx6ZXIgPGRka2lsemVyQGFwcGxlLmNvbT4KRGF0 ZTogTW9uLCAxNCBNYXIgMjAxMSAxMjo0NDoyMyAtMDcwMApTdWJqZWN0OiBbUEFUQ0ggMS81XSBG aXggY2xhbmcgd2FybmluZzogQ29uc3RhbnRVbmlvbi5oOjU2OjE3OiB3YXJuaW5nOiA3IGVudW1l cmF0aW9uIHZhbHVlcyBub3QgaGFuZGxlZCBpbiBzd2l0Y2gKClBhcnQgMSBvZiA1OiA8aHR0cDov L3dlYmtpdC5vcmcvYi81NjMzNz4gRW5hYmxlIC1XZXJyb3Igb24gQU5HTEUKClJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgoKVXBzdHJlYW0gYnVnOiA8aHR0cDovL2NvZGUuZ29vZ2xlLmNvbS9w L2FuZ2xlcHJvamVjdC9pc3N1ZXMvZGV0YWlsP2lkPTEyND4KCkZpeGVzIHRoZSBmb2xsb3dpbmcg c3RhdGljIGFuYWx5emVyIHdhcm5pbmc6CgogICAgSW4gZmlsZSBpbmNsdWRlZCBmcm9tIHNyYy9j b21waWxlci9kZWJ1Zy5jcHA6MTQ6CiAgICBJbiBmaWxlIGluY2x1ZGVkIGZyb20gc3JjL2NvbXBp bGVyL1BhcnNlSGVscGVyLmg6MTA6CiAgICBJbiBmaWxlIGluY2x1ZGVkIGZyb20gc3JjL2NvbXBp bGVyL2xvY2FsaW50ZXJtZWRpYXRlLmg6MTE6CiAgICBJbiBmaWxlIGluY2x1ZGVkIGZyb20gc3Jj L2NvbXBpbGVyL2ludGVybWVkaWF0ZS5oOjIxOgogICAgc3JjL2NvbXBpbGVyL0NvbnN0YW50VW5p b24uaDo1NjoxNzogd2FybmluZzogNyBlbnVtZXJhdGlvbiB2YWx1ZXMgbm90IGhhbmRsZWQgaW4g c3dpdGNoOiAnRWJ0Vm9pZCcsICdFYnRHdWFyZFNhbXBsZXJCZWdpbicsICdFYnRTYW1wbGVyMkQn Li4uIFstV3N3aXRjaC1lbnVtLDJdCiAgICAgICAgICAgICBzd2l0Y2ggKHR5cGUpIHsKICAgICAg ICAgICAgICAgICAgICAgXgoKKiBzcmMvY29tcGlsZXIvQ29uc3RhbnRVbmlvbi5oOgooQ29uc3Rh bnRVbmlvbjo6b3BlcmF0b3I9PSk6IEFkZGVkIGEgZGVmYXVsdCBjYXNlLgotLS0KIFNvdXJjZS9U aGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgIHwgICAyMyArKysrKysr KysrKysrKysrKysrKwogLi4uL1RoaXJkUGFydHkvQU5HTEUvc3JjL2NvbXBpbGVyL0NvbnN0YW50 VW5pb24uaCAgfCAgICAyICsKIDIgZmlsZXMgY2hhbmdlZCwgMjUgaW5zZXJ0aW9ucygrKSwgMCBk ZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VM b2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5kZXggNjA0ZGY1MS4uZTNk ZDAzZiAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDEx LTAzLTE0ICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAgICAgICAgRml4 IGNsYW5nIHdhcm5pbmc6IENvbnN0YW50VW5pb24uaDo1NjoxNzogd2FybmluZzogNyBlbnVtZXJh dGlvbiB2YWx1ZXMgbm90IGhhbmRsZWQgaW4gc3dpdGNoCisKKyAgICAgICAgUGFydCAxIG9mIDU6 IDxodHRwOi8vd2Via2l0Lm9yZy9iLzU2MzM3PiBFbmFibGUgLVdlcnJvciBvbiBBTkdMRQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVwc3RyZWFtIGJ1 ZzogPGh0dHA6Ly9jb2RlLmdvb2dsZS5jb20vcC9hbmdsZXByb2plY3QvaXNzdWVzL2RldGFpbD9p ZD0xMjQ+CisKKyAgICAgICAgRml4ZXMgdGhlIGZvbGxvd2luZyBzdGF0aWMgYW5hbHl6ZXIgd2Fy bmluZzoKKworICAgICAgICAgICAgSW4gZmlsZSBpbmNsdWRlZCBmcm9tIHNyYy9jb21waWxlci9k ZWJ1Zy5jcHA6MTQ6CisgICAgICAgICAgICBJbiBmaWxlIGluY2x1ZGVkIGZyb20gc3JjL2NvbXBp bGVyL1BhcnNlSGVscGVyLmg6MTA6CisgICAgICAgICAgICBJbiBmaWxlIGluY2x1ZGVkIGZyb20g c3JjL2NvbXBpbGVyL2xvY2FsaW50ZXJtZWRpYXRlLmg6MTE6CisgICAgICAgICAgICBJbiBmaWxl IGluY2x1ZGVkIGZyb20gc3JjL2NvbXBpbGVyL2ludGVybWVkaWF0ZS5oOjIxOgorICAgICAgICAg ICAgc3JjL2NvbXBpbGVyL0NvbnN0YW50VW5pb24uaDo1NjoxNzogd2FybmluZzogNyBlbnVtZXJh dGlvbiB2YWx1ZXMgbm90IGhhbmRsZWQgaW4gc3dpdGNoOiAnRWJ0Vm9pZCcsICdFYnRHdWFyZFNh bXBsZXJCZWdpbicsICdFYnRTYW1wbGVyMkQnLi4uIFstV3N3aXRjaC1lbnVtLDJdCisgICAgICAg ICAgICAgICAgICAgICBzd2l0Y2ggKHR5cGUpIHsKKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgXgorCisgICAgICAgICogc3JjL2NvbXBpbGVyL0NvbnN0YW50VW5pb24uaDoKKyAgICAgICAg KENvbnN0YW50VW5pb246Om9wZXJhdG9yPT0pOiBBZGRlZCBhIGRlZmF1bHQgY2FzZS4KKwogMjAx MS0wMS0xOCAgS2VubmV0aCBSdXNzZWxsICA8a2JyQGdvb2dsZS5jb20+CiAKICAgICAgICAgVW5y ZXZpZXdlZCwgTGVvcGFyZCBidWlsZCBmaXguIFJlbW92ZSBmbGV4L2Jpc29uIHRhcmdldHMgZm9y IEdMU0wKZGlmZiAtLWdpdCBhL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9jb21waWxlci9D b25zdGFudFVuaW9uLmggYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMvY29tcGlsZXIvQ29u c3RhbnRVbmlvbi5oCmluZGV4IGNmNTMxZWEuLmFhMWI4NzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9U aGlyZFBhcnR5L0FOR0xFL3NyYy9jb21waWxlci9Db25zdGFudFVuaW9uLmgKKysrIGIvU291cmNl L1RoaXJkUGFydHkvQU5HTEUvc3JjL2NvbXBpbGVyL0NvbnN0YW50VW5pb24uaApAQCAtNjksNiAr NjksOCBAQCBwdWJsaWM6CiAgICAgICAgICAgICAgICAgcmV0dXJuIHRydWU7CiAKICAgICAgICAg ICAgIGJyZWFrOworICAgICAgICBkZWZhdWx0OgorICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwog ICAgICAgICB9CiAKICAgICAgICAgcmV0dXJuIGZhbHNlOwotLSAKMS43LjIuMS4xNTguZ2JkM2E5 NwoK 85738 2011-03-14 16:10:15 -0700 2011-03-14 20:24:38 -0700 Patch 2/5: Fix clang warning: ParseHelper.cpp:264:13: warning: 8 enumeration values not handled in switch 0002-Fix-clang-warning-ParseHelper.cpp-264-13-warning-8-e.patch text/plain 2688 ddkilzer RnJvbSBkYmIxNmEzZTUyZDJlYmFiMTNlMWYwZjIxNTMxMjllN2E0NTc1ZmI2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEYXZpZCBLaWx6ZXIgPGRka2lsemVyQGFwcGxlLmNvbT4KRGF0 ZTogTW9uLCAxNCBNYXIgMjAxMSAxMzoyNDozOCAtMDcwMApTdWJqZWN0OiBbUEFUQ0ggMi81XSBG aXggY2xhbmcgd2FybmluZzogUGFyc2VIZWxwZXIuY3BwOjI2NDoxMzogd2FybmluZzogOCBlbnVt ZXJhdGlvbiB2YWx1ZXMgbm90IGhhbmRsZWQgaW4gc3dpdGNoCgpQYXJ0IDIgb2YgNTogPGh0dHA6 Ly93ZWJraXQub3JnL2IvNTYzMzc+IEVuYWJsZSAtV2Vycm9yIG9uIEFOR0xFCgpSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KClVwc3RyZWFtIGJ1ZzogPGh0dHA6Ly9jb2RlLmdvb2dsZS5jb20v cC9hbmdsZXByb2plY3QvaXNzdWVzL2RldGFpbD9pZD0xMjU+CgpGaXhlcyB0aGUgZm9sbG93aW5n IHN0YXRpYyBhbmFseXplciB3YXJuaW5nOgoKICAgIHNyYy9jb21waWxlci9QYXJzZUhlbHBlci5j cHA6MjY0OjEzOiB3YXJuaW5nOiA4IGVudW1lcmF0aW9uIHZhbHVlcyBub3QgaGFuZGxlZCBpbiBz d2l0Y2g6ICdFYnRWb2lkJywgJ0VidEJvb2wnLCAnRWJ0R3VhcmRTYW1wbGVyQmVnaW4nLi4uIFst V3N3aXRjaC1lbnVtLDJdCiAgICAgICAgIHN3aXRjaCggdHlwZSApewogICAgICAgICAgICAgICAg IF4KCiogc3JjL2NvbXBpbGVyL1BhcnNlSGVscGVyLmNwcDoKKFRQYXJzZUNvbnRleHQ6OnByZWNp c2lvbkVycm9yQ2hlY2spOiBBZGRlZCBhIGRlZmF1bHQgY2FzZS4KLS0tCiBTb3VyY2UvVGhpcmRQ YXJ0eS9BTkdMRS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICB8ICAgMTkgKysrKysrKysrKysr KysrKysrKwogLi4uL1RoaXJkUGFydHkvQU5HTEUvc3JjL2NvbXBpbGVyL1BhcnNlSGVscGVyLmNw cCAgfCAgICAyICsrCiAyIGZpbGVzIGNoYW5nZWQsIDIxIGluc2VydGlvbnMoKyksIDAgZGVsZXRp b25zKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvQ2hhbmdlTG9nIGIv U291cmNlL1RoaXJkUGFydHkvQU5HTEUvQ2hhbmdlTG9nCmluZGV4IGUzZGQwM2YuLjQyNDM5OGUg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxvZworKysgYi9Tb3Vy Y2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwyNCBAQAogMjAxMS0wMy0x NCAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBwbGUuY29tPgogCisgICAgICAgIEZpeCBjbGFu ZyB3YXJuaW5nOiBQYXJzZUhlbHBlci5jcHA6MjY0OjEzOiB3YXJuaW5nOiA4IGVudW1lcmF0aW9u IHZhbHVlcyBub3QgaGFuZGxlZCBpbiBzd2l0Y2gKKworICAgICAgICBQYXJ0IDIgb2YgNTogPGh0 dHA6Ly93ZWJraXQub3JnL2IvNTYzMzc+IEVuYWJsZSAtV2Vycm9yIG9uIEFOR0xFCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXBzdHJlYW0gYnVnOiA8 aHR0cDovL2NvZGUuZ29vZ2xlLmNvbS9wL2FuZ2xlcHJvamVjdC9pc3N1ZXMvZGV0YWlsP2lkPTEy NT4KKworICAgICAgICBGaXhlcyB0aGUgZm9sbG93aW5nIHN0YXRpYyBhbmFseXplciB3YXJuaW5n OgorCisgICAgICAgICAgICBzcmMvY29tcGlsZXIvUGFyc2VIZWxwZXIuY3BwOjI2NDoxMzogd2Fy bmluZzogOCBlbnVtZXJhdGlvbiB2YWx1ZXMgbm90IGhhbmRsZWQgaW4gc3dpdGNoOiAnRWJ0Vm9p ZCcsICdFYnRCb29sJywgJ0VidEd1YXJkU2FtcGxlckJlZ2luJy4uLiBbLVdzd2l0Y2gtZW51bSwy XQorICAgICAgICAgICAgICAgICBzd2l0Y2goIHR5cGUgKXsKKyAgICAgICAgICAgICAgICAgICAg ICAgICBeCisKKyAgICAgICAgKiBzcmMvY29tcGlsZXIvUGFyc2VIZWxwZXIuY3BwOgorICAgICAg ICAoVFBhcnNlQ29udGV4dDo6cHJlY2lzaW9uRXJyb3JDaGVjayk6IEFkZGVkIGEgZGVmYXVsdCBj YXNlLgorCisyMDExLTAzLTE0ICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisK ICAgICAgICAgRml4IGNsYW5nIHdhcm5pbmc6IENvbnN0YW50VW5pb24uaDo1NjoxNzogd2Fybmlu ZzogNyBlbnVtZXJhdGlvbiB2YWx1ZXMgbm90IGhhbmRsZWQgaW4gc3dpdGNoCiAKICAgICAgICAg UGFydCAxIG9mIDU6IDxodHRwOi8vd2Via2l0Lm9yZy9iLzU2MzM3PiBFbmFibGUgLVdlcnJvciBv biBBTkdMRQpkaWZmIC0tZ2l0IGEvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvc3JjL2NvbXBpbGVy L1BhcnNlSGVscGVyLmNwcCBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9jb21waWxlci9Q YXJzZUhlbHBlci5jcHAKaW5kZXggNTNmM2ZhOC4uZTE0OTQzMCAxMDA2NDQKLS0tIGEvU291cmNl L1RoaXJkUGFydHkvQU5HTEUvc3JjL2NvbXBpbGVyL1BhcnNlSGVscGVyLmNwcAorKysgYi9Tb3Vy Y2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMvY29tcGlsZXIvUGFyc2VIZWxwZXIuY3BwCkBAIC0yNzQs NiArMjc0LDggQEAgYm9vbCBUUGFyc2VDb250ZXh0OjpwcmVjaXNpb25FcnJvckNoZWNrKGludCBs aW5lLCBUUHJlY2lzaW9uIHByZWNpc2lvbiwgVEJhc2ljVHkKICAgICAgICAgICAgIHJldHVybiB0 cnVlOwogICAgICAgICB9CiAgICAgICAgIGJyZWFrOworICAgIGRlZmF1bHQ6CisgICAgICAgIHJl dHVybiBmYWxzZTsKICAgICB9CiAgICAgcmV0dXJuIGZhbHNlOwogfQotLSAKMS43LjIuMS4xNTgu Z2JkM2E5NwoK 85739 2011-03-14 16:10:44 -0700 2011-03-14 20:24:53 -0700 Patch 3/5: Fix clang warnings: Intermediate.cpp: warning: '&&' within '||' 0003-Fix-clang-warnings-Intermediate.cpp-warning-within.patch text/plain 8468 ddkilzer RnJvbSBlZjczYmVlYzRjMTQ4ODU1YzQ1OTE5NzE1ZGExYzE2YjE3ZDJlMjdmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEYXZpZCBLaWx6ZXIgPGRka2lsemVyQGFwcGxlLmNvbT4KRGF0 ZTogTW9uLCAxNCBNYXIgMjAxMSAxMzo1MDoxNCAtMDcwMApTdWJqZWN0OiBbUEFUQ0ggMy81XSBG aXggY2xhbmcgd2FybmluZ3M6IEludGVybWVkaWF0ZS5jcHA6IHdhcm5pbmc6ICcmJicgd2l0aGlu ICd8fCcKClBhcnQgMyBvZiA1OiA8aHR0cDovL3dlYmtpdC5vcmcvYi81NjMzNz4gRW5hYmxlIC1X ZXJyb3Igb24gQU5HTEUKClJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKVXBzdHJlYW0gYnVn OiA8aHR0cDovL2NvZGUuZ29vZ2xlLmNvbS9wL2FuZ2xlcHJvamVjdC9pc3N1ZXMvZGV0YWlsP2lk PTEyNj4KCkZpeGVzIHRoZSBmb2xsb3dpbmcgc3RhdGljIGFuYWx5emVyIHdhcm5pbmdzOgoKICAg IHNyYy9jb21waWxlci9JbnRlcm1lZGlhdGUuY3BwOjEwMDg6NTU6ezEwMDg6MTctMTAwODo1NH06 IHdhcm5pbmc6ICcmJicgd2l0aGluICd8fCcgWy1XbG9naWNhbC1vcC1wYXJlbnRoZXNlcywyXQog ICAgICAgICAgICAgICAgIGlmIChsZWZ0LT5pc01hdHJpeCgpICYmIHJpZ2h0LT5pc1ZlY3Rvcigp IHx8CiAgICAgICAgICAgICAgICAgICAgIH5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+ fn5+fn4gXgogICAgc3JjL2NvbXBpbGVyL0ludGVybWVkaWF0ZS5jcHA6MTAwODo1NTogbm90ZTog cGxhY2UgcGFyZW50aGVzZXMgYXJvdW5kIHRoZSAnJiYnIGV4cHJlc3Npb24gdG8gc2lsZW5jZSB0 aGlzIHdhcm5pbmcgWzJdCiAgICAgICAgICAgICAgICAgaWYgKGxlZnQtPmlzTWF0cml4KCkgJiYg cmlnaHQtPmlzVmVjdG9yKCkgfHwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBeCiAgICAgICAgICAgICAgICAgICAgICggICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICApCiAgICBmaXgtaXQ6InNyYy9jb21waWxlci9JbnRl cm1lZGlhdGUuY3BwIjp7MTAwODoxNy0xMDA4OjE3fToiKCIKICAgIGZpeC1pdDoic3JjL2NvbXBp bGVyL0ludGVybWVkaWF0ZS5jcHAiOnsxMDA4OjU0LTEwMDg6NTR9OiIpIgogICAgc3JjL2NvbXBp bGVyL0ludGVybWVkaWF0ZS5jcHA6MTAwODo1NTp7MTAwOToxNy0xMDA5OjU0fTogd2FybmluZzog JyYmJyB3aXRoaW4gJ3x8JyBbLVdsb2dpY2FsLW9wLXBhcmVudGhlc2VzLDJdCiAgICAgICAgICAg ICAgICAgaWYgKGxlZnQtPmlzTWF0cml4KCkgJiYgcmlnaHQtPmlzVmVjdG9yKCkgfHwKICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBeCiAg ICBzcmMvY29tcGlsZXIvSW50ZXJtZWRpYXRlLmNwcDoxMDA4OjU1OiBub3RlOiBwbGFjZSBwYXJl bnRoZXNlcyBhcm91bmQgdGhlICcmJicgZXhwcmVzc2lvbiB0byBzaWxlbmNlIHRoaXMgd2Fybmlu ZyBbMl0KICAgICAgICAgICAgICAgICBpZiAobGVmdC0+aXNNYXRyaXgoKSAmJiByaWdodC0+aXNW ZWN0b3IoKSB8fAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIF4KICAgIGZpeC1pdDoic3JjL2NvbXBpbGVyL0ludGVybWVkaWF0ZS5jcHAi OnsxMDA5OjE3LTEwMDk6MTd9OiIoIgogICAgZml4LWl0OiJzcmMvY29tcGlsZXIvSW50ZXJtZWRp YXRlLmNwcCI6ezEwMDk6NTQtMTAwOTo1NH06IikiCiAgICBzcmMvY29tcGlsZXIvSW50ZXJtZWRp YXRlLmNwcDoxMDIwOjU1OnsxMDIwOjE3LTEwMjA6NTR9OiB3YXJuaW5nOiAnJiYnIHdpdGhpbiAn fHwnIFstV2xvZ2ljYWwtb3AtcGFyZW50aGVzZXMsMl0KICAgICAgICAgICAgICAgICBpZiAobGVm dC0+aXNNYXRyaXgoKSAmJiByaWdodC0+aXNWZWN0b3IoKSB8fAogICAgICAgICAgICAgICAgICAg ICB+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+IF4KICAgIHNyYy9jb21waWxl ci9JbnRlcm1lZGlhdGUuY3BwOjEwMjA6NTU6IG5vdGU6IHBsYWNlIHBhcmVudGhlc2VzIGFyb3Vu ZCB0aGUgJyYmJyBleHByZXNzaW9uIHRvIHNpbGVuY2UgdGhpcyB3YXJuaW5nIFsyXQogICAgICAg ICAgICAgICAgIGlmIChsZWZ0LT5pc01hdHJpeCgpICYmIHJpZ2h0LT5pc1ZlY3RvcigpIHx8CiAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg XgogICAgICAgICAgICAgICAgICAgICAoICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgKQogICAgZml4LWl0OiJzcmMvY29tcGlsZXIvSW50ZXJtZWRpYXRlLmNwcCI6ezEwMjA6MTct MTAyMDoxN306IigiCiAgICBmaXgtaXQ6InNyYy9jb21waWxlci9JbnRlcm1lZGlhdGUuY3BwIjp7 MTAyMDo1NC0xMDIwOjU0fToiKSIKICAgIHNyYy9jb21waWxlci9JbnRlcm1lZGlhdGUuY3BwOjEw MjA6NTU6ezEwMjE6MTctMTAyMTo1NH06IHdhcm5pbmc6ICcmJicgd2l0aGluICd8fCcgWy1XbG9n aWNhbC1vcC1wYXJlbnRoZXNlcywyXQogICAgICAgICAgICAgICAgIGlmIChsZWZ0LT5pc01hdHJp eCgpICYmIHJpZ2h0LT5pc1ZlY3RvcigpIHx8CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXgogICAgc3JjL2NvbXBpbGVyL0ludGVybWVk aWF0ZS5jcHA6MTAyMDo1NTogbm90ZTogcGxhY2UgcGFyZW50aGVzZXMgYXJvdW5kIHRoZSAnJiYn IGV4cHJlc3Npb24gdG8gc2lsZW5jZSB0aGlzIHdhcm5pbmcgWzJdCiAgICAgICAgICAgICAgICAg aWYgKGxlZnQtPmlzTWF0cml4KCkgJiYgcmlnaHQtPmlzVmVjdG9yKCkgfHwKICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBeCiAgICBmaXgt aXQ6InNyYy9jb21waWxlci9JbnRlcm1lZGlhdGUuY3BwIjp7MTAyMToxNy0xMDIxOjE3fToiKCIK ICAgIGZpeC1pdDoic3JjL2NvbXBpbGVyL0ludGVybWVkaWF0ZS5jcHAiOnsxMDIxOjU0LTEwMjE6 NTR9OiIpIgoKKiBzcmMvY29tcGlsZXIvSW50ZXJtZWRpYXRlLmNwcDoKKFRJbnRlcm1CaW5hcnk6 OnByb21vdGUpOiBBZGRlZCBwYXJuZXRoZXNlcy4KLS0tCiBTb3VyY2UvVGhpcmRQYXJ0eS9BTkdM RS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICB8ICAgNTAgKysrKysrKysrKysrKysrKysrKysK IC4uLi9UaGlyZFBhcnR5L0FOR0xFL3NyYy9jb21waWxlci9JbnRlcm1lZGlhdGUuY3BwIHwgICAg OCArKy0tCiAyIGZpbGVzIGNoYW5nZWQsIDU0IGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0p CgpkaWZmIC0tZ2l0IGEvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvQ2hhbmdlTG9nIGIvU291cmNl L1RoaXJkUGFydHkvQU5HTEUvQ2hhbmdlTG9nCmluZGV4IDQyNDM5OGUuLjg5N2QzMDEgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvVGhp cmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKQEAgLTEsNSArMSw1NSBAQAogMjAxMS0wMy0xNCAgRGF2 aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBwbGUuY29tPgogCisgICAgICAgIEZpeCBjbGFuZyB3YXJu aW5nczogSW50ZXJtZWRpYXRlLmNwcDogd2FybmluZzogJyYmJyB3aXRoaW4gJ3x8JworCisgICAg ICAgIFBhcnQgMyBvZiA1OiA8aHR0cDovL3dlYmtpdC5vcmcvYi81NjMzNz4gRW5hYmxlIC1XZXJy b3Igb24gQU5HTEUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBVcHN0cmVhbSBidWc6IDxodHRwOi8vY29kZS5nb29nbGUuY29tL3AvYW5nbGVwcm9qZWN0 L2lzc3Vlcy9kZXRhaWw/aWQ9MTI2PgorCisgICAgICAgIEZpeGVzIHRoZSBmb2xsb3dpbmcgc3Rh dGljIGFuYWx5emVyIHdhcm5pbmdzOgorCisgICAgICAgICAgICBzcmMvY29tcGlsZXIvSW50ZXJt ZWRpYXRlLmNwcDoxMDA4OjU1OnsxMDA4OjE3LTEwMDg6NTR9OiB3YXJuaW5nOiAnJiYnIHdpdGhp biAnfHwnIFstV2xvZ2ljYWwtb3AtcGFyZW50aGVzZXMsMl0KKyAgICAgICAgICAgICAgICAgICAg ICAgICBpZiAobGVmdC0+aXNNYXRyaXgoKSAmJiByaWdodC0+aXNWZWN0b3IoKSB8fAorICAgICAg ICAgICAgICAgICAgICAgICAgICAgICB+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+ fn5+IF4KKyAgICAgICAgICAgIHNyYy9jb21waWxlci9JbnRlcm1lZGlhdGUuY3BwOjEwMDg6NTU6 IG5vdGU6IHBsYWNlIHBhcmVudGhlc2VzIGFyb3VuZCB0aGUgJyYmJyBleHByZXNzaW9uIHRvIHNp bGVuY2UgdGhpcyB3YXJuaW5nIFsyXQorICAgICAgICAgICAgICAgICAgICAgICAgIGlmIChsZWZ0 LT5pc01hdHJpeCgpICYmIHJpZ2h0LT5pc1ZlY3RvcigpIHx8CisgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXgorICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAoICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgKQorICAgICAgICAgICAgZml4LWl0OiJzcmMvY29tcGlsZXIvSW50ZXJtZWRpYXRlLmNwcCI6 ezEwMDg6MTctMTAwODoxN306IigiCisgICAgICAgICAgICBmaXgtaXQ6InNyYy9jb21waWxlci9J bnRlcm1lZGlhdGUuY3BwIjp7MTAwODo1NC0xMDA4OjU0fToiKSIKKyAgICAgICAgICAgIHNyYy9j b21waWxlci9JbnRlcm1lZGlhdGUuY3BwOjEwMDg6NTU6ezEwMDk6MTctMTAwOTo1NH06IHdhcm5p bmc6ICcmJicgd2l0aGluICd8fCcgWy1XbG9naWNhbC1vcC1wYXJlbnRoZXNlcywyXQorICAgICAg ICAgICAgICAgICAgICAgICAgIGlmIChsZWZ0LT5pc01hdHJpeCgpICYmIHJpZ2h0LT5pc1ZlY3Rv cigpIHx8CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgXgorICAgICAgICAgICAgc3JjL2NvbXBpbGVyL0ludGVybWVkaWF0 ZS5jcHA6MTAwODo1NTogbm90ZTogcGxhY2UgcGFyZW50aGVzZXMgYXJvdW5kIHRoZSAnJiYnIGV4 cHJlc3Npb24gdG8gc2lsZW5jZSB0aGlzIHdhcm5pbmcgWzJdCisgICAgICAgICAgICAgICAgICAg ICAgICAgaWYgKGxlZnQtPmlzTWF0cml4KCkgJiYgcmlnaHQtPmlzVmVjdG9yKCkgfHwKKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBeCisgICAgICAgICAgICBmaXgtaXQ6InNyYy9jb21waWxlci9JbnRlcm1lZGlhdGUuY3Bw Ijp7MTAwOToxNy0xMDA5OjE3fToiKCIKKyAgICAgICAgICAgIGZpeC1pdDoic3JjL2NvbXBpbGVy L0ludGVybWVkaWF0ZS5jcHAiOnsxMDA5OjU0LTEwMDk6NTR9OiIpIgorICAgICAgICAgICAgc3Jj L2NvbXBpbGVyL0ludGVybWVkaWF0ZS5jcHA6MTAyMDo1NTp7MTAyMDoxNy0xMDIwOjU0fTogd2Fy bmluZzogJyYmJyB3aXRoaW4gJ3x8JyBbLVdsb2dpY2FsLW9wLXBhcmVudGhlc2VzLDJdCisgICAg ICAgICAgICAgICAgICAgICAgICAgaWYgKGxlZnQtPmlzTWF0cml4KCkgJiYgcmlnaHQtPmlzVmVj dG9yKCkgfHwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfn5+fn5+fn5+fn5+fn5+fn5+ fn5+fn5+fn5+fn5+fn5+fn5+fiBeCisgICAgICAgICAgICBzcmMvY29tcGlsZXIvSW50ZXJtZWRp YXRlLmNwcDoxMDIwOjU1OiBub3RlOiBwbGFjZSBwYXJlbnRoZXNlcyBhcm91bmQgdGhlICcmJicg ZXhwcmVzc2lvbiB0byBzaWxlbmNlIHRoaXMgd2FybmluZyBbMl0KKyAgICAgICAgICAgICAgICAg ICAgICAgICBpZiAobGVmdC0+aXNNYXRyaXgoKSAmJiByaWdodC0+aXNWZWN0b3IoKSB8fAorICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIF4KKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKCAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICkKKyAgICAgICAgICAgIGZpeC1pdDoic3JjL2NvbXBpbGVyL0lu dGVybWVkaWF0ZS5jcHAiOnsxMDIwOjE3LTEwMjA6MTd9OiIoIgorICAgICAgICAgICAgZml4LWl0 OiJzcmMvY29tcGlsZXIvSW50ZXJtZWRpYXRlLmNwcCI6ezEwMjA6NTQtMTAyMDo1NH06IikiCisg ICAgICAgICAgICBzcmMvY29tcGlsZXIvSW50ZXJtZWRpYXRlLmNwcDoxMDIwOjU1OnsxMDIxOjE3 LTEwMjE6NTR9OiB3YXJuaW5nOiAnJiYnIHdpdGhpbiAnfHwnIFstV2xvZ2ljYWwtb3AtcGFyZW50 aGVzZXMsMl0KKyAgICAgICAgICAgICAgICAgICAgICAgICBpZiAobGVmdC0+aXNNYXRyaXgoKSAm JiByaWdodC0+aXNWZWN0b3IoKSB8fAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIF4KKyAgICAgICAgICAgIHNyYy9jb21w aWxlci9JbnRlcm1lZGlhdGUuY3BwOjEwMjA6NTU6IG5vdGU6IHBsYWNlIHBhcmVudGhlc2VzIGFy b3VuZCB0aGUgJyYmJyBleHByZXNzaW9uIHRvIHNpbGVuY2UgdGhpcyB3YXJuaW5nIFsyXQorICAg ICAgICAgICAgICAgICAgICAgICAgIGlmIChsZWZ0LT5pc01hdHJpeCgpICYmIHJpZ2h0LT5pc1Zl Y3RvcigpIHx8CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgXgorICAgICAgICAgICAgZml4LWl0OiJzcmMvY29tcGlsZXIv SW50ZXJtZWRpYXRlLmNwcCI6ezEwMjE6MTctMTAyMToxN306IigiCisgICAgICAgICAgICBmaXgt aXQ6InNyYy9jb21waWxlci9JbnRlcm1lZGlhdGUuY3BwIjp7MTAyMTo1NC0xMDIxOjU0fToiKSIK KworICAgICAgICAqIHNyYy9jb21waWxlci9JbnRlcm1lZGlhdGUuY3BwOgorICAgICAgICAoVElu dGVybUJpbmFyeTo6cHJvbW90ZSk6IEFkZGVkIHBhcm5ldGhlc2VzLgorCisyMDExLTAzLTE0ICBE YXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKICAgICAgICAgRml4IGNsYW5nIHdh cm5pbmc6IFBhcnNlSGVscGVyLmNwcDoyNjQ6MTM6IHdhcm5pbmc6IDggZW51bWVyYXRpb24gdmFs dWVzIG5vdCBoYW5kbGVkIGluIHN3aXRjaAogCiAgICAgICAgIFBhcnQgMiBvZiA1OiA8aHR0cDov L3dlYmtpdC5vcmcvYi81NjMzNz4gRW5hYmxlIC1XZXJyb3Igb24gQU5HTEUKZGlmZiAtLWdpdCBh L1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9jb21waWxlci9JbnRlcm1lZGlhdGUuY3BwIGIv U291cmNlL1RoaXJkUGFydHkvQU5HTEUvc3JjL2NvbXBpbGVyL0ludGVybWVkaWF0ZS5jcHAKaW5k ZXggZWE3MTIzNC4uZTFlOGRhMiAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFydHkvQU5HTEUv c3JjL2NvbXBpbGVyL0ludGVybWVkaWF0ZS5jcHAKKysrIGIvU291cmNlL1RoaXJkUGFydHkvQU5H TEUvc3JjL2NvbXBpbGVyL0ludGVybWVkaWF0ZS5jcHAKQEAgLTEwMDUsOCArMTAwNSw4IEBAIGJv b2wgVEludGVybUJpbmFyeTo6cHJvbW90ZShUSW5mb1NpbmsmIGluZm9TaW5rKQogICAgICAgICBj YXNlIEVPcEFkZEFzc2lnbjoKICAgICAgICAgY2FzZSBFT3BTdWJBc3NpZ246CiAgICAgICAgIGNh c2UgRU9wRGl2QXNzaWduOgotICAgICAgICAgICAgaWYgKGxlZnQtPmlzTWF0cml4KCkgJiYgcmln aHQtPmlzVmVjdG9yKCkgfHwKLSAgICAgICAgICAgICAgICBsZWZ0LT5pc1ZlY3RvcigpICYmIHJp Z2h0LT5pc01hdHJpeCgpKQorICAgICAgICAgICAgaWYgKChsZWZ0LT5pc01hdHJpeCgpICYmIHJp Z2h0LT5pc1ZlY3RvcigpKSB8fAorICAgICAgICAgICAgICAgIChsZWZ0LT5pc1ZlY3RvcigpICYm IHJpZ2h0LT5pc01hdHJpeCgpKSkKICAgICAgICAgICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAg ICAgICAgICBzZXRUeXBlKFRUeXBlKGJhc2ljVHlwZSwgaGlnaGVyUHJlY2lzaW9uLCBFdnFUZW1w b3JhcnksIHNpemUsIGxlZnQtPmlzTWF0cml4KCkgfHwgcmlnaHQtPmlzTWF0cml4KCkpKTsKICAg ICAgICAgICAgIGJyZWFrOwpAQCAtMTAxNyw4ICsxMDE3LDggQEAgYm9vbCBUSW50ZXJtQmluYXJ5 Ojpwcm9tb3RlKFRJbmZvU2luayYgaW5mb1NpbmspCiAgICAgICAgIGNhc2UgRU9wR3JlYXRlclRo YW46CiAgICAgICAgIGNhc2UgRU9wTGVzc1RoYW5FcXVhbDoKICAgICAgICAgY2FzZSBFT3BHcmVh dGVyVGhhbkVxdWFsOgotICAgICAgICAgICAgaWYgKGxlZnQtPmlzTWF0cml4KCkgJiYgcmlnaHQt PmlzVmVjdG9yKCkgfHwKLSAgICAgICAgICAgICAgICBsZWZ0LT5pc1ZlY3RvcigpICYmIHJpZ2h0 LT5pc01hdHJpeCgpKQorICAgICAgICAgICAgaWYgKChsZWZ0LT5pc01hdHJpeCgpICYmIHJpZ2h0 LT5pc1ZlY3RvcigpKSB8fAorICAgICAgICAgICAgICAgIChsZWZ0LT5pc1ZlY3RvcigpICYmIHJp Z2h0LT5pc01hdHJpeCgpKSkKICAgICAgICAgICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgICAg ICAgICBzZXRUeXBlKFRUeXBlKEVidEJvb2wsIEVicFVuZGVmaW5lZCkpOwogICAgICAgICAgICAg YnJlYWs7Ci0tIAoxLjcuMi4xLjE1OC5nYmQzYTk3Cgo= 85740 2011-03-14 16:11:14 -0700 2011-03-14 20:25:05 -0700 Patch 4/5: Fix clang warnings in PoolAlloc.cpp 0004-Fix-clang-warnings-in-PoolAlloc.cpp.patch text/plain 4761 ddkilzer RnJvbSAwNjZkZjhjYzQyYTI0MTAwYjgxYWEwYTc0YTAzNTE0NzI4NmI1ZGI0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEYXZpZCBLaWx6ZXIgPGRka2lsemVyQGFwcGxlLmNvbT4KRGF0 ZTogTW9uLCAxNCBNYXIgMjAxMSAxNDoyMDoyNiAtMDcwMApTdWJqZWN0OiBbUEFUQ0ggNC81XSBG aXggY2xhbmcgd2FybmluZ3MgaW4gUG9vbEFsbG9jLmNwcAoKUGFydCA0IG9mIDU6IDxodHRwOi8v d2Via2l0Lm9yZy9iLzU2MzM3PiBFbmFibGUgLVdlcnJvciBvbiBBTkdMRQoKUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCgpVcHN0cmVhbSBidWc6IDxodHRwOi8vY29kZS5nb29nbGUuY29tL3Av YW5nbGVwcm9qZWN0L2lzc3Vlcy9kZXRhaWw/aWQ9MTI3PgoKRml4ZXMgdGhlIGZvbGxvd2luZyBz dGF0aWMgYW5hbHl6ZXIgd2FybmluZ3M6CgogICAgc3JjL2NvbXBpbGVyL1Bvb2xBbGxvYy5jcHA6 MTU0OjI2OnsxNTQ6MjQtMTU0OjI1fXsxNTQ6MjgtMTU0OjQyfTogd2FybmluZzogY29tcGFyaXNv biBvZiB1bnNpZ25lZCBleHByZXNzaW9uIDwgMCBpcyBhbHdheXMgZmFsc2UgWy1XdGF1dG9sb2dp Y2FsLWNvbXBhcmUsMl0KICAgICAgICAgZm9yIChzaXplX3QgeCA9IDA7IHggPCBndWFyZEJsb2Nr U2l6ZTsgeCsrKSB7CiAgICAgICAgICAgICAgICAgICAgICAgICAgICB+IF4gfn5+fn5+fn5+fn5+ fn4KICAgIHNyYy9jb21waWxlci9Qb29sQWxsb2MuY3BwOjE1OTo1NTp7MTU5OjU0LTE1OTo1Nn17 MTYwOjMwLTE2MDozNH06IHdhcm5pbmc6IGNvbnZlcnNpb24gc3BlY2lmaWVzIHR5cGUgJ3Vuc2ln bmVkIGludCcgYnV0IHRoZSBhcmd1bWVudCBoYXMgdHlwZSAnc2l6ZV90JyAoYWthICd1bnNpZ25l ZCBsb25nJykgWy1XZm9ybWF0LDddCiAgICAgICAgICAgICAgICAgc3ByaW50Zihhc3NlcnRNc2cs ICJQb29sQWxsb2M6IERhbWFnZSAlcyAldSBieXRlIGFsbG9jYXRpb24gYXQgMHglcFxuIiwKICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIH5e CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAlbHUKICAgIGZpeC1pdDoic3JjL2NvbXBpbGVyL1Bvb2xBbGxvYy5jcHAiOnsxNTk6NTQtMTU5 OjU2fToiJWx1IgoKKiBzcmMvY29tcGlsZXIvUG9vbEFsbG9jLmNwcDoKKFRBbGxvY2F0aW9uOjpj aGVja0d1YXJkQmxvY2spOiBDaGFuZ2VkICcldScgdG8gJyVsdScgZm9yIHNpemVfdAp2YXJpYWJs ZS4gIFB1dCBmb3IgbG9vcCBpbnNpZGUgI2lmZGVmIEdVQVJEX0JMT0NLUy8jZW5kaWYgbWFjcm9z CnRvIGZpeCB0YXV0b2xvZ2ljYWwtY29tcGFyZSB3YXJuaW5nLgooVEFsbG9jYXRpb246OmNoZWNr QWxsb2NMaXN0KTogQWRkZWQgbmV3bGluZSB0byBlbmQgb2YgZmlsZS4KLS0tCiBTb3VyY2UvVGhp cmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICB8ICAgMjkgKysrKysrKysr KysrKysrKysrKysKIFNvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9jb21waWxlci9Qb29sQWxs b2MuY3BwIHwgICAgNiArKystCiAyIGZpbGVzIGNoYW5nZWQsIDMzIGluc2VydGlvbnMoKyksIDIg ZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvQ2hhbmdl TG9nIGIvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvQ2hhbmdlTG9nCmluZGV4IDg5N2QzMDEuLjk3 OTNjMjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxvZworKysg Yi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwzNCBAQAogMjAx MS0wMy0xNCAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBwbGUuY29tPgogCisgICAgICAgIEZp eCBjbGFuZyB3YXJuaW5ncyBpbiBQb29sQWxsb2MuY3BwCisKKyAgICAgICAgUGFydCA0IG9mIDU6 IDxodHRwOi8vd2Via2l0Lm9yZy9iLzU2MzM3PiBFbmFibGUgLVdlcnJvciBvbiBBTkdMRQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVwc3RyZWFtIGJ1 ZzogPGh0dHA6Ly9jb2RlLmdvb2dsZS5jb20vcC9hbmdsZXByb2plY3QvaXNzdWVzL2RldGFpbD9p ZD0xMjc+CisKKyAgICAgICAgRml4ZXMgdGhlIGZvbGxvd2luZyBzdGF0aWMgYW5hbHl6ZXIgd2Fy bmluZ3M6CisKKyAgICAgICAgICAgIHNyYy9jb21waWxlci9Qb29sQWxsb2MuY3BwOjE1NDoyNjp7 MTU0OjI0LTE1NDoyNX17MTU0OjI4LTE1NDo0Mn06IHdhcm5pbmc6IGNvbXBhcmlzb24gb2YgdW5z aWduZWQgZXhwcmVzc2lvbiA8IDAgaXMgYWx3YXlzIGZhbHNlIFstV3RhdXRvbG9naWNhbC1jb21w YXJlLDJdCisgICAgICAgICAgICAgICAgIGZvciAoc2l6ZV90IHggPSAwOyB4IDwgZ3VhcmRCbG9j a1NpemU7IHgrKykgeworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfiBeIH5+ fn5+fn5+fn5+fn5+CisgICAgICAgICAgICBzcmMvY29tcGlsZXIvUG9vbEFsbG9jLmNwcDoxNTk6 NTU6ezE1OTo1NC0xNTk6NTZ9ezE2MDozMC0xNjA6MzR9OiB3YXJuaW5nOiBjb252ZXJzaW9uIHNw ZWNpZmllcyB0eXBlICd1bnNpZ25lZCBpbnQnIGJ1dCB0aGUgYXJndW1lbnQgaGFzIHR5cGUgJ3Np emVfdCcgKGFrYSAndW5zaWduZWQgbG9uZycpIFstV2Zvcm1hdCw3XQorICAgICAgICAgICAgICAg ICAgICAgICAgIHNwcmludGYoYXNzZXJ0TXNnLCAiUG9vbEFsbG9jOiBEYW1hZ2UgJXMgJXUgYnl0 ZSBhbGxvY2F0aW9uIGF0IDB4JXBcbiIsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB+XgorICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJWx1CisgICAg ICAgICAgICBmaXgtaXQ6InNyYy9jb21waWxlci9Qb29sQWxsb2MuY3BwIjp7MTU5OjU0LTE1OTo1 Nn06IiVsdSIKKworICAgICAgICAqIHNyYy9jb21waWxlci9Qb29sQWxsb2MuY3BwOgorICAgICAg ICAoVEFsbG9jYXRpb246OmNoZWNrR3VhcmRCbG9jayk6IENoYW5nZWQgJyV1JyB0byAnJWx1JyBm b3Igc2l6ZV90CisgICAgICAgIHZhcmlhYmxlLiAgUHV0IGZvciBsb29wIGluc2lkZSAjaWZkZWYg R1VBUkRfQkxPQ0tTLyNlbmRpZiBtYWNyb3MKKyAgICAgICAgdG8gZml4IHRhdXRvbG9naWNhbC1j b21wYXJlIHdhcm5pbmcuCisgICAgICAgIChUQWxsb2NhdGlvbjo6Y2hlY2tBbGxvY0xpc3QpOiBB ZGRlZCBuZXdsaW5lIHRvIGVuZCBvZiBmaWxlLgorCitodHRwOi8vY29kZS5nb29nbGUuY29tL3Av YW5nbGVwcm9qZWN0L2lzc3Vlcy9kZXRhaWw/aWQ9MTI3CisKKzIwMTEtMDMtMTQgIERhdmlkIEtp bHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KKwogICAgICAgICBGaXggY2xhbmcgd2FybmluZ3M6 IEludGVybWVkaWF0ZS5jcHA6IHdhcm5pbmc6ICcmJicgd2l0aGluICd8fCcKIAogICAgICAgICBQ YXJ0IDMgb2YgNTogPGh0dHA6Ly93ZWJraXQub3JnL2IvNTYzMzc+IEVuYWJsZSAtV2Vycm9yIG9u IEFOR0xFCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMvY29tcGlsZXIv UG9vbEFsbG9jLmNwcCBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9jb21waWxlci9Qb29s QWxsb2MuY3BwCmluZGV4IDkzZTIxZTQuLmUyODZjN2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9UaGly ZFBhcnR5L0FOR0xFL3NyYy9jb21waWxlci9Qb29sQWxsb2MuY3BwCisrKyBiL1NvdXJjZS9UaGly ZFBhcnR5L0FOR0xFL3NyYy9jb21waWxlci9Qb29sQWxsb2MuY3BwCkBAIC0xNTEsMTYgKzE1MSwx OCBAQCBjb25zdCB1bnNpZ25lZCBjaGFyIFRBbGxvY2F0aW9uOjp1c2VyRGF0YUZpbGwgICAgICAg PSAweGNkOwogLy8KIHZvaWQgVEFsbG9jYXRpb246OmNoZWNrR3VhcmRCbG9jayh1bnNpZ25lZCBj aGFyKiBibG9ja01lbSwgdW5zaWduZWQgY2hhciB2YWwsIGNvbnN0IGNoYXIqIGxvY1RleHQpIGNv bnN0CiB7CisjaWZkZWYgR1VBUkRfQkxPQ0tTCiAgICAgZm9yIChzaXplX3QgeCA9IDA7IHggPCBn dWFyZEJsb2NrU2l6ZTsgeCsrKSB7CiAgICAgICAgIGlmIChibG9ja01lbVt4XSAhPSB2YWwpIHsK ICAgICAgICAgICAgIGNoYXIgYXNzZXJ0TXNnWzgwXTsKIAogICAgICAgICAgICAgLy8gV2UgZG9u J3QgcHJpbnQgdGhlIGFzc2VydCBtZXNzYWdlLiAgSXQncyBoZXJlIGp1c3QgdG8gYmUgaGVscGZ1 bC4KLSAgICAgICAgICAgIHNwcmludGYoYXNzZXJ0TXNnLCAiUG9vbEFsbG9jOiBEYW1hZ2UgJXMg JXUgYnl0ZSBhbGxvY2F0aW9uIGF0IDB4JXBcbiIsCisgICAgICAgICAgICBzcHJpbnRmKGFzc2Vy dE1zZywgIlBvb2xBbGxvYzogRGFtYWdlICVzICVsdSBieXRlIGFsbG9jYXRpb24gYXQgMHglcFxu IiwKICAgICAgICAgICAgICAgICAgICAgbG9jVGV4dCwgc2l6ZSwgZGF0YSgpKTsKICAgICAgICAg ICAgIGFzc2VydCgwICYmICJQb29sQWxsb2M6IERhbWFnZSBpbiBndWFyZCBibG9jayIpOwogICAg ICAgICB9CiAgICAgfQorI2VuZGlmCiB9CiAKIApAQCAtMjk5LDQgKzMwMSw0IEBAIHZvaWQgVEFs bG9jYXRpb246OmNoZWNrQWxsb2NMaXN0KCkgY29uc3QKIHsKICAgICBmb3IgKGNvbnN0IFRBbGxv Y2F0aW9uKiBhbGxvYyA9IHRoaXM7IGFsbG9jICE9IDA7IGFsbG9jID0gYWxsb2MtPnByZXZBbGxv YykKICAgICAgICAgYWxsb2MtPmNoZWNrKCk7Ci19ClwgTm8gbmV3bGluZSBhdCBlbmQgb2YgZmls ZQorfQotLSAKMS43LjIuMS4xNTguZ2JkM2E5NwoK