56334 2011-03-14 14:10:52 -0700 Web Inspector: crash upon "//html//@id" search in elements panel. 2011-03-15 07:13:35 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 pfeldman webkit-unassigned apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 367213 0 pfeldman 2011-03-14 14:10:52 -0700 We can't return Attr results / highlight them. 367223 1 85719 pfeldman 2011-03-14 14:18:15 -0700 Created attachment 85719 Patch 367235 2 85719 joepeck 2011-03-14 14:31:12 -0700 Comment on attachment 85719 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=85719&action=review > Source/WebCore/inspector/InspectorDOMAgent.cpp:212 > + if (node->nodeType() == Node::ATTRIBUTE_NODE) > + node = static_cast<Attr*>(node)->ownerElement(); > if (!ec) > resultCollector.add(node); This should probably go inside the (!ec) block. Or make it an early continue check. "if (ec) continue;" Are there other node types we should avoid here? Should we whitelist certain types? Other then this, the patch looks good to me. 367356 3 85719 ap 2011-03-14 16:52:21 -0700 Comment on attachment 85719 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=85719&action=review > Source/WebCore/inspector/InspectorDOMAgent.cpp:211 > if (!ec) In WebCore, any code that looks at exception codes is responsible for initializing them. So, there should be "ec = 0;" inside the loop. 367530 4 85719 pfeldman 2011-03-14 23:21:11 -0700 Comment on attachment 85719 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=85719&action=review >> Source/WebCore/inspector/InspectorDOMAgent.cpp:211 >> if (!ec) > > In WebCore, any code that looks at exception codes is responsible for initializing them. So, there should be "ec = 0;" inside the loop. I don't follow. There is ExceptionCode ec = 0; above. I quit as soon as I hit ec != 0. See the for condition. >> Source/WebCore/inspector/InspectorDOMAgent.cpp:212 >> resultCollector.add(node); > > This should probably go inside the (!ec) block. Or make it an early continue check. "if (ec) continue;" > > Are there other node types we should avoid here? Should we whitelist certain types? > > Other then this, the patch looks good to me. Good catch. I can't think of any other type - we are only interested in node types with broken "parentNode" link. 367535 5 85780 pfeldman 2011-03-14 23:43:21 -0700 Created attachment 85780 [PATCH] Review comments addressed. 367562 6 85780 abarth 2011-03-15 02:01:19 -0700 Comment on attachment 85780 [PATCH] Review comments addressed. /me is super excited about the testing! 367646 7 85780 pfeldman 2011-03-15 07:13:27 -0700 Comment on attachment 85780 [PATCH] Review comments addressed. Clearing flags on attachment: 85780 Committed r81132: <http://trac.webkit.org/changeset/81132> 367647 8 pfeldman 2011-03-15 07:13:35 -0700 All reviewed patches have been landed. Closing bug. 85719 2011-03-14 14:18:15 -0700 2011-03-14 23:43:12 -0700 Patch bug-56334-20110315001813.patch text/plain 4663 pfeldman U3VidmVyc2lvbiBSZXZpc2lvbjogODEwMjMKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAyMTRjYmEyMTc0MmFmYmViMmU3Yzhh N2ZiY2NlOWE3M2FkMjk2Y2ZkLi4zMTM5YmM5MGVlY2QyZTBiZDJmMmIwYTczYTQxNmQzMDc2OTRj ZTFiIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDUgKzEsMTUgQEAKIDIwMTEtMDMtMTQgIFBhdmVsIEZlbGRtYW4gIDxw ZmVsZG1hbkBjaHJvbWl1bS5vcmc+CiAKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogY3Jhc2ggdXBvbiAiLy9odG1sLy9AaWQiIHNl YXJjaCBpbiBlbGVtZW50cyBwYW5lbC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTU2MzM0CisKKyAgICAgICAgKiBpbnNwZWN0b3IvZWxlbWVudHMvZWxl bWVudHMtcGFuZWwtc2VhcmNoLWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBpbnNwZWN0b3IvZWxl bWVudHMvZWxlbWVudHMtcGFuZWwtc2VhcmNoLmh0bWw6CisKKzIwMTEtMDMtMTQgIFBhdmVsIEZl bGRtYW4gIDxwZmVsZG1hbkBjaHJvbWl1bS5vcmc+CisKICAgICAgICAgUmV2aWV3ZWQgYnkgWXVy eSBTZW1pa2hhdHNreS4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBkb24ndCB1c2UgaW5uZXJU ZXh0LCB1c2UgdGV4dENvbnRlbnQgaW5zdGVhZC4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2lu c3BlY3Rvci9lbGVtZW50cy9lbGVtZW50cy1wYW5lbC1zZWFyY2gtZXhwZWN0ZWQudHh0IGIvTGF5 b3V0VGVzdHMvaW5zcGVjdG9yL2VsZW1lbnRzL2VsZW1lbnRzLXBhbmVsLXNlYXJjaC1leHBlY3Rl ZC50eHQKaW5kZXggODZkMmRlYTI1ZTZiNzJjZDEwZDEyYzk5OWIzNjkxNTZlNzMyYTUwZS4uZDdl ZWVmNTc1OTk3NzRmZjZlMDViYmFlNDhiYjAxNjNjZWFkZDExNiAxMDA2NDQKLS0tIGEvTGF5b3V0 VGVzdHMvaW5zcGVjdG9yL2VsZW1lbnRzL2VsZW1lbnRzLXBhbmVsLXNlYXJjaC1leHBlY3RlZC50 eHQKKysrIGIvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2VsZW1lbnRzL2VsZW1lbnRzLXBhbmVsLXNl YXJjaC1leHBlY3RlZC50eHQKQEAgLTExLDQgKzExLDUgQEAgRm9vQmFyCiA8aW5wdXQgdmFsdWU9 IklucHV0VmFsIj4KIDxpbnB1dCB2YWx1ZT0iSW5wdXRWYWwiPgogPGlucHV0IHZhbHVlPSJJbnB1 dFZhbCI+Cis8ZGl2IGF0dHI9ImZvbyI+PC9kaXY+CiAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L2luc3BlY3Rvci9lbGVtZW50cy9lbGVtZW50cy1wYW5lbC1zZWFyY2guaHRtbCBiL0xheW91dFRl c3RzL2luc3BlY3Rvci9lbGVtZW50cy9lbGVtZW50cy1wYW5lbC1zZWFyY2guaHRtbAppbmRleCBm NGRkNWRjYjA5ZTBjOTI5MWUyNmFkNWZjZDExMWI0ZTJlNWM0NjUxLi4wYmVkNDJjZmM2MWU4MDRk YzBjNWQ0ZjA1MWM1OTlhNmQwYWJjODVmIDEwMDc1NQotLS0gYS9MYXlvdXRUZXN0cy9pbnNwZWN0 b3IvZWxlbWVudHMvZWxlbWVudHMtcGFuZWwtc2VhcmNoLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMv aW5zcGVjdG9yL2VsZW1lbnRzL2VsZW1lbnRzLXBhbmVsLXNlYXJjaC5odG1sCkBAIC01Miw2ICs1 Miw4IEBAIGZ1bmN0aW9uIHRlc3QoKQogICAgICAgICBXZWJJbnNwZWN0b3IuZG9tQWdlbnQucGVy Zm9ybVNlYXJjaCgiSW4iICsgInB1dFZhIiArICJsIiwgYWRkTm9kZXNUb1NlYXJjaFJlc3VsdCwg dHJ1ZSk7CiAgICAgICAgIC8vIFBhcnRpYWwgYXR0cmlidXRlIHZhbDw+dWUuCiAgICAgICAgIFdl Ykluc3BlY3Rvci5kb21BZ2VudC5wZXJmb3JtU2VhcmNoKCJuIiArICJwdXRWYSIgKyAibCIsIGFk ZE5vZGVzVG9TZWFyY2hSZXN1bHQsIHRydWUpOworICAgICAgICAvLyBYUGF0aCBhdHRyaWJ1dGUu CisgICAgICAgIFdlYkluc3BlY3Rvci5kb21BZ2VudC5wZXJmb3JtU2VhcmNoKCIvL2h0bWwiICsg Ii8vQGF0dHIiLCBhZGROb2Rlc1RvU2VhcmNoUmVzdWx0LCB0cnVlKTsKICAgICAgICAgLy8gVGVy bWluYXRvci4KICAgICAgICAgV2ViSW5zcGVjdG9yLmRvbUFnZW50LnBlcmZvcm1TZWFyY2goInRl ciIgKyAibWkiICsgIm5hdG9yIiwgYWRkTm9kZXNUb1NlYXJjaFJlc3VsdCwgdHJ1ZSk7CiAgICAg fQpAQCAtNjYsNiArNjgsNyBAQCBUZXN0cyB0aGF0IGVsZW1lbnRzIHBhbmVsIHNlYXJjaCBpcyBy ZXR1cm5pbmcgcHJvcGVyIHJlc3VsdHMuCiAKIDxkaXY+Rm9vQmFyPC9kaXY+CiA8aW5wdXQgdmFs dWU9IklucHV0VmFsIj4KKzxkaXYgYXR0cj0iZm9vIj48L2Rpdj4KIDxkaXYgaWQ9InRlcm1pbmF0 b3IiPjwvZGl2PgogCiA8L2JvZHk+CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VM b2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNThkZjE4ZWNkMWNmYWZhMjNiZDVj NjQxOGYwNDBhMDgyMDNkOGQ4Zi4uYTg1NDE1ZjBmMDkxZmNlZTAzZmVmNmU4NGJiMmQxYzU1N2Q5 YTQ4NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9X ZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE1IEBACiAyMDExLTAzLTE0ICBQYXZlbCBGZWxk bWFuICA8cGZlbGRtYW5AY2hyb21pdW0ub3JnPgogCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IGNyYXNoIHVwb24gIi8vaHRtbC8v QGlkIiBzZWFyY2ggaW4gZWxlbWVudHMgcGFuZWwuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NjMzNAorCisgICAgICAgICogaW5zcGVjdG9yL0luc3Bl Y3RvckRPTUFnZW50LmNwcDoKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0VsZW1lbnRz VHJlZU91dGxpbmUuanM6CisKKzIwMTEtMDMtMTQgIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBj aHJvbWl1bS5vcmc+CisKICAgICAgICAgUmV2aWV3ZWQgYnkgWXVyeSBTZW1pa2hhdHNreS4KIAog ICAgICAgICBXZWIgSW5zcGVjdG9yOiBkb24ndCB1c2UgaW5uZXJUZXh0LCB1c2UgdGV4dENvbnRl bnQgaW5zdGVhZC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0 b3JET01BZ2VudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRE9NQWdl bnQuY3BwCmluZGV4IGNlOWQ2NjgyNjA1YTk2NmM1NzdjNjhkNzk4ODY2MjExOTdiNmY1YzUuLjA3 MGI5MGQwMDY0ODBlYTRjNWRiODA2YWRkZWI1MDk1NzJmZDE4NWQgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JET01BZ2VudC5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckRPTUFnZW50LmNwcApAQCAtMjA2LDYgKzIwNiw4IEBA IHB1YmxpYzoKICAgICAgICAgdW5zaWduZWQgbG9uZyBzaXplID0gcmVzdWx0LT5zbmFwc2hvdExl bmd0aChlYyk7CiAgICAgICAgIGZvciAodW5zaWduZWQgbG9uZyBpID0gMDsgIWVjICYmIGkgPCBz aXplOyArK2kpIHsKICAgICAgICAgICAgIE5vZGUqIG5vZGUgPSByZXN1bHQtPnNuYXBzaG90SXRl bShpLCBlYyk7CisgICAgICAgICAgICBpZiAobm9kZS0+bm9kZVR5cGUoKSA9PSBOb2RlOjpBVFRS SUJVVEVfTk9ERSkKKyAgICAgICAgICAgICAgICBub2RlID0gc3RhdGljX2Nhc3Q8QXR0cio+KG5v ZGUpLT5vd25lckVsZW1lbnQoKTsKICAgICAgICAgICAgIGlmICghZWMpCiAgICAgICAgICAgICAg ICAgcmVzdWx0Q29sbGVjdG9yLmFkZChub2RlKTsKICAgICAgICAgfQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9FbGVtZW50c1RyZWVPdXRsaW5lLmpzIGIv U291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9FbGVtZW50c1RyZWVPdXRsaW5lLmpz CmluZGV4IGMyMTZiMzQyNGE0ODY0ODg4Yzk3MTQxMDE0YzZiNGI5YmU2ZjMwMzUuLmRlYjlmNDMy OWE1YWFiMmRjNmUwOTU5Y2VkZWRkNzVjNjUyNWNkMjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRWxlbWVudHNUcmVlT3V0bGluZS5qcworKysgYi9Tb3Vy Y2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0VsZW1lbnRzVHJlZU91dGxpbmUuanMKQEAg LTE0OTIsNiArMTQ5MiwxMSBAQCBXZWJJbnNwZWN0b3IuRWxlbWVudHNUcmVlRWxlbWVudC5wcm90 b3R5cGUgPSB7CiAgICAgICAgICAgICBtYXRjaFJhbmdlcy5wdXNoKHsgb2Zmc2V0OiBtYXRjaC5p bmRleCwgbGVuZ3RoOiBtYXRjaFswXS5sZW5ndGggfSk7CiAgICAgICAgICAgICBtYXRjaCA9IHJl Z2V4T2JqZWN0LmV4ZWModGV4dCk7CiAgICAgICAgIH0KKworICAgICAgICAvLyBGYWxsIGJhY2sg Zm9yIFhQYXRoLCBldGMuIG1hdGNoZXMuCisgICAgICAgIGlmICghbWF0Y2hSYW5nZXMubGVuZ3Ro KQorICAgICAgICAgICAgbWF0Y2hSYW5nZXMucHVzaCh7IG9mZnNldDogMCwgbGVuZ3RoOiB0ZXh0 Lmxlbmd0aCB9KTsKKwogICAgICAgICBoaWdobGlnaHRTZWFyY2hSZXN1bHRzKHRoaXMubGlzdEl0 ZW1FbGVtZW50LCBtYXRjaFJhbmdlcyk7CiAgICAgICAgIHRoaXMuX3NlYXJjaEhpZ2hsaWdodGVk SFRNTCA9IHRoaXMubGlzdEl0ZW1FbGVtZW50LmlubmVySFRNTDsKICAgICB9Cg== 85780 2011-03-14 23:43:21 -0700 2011-03-15 07:13:27 -0700 [PATCH] Review comments addressed. bug-56334-20110315094317.patch text/plain 4798 pfeldman U3VidmVyc2lvbiBSZXZpc2lvbjogODEwMjMKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAyMTRjYmEyMTc0MmFmYmViMmU3Yzhh N2ZiY2NlOWE3M2FkMjk2Y2ZkLi4zMTM5YmM5MGVlY2QyZTBiZDJmMmIwYTczYTQxNmQzMDc2OTRj ZTFiIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDUgKzEsMTUgQEAKIDIwMTEtMDMtMTQgIFBhdmVsIEZlbGRtYW4gIDxw ZmVsZG1hbkBjaHJvbWl1bS5vcmc+CiAKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogY3Jhc2ggdXBvbiAiLy9odG1sLy9AaWQiIHNl YXJjaCBpbiBlbGVtZW50cyBwYW5lbC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTU2MzM0CisKKyAgICAgICAgKiBpbnNwZWN0b3IvZWxlbWVudHMvZWxl bWVudHMtcGFuZWwtc2VhcmNoLWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBpbnNwZWN0b3IvZWxl bWVudHMvZWxlbWVudHMtcGFuZWwtc2VhcmNoLmh0bWw6CisKKzIwMTEtMDMtMTQgIFBhdmVsIEZl bGRtYW4gIDxwZmVsZG1hbkBjaHJvbWl1bS5vcmc+CisKICAgICAgICAgUmV2aWV3ZWQgYnkgWXVy eSBTZW1pa2hhdHNreS4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBkb24ndCB1c2UgaW5uZXJU ZXh0LCB1c2UgdGV4dENvbnRlbnQgaW5zdGVhZC4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2lu c3BlY3Rvci9lbGVtZW50cy9lbGVtZW50cy1wYW5lbC1zZWFyY2gtZXhwZWN0ZWQudHh0IGIvTGF5 b3V0VGVzdHMvaW5zcGVjdG9yL2VsZW1lbnRzL2VsZW1lbnRzLXBhbmVsLXNlYXJjaC1leHBlY3Rl ZC50eHQKaW5kZXggODZkMmRlYTI1ZTZiNzJjZDEwZDEyYzk5OWIzNjkxNTZlNzMyYTUwZS4uZDdl ZWVmNTc1OTk3NzRmZjZlMDViYmFlNDhiYjAxNjNjZWFkZDExNiAxMDA2NDQKLS0tIGEvTGF5b3V0 VGVzdHMvaW5zcGVjdG9yL2VsZW1lbnRzL2VsZW1lbnRzLXBhbmVsLXNlYXJjaC1leHBlY3RlZC50 eHQKKysrIGIvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2VsZW1lbnRzL2VsZW1lbnRzLXBhbmVsLXNl YXJjaC1leHBlY3RlZC50eHQKQEAgLTExLDQgKzExLDUgQEAgRm9vQmFyCiA8aW5wdXQgdmFsdWU9 IklucHV0VmFsIj4KIDxpbnB1dCB2YWx1ZT0iSW5wdXRWYWwiPgogPGlucHV0IHZhbHVlPSJJbnB1 dFZhbCI+Cis8ZGl2IGF0dHI9ImZvbyI+PC9kaXY+CiAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L2luc3BlY3Rvci9lbGVtZW50cy9lbGVtZW50cy1wYW5lbC1zZWFyY2guaHRtbCBiL0xheW91dFRl c3RzL2luc3BlY3Rvci9lbGVtZW50cy9lbGVtZW50cy1wYW5lbC1zZWFyY2guaHRtbAppbmRleCBm NGRkNWRjYjA5ZTBjOTI5MWUyNmFkNWZjZDExMWI0ZTJlNWM0NjUxLi4wYmVkNDJjZmM2MWU4MDRk YzBjNWQ0ZjA1MWM1OTlhNmQwYWJjODVmIDEwMDc1NQotLS0gYS9MYXlvdXRUZXN0cy9pbnNwZWN0 b3IvZWxlbWVudHMvZWxlbWVudHMtcGFuZWwtc2VhcmNoLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMv aW5zcGVjdG9yL2VsZW1lbnRzL2VsZW1lbnRzLXBhbmVsLXNlYXJjaC5odG1sCkBAIC01Miw2ICs1 Miw4IEBAIGZ1bmN0aW9uIHRlc3QoKQogICAgICAgICBXZWJJbnNwZWN0b3IuZG9tQWdlbnQucGVy Zm9ybVNlYXJjaCgiSW4iICsgInB1dFZhIiArICJsIiwgYWRkTm9kZXNUb1NlYXJjaFJlc3VsdCwg dHJ1ZSk7CiAgICAgICAgIC8vIFBhcnRpYWwgYXR0cmlidXRlIHZhbDw+dWUuCiAgICAgICAgIFdl Ykluc3BlY3Rvci5kb21BZ2VudC5wZXJmb3JtU2VhcmNoKCJuIiArICJwdXRWYSIgKyAibCIsIGFk ZE5vZGVzVG9TZWFyY2hSZXN1bHQsIHRydWUpOworICAgICAgICAvLyBYUGF0aCBhdHRyaWJ1dGUu CisgICAgICAgIFdlYkluc3BlY3Rvci5kb21BZ2VudC5wZXJmb3JtU2VhcmNoKCIvL2h0bWwiICsg Ii8vQGF0dHIiLCBhZGROb2Rlc1RvU2VhcmNoUmVzdWx0LCB0cnVlKTsKICAgICAgICAgLy8gVGVy bWluYXRvci4KICAgICAgICAgV2ViSW5zcGVjdG9yLmRvbUFnZW50LnBlcmZvcm1TZWFyY2goInRl ciIgKyAibWkiICsgIm5hdG9yIiwgYWRkTm9kZXNUb1NlYXJjaFJlc3VsdCwgdHJ1ZSk7CiAgICAg fQpAQCAtNjYsNiArNjgsNyBAQCBUZXN0cyB0aGF0IGVsZW1lbnRzIHBhbmVsIHNlYXJjaCBpcyBy ZXR1cm5pbmcgcHJvcGVyIHJlc3VsdHMuCiAKIDxkaXY+Rm9vQmFyPC9kaXY+CiA8aW5wdXQgdmFs dWU9IklucHV0VmFsIj4KKzxkaXYgYXR0cj0iZm9vIj48L2Rpdj4KIDxkaXYgaWQ9InRlcm1pbmF0 b3IiPjwvZGl2PgogCiA8L2JvZHk+CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VM b2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNThkZjE4ZWNkMWNmYWZhMjNiZDVj NjQxOGYwNDBhMDgyMDNkOGQ4Zi4uYTg1NDE1ZjBmMDkxZmNlZTAzZmVmNmU4NGJiMmQxYzU1N2Q5 YTQ4NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9X ZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE1IEBACiAyMDExLTAzLTE0ICBQYXZlbCBGZWxk bWFuICA8cGZlbGRtYW5AY2hyb21pdW0ub3JnPgogCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IGNyYXNoIHVwb24gIi8vaHRtbC8v QGlkIiBzZWFyY2ggaW4gZWxlbWVudHMgcGFuZWwuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NjMzNAorCisgICAgICAgICogaW5zcGVjdG9yL0luc3Bl Y3RvckRPTUFnZW50LmNwcDoKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0VsZW1lbnRz VHJlZU91dGxpbmUuanM6CisKKzIwMTEtMDMtMTQgIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBj aHJvbWl1bS5vcmc+CisKICAgICAgICAgUmV2aWV3ZWQgYnkgWXVyeSBTZW1pa2hhdHNreS4KIAog ICAgICAgICBXZWIgSW5zcGVjdG9yOiBkb24ndCB1c2UgaW5uZXJUZXh0LCB1c2UgdGV4dENvbnRl bnQgaW5zdGVhZC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0 b3JET01BZ2VudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRE9NQWdl bnQuY3BwCmluZGV4IGNlOWQ2NjgyNjA1YTk2NmM1NzdjNjhkNzk4ODY2MjExOTdiNmY1YzUuLjIy NTRiZTQ1MTc0M2ExMjdlOWU0ODdjMDg5YmY1YmZmOWViYTM2OGUgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JET01BZ2VudC5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckRPTUFnZW50LmNwcApAQCAtMjA2LDggKzIwNiwxMiBA QCBwdWJsaWM6CiAgICAgICAgIHVuc2lnbmVkIGxvbmcgc2l6ZSA9IHJlc3VsdC0+c25hcHNob3RM ZW5ndGgoZWMpOwogICAgICAgICBmb3IgKHVuc2lnbmVkIGxvbmcgaSA9IDA7ICFlYyAmJiBpIDwg c2l6ZTsgKytpKSB7CiAgICAgICAgICAgICBOb2RlKiBub2RlID0gcmVzdWx0LT5zbmFwc2hvdEl0 ZW0oaSwgZWMpOwotICAgICAgICAgICAgaWYgKCFlYykKLSAgICAgICAgICAgICAgICByZXN1bHRD b2xsZWN0b3IuYWRkKG5vZGUpOworICAgICAgICAgICAgaWYgKGVjKQorICAgICAgICAgICAgICAg IGJyZWFrOworCisgICAgICAgICAgICBpZiAobm9kZS0+bm9kZVR5cGUoKSA9PSBOb2RlOjpBVFRS SUJVVEVfTk9ERSkKKyAgICAgICAgICAgICAgICBub2RlID0gc3RhdGljX2Nhc3Q8QXR0cio+KG5v ZGUpLT5vd25lckVsZW1lbnQoKTsKKyAgICAgICAgICAgIHJlc3VsdENvbGxlY3Rvci5hZGQobm9k ZSk7CiAgICAgICAgIH0KICNlbHNlCiAgICAgICAgIFVOVVNFRF9QQVJBTShyZXN1bHRDb2xsZWN0 b3IpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9FbGVt ZW50c1RyZWVPdXRsaW5lLmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9F bGVtZW50c1RyZWVPdXRsaW5lLmpzCmluZGV4IGMyMTZiMzQyNGE0ODY0ODg4Yzk3MTQxMDE0YzZi NGI5YmU2ZjMwMzUuLmRlYjlmNDMyOWE1YWFiMmRjNmUwOTU5Y2VkZWRkNzVjNjUyNWNkMjUgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRWxlbWVudHNUcmVl T3V0bGluZS5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0VsZW1l bnRzVHJlZU91dGxpbmUuanMKQEAgLTE0OTIsNiArMTQ5MiwxMSBAQCBXZWJJbnNwZWN0b3IuRWxl bWVudHNUcmVlRWxlbWVudC5wcm90b3R5cGUgPSB7CiAgICAgICAgICAgICBtYXRjaFJhbmdlcy5w dXNoKHsgb2Zmc2V0OiBtYXRjaC5pbmRleCwgbGVuZ3RoOiBtYXRjaFswXS5sZW5ndGggfSk7CiAg ICAgICAgICAgICBtYXRjaCA9IHJlZ2V4T2JqZWN0LmV4ZWModGV4dCk7CiAgICAgICAgIH0KKwor ICAgICAgICAvLyBGYWxsIGJhY2sgZm9yIFhQYXRoLCBldGMuIG1hdGNoZXMuCisgICAgICAgIGlm ICghbWF0Y2hSYW5nZXMubGVuZ3RoKQorICAgICAgICAgICAgbWF0Y2hSYW5nZXMucHVzaCh7IG9m ZnNldDogMCwgbGVuZ3RoOiB0ZXh0Lmxlbmd0aCB9KTsKKwogICAgICAgICBoaWdobGlnaHRTZWFy Y2hSZXN1bHRzKHRoaXMubGlzdEl0ZW1FbGVtZW50LCBtYXRjaFJhbmdlcyk7CiAgICAgICAgIHRo aXMuX3NlYXJjaEhpZ2hsaWdodGVkSFRNTCA9IHRoaXMubGlzdEl0ZW1FbGVtZW50LmlubmVySFRN TDsKICAgICB9Cg==