56327 2011-03-14 13:26:00 -0700 Web Inspector: further extension API cleanup (removed inspectedPage, add experimental prefix) 2011-03-15 07:02:18 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 caseq caseq apavlov bweinstein commit-queue joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 367174 0 caseq 2011-03-14 13:26:00 -0700 This removes webInspector.inspectedPage.* (extensions are expected to use browser API for this), adds optional experimental perfix (experimental.webInspector == webInspector for now). 367180 1 85711 caseq 2011-03-14 13:33:25 -0700 Created attachment 85711 patch 367592 2 85711 yurys 2011-03-15 02:49:01 -0700 Comment on attachment 85711 patch View in context: https://bugs.webkit.org/attachment.cgi?id=85711&action=review > Source/WebCore/inspector/front-end/ExtensionAPI.js:520 > +experimental.webInspector = webInspector; Why do we need both at the same time? 367643 3 caseq 2011-03-15 07:02:18 -0700 Manually committed a variation of the patch as r81130: http://trac.webkit.org/changeset/81130 85711 2011-03-14 13:33:25 -0700 2011-03-15 06:23:37 -0700 patch extension-api-cleanup.diff text/plain 3291 caseq ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAwZDFjYTUxLi41ZjAzMDA5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg QEAKKzIwMTEtMDMtMTQgIEFuZHJleSBLb3N5YWtvdiAgPGNhc2VxQGNocm9taXVtLm9yZz4KKwor ICAgICAgICBXZWIgSW5zcGVjdG9yOiBmdXJ0aGVyIGV4dGVuc2lvbiBBUEkgY2xlYW51cCAocmVt b3ZlZCBpbnNwZWN0ZWRQYWdlLCBhZGQgZXhwZXJpbWVudGFsIHByZWZpeCkKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU2MzI3CisKKyAgICAgICAgKiBp bnNwZWN0b3IvZnJvbnQtZW5kL0V4dGVuc2lvbkFQSS5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rv ci5pbmplY3RlZEV4dGVuc2lvbkFQSSk6CisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9F eHRlbnNpb25BUElTY2hlbWEuanNvbjoKKwogMjAxMS0wMy0xNCAgQnJhZHkgRWlkc29uICA8YmVp ZHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFuIEJlcm5zdGVpbi4KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRXh0ZW5zaW9uQVBJ LmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9FeHRlbnNpb25BUEkuanMK aW5kZXggNmExMWQ2Mi4uZjBhNDkxYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVj dG9yL2Zyb250LWVuZC9FeHRlbnNpb25BUEkuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVj dG9yL2Zyb250LWVuZC9FeHRlbnNpb25BUEkuanMKQEAgLTUxNiw1ICs1MTYsNyBAQCB2YXIgV2F0 Y2hFeHByZXNzaW9uU2lkZWJhclBhbmUgPSBkZWNsYXJlSW50ZXJmYWNlQ2xhc3MoV2F0Y2hFeHBy ZXNzaW9uU2lkZWJhclBhbgogdmFyIGV4dGVuc2lvblNlcnZlciA9IG5ldyBFeHRlbnNpb25TZXJ2 ZXJDbGllbnQoKTsKIAogd2ViSW5zcGVjdG9yID0gbmV3IEluc3BlY3RvckV4dGVuc2lvbkFQSSgp OworZXhwZXJpbWVudGFsID0gZXhwZXJpbWVudGFsIHx8IHt9OworZXhwZXJpbWVudGFsLndlYklu c3BlY3RvciA9IHdlYkluc3BlY3RvcjsKIAogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv aW5zcGVjdG9yL2Zyb250LWVuZC9FeHRlbnNpb25BUElTY2hlbWEuanNvbiBiL1NvdXJjZS9XZWJD b3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRXh0ZW5zaW9uQVBJU2NoZW1hLmpzb24KaW5kZXggZDll NmQxOC4uMGFhN2FhOCAxMDA3NTUKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250 LWVuZC9FeHRlbnNpb25BUElTY2hlbWEuanNvbgorKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0 b3IvZnJvbnQtZW5kL0V4dGVuc2lvbkFQSVNjaGVtYS5qc29uCkBAIC0xLDU3ICsxLDUgQEAKIFsK ICAgewotICAgICJuYW1lc3BhY2UiOiAiZXhwZXJpbWVudGFsLndlYkluc3BlY3Rvci5pbnNwZWN0 ZWRXaW5kb3ciLAotICAgICJkZXNjcmlwdGlvbiI6ICJQcm92aWRlcyBhY2Nlc3MgdG8gdGhlIHdp bmRvdyBiZWluZyBpbnNwZWN0ZWQuIiwKLSAgICAiZnVuY3Rpb25zIjogWwotICAgICAgewotICAg ICAgICAibmFtZSI6ICJldmFsIiwKLSAgICAgICAgInR5cGUiOiAiZnVuY3Rpb24iLAotICAgICAg ICAiZGVzY3JpcHRpb24iOiAiRXZhbHVhdGVzIGEgSmF2YVNjcmlwdCBleHByZXNzaW9uIGluIHRo ZSBjb250ZXh0IG9mIGluc3BlY3RlZCBwYWdlIChOT1RFOiB0aGUgZXhwcmVzc2lvbiBtdXN0IGV2 YWx1YXRlIHRvIGEgSlNPTi1jb21wbGlhbnQgb2JqZWN0LCBvdGhlcndpc2UgdGhlIGV4Y2VwdGlv biBpcyB0aHJvd24pIiwKLSAgICAgICAgInBhcmFtZXRlcnMiOiBbCi0gICAgICAgICAgewotICAg ICAgICAgICAgIm5hbWUiOiAiZXhwcmVzc2lvbiIsCi0gICAgICAgICAgICAidHlwZSI6ICJzdHJp bmciLAotICAgICAgICAgICAgImRlc2NyaXB0aW9uIjogIkFuIGV4cHJlc3Npb24gdG8gZXZhbHVh dGUuIgotICAgICAgICAgIH0sCi0gICAgICAgICAgewotICAgICAgICAgICAgIm5hbWUiOiAiY2Fs bGJhY2siLAotICAgICAgICAgICAgInR5cGUiOiAiZnVuY3Rpb24iLAotICAgICAgICAgICAgImRl c2NyaXB0aW9uIjogIkEgZnVuY3Rpb24gY2FsbGVkIHdoZW4gZXZhbHVhdGlvbiBjb21wbGV0ZXMu IiwKLSAgICAgICAgICAgICJwYXJhbWV0ZXJzIjogWwotICAgICAgICAgICAgICB7Ci0gICAgICAg ICAgICAgICAgIm5hbWUiOiAicmVzdWx0IiwKLSAgICAgICAgICAgICAgICAidHlwZSI6ICJvYmpl Y3QiLAotICAgICAgICAgICAgICAgICJkZXNjcmlwdGlvbiI6ICJUaGUgcmVzdWx0IG9mIGV2YWx1 YXRpb24iCi0gICAgICAgICAgICAgIH0sCi0gICAgICAgICAgICAgIHsKLSAgICAgICAgICAgICAg ICAibmFtZSI6ICJpc0V4Y2VwdGlvbiIsCi0gICAgICAgICAgICAgICAgInR5cGUiOiAiYm9vbGVh biIsCi0gICAgICAgICAgICAgICAgImRlc2NyaXB0aW9uIjogIlNldCBpZiBhbiBleGNlcHRpb24g d2FzIGNhdWdodCB3aGlsZSBldmFsdWF0aW5nIHRoZSBleHByZXNzaW9uIgotICAgICAgICAgICAg ICB9Ci0gICAgICAgICAgICBdCi0gICAgICAgICAgfQotICAgICAgICBdCi0gICAgICB9Ci0gICAg XSwKLSAgICAiZXZlbnRzIjogWwotICAgICAgewotICAgICAgICAibmFtZSI6ICJvbkRPTUNvbnRl bnRMb2FkZWQiLAotICAgICAgICAidHlwZSI6ICJmdW5jdGlvbiIsCi0gICAgICAgICJkZXNjcmlw dGlvbiI6ICJGaXJlZCBhZnRlciBET01Db250ZW50TG9hZGVkIGV2ZW50IG9uIGluc3BlY3RlZCBw YWdlIGlzIGZpcmVkLiIKLSAgICAgIH0sCi0gICAgICB7Ci0gICAgICAgICJuYW1lIjogIm9uTG9h ZGVkIiwKLSAgICAgICAgInR5cGUiOiAiZnVuY3Rpb24iLAotICAgICAgICAiZGVzY3JpcHRpb24i OiAiRmlyZWQgYWZ0ZXIgbG9hZCBldmVudCBvbiBpbnNwZWN0ZWQgcGFnZSBpcyBmaXJlZC4iCi0g ICAgICB9LAotICAgICAgewotICAgICAgICAibmFtZSI6ICJvbk5hdmlnYXRlZCIsCi0gICAgICAg ICJ0eXBlIjogImZ1bmN0aW9uIiwKLSAgICAgICAgImRlc2NyaXB0aW9uIjogIkZpcmVkIHdoZW4g bmF2aWdhdGlvbiBvY2N1cnMgaW4gdGhlIHdpbmRvdyBiZWluZyBpbnNwZWN0ZWQuIgotICAgICAg fQotICAgIF0KLSAgfSwKLSAgewogICAgICJuYW1lc3BhY2UiOiAiZXhwZXJpbWVudGFsLndlYklu c3BlY3Rvci5wYW5lbHMiLAogICAgICJ0eXBlcyI6IFsKICAgICAgIHsK