56316 2011-03-14 10:42:47 -0700 Stalled media elements don't stop delaying the load event 2011-03-14 21:11:52 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED InRadar P2 Normal --- 1 joepeck webkit-unassigned commit-queue eric.carlson joepeck oldest_to_newest 367055 0 joepeck 2011-03-14 10:42:47 -0700 If a media element is stalled, or doesn't load without user interaction, the media element should stop deferring the (window's) load event. The spec does also say: http://www.whatwg.org/specs/web-apps/current-work/multipage/video.html#concept-media-load-resource > "When a user agent decides to completely stall a download, e.g. if it is > waiting until the user starts playback before downloading any further > content, the element's delaying-the-load-event flag must be set to false." There are a number of points we can stall that seem to be affected: • super early, after load start but before getting meta data (or any data if user required). • early, after meta data but before real data 367062 1 joepeck 2011-03-14 10:49:46 -0700 The spec also says: > When a user agent decides to completely stall a download, e.g. if it is waiting > until the user starts playback before downloading any further content, the > element's delaying-the-load-event flag must be set to false. This stops > delaying the load event. 367063 2 joepeck 2011-03-14 10:50:41 -0700 Sorry about the double paste. 367067 3 joepeck 2011-03-14 10:57:34 -0700 <rdar://problem/9071398> 367093 4 85693 joepeck 2011-03-14 11:33:24 -0700 Created attachment 85693 [PATCH] Suggested Fix: Stop Delaying @ stalled + suspend events 367491 5 85693 commit-queue 2011-03-14 21:11:46 -0700 Comment on attachment 85693 [PATCH] Suggested Fix: Stop Delaying @ stalled + suspend events Clearing flags on attachment: 85693 Committed r81104: <http://trac.webkit.org/changeset/81104> 367492 6 commit-queue 2011-03-14 21:11:52 -0700 All reviewed patches have been landed. Closing bug. 85693 2011-03-14 11:33:24 -0700 2011-03-14 21:11:46 -0700 [PATCH] Suggested Fix: Stop Delaying @ stalled + suspend events suggested-fix.patch text/plain 4000 joepeck ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA3YTFhN2UyLi5kNGMzNjQxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDMt MTQgIEpvc2VwaCBQZWNvcmFybyAgPGpvZXBlY2tAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTdGFsbGVkIG1lZGlhIGVsZW1lbnRz IGRvbid0IHN0b3AgZGVsYXlpbmcgdGhlIGxvYWQgZXZlbnQKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU2MzE2CisKKyAgICAgICAgKiBodHRwL3Rlc3Rz L21lZGlhL3ZpZGVvLXBsYXktc3RhbGwtYmVmb3JlLW1ldGEtZGF0YS1leHBlY3RlZC50eHQ6IEFk ZGVkLgorICAgICAgICAqIGh0dHAvdGVzdHMvbWVkaWEvdmlkZW8tcGxheS1zdGFsbC1iZWZvcmUt bWV0YS1kYXRhLmh0bWw6IEFkZGVkLgorCiAyMDExLTAzLTAzICBNaWhhaSBQYXJwYXJpdGEgIDxt aWhhaXBAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQgQ2hyb21pdW0gU25vdyBM ZW9wYXJkIGV4cGVjdGF0aW9ucyB1cGRhdGUuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9odHRw L3Rlc3RzL21lZGlhL3ZpZGVvLXBsYXktc3RhbGwtYmVmb3JlLW1ldGEtZGF0YS1leHBlY3RlZC50 eHQgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL21lZGlhL3ZpZGVvLXBsYXktc3RhbGwtYmVmb3Jl LW1ldGEtZGF0YS1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAw MC4uNTg4MTAwOAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvbWVk aWEvdmlkZW8tcGxheS1zdGFsbC1iZWZvcmUtbWV0YS1kYXRhLWV4cGVjdGVkLnR4dApAQCAtMCww ICsxLDggQEAKK1Rlc3QgdGhhdCBzdGFsbGluZyB2ZXJ5IGVhcmx5LCB3aGlsZSBsb2FkaW5nIG1l dGEtZGF0YSwgc3RvcHMgZGVsYXlpbmcgdGhlIGxvYWQgZXZlbnQuCisKK0VWRU5UKGJlZm9yZWxv YWQpCitFVkVOVChsb2Fkc3RhcnQpCitFVkVOVChzdGFsbGVkKQorRVZFTlQod2luZG93Lm9ubG9h ZCkKK0VORCBPRiBURVNUCisKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvbWVk aWEvdmlkZW8tcGxheS1zdGFsbC1iZWZvcmUtbWV0YS1kYXRhLmh0bWwgYi9MYXlvdXRUZXN0cy9o dHRwL3Rlc3RzL21lZGlhL3ZpZGVvLXBsYXktc3RhbGwtYmVmb3JlLW1ldGEtZGF0YS5odG1sCm5l dyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLjZkNjM4MzUKLS0tIC9kZXYvbnVsbAor KysgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL21lZGlhL3ZpZGVvLXBsYXktc3RhbGwtYmVmb3Jl LW1ldGEtZGF0YS5odG1sCkBAIC0wLDAgKzEsMjEgQEAKKzx2aWRlbz48L3ZpZGVvPgorPHA+VGVz dCB0aGF0IHN0YWxsaW5nIHZlcnkgZWFybHksIHdoaWxlIGxvYWRpbmcgbWV0YS1kYXRhLCBzdG9w cyBkZWxheWluZyB0aGUgbG9hZCBldmVudC48L3A+Cis8c2NyaXB0IHNyYz0uLi8uLi9tZWRpYS1y ZXNvdXJjZXMvdmlkZW8tdGVzdC5qcz48L3NjcmlwdD4KKzxzY3JpcHQ+CisKKyAgICAvLyBFeHBl Y3RlZCBldmVudHMuCisgICAgd2FpdEZvckV2ZW50KCJiZWZvcmVsb2FkIik7CisgICAgd2FpdEZv ckV2ZW50KCJsb2Fkc3RhcnQiKTsKKyAgICB3YWl0Rm9yRXZlbnQoInN0YWxsZWQiKTsKKyAgICB3 YWl0Rm9yRXZlbnQoInN1c3BlbmQiKTsKKworICAgIC8vIFdlIHdhbnQgdG8gbWFrZSBzdXJlIHRo ZSBvbmxvYWQgZXZlbnQgZmlyZXMuCisgICAgd2luZG93Lm9ubG9hZCA9IGZ1bmN0aW9uKCkgewor ICAgICAgIGNvbnNvbGVXcml0ZSgiRVZFTlQod2luZG93Lm9ubG9hZCkiKTsKKyAgICAgICBlbmRU ZXN0KCk7CisgICAgfTsKKworICAgIC8vIExvYWQgc2hvdWxkIHN0YWxsIHZlcnkgZWFybHkgaW4g dGhlIGxvYWRpbmcgcHJvY2Vzcy4KKyAgICB2aWRlby5zcmMgPSAiaHR0cDovLzEyNy4wLjAuMTo4 MDAwL21lZGlhL3ZpZGVvLWxvYWQtYW5kLXN0YWxsLmNnaT9uYW1lPS4uLy4uLy4uL21lZGlhL2Nv bnRlbnQvdGVzdC5tcDQmc3RhbGxBdD0xIjsKKworPC9zY3JpcHQ+CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWQ2 OWI1OC4uZGE5OTI2NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDExLTAzLTE0ICBK b3NlcGggUGVjb3Jhcm8gIDxqb2VwZWNrQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU3RhbGxlZCBtZWRpYSBlbGVtZW50cyBkb24n dCBzdG9wIGRlbGF5aW5nIHRoZSBsb2FkIGV2ZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NjMxNgorCisgICAgICAgIFdlIHNob3VsZCBzdG9wIGRl bGF5aW5nIHRoZSBsb2FkIGV2ZW50IHdoZW4gdGhlIGxvYWQgaGFzCisgICAgICAgIHN0YWxsZWQg bmF0dXJhbGx5LCBvciBpZiB3ZSByZXF1aXJlIGEgdXNlciBnZXN0dXJlIHRvCisgICAgICAgIGNv bnRpbnVlIHRoZSBsb2FkLgorCisgICAgICAgIFRlc3Q6IGh0dHAvdGVzdHMvbWVkaWEvdmlkZW8t cGxheS1zdGFsbC1iZWZvcmUtbWV0YS1kYXRhLmh0bWwKKworICAgICAgICAqIGh0bWwvSFRNTE1l ZGlhRWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MTWVkaWFFbGVtZW50OjpzZXRO ZXR3b3JrU3RhdGUpOiB3aGVuIHN1c3BlbmRpbmcsIHN0b3AgZGVsYXlpbmcuCisgICAgICAgIChX ZWJDb3JlOjpIVE1MTWVkaWFFbGVtZW50Ojpwcm9ncmVzc0V2ZW50VGltZXJGaXJlZCk6IHdoZW4g c3RhbGxpbmcsIHN0b3AgZGVsYXlpbmcuCisKIDIwMTEtMDMtMDMgIEJyYWR5IEVpZHNvbiAgPGJl aWRzb25AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcCBiL1NvdXJj ZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAKaW5kZXggMmVhZDliOC4uMzNmZjBh MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCkBAIC04OTYsNiAr ODk2LDcgQEAgdm9pZCBIVE1MTWVkaWFFbGVtZW50OjpzZXROZXR3b3JrU3RhdGUoTWVkaWFQbGF5 ZXI6Ok5ldHdvcmtTdGF0ZSBzdGF0ZSkKICAgICAgICAgaWYgKG1fbmV0d29ya1N0YXRlID4gTkVU V09SS19JRExFKSB7CiAgICAgICAgICAgICBtX3Byb2dyZXNzRXZlbnRUaW1lci5zdG9wKCk7CiAg ICAgICAgICAgICBzY2hlZHVsZUV2ZW50KGV2ZW50TmFtZXMoKS5zdXNwZW5kRXZlbnQpOworICAg ICAgICAgICAgc2V0U2hvdWxkRGVsYXlMb2FkRXZlbnQoZmFsc2UpOwogICAgICAgICB9CiAgICAg ICAgIG1fbmV0d29ya1N0YXRlID0gTkVUV09SS19JRExFOwogICAgIH0KQEAgLTEwMjcsNiArMTAy OCw3IEBAIHZvaWQgSFRNTE1lZGlhRWxlbWVudDo6cHJvZ3Jlc3NFdmVudFRpbWVyRmlyZWQoVGlt ZXI8SFRNTE1lZGlhRWxlbWVudD4qKQogICAgICAgICBpZiAodGltZWRlbHRhID4gMy4wICYmICFt X3NlbnRTdGFsbGVkRXZlbnQpIHsKICAgICAgICAgICAgIHNjaGVkdWxlRXZlbnQoZXZlbnROYW1l cygpLnN0YWxsZWRFdmVudCk7CiAgICAgICAgICAgICBtX3NlbnRTdGFsbGVkRXZlbnQgPSB0cnVl OworICAgICAgICAgICAgc2V0U2hvdWxkRGVsYXlMb2FkRXZlbnQoZmFsc2UpOwogICAgICAgICB9 CiAgICAgfSBlbHNlIHsKICAgICAgICAgc2NoZWR1bGVFdmVudChldmVudE5hbWVzKCkucHJvZ3Jl c3NFdmVudCk7Cg==