56306 2011-03-14 06:43:36 -0700 JavaMethod.cpp does not compile with V8 2011-03-14 10:39:40 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 1 steveblock webkit-unassigned commit-queue jorlow oliver steveblock oldest_to_newest 366962 0 steveblock 2011-03-14 06:43:36 -0700 Code in bridge/jni is used with both JSC and V8 (on Android). The compile error is because JavaMethod.cpp includes the JSC-specific header ScopeChain.h. This was introduced in http://trac.webkit.org/changeset/79904 (when the file was called JNIBridge.cpp) 366988 1 85675 steveblock 2011-03-14 08:10:34 -0700 Created attachment 85675 Patch 367002 2 85675 oliver 2011-03-14 08:43:52 -0700 Comment on attachment 85675 Patch r=me 367051 3 85675 commit-queue 2011-03-14 10:39:36 -0700 Comment on attachment 85675 Patch Clearing flags on attachment: 85675 Committed r81036: <http://trac.webkit.org/changeset/81036> 367052 4 commit-queue 2011-03-14 10:39:40 -0700 All reviewed patches have been landed. Closing bug. 85675 2011-03-14 08:10:34 -0700 2011-03-14 10:39:36 -0700 Patch bug-56306-20110314151032.patch text/plain 1635 steveblock U3VidmVyc2lvbiBSZXZpc2lvbjogODEwMjAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBkYmMyODI3NmE2NWZhYTI5 OTkwNTUyYWMwOTk1MmMwMjI5OTY3ODcxLi4wYmI3Y2U5MjRlNDU1MjkwOTMwMTlhZTVmMGI5NTE0 MTRhZTI1NDQ2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDMtMTQgIFN0ZXZl IEJsb2NrICA8c3RldmVibG9ja0Bnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEphdmFNZXRob2QuY3BwIGRvZXMgbm90IGNvbXBpbGUg d2l0aCBWOAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NTYzMDYKKworICAgICAgICBNb3ZlZCB0aGUgU2NvcGVDaGFpbi5oIGluY2x1ZGUgdG8gSmF2YVN0 cmluZ0pTQy4KKworICAgICAgICBObyBuZXcgdGVzdHMsIGJ1aWxkIGZpeCBvbmx5LgorCisgICAg ICAgICogYnJpZGdlL2puaS9KYXZhTWV0aG9kLmNwcDoKKyAgICAgICAgKiBicmlkZ2Uvam5pL2pz Yy9KYXZhU3RyaW5nSlNDLmgKKwogMjAxMS0wMy0xMSAgUGF2ZWwgUG9kaXZpbG92ICA8cG9kaXZp bG92QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBQYXZlbCBGZWxkbWFuLgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYnJpZGdlL2puaS9KYXZhTWV0aG9kLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL2JyaWRnZS9qbmkvSmF2YU1ldGhvZC5jcHAKaW5kZXggZjUzZjI4MTZhMGU3 ZDc4YTY4YTU3NDBjOWQzZmU3MGM0YjBlZmY0ZS4uNWNjYjA4OTY2MGU3ZGY5ZDBiMjY1MDM2YjUy ZmViZTczOWY1NmMxNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYnJpZGdlL2puaS9KYXZh TWV0aG9kLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9icmlkZ2Uvam5pL0phdmFNZXRob2QuY3Bw CkBAIC0zMSw3ICszMSw2IEBACiAKICNpbmNsdWRlICJKYXZhU3RyaW5nLmgiCiAKLSNpbmNsdWRl IDxydW50aW1lL1Njb3BlQ2hhaW4uaD4KICNpbmNsdWRlIDx3dGYvdGV4dC9TdHJpbmdCdWlsZGVy Lmg+CiAKIHVzaW5nIG5hbWVzcGFjZSBKU0M7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9i cmlkZ2Uvam5pL2pzYy9KYXZhU3RyaW5nSlNDLmggYi9Tb3VyY2UvV2ViQ29yZS9icmlkZ2Uvam5p L2pzYy9KYXZhU3RyaW5nSlNDLmgKaW5kZXggM2NlN2ExNmI2N2MyY2RlNTlmY2FiNzg2NWU4Y2Qw MTZlZTg0ZmRiMC4uN2MxOWQ0ZWI4MTRhMTlhYTViMWM4NDRlYWJlNWQ2YTdmODE3MGY5MiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYnJpZGdlL2puaS9qc2MvSmF2YVN0cmluZ0pTQy5oCisr KyBiL1NvdXJjZS9XZWJDb3JlL2JyaWRnZS9qbmkvanNjL0phdmFTdHJpbmdKU0MuaApAQCAtMjgs NyArMjgsOSBAQAogCiAjaW5jbHVkZSAiSk5JVXRpbGl0eS5oIgogI2luY2x1ZGUgIkphdmFJbnN0 YW5jZUpTQy5oIgorCiAjaW5jbHVkZSA8cnVudGltZS9KU0xvY2suaD4KKyNpbmNsdWRlIDxydW50 aW1lL1Njb3BlQ2hhaW4uaD4KIAogCiBuYW1lc3BhY2UgSlNDIHsK