56304 2011-03-14 05:14:19 -0700 REGRESSION(r80892): 100,000+ leaks seen on the build bot 2011-03-14 13:41:17 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r81011%20(15552)/ P2 Normal --- 1 mrowe webkit-unassigned adauria barraclough beidson ggaren levin oliver oldest_to_newest 366938 0 mrowe 2011-03-14 05:14:19 -0700 After r80892 there are over 100,000 leaks reported on the leaks bot. Prior to that revision the number was much, much smaller. 366939 1 mrowe 2011-03-14 05:15:50 -0700 The reason for this is that r80892 adds duplicate static function entries to the JSClassDefinition in DumpRenderTree’s LayoutTestController.cpp. This appears to cause JavaScriptCore to leak each of the duplicates. This is triggered every time the window object is cleared (once per frame per test?). 366943 2 85668 mrowe 2011-03-14 05:24:31 -0700 Created attachment 85668 Patch The explicit calls to StringImpl::ref seem as though they will also result in leaks as there are no matching calls to StringImpl::deref anywhere. The patch removes those as well as fixing the bigger issue of the leaked duplicate entries. 367187 3 mrowe 2011-03-14 13:41:17 -0700 Fixed in r81051. 85668 2011-03-14 05:24:31 -0700 2011-03-14 08:00:32 -0700 Patch 0001-http-webkit.org-b-56304-REGRESSION-r80892-100-000-le.patch text/plain 5367 mrowe RnJvbSBmYTBlNDUwNjVhNGQ3ZGYwNDY4MTI5NjdkNmYwMGUwZTFkZDI1ZjE4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJrIFJvd2UgPG1yb3dlQGFwcGxlLmNvbT4KRGF0ZTogTW9u LCAxNCBNYXIgMjAxMSAwNToyMjowMiAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIDxodHRwOi8vd2Vi a2l0Lm9yZy9iLzU2MzA0PiBSRUdSRVNTSU9OKHI4MDg5Mik6IDEwMCwwMDArIGxlYWtzIHNlZW4g b24gdGhlIGJ1aWxkIGJvdAoKUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgpTb3VyY2UvSmF2 YVNjcmlwdENvcmU6CgoqIEFQSS9KU0NsYXNzUmVmLmNwcDoKKE9wYXF1ZUpTQ2xhc3M6Ok9wYXF1 ZUpTQ2xhc3MpOiBEb24ndCBsZWFrIGFueSBleGlzdGluZyBlbnRyeSBmb3IgdGhlIGdpdmVuIG5h bWUgaWYKdGhlIGNsYXNzIGRlZmluaXRpb24gY29udGFpbnMgZHVwbGljYXRlcy4gVGhpcyBhbHNv IHJlbW92ZXMgd2hhdCBsb29rIHRvIGJlIGxlYWtzCm9mIHRoZSBTdHJpbmdJbXBsIGluc3RhbmNl cyB0aGF0IGFyZSB1c2VkIGFzIGtleXM6IHRoZSBIYXNoTWFwIGtleSB0eXBlIGlzIGEgUmVmUHRy CndoaWNoIHJldGFpbnMgLyByZWxlYXNlcyB0aGUgaW5zdGFuY2VzIGF0IHRoZSBhcHByb3ByaWF0 ZSB0aW1lLCBzbyBleHBsaWNpdGx5IGNhbGxpbmcKcmVmIGlzIG5vdCBuZWNlc3NhcnkuCgpUb29s czoKCiogRHVtcFJlbmRlclRyZWUvTGF5b3V0VGVzdENvbnRyb2xsZXIuY3BwOgooTGF5b3V0VGVz dENvbnRyb2xsZXI6OnN0YXRpY0Z1bmN0aW9ucyk6IFJlbW92ZSBkdXBsaWNhdGUgZW50cmllcy4K LS0tCiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL0pTQ2xhc3NSZWYuY3BwICAgICAgfCAgIDEw ICsrKysrKy0tLS0KIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAg ICB8ICAgMTMgKysrKysrKysrKysrKwogVG9vbHMvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIHwgICAgOSArKysrKysrKysKIFRvb2xzL0R1bXBSZW5kZXJUcmVlL0xheW91 dFRlc3RDb250cm9sbGVyLmNwcCB8ICAgIDIgLS0KIDQgZmlsZXMgY2hhbmdlZCwgMjggaW5zZXJ0 aW9ucygrKSwgNiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQVBJL0pTQ2xhc3NSZWYuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9KU0NsYXNz UmVmLmNwcAppbmRleCBkOTUzZGNlLi43MDY2OGJkIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvQVBJL0pTQ2xhc3NSZWYuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9B UEkvSlNDbGFzc1JlZi5jcHAKQEAgLTg0LDggKzg0LDkgQEAgT3BhcXVlSlNDbGFzczo6T3BhcXVl SlNDbGFzcyhjb25zdCBKU0NsYXNzRGVmaW5pdGlvbiogZGVmaW5pdGlvbiwgT3BhcXVlSlNDbGFz cyoKICAgICAgICAgICAgICAgICAvLyBVc2UgYSBsb2NhbCB2YXJpYWJsZSBoZXJlIHRvIHNpZGVz dGVwIGFuIFJWQ1QgY29tcGlsZXIgYnVnLgogICAgICAgICAgICAgICAgIFN0YXRpY1ZhbHVlRW50 cnkqIGVudHJ5ID0gbmV3IFN0YXRpY1ZhbHVlRW50cnkoc3RhdGljVmFsdWUtPmdldFByb3BlcnR5 LCBzdGF0aWNWYWx1ZS0+c2V0UHJvcGVydHksIHN0YXRpY1ZhbHVlLT5hdHRyaWJ1dGVzKTsKICAg ICAgICAgICAgICAgICBTdHJpbmdJbXBsKiBpbXBsID0gdmFsdWVOYW1lLmltcGwoKTsKLSAgICAg ICAgICAgICAgICBpbXBsLT5yZWYoKTsKLSAgICAgICAgICAgICAgICBtX3N0YXRpY1ZhbHVlcy0+ YWRkKGltcGwsIGVudHJ5KTsKKyAgICAgICAgICAgICAgICBTdGF0aWNWYWx1ZUVudHJ5KiBleGlz dGluZ0VudHJ5ID0gbV9zdGF0aWNWYWx1ZXMtPmdldChpbXBsKTsKKyAgICAgICAgICAgICAgICBt X3N0YXRpY1ZhbHVlcy0+c2V0KGltcGwsIGVudHJ5KTsKKyAgICAgICAgICAgICAgICBkZWxldGUg ZXhpc3RpbmdFbnRyeTsKICAgICAgICAgICAgIH0KICAgICAgICAgICAgICsrc3RhdGljVmFsdWU7 CiAgICAgICAgIH0KQEAgLTk5LDggKzEwMCw5IEBAIE9wYXF1ZUpTQ2xhc3M6Ok9wYXF1ZUpTQ2xh c3MoY29uc3QgSlNDbGFzc0RlZmluaXRpb24qIGRlZmluaXRpb24sIE9wYXF1ZUpTQ2xhc3MqCiAg ICAgICAgICAgICAgICAgLy8gVXNlIGEgbG9jYWwgdmFyaWFibGUgaGVyZSB0byBzaWRlc3RlcCBh biBSVkNUIGNvbXBpbGVyIGJ1Zy4KICAgICAgICAgICAgICAgICBTdGF0aWNGdW5jdGlvbkVudHJ5 KiBlbnRyeSA9IG5ldyBTdGF0aWNGdW5jdGlvbkVudHJ5KHN0YXRpY0Z1bmN0aW9uLT5jYWxsQXNG dW5jdGlvbiwgc3RhdGljRnVuY3Rpb24tPmF0dHJpYnV0ZXMpOwogICAgICAgICAgICAgICAgIFN0 cmluZ0ltcGwqIGltcGwgPSBmdW5jdGlvbk5hbWUuaW1wbCgpOwotICAgICAgICAgICAgICAgIGlt cGwtPnJlZigpOwotICAgICAgICAgICAgICAgIG1fc3RhdGljRnVuY3Rpb25zLT5hZGQoaW1wbCwg ZW50cnkpOworICAgICAgICAgICAgICAgIFN0YXRpY0Z1bmN0aW9uRW50cnkqIGV4aXN0aW5nRW50 cnkgPSBtX3N0YXRpY0Z1bmN0aW9ucy0+Z2V0KGltcGwpOworICAgICAgICAgICAgICAgIG1fc3Rh dGljRnVuY3Rpb25zLT5zZXQoaW1wbCwgZW50cnkpOworICAgICAgICAgICAgICAgIGRlbGV0ZSBl eGlzdGluZ0VudHJ5OwogICAgICAgICAgICAgfQogICAgICAgICAgICAgKytzdGF0aWNGdW5jdGlv bjsKICAgICAgICAgfQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxv ZyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKaW5kZXggYzI0ZDM2Zi4uNDY3Zjg5 MiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysgYi9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDMtMTQg IE1hcmsgUm93ZSAgPG1yb3dlQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICA8aHR0cDovL3dlYmtpdC5vcmcvYi81NjMwND4gUkVHUkVT U0lPTihyODA4OTIpOiAxMDAsMDAwKyBsZWFrcyBzZWVuIG9uIHRoZSBidWlsZCBib3QKKworICAg ICAgICAqIEFQSS9KU0NsYXNzUmVmLmNwcDoKKyAgICAgICAgKE9wYXF1ZUpTQ2xhc3M6Ok9wYXF1 ZUpTQ2xhc3MpOiBEb24ndCBsZWFrIGFueSBleGlzdGluZyBlbnRyeSBmb3IgdGhlIGdpdmVuIG5h bWUgaWYKKyAgICAgICAgdGhlIGNsYXNzIGRlZmluaXRpb24gY29udGFpbnMgZHVwbGljYXRlcy4g VGhpcyBhbHNvIHJlbW92ZXMgd2hhdCBsb29rIHRvIGJlIGxlYWtzCisgICAgICAgIG9mIHRoZSBT dHJpbmdJbXBsIGluc3RhbmNlcyB0aGF0IGFyZSB1c2VkIGFzIGtleXM6IHRoZSBIYXNoTWFwIGtl eSB0eXBlIGlzIGEgUmVmUHRyCisgICAgICAgIHdoaWNoIHJldGFpbnMgLyByZWxlYXNlcyB0aGUg aW5zdGFuY2VzIGF0IHRoZSBhcHByb3ByaWF0ZSB0aW1lLCBzbyBleHBsaWNpdGx5IGNhbGxpbmcK KyAgICAgICAgcmVmIGlzIG5vdCBuZWNlc3NhcnkuCisKIDIwMTEtMDMtMTMgIEdlb2ZmcmV5IEdh cmVuICA8Z2dhcmVuQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTYW0gV2Vpbmln LgpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IDE5 NDEwMGYuLjRmNThjMzcgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9D aGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxMS0wMy0xNCAgTWFyayBSb3dlICA8bXJvd2VA YXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIDxodHRwOi8vd2Via2l0Lm9yZy9iLzU2MzA0PiBSRUdSRVNTSU9OKHI4MDg5Mik6IDEwMCww MDArIGxlYWtzIHNlZW4gb24gdGhlIGJ1aWxkIGJvdAorCisgICAgICAgICogRHVtcFJlbmRlclRy ZWUvTGF5b3V0VGVzdENvbnRyb2xsZXIuY3BwOgorICAgICAgICAoTGF5b3V0VGVzdENvbnRyb2xs ZXI6OnN0YXRpY0Z1bmN0aW9ucyk6IFJlbW92ZSBkdXBsaWNhdGUgZW50cmllcy4KKwogMjAxMS0w My0xMyAgSm9lIFdpbGQgIDxqb3NlcGgud2lsZEBub2tpYS5jb20+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgS2VubmV0aCBSb2hkZSBDaHJpc3RpYW5zZW4uCmRpZmYgLS1naXQgYS9Ub29scy9EdW1w UmVuZGVyVHJlZS9MYXlvdXRUZXN0Q29udHJvbGxlci5jcHAgYi9Ub29scy9EdW1wUmVuZGVyVHJl ZS9MYXlvdXRUZXN0Q29udHJvbGxlci5jcHAKaW5kZXggMDc3YTBkMi4uMTZjNjYzNiAxMDA2NDQK LS0tIGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvTGF5b3V0VGVzdENvbnRyb2xsZXIuY3BwCisrKyBi L1Rvb2xzL0R1bXBSZW5kZXJUcmVlL0xheW91dFRlc3RDb250cm9sbGVyLmNwcApAQCAtMjIyMiw4 ICsyMjIyLDYgQEAgSlNTdGF0aWNGdW5jdGlvbiogTGF5b3V0VGVzdENvbnRyb2xsZXI6OnN0YXRp Y0Z1bmN0aW9ucygpCiAgICAgICAgIHsgIm9ic2VydmVTdG9yYWdlVHJhY2tlck5vdGlmaWNhdGlv bnMiLCBvYnNlcnZlU3RvcmFnZVRyYWNrZXJOb3RpZmljYXRpb25zQ2FsbGJhY2ssIGtKU1Byb3Bl cnR5QXR0cmlidXRlUmVhZE9ubHkgfCBrSlNQcm9wZXJ0eUF0dHJpYnV0ZURvbnREZWxldGUgfSwg ICAgICAgIAogICAgICAgICB7ICJkZWxldGVMb2NhbFN0b3JhZ2VGb3JPcmlnaW4iLCBkZWxldGVM b2NhbFN0b3JhZ2VGb3JPcmlnaW5DYWxsYmFjaywga0pTUHJvcGVydHlBdHRyaWJ1dGVSZWFkT25s eSB8IGtKU1Byb3BlcnR5QXR0cmlidXRlRG9udERlbGV0ZSB9LAogICAgICAgICB7ICJvcmlnaW5z V2l0aExvY2FsU3RvcmFnZSIsIG9yaWdpbnNXaXRoTG9jYWxTdG9yYWdlQ2FsbGJhY2ssIGtKU1By b3BlcnR5QXR0cmlidXRlUmVhZE9ubHkgfCBrSlNQcm9wZXJ0eUF0dHJpYnV0ZURvbnREZWxldGUg fSwKLSAgICAgICAgeyAib2JzZXJ2ZVN0b3JhZ2VUcmFja2VyTm90aWZpY2F0aW9ucyIsIG9ic2Vy dmVTdG9yYWdlVHJhY2tlck5vdGlmaWNhdGlvbnNDYWxsYmFjaywga0pTUHJvcGVydHlBdHRyaWJ1 dGVSZWFkT25seSB8IGtKU1Byb3BlcnR5QXR0cmlidXRlRG9udERlbGV0ZSB9LAotICAgICAgICB7 ICJzeW5jTG9jYWxTdG9yYWdlIiwgc3luY0xvY2FsU3RvcmFnZUNhbGxiYWNrLCBrSlNQcm9wZXJ0 eUF0dHJpYnV0ZVJlYWRPbmx5IHwga0pTUHJvcGVydHlBdHRyaWJ1dGVEb250RGVsZXRlIH0sCiAg ICAgICAgIHsgInNldFNob3VsZFBhaW50QnJva2VuSW1hZ2UiLCBzZXRTaG91bGRQYWludEJyb2tl bkltYWdlQ2FsbGJhY2ssIGtKU1Byb3BlcnR5QXR0cmlidXRlUmVhZE9ubHkgfCBrSlNQcm9wZXJ0 eUF0dHJpYnV0ZURvbnREZWxldGUgfSwKICAgICAgICAgeyAwLCAwLCAwIH0KICAgICB9OwotLSAK MS43LjQuMQoK