56303 2011-03-14 04:40:54 -0700 REGRESSION(r80892): Use of uninitialized variable "m_syncCloseDatabase" in StorageAreaSync::sync. 2011-03-14 10:47:00 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 51878 1 levin adauria beidson levin oldest_to_newest 366932 0 levin 2011-03-14 04:40:54 -0700 I suspect that m_syncCloseDatabase just needs to be initialized in the constructor to false. Right now it is only set to a value in StorageAreaSync::sync (after the if) and in StorageAreaSync::scheduleCloseDatabase. More details Here's the valgrind error (from http://build.chromium.org/p/chromium.memory/builders/Linux%20Tests%20%28valgrind%29%283%29/builds/1852/steps/memory%20test%3A%20ui_1/logs/stdio): Conditional jump or move depends on uninitialised value(s) WebCore::StorageAreaSync::sync(bool, WTF::HashMap<WTF::String, WTF::String, WTF::StringHash, WTF::HashTraits<WTF::String>, WTF::HashTraits<WTF::String> > const&) (uilder/build/src/third_party/WebKit/Source/WebCore/storage/StorageAreaSync.cpp:351) WebCore::StorageAreaSync::performSync() (uilder/build/src/third_party/WebKit/Source/WebCore/storage/StorageAreaSync.cpp:425) WebCore::LocalStorageTask::performTask() (uilder/build/src/third_party/WebKit/Source/WebCore/storage/LocalStorageTask.cpp:87) WebCore::LocalStorageThread::threadEntryPoint() (uilder/build/src/third_party/WebKit/Source/WebCore/storage/LocalStorageThread.cpp:69) WebCore::LocalStorageThread::threadEntryPointCallback(void*) (uilder/build/src/third_party/WebKit/Source/WebCore/storage/LocalStorageThread.cpp:62) WTF::threadEntryPoint(void*) (uilder/build/src/third_party/WebKit/Source/JavaScriptCore/wtf/Threading.cpp:67) start_thread (/lib/tls/i686/cmov/libpthread-2.7.so) 367046 1 85690 adauria 2011-03-14 10:34:24 -0700 Created attachment 85690 Patch 367048 2 85690 levin 2011-03-14 10:35:48 -0700 Comment on attachment 85690 Patch Actually I'll land this. 367059 3 levin 2011-03-14 10:47:00 -0700 Committed as http://trac.webkit.org/changeset/81037 85690 2011-03-14 10:34:24 -0700 2011-03-14 10:35:48 -0700 Patch bug-56303-20110314103423.patch text/plain 1221 adauria SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDgxMDM0KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDMtMTQgIEFudG9uIEQn QXVyaWEgIDxhZGF1cmlhQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBSRUdSRVNTSU9OKHI4MDg5Mik6IFVzZSBvZiB1bmluaXRpYWxp emVkIHZhcmlhYmxlICJtX3N5bmNDbG9zZURhdGFiYXNlIiBpbiBTdG9yYWdlQXJlYVN5bmM6OnN5 bmMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU2MzAz CisKKyAgICAgICAgSW5pdGlhbGl6ZWQgbV9zeW5jQ2xvc2VEYXRhYmFzZSB0byBmYWxzZSBpbiB0 aGUgU3RvcmFnZUFyZWFTeW5jIGNvbnN0cnVjdG9yLgorCisgICAgICAgICogc3RvcmFnZS9TdG9y YWdlQXJlYVN5bmMuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U3RvcmFnZUFyZWFTeW5jOjpTdG9y YWdlQXJlYVN5bmMpOgorCiAyMDExLTAzLTE0ICBCcmFkeSBFaWRzb24gIDxiZWlkc29uQGFwcGxl LmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTYW0gV2VpbmlnLgpJbmRleDogU291cmNlL1dl YkNvcmUvc3RvcmFnZS9TdG9yYWdlQXJlYVN5bmMuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJDb3JlL3N0b3JhZ2UvU3RvcmFnZUFyZWFTeW5jLmNwcAkocmV2aXNpb24gODEwMzQpCisrKyBT b3VyY2UvV2ViQ29yZS9zdG9yYWdlL1N0b3JhZ2VBcmVhU3luYy5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTYxLDYgKzYxLDcgQEAgaW5saW5lIFN0b3JhZ2VBcmVhU3luYzo6U3RvcmFnZUFyZWFTeW5j KAogICAgICwgbV9zeW5jU2NoZWR1bGVkKGZhbHNlKQogICAgICwgbV9zeW5jSW5Qcm9ncmVzcyhm YWxzZSkKICAgICAsIG1fZGF0YWJhc2VPcGVuRmFpbGVkKGZhbHNlKQorICAgICwgbV9zeW5jQ2xv c2VEYXRhYmFzZShmYWxzZSkKICAgICAsIG1faW1wb3J0Q29tcGxldGUoZmFsc2UpCiB7CiAgICAg QVNTRVJUKGlzTWFpblRocmVhZCgpKTsK