5626 2005-11-04 09:33:06 -0800 REGRESSION: float element with bottom padding and negative margin overlaps subsequent elements 2011-03-12 23:50:26 -0800 1 1 1 Unclassified WebKit CSS 420+ Mac OS X 10.4 RESOLVED FIXED http://xkr.us/bugs/safari-05-002.html P1 Normal --- 4223 1 bfults hyatt hyatt mathias oldest_to_newest 23719 0 bfults 2005-11-04 09:33:06 -0800 See the testcase URL: http://xkr.us/bugs/safari-05-002.html 23720 1 4594 bfults 2005-11-04 09:35:58 -0800 Created attachment 4594 Reduced testcase 23721 2 4595 dan 2005-11-04 09:43:55 -0800 Created attachment 4595 Reduced Testcase/variation The bug is arising because floating elements with a specific size (including padding) are not constrained by their enclosing elements even if overflow: hidden; is set. The object is constrained visually, but the layout still considers the box to be there for the purposes of user input, and as such, it captures clicks, preventing them from being passed to the elements 'below'. In this testcase, an onclick event was added to the inner div. When the input is clicked on, the onclick event in the inner div fires instead. 23734 3 4599 hyatt 2005-11-04 12:50:13 -0800 Created attachment 4599 Patch that fixes the ghosted float problem This patch makes sure floatRect will just return the border box if an overflow clip is in effect. It also further optimizes event handling and painting by making sure that phases other than the float phase don't even need to check floats (and can possibly short circuit much earlier as a result). 23735 4 hyatt 2005-11-04 12:52:03 -0800 This is a regression from Safari 1.2. 23739 5 hyatt 2005-11-04 13:12:24 -0800 Fixed. 23761 6 4599 darin 2005-11-05 08:06:51 -0800 Comment on attachment 4599 Patch that fixes the ghosted float problem Dave already landed this. 23844 7 dan 2005-11-09 07:07:30 -0800 *** Bug 3254 has been marked as a duplicate of this bug. *** 4594 2005-11-04 09:35:58 -0800 2005-11-04 12:53:07 -0800 Reduced testcase safari-05-002.html text/html 1970 bfults 77u/PCFET0NUWVBFIGh0bWwgUFVCTElDICItLy9XM0MvL0RURCBYSFRNTCAxLjAgU3RyaWN0Ly9F TiIKCSJodHRwOi8vd3d3LnczLm9yZy9UUi94aHRtbDEvRFREL3hodG1sMS1zdHJpY3QuZHRkIj4K PGh0bWwgeG1sbnM9Imh0dHA6Ly93d3cudzMub3JnLzE5OTkveGh0bWwiIHhtbDpsYW5nPSJlbiIg bGFuZz0iZW4iPgo8aGVhZD4KCTxtZXRhIGh0dHAtZXF1aXY9ImNvbnRlbnQtdHlwZSIgY29udGVu dD0idGV4dC9odG1sO2NoYXJzZXQ9dXRmLTgiIC8+Cgk8dGl0bGU+c2FmYXJpLTA1LTAwMjogR2hv c3RlZCBmbG9hdCBlbGVtZW50IG92ZXJsYXBzIHN1YnNlcXVlbnQgZWxlbWVudHM8L3RpdGxlPgoJ PHN0eWxlIHR5cGU9InRleHQvY3NzIj4KCS8qIFVubmVjZXNzYXJ5ICovCglib2R5IHsgbWFyZ2lu OiAwOyBwYWRkaW5nOiAxZW0gfQoJZGl2I3RhbGxndXkgeyBiYWNrZ3JvdW5kLWNvbG9yOiAjRDlE OUZGIH0KCWlucHV0IHsgd2lkdGg6IDUwJSB9CgoJLyogTmVjZXNzYXJ5ICovCglkaXYjd3JhcHBl ciB7CgkJb3ZlcmZsb3c6IGhpZGRlbgoJfQoKCWRpdiN0YWxsZ3V5IHsKCQltYXJnaW4tYm90dG9t OiAtNzgwcHg7CgkJcGFkZGluZy1ib3R0b206IDgwMHB4OwoJCWZsb2F0OmxlZnQ7Cgl9CgoJPC9z dHlsZT4KPC9oZWFkPgo8Ym9keT4KCjxoMT5zYWZhcmktMDUtMDAyIC0gU2FmYXJpIEJ1ZzogR2hv c3RlZCBmbG9hdCBlbGVtZW50IG92ZXJsYXBzIHN1YnNlcXVlbnQKZWxlbWVudHM8L2gxPgo8aDI+ UmVwb3J0ZWQ6IDIwMDQtMTEtMDQuIENvbmZpcm1lZCBPbjogU2FmYXJpIFRvVCAoTmlnaHRseSkg MjAwNS0xMS0wMi48L2gyPgoKPGgyPkNyZWRpdDwvaDI+CjxwPlRoaXMgYnVnIHdhcyBtZW50aW9u ZWQgaW4gQWxleCBSb2JpbnNvbidzCjxhIGhyZWY9Imh0dHA6Ly9wb3NpdGlvbmlzZXZlcnl0aGlu Zy5uZXQvYXJ0aWNsZXMvb25ldHJ1ZWxheW91dC9lcXVhbGhlaWdodCI+IkluClNlYXJjaCBvZiBU aGUgT25lIFRydWUgTGF5b3V0IiBhcnRpY2xlPC9hPi48L3A+Cgo8aDI+U3RlcHMgdG8gUmVwcm9k dWNlPC9oMj4KPHA+VmlldyB0aGUgQ1NTIG9uIHRoaXMgcGFnZSByZXF1aXJlZCBmb3IgdGhlIHRl c3RjYXNlLjwvcD4KCjxoMj5PYnNlcnZlZCBSZXN1bHRzPC9oMj4KPHA+VHJ5IGNsaWNraW5nIG9u IGFueSBvZiB0aGUgZm9ybSBlbGVtZW50cyB0aGF0IGV4aXN0IGRpcmVjdGx5IGJlbG93IHRoZSAi dGFsbApndXkiIGVsZW1lbnQuIE5vdGljZSB0aGF0IHlvdSBjYW4ndCBjbGljayBvciBzZWxlY3Qg YW55dGhpbmcgZGlyZWN0bHkgYmVsb3cKdGhhdCBlbGVtZW50LCBidXQgY2FuIG91dHNpZGUgb2Yg aXRzICJzaGFkb3ciICh0byB0aGUgcmlnaHQpLjwvcD4KCjxoMj5FeHBlY3RlZCBSZXN1bHRzPC9o Mj4KPHA+VGhlICN0YWxsZ3V5IGRpdiBzaG91bGQgbm90IGFmZmVjdCB0aGUgdXNhYmlsaXR5IG9m IGVsZW1lbnRzIGJlbG93IGl0LjwvcD4KCjxoMj5UZXN0IENhc2U8L2gyPgoKPGRpdiBpZD0id3Jh cHBlciI+Cgk8ZGl2IGlkPSJ0YWxsZ3V5Ij5JJ20gdGhlIHRhbGwgZ3V5LiBDbGljayB1bmRlciBt ZS48L2Rpdj4KPC9kaXY+Cgo8ZGl2IGlkPSJmb3Jtd3JhcCI+Cgk8Zm9ybSBhY3Rpb249ImR1bXAu cGhwIiBtZXRob2Q9InBvc3QiPgoJCTxwPgoJCQk8aW5wdXQgdHlwZT0idGV4dCIgbmFtZT0iZmll bGRfMCIgdmFsdWU9InNvbWUgaW5wdXQiIC8+CgkJPC9wPgoJCTxwPgoJCQk8c2VsZWN0IG5hbWU9 ImZpZWxkXzEiPgoJCQkJPG9wdGlvbiB2YWx1ZT0ib3B0aW9uXzAiPm9wdGlvbiAwPC9vcHRpb24+ CgkJCQk8b3B0aW9uIHZhbHVlPSJvcHRpb25fMSI+b3B0aW9uIDE8L29wdGlvbj4KCQkJCTxvcHRp b24gdmFsdWU9Im9wdGlvbl8yIj5vcHRpb24gMjwvb3B0aW9uPgoJCQk8L3NlbGVjdD4KCQk8L3A+ CgkJPHA+CgkJCTxpbnB1dCB0eXBlPSJzdWJtaXQiIHZhbHVlPSJTdWJtaXQiIC8+CgkJPC9wPgoJ PC9mb3JtPgo8L2Rpdj4KCjwvYm9keT4KPC9odG1sPgo= 4595 2005-11-04 09:43:55 -0800 2005-11-04 09:43:55 -0800 Reduced Testcase/variation Tallguy Overlap Testcase.html text/html 802 dan 77u/PCFET0NUWVBFIGh0bWwgUFVCTElDICItLy9XM0MvL0RURCBYSFRNTCAxLjAgU3RyaWN0Ly9F TiIKCSJodHRwOi8vd3d3LnczLm9yZy9UUi94aHRtbDEvRFREL3hodG1sMS1zdHJpY3QuZHRkIj4K PGh0bWwgeG1sbnM9Imh0dHA6Ly93d3cudzMub3JnLzE5OTkveGh0bWwiIHhtbDpsYW5nPSJlbiIg bGFuZz0iZW4iPgo8aGVhZD4KCTx0aXRsZT5zYWZhcmktMDUtMDAyOiBHaG9zdGVkIGZsb2F0IGVs ZW1lbnQgb3ZlcmxhcHMgc3Vic2VxdWVudCBlbGVtZW50czwvdGl0bGU+CgkKCTxzdHlsZSB0eXBl PSJ0ZXh0L2NzcyI+CgkvKiBOZWNlc3NhcnkgKi8KCWRpdiN3cmFwcGVyIHsKCQlvdmVyZmxvdzog aGlkZGVuOwoJCWJvcmRlcjogMXB4IHNvbGlkIHJlZDsKCQloZWlnaHQ6IDFlbTsKCX0KCglkaXYj dGFsbGd1eSB7CiAgICAgICAgaGVpZ2h0OiA4MDBweDsKCQlmbG9hdDpsZWZ0OwoJCWJhY2tncm91 bmQtY29sb3I6ICNEOUQ5RkY7Cgl9CgoJPC9zdHlsZT4KPC9oZWFkPgo8Ym9keT4KCjxoMj5UZXN0 IENhc2U8L2gyPgoKPGRpdiBpZD0id3JhcHBlciI+Cgk8ZGl2IGlkPSJ0YWxsZ3V5IiBvbmNsaWNr PSJ0aGlzLnN0eWxlLmJhY2tncm91bmRDb2xvcj0nYmx1ZSciPkknbSB0aGUgdGFsbCBndXkuIENs aWNrIHVuZGVyIG1lIHRvIG1ha2UgbWUgYmx1ZS48L2Rpdj4KPC9kaXY+Cgo8ZGl2IGlkPSJmb3Jt d3JhcCI+Cgk8Zm9ybSBhY3Rpb249ImR1bXAucGhwIiBtZXRob2Q9InBvc3QiPgoJCTxwPgoJCQk8 aW5wdXQgdHlwZT0idGV4dCIgLz4KCQk8L3A+Cgk8L2Zvcm0+CjwvZGl2PgoKPC9ib2R5Pgo8L2h0 bWw+Cg== 4599 2005-11-04 12:50:13 -0800 2005-11-05 08:06:51 -0800 Patch that fixes the ghosted float problem patch.txt text/plain 1537 hyatt SW5kZXg6IGtodG1sL3JlbmRlcmluZy9yZW5kZXJfYmxvY2suY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZp bGU6IC9jdnMvcm9vdC9XZWJDb3JlL2todG1sL3JlbmRlcmluZy9yZW5kZXJfYmxvY2suY3BwLHYK cmV0cmlldmluZyByZXZpc2lvbiAxLjIxMwpkaWZmIC11IC1wIC1yMS4yMTMga2h0bWwvcmVuZGVy aW5nL3JlbmRlcl9ibG9jay5jcHAKLS0tIGtodG1sL3JlbmRlcmluZy9yZW5kZXJfYmxvY2suY3Bw CTIgTm92IDIwMDUgMDg6NTI6NDUgLTAwMDAJMS4yMTMKKysrIGtodG1sL3JlbmRlcmluZy9yZW5k ZXJfYmxvY2suY3BwCTQgTm92IDIwMDUgMjA6NDg6MTUgLTAwMDAKQEAgLTEyMjMsNiArMTIyMyw4 IEBAIHZvaWQgUmVuZGVyQmxvY2s6OnBhaW50KFBhaW50SW5mbyYgaSwgaW4KICAgICAgICAgYm9v bCBpbnRlcnNlY3RzT3ZlcmZsb3dCb3ggPSBvdmVyZmxvd0JveC5pbnRlcnNlY3RzKGkucik7CiAg ICAgICAgIGlmICghaW50ZXJzZWN0c092ZXJmbG93Qm94KSB7CiAgICAgICAgICAgICAvLyBDaGVj ayBmbG9hdHMgbmV4dC4KKyAgICAgICAgICAgIGlmIChpLnBoYXNlICE9IFBhaW50QWN0aW9uRmxv YXQpCisgICAgICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICAgICAgUVJlY3QgZmxvYXRCb3gg PSBmbG9hdFJlY3QoKTsKICAgICAgICAgICAgIGZsb2F0Qm94LmluZmxhdGUobWF4aW1hbE91dGxp bmVTaXplKGkucGhhc2UpKTsKICAgICAgICAgICAgIGZsb2F0Qm94LnNldFgoZmxvYXRCb3gueCgp ICsgX3R4KTsKQEAgLTIwNDIsNyArMjA0NCw3IEBAIFJlbmRlckJsb2NrOjpmbG9hdEJvdHRvbSgp IGNvbnN0CiBRUmVjdCBSZW5kZXJCbG9jazo6ZmxvYXRSZWN0KCkgY29uc3QKIHsKICAgICBRUmVj dCByZXN1bHQoYm9yZGVyQm94KCkpOwotICAgIGlmICghbV9mbG9hdGluZ09iamVjdHMpCisgICAg aWYgKCFtX2Zsb2F0aW5nT2JqZWN0cyB8fCBoYXNPdmVyZmxvd0NsaXAoKSkKICAgICAgICAgcmV0 dXJuIHJlc3VsdDsKICAgICBGbG9hdGluZ09iamVjdCogcjsKICAgICBRUHRyTGlzdEl0ZXJhdG9y PEZsb2F0aW5nT2JqZWN0PiBpdCgqbV9mbG9hdGluZ09iamVjdHMpOwpAQCAtMjQ2Myw2ICsyNDY1 LDggQEAgYm9vbCBSZW5kZXJCbG9jazo6bm9kZUF0UG9pbnQoTm9kZUluZm8mIAogICAgICAgICBi b29sIGluc2lkZU92ZXJmbG93Qm94ID0gb3ZlcmZsb3dCb3guY29udGFpbnMoX3gsIF95KTsKICAg ICAgICAgaWYgKCFpbnNpZGVPdmVyZmxvd0JveCkgewogICAgICAgICAgICAgLy8gQ2hlY2sgZmxv YXRzIG5leHQuCisgICAgICAgICAgICBpZiAoaGl0VGVzdEFjdGlvbiAhPSBIaXRUZXN0RmxvYXQp CisgICAgICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgICAgICAgICAgUVJlY3QgZmxvYXRC b3ggPSBmbG9hdFJlY3QoKTsKICAgICAgICAgICAgIGZsb2F0Qm94LnNldFgoZmxvYXRCb3gueCgp ICsgdHgpOwogICAgICAgICAgICAgZmxvYXRCb3guc2V0WShmbG9hdEJveC55KCkgKyB0eSk7Cg==