56257 2011-03-12 17:51:36 -0800 WebCore fails to build with Clang on ARM 2011-03-12 19:33:01 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 zwarich zwarich abarth andersca eric oliver webkit.review.bot oldest_to_newest 366626 0 zwarich 2011-03-12 17:51:36 -0800 /Volumes/Data/WebKit/Source/WebCore/bindings/js/SerializedScriptValue.cpp:460:19: error: shift count >= width of type value >>= 8; ^ ~ /Volumes/Data/WebKit/Source/WebCore/bindings/js/SerializedScriptValue.cpp:221:13: note: in instantiation of function template specialization 'WebCore::CloneSerializer::writeLittleEndian<unsigned char>' requested here writeLittleEndian<uint8_t>(out, EmptyStringTag); ^ 1 error generated. We need to add an explicit specialization, since this is actually used in a lot of places. But you can't add an explicit specialization at class scope, so writeLittleEndian needs to be made a non-member function. 366627 1 85603 zwarich 2011-03-12 17:53:57 -0800 Created attachment 85603 Proposed patch 366630 2 zwarich 2011-03-12 19:19:15 -0800 Fixed in r80949. 366633 3 webkit.review.bot 2011-03-12 19:29:01 -0800 http://trac.webkit.org/changeset/80949 might have broken Qt Linux Release minimal, Qt Linux ARMv7 Release, Qt Windows 32-bit Release, Qt Windows 32-bit Debug, and EFL Linux Release (Build) 366635 4 zwarich 2011-03-12 19:33:01 -0800 Ah, the specialization should not have a static. 85603 2011-03-12 17:53:57 -0800 2011-03-12 19:10:27 -0800 Proposed patch scriptvalue-clang.patch text/plain 3723 zwarich SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA4MDk0NykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTEtMDMtMTIgIENhbWVyb24gWndhcmljaCAgPHp3YXJpY2hAYXBw bGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFdlYkNvcmUgZmFpbHMgdG8gYnVpbGQgd2l0aCBDbGFuZyBvbiBBUk0KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU2MjU3CisKKyAgICAgICAgQWRkIGFu IGV4cGxpY2l0IGluc3RhbnRpYXRpb24gb2Ygd3JpdGVMaXR0bGVFbmRpYW4gZm9yIHVpbnQ4X3Qg YW5kIG1vdmUgaXQgdG8KKyAgICAgICAgbmFtZXNwYWNlIHNjb3BlLCBzaW5jZSBleHBsaWNpdCBz cGVjaWFsaXphdGlvbnMgYXJlIG5vdCBhbGxvd2VkIGF0IGNsYXNzIHNjb3BlLgorCisgICAgICAg ICogYmluZGluZ3MvanMvU2VyaWFsaXplZFNjcmlwdFZhbHVlLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OndyaXRlTGl0dGxlRW5kaWFuKToKKwogMjAxMS0wMy0xMiAgU2hlcmlmZiBCb3QgIDx3ZWJr aXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBv dXQgcjgwOTE5LgpJbmRleDogV2ViQ29yZS9iaW5kaW5ncy9qcy9TZXJpYWxpemVkU2NyaXB0VmFs dWUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvYmluZGluZ3MvanMvU2VyaWFsaXplZFNjcmlw dFZhbHVlLmNwcAkocmV2aXNpb24gODA5NDcpCisrKyBXZWJDb3JlL2JpbmRpbmdzL2pzL1Nlcmlh bGl6ZWRTY3JpcHRWYWx1ZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTIwNiw2ICsyMDYsNDkgQEAK ICAgICBNYXJrZWRBcmd1bWVudEJ1ZmZlciBtX2djQnVmZmVyOwogfTsKIAorI2lmIEFTU1VNRV9M SVRUTEVfRU5ESUFOCit0ZW1wbGF0ZSA8dHlwZW5hbWUgVD4gc3RhdGljIHZvaWQgd3JpdGVMaXR0 bGVFbmRpYW4oVmVjdG9yPHVpbnQ4X3Q+JiBidWZmZXIsIFQgdmFsdWUpCit7CisgICAgaWYgKHNp emVvZihUKSA9PSAxKQorICAgICAgICBidWZmZXIuYXBwZW5kKHZhbHVlKTsKKyAgICBlbHNlCisg ICAgICAgIGJ1ZmZlci5hcHBlbmQocmVpbnRlcnByZXRfY2FzdDx1aW50OF90Kj4oJnZhbHVlKSwg c2l6ZW9mKHZhbHVlKSk7Cit9CisjZWxzZQordGVtcGxhdGUgPHR5cGVuYW1lIFQ+IHN0YXRpYyB2 b2lkIHdyaXRlTGl0dGxlRW5kaWFuKFZlY3Rvcjx1aW50OF90PiYgYnVmZmVyLCBUIHZhbHVlKQor eworICAgIGZvciAodW5zaWduZWQgaSA9IDA7IGkgPCBzaXplb2YoVCk7IGkrKykgeworICAgICAg ICBidWZmZXIuYXBwZW5kKHZhbHVlICYgMHhGRik7CisgICAgICAgIHZhbHVlID4+PSA4OworICAg IH0KK30KKwordGVtcGxhdGUgPD4gc3RhdGljIHZvaWQgd3JpdGVMaXR0bGVFbmRpYW48dWludDhf dD4oVmVjdG9yPHVpbnQ4X3Q+JiBidWZmZXIsIHVpbnQ4X3QgdmFsdWUpCit7CisgICAgYnVmZmVy LmFwcGVuZCh2YWx1ZSk7Cit9CisjZW5kaWYKKwordGVtcGxhdGUgPHR5cGVuYW1lIFQ+IHN0YXRp YyBib29sIHdyaXRlTGl0dGxlRW5kaWFuKFZlY3Rvcjx1aW50OF90PiYgYnVmZmVyLCBjb25zdCBU KiB2YWx1ZXMsIHVpbnQzMl90IGxlbmd0aCkKK3sKKyAgICBpZiAobGVuZ3RoID4gbnVtZXJpY19s aW1pdHM8dWludDMyX3Q+OjptYXgoKSAvIHNpemVvZihUKSkKKyAgICAgICAgcmV0dXJuIGZhbHNl OworCisjaWYgQVNTVU1FX0xJVFRMRV9FTkRJQU4KKyAgICBidWZmZXIuYXBwZW5kKHJlaW50ZXJw cmV0X2Nhc3Q8Y29uc3QgdWludDhfdCo+KHZhbHVlcyksIGxlbmd0aCAqIHNpemVvZihUKSk7Cisj ZWxzZQorICAgIGZvciAodW5zaWduZWQgaSA9IDA7IGkgPCBsZW5ndGg7IGkrKykgeworICAgICAg ICBUIHZhbHVlID0gdmFsdWVzW2ldOworICAgICAgICBmb3IgKHVuc2lnbmVkIGogPSAwOyBqIDwg c2l6ZW9mKFQpOyBqKyspIHsKKyAgICAgICAgICAgIGJ1ZmZlci5hcHBlbmQoc3RhdGljX2Nhc3Q8 dWludDhfdD4odmFsdWUgJiAweEZGKSk7CisgICAgICAgICAgICB2YWx1ZSA+Pj0gODsKKyAgICAg ICAgfQorICAgIH0KKyNlbmRpZgorICAgIHJldHVybiB0cnVlOworfQorCisKIGNsYXNzIENsb25l U2VyaWFsaXplciA6IENsb25lQmFzZSB7CiBwdWJsaWM6CiAgICAgc3RhdGljIGJvb2wgc2VyaWFs aXplKEV4ZWNTdGF0ZSogZXhlYywgSlNWYWx1ZSB2YWx1ZSwgVmVjdG9yPHVpbnQ4X3Q+JiBvdXQp CkBAIC00NDQsNDMgKzQ4Nyw2IEBACiAgICAgICAgIHdyaXRlTGl0dGxlRW5kaWFuKG1fYnVmZmVy LCBjKTsKICAgICB9CiAKLSNpZiBBU1NVTUVfTElUVExFX0VORElBTgotICAgIHRlbXBsYXRlIDx0 eXBlbmFtZSBUPiBzdGF0aWMgdm9pZCB3cml0ZUxpdHRsZUVuZGlhbihWZWN0b3I8dWludDhfdD4m IGJ1ZmZlciwgVCB2YWx1ZSkKLSAgICB7Ci0gICAgICAgIGlmIChzaXplb2YoVCkgPT0gMSkKLSAg ICAgICAgICAgIGJ1ZmZlci5hcHBlbmQodmFsdWUpOwotICAgICAgICBlbHNlCi0gICAgICAgICAg ICBidWZmZXIuYXBwZW5kKHJlaW50ZXJwcmV0X2Nhc3Q8dWludDhfdCo+KCZ2YWx1ZSksIHNpemVv Zih2YWx1ZSkpOwotICAgIH0KLSNlbHNlCi0gICAgdGVtcGxhdGUgPHR5cGVuYW1lIFQ+IHN0YXRp YyB2b2lkIHdyaXRlTGl0dGxlRW5kaWFuKFZlY3Rvcjx1aW50OF90PiYgYnVmZmVyLCBUIHZhbHVl KQotICAgIHsKLSAgICAgICAgZm9yICh1bnNpZ25lZCBpID0gMDsgaSA8IHNpemVvZihUKTsgaSsr KSB7Ci0gICAgICAgICAgICBidWZmZXIuYXBwZW5kKHZhbHVlICYgMHhGRik7Ci0gICAgICAgICAg ICB2YWx1ZSA+Pj0gODsKLSAgICAgICAgfQotICAgIH0KLSNlbmRpZgotCi0gICAgdGVtcGxhdGUg PHR5cGVuYW1lIFQ+IHN0YXRpYyBib29sIHdyaXRlTGl0dGxlRW5kaWFuKFZlY3Rvcjx1aW50OF90 PiYgYnVmZmVyLCBjb25zdCBUKiB2YWx1ZXMsIHVpbnQzMl90IGxlbmd0aCkKLSAgICB7Ci0gICAg ICAgIGlmIChsZW5ndGggPiBudW1lcmljX2xpbWl0czx1aW50MzJfdD46Om1heCgpIC8gc2l6ZW9m KFQpKQotICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwotCi0jaWYgQVNTVU1FX0xJVFRMRV9FTkRJ QU4KLSAgICAgICAgYnVmZmVyLmFwcGVuZChyZWludGVycHJldF9jYXN0PGNvbnN0IHVpbnQ4X3Qq Pih2YWx1ZXMpLCBsZW5ndGggKiBzaXplb2YoVCkpOwotI2Vsc2UKLSAgICAgICAgZm9yICh1bnNp Z25lZCBpID0gMDsgaSA8IGxlbmd0aDsgaSsrKSB7Ci0gICAgICAgICAgICBUIHZhbHVlID0gdmFs dWVzW2ldOwotICAgICAgICAgICAgZm9yICh1bnNpZ25lZCBqID0gMDsgaiA8IHNpemVvZihUKTsg aisrKSB7Ci0gICAgICAgICAgICAgICAgYnVmZmVyLmFwcGVuZChzdGF0aWNfY2FzdDx1aW50OF90 Pih2YWx1ZSAmIDB4RkYpKTsKLSAgICAgICAgICAgICAgICB2YWx1ZSA+Pj0gODsKLSAgICAgICAg ICAgIH0KLSAgICAgICAgfQotI2VuZGlmCi0gICAgICAgIHJldHVybiB0cnVlOwotICAgIH0KLQog ICAgIHZvaWQgd3JpdGUodWludDMyX3QgaSkKICAgICB7CiAgICAgICAgIHdyaXRlTGl0dGxlRW5k aWFuKG1fYnVmZmVyLCBpKTsK