56240 2011-03-11 21:04:28 -0800 Invalid assertion in StorageTracker -- PageGroup::numberOfPageGroups() == 1 2011-03-14 11:03:36 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 adauria adauria beidson commit-queue jorlow oldest_to_newest 366506 0 adauria 2011-03-11 21:04:28 -0800 LocalStorage is currently in limbo. It is accessed through separate PageGroup instances with their own StorageNamespace instances, but each PageGroup uses the same path for LocalStorage dbs. Thus, the in-memory versions of those dbs can be out of sync with the db if another PageGroup is writing to it. This has been brought up in https://bugs.webkit.org/show_bug.cgi?id=51878 LocalStorage should either be truly per-PageGroup, or global. Right now it is neither, so until this is fixed, the assertion in StorageTracker -- (PageGroup::numberOfPageGroups() == 1) -- is invalid. 366507 1 adauria 2011-03-11 21:05:56 -0800 I should have stated explicitly that "the in-memory versions of those dbs" are StorageAreas with their HashMap representations of the backing dbs. 366526 2 85572 adauria 2011-03-11 23:11:00 -0800 Created attachment 85572 Patch 366854 3 beidson 2011-03-13 23:21:15 -0700 Landed in r81002 366855 4 beidson 2011-03-13 23:21:59 -0700 We should still track actually clearing up the "am I per-pagegroup or not?" concept here. 85572 2011-03-11 23:11:00 -0800 2011-03-13 23:21:22 -0700 Patch bug-56240-20110311231058.patch text/plain 2324 adauria SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDgwOTI3KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDMtMTEgIEFudG9uIEQn QXVyaWEgIDxhZGF1cmlhQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBJbnZhbGlkIGFzc2VydGlvbiBpbiBTdG9yYWdlVHJhY2tlciAt IFBhZ2VHcm91cDo6bnVtYmVyT2ZQYWdlR3JvdXBzKCkgPT0gMQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTYyNDAKKworICAgICAgICBUaGlzIGFzc2Vy dGlvbiBpcyBpbnZhbGlkIHVudGlsIExvY2FsU3RvcmFnZSBpcyBlaXRoZXIgZ2xvYmFsIG9yIGlz IGlzb2xhdGVkIGJ5IFBhZ2VHcm91cC4KKworICAgICAgICAqIHN0b3JhZ2UvU3RvcmFnZVRyYWNr ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U3RvcmFnZVRyYWNrZXI6Om9yaWdpbnMpOgorICAg ICAgICAoV2ViQ29yZTo6U3RvcmFnZVRyYWNrZXI6OmRlbGV0ZUFsbE9yaWdpbnMpOgorICAgICAg ICAoV2ViQ29yZTo6U3RvcmFnZVRyYWNrZXI6OmRlbGV0ZU9yaWdpbik6CisKIDIwMTEtMDMtMTEg IEplciBOb2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg QW5kZXJzIENhcmxzc29uLgpJbmRleDogU291cmNlL1dlYkNvcmUvc3RvcmFnZS9TdG9yYWdlVHJh Y2tlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvc3RvcmFnZS9TdG9yYWdlVHJh Y2tlci5jcHAJKHJldmlzaW9uIDgwOTI3KQorKysgU291cmNlL1dlYkNvcmUvc3RvcmFnZS9TdG9y YWdlVHJhY2tlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI4NywxMCArMjg3LDYgQEAgdm9pZCBT dG9yYWdlVHJhY2tlcjo6b3JpZ2lucyhWZWN0b3I8UmVmUAogICAgIAogICAgIGlmICghbV9pc0Fj dGl2ZSkKICAgICAgICAgcmV0dXJuOwotICAgIAotICAgIC8vIEZJWE1FOiBTdG9yYWdlVHJhY2tl ciBpcyBjdXJyZW50bHkgYSBzaW5nbGV0b24gYW5kIHNob3VsZCBiZSBhc3N1bWVkCi0gICAgLy8g dG8gaGF2ZSB1bmRlZmluZWQgYmVoYXZpb3Igd2l0aCBtb3JlIHRoYW4gb25lIFBhZ2VHcm91cC4K LSAgICBBU1NFUlQoUGFnZUdyb3VwOjpudW1iZXJPZlBhZ2VHcm91cHMoKSA9PSAxKTsKIAogICAg IE11dGV4TG9ja2VyIGxvY2tPcmlnaW5zKG1fb3JpZ2luU2V0R3VhcmQpOwogCkBAIC0zMDcsMTAg KzMwMyw2IEBAIHZvaWQgU3RvcmFnZVRyYWNrZXI6OmRlbGV0ZUFsbE9yaWdpbnMoKQogICAgIAog ICAgIGlmICghbV9pc0FjdGl2ZSkKICAgICAgICAgcmV0dXJuOwotICAgIAotICAgIC8vIEZJWE1F OiBTdG9yYWdlVHJhY2tlciBpcyBjdXJyZW50bHkgYSBzaW5nbGV0b24gYW5kIHNob3VsZCBiZSBh c3N1bWVkCi0gICAgLy8gdG8gaGF2ZSB1bmRlZmluZWQgYmVoYXZpb3Igd2l0aCBtb3JlIHRoYW4g b25lIFBhZ2VHcm91cC4KLSAgICBBU1NFUlQoUGFnZUdyb3VwOjpudW1iZXJPZlBhZ2VHcm91cHMo KSA9PSAxKTsKIAogICAgIHsKICAgICAgICAgTXV0ZXhMb2NrZXIgbG9ja09yaWdpbnMobV9vcmln aW5TZXRHdWFyZCk7CkBAIC0zNzMsMTAgKzM2NSw2IEBAIHZvaWQgU3RvcmFnZVRyYWNrZXI6OmRl bGV0ZU9yaWdpbihTZWN1cmkKICAgICBpZiAoIW1faXNBY3RpdmUpCiAgICAgICAgIHJldHVybjsK IAotICAgIC8vIEZJWE1FOiBTdG9yYWdlVHJhY2tlciBpcyBjdXJyZW50bHkgYSBzaW5nbGV0b24g YW5kIHNob3VsZCBiZSBhc3N1bWVkCi0gICAgLy8gdG8gaGF2ZSB1bmRlZmluZWQgYmVoYXZpb3Ig d2l0aCBtb3JlIHRoYW4gb25lIFBhZ2VHcm91cC4KLSAgICBBU1NFUlQoUGFnZUdyb3VwOjpudW1i ZXJPZlBhZ2VHcm91cHMoKSA9PSAxKTsKLSAgICAKICAgICAvLyBCZWZvcmUgZGVsZXRpbmcgZGF0 YWJhc2UsIHdlIG5lZWQgdG8gY2xlYXIgaW4tbWVtb3J5IGxvY2FsIHN0b3JhZ2UgZGF0YQogICAg IC8vIGluIFN0b3JhZ2VBcmVhLCBhbmQgdG8gY2xvc2UgdGhlIFN0b3JhZ2VBcmVhIGRiLiBJdCdz IHBvc3NpYmxlIGZvciBhbgogICAgIC8vIGl0ZW0gdG8gYmUgYWRkZWQgaW1tZWRpYXRlbHkgYWZ0 ZXIgY2xvc2luZyB0aGUgZGIgYW5kIGNhdXNlIFN0b3JhZ2VBcmVhU3luYwo=