56234 2011-03-11 16:45:37 -0800 [chromium] Correct return type of WebClipboard::readImage 2011-03-11 17:08:03 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 dcheng webkit-unassigned dimich tony oldest_to_newest 366422 0 dcheng 2011-03-11 16:45:37 -0800 Change it from a WebImage to WebData to indicate that we are returning a blob of PNG data. 366424 1 85556 dcheng 2011-03-11 16:50:47 -0800 Created attachment 85556 Patch 366427 2 85556 tony 2011-03-11 16:58:11 -0800 Comment on attachment 85556 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=85556&action=review > Source/WebKit/chromium/public/WebClipboard.h:36 > #include "WebImage.h" Can we remove this? 366428 3 dimich 2011-03-11 16:58:50 -0800 (In reply to comment #2) > (From update of attachment 85556 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=85556&action=review > > > Source/WebKit/chromium/public/WebClipboard.h:36 > > #include "WebImage.h" > > Can we remove this? Should be possible, see the patch that added it: https://bugs.webkit.org/attachment.cgi?id=84843&action=prettypatch 366430 4 tony 2011-03-11 17:00:17 -0800 (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 85556 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=85556&action=review > > > > > Source/WebKit/chromium/public/WebClipboard.h:36 > > > #include "WebImage.h" > > > > Can we remove this? > > Should be possible, see the patch that added it: https://bugs.webkit.org/attachment.cgi?id=84843&action=prettypatch Looks like we'll have to forward declare WebImage because writeImage uses it, which is fine. 366431 5 dcheng 2011-03-11 17:02:39 -0800 (In reply to comment #4) > (In reply to comment #3) > > (In reply to comment #2) > > > (From update of attachment 85556 [details] [details] [details]) > > > View in context: https://bugs.webkit.org/attachment.cgi?id=85556&action=review > > > > > > > Source/WebKit/chromium/public/WebClipboard.h:36 > > > > #include "WebImage.h" > > > > > > Can we remove this? > > > > Should be possible, see the patch that added it: https://bugs.webkit.org/attachment.cgi?id=84843&action=prettypatch > > Looks like we'll have to forward declare WebImage because writeImage uses it, which is fine. I will fix this before landing. Thanks! 366436 6 dcheng 2011-03-11 17:08:03 -0800 Committed r80907: <http://trac.webkit.org/changeset/80907> 85556 2011-03-11 16:50:47 -0800 2011-03-11 16:58:11 -0800 Patch bug-56234-20110311165046.patch text/plain 1636 dcheng U3VidmVyc2lvbiBSZXZpc2lvbjogODA4OTkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg MTQ5OWVkZGFmYTg4YjhlMDFlZTE4NzM5ZWQzZGMyMDM0NjIyNjQ4MS4uZDQ1NjI5YjJjY2VhOTg2 OGU3NWFiNzZlZWMxZDJiMTY3ZWU3ZWIwNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxNiBAQAorMjAxMS0wMy0xMSAgRGFuaWVsIENoZW5nICA8ZGNoZW5nQGNocm9taXVt Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBb Y2hyb21pdW1dIENvcnJlY3QgcmV0dXJuIHR5cGUgb2YgV2ViQ2xpcGJvYXJkOjpyZWFkSW1hZ2Uu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NjIzNAor CisgICAgICAgIFVwZGF0ZSB0aGUgcmV0dXJuIHR5cGUgdG8gcmVmbGVjdCB0aGF0IHdlIGFyZSBy ZXR1cm5pbmcgYSBibG9iIG9mIFBORworICAgICAgICBkYXRhLCBub3QgYSBiaXRtYXAuCisKKyAg ICAgICAgKiBwdWJsaWMvV2ViQ2xpcGJvYXJkLmg6CisgICAgICAgIChXZWJLaXQ6OldlYkNsaXBi b2FyZDo6cmVhZEltYWdlKToKKwogMjAxMS0wMy0xMSAgQWRyaWVubmUgV2Fsa2VyICA8ZW5uZUBn b29nbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEtlbm5ldGggUnVzc2VsbC4KZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkNsaXBib2FyZC5oIGIvU291 cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViQ2xpcGJvYXJkLmgKaW5kZXggZjlhMDZjZjY2 ZGZhNjNhNTIyMTUwNWU1ODFmOTBjM2VhODFhM2JiMi4uMmY5MzFkMzQyNGZkNDgxYmVjMGFiYjRm MzM3MTk4ZTQ2YTlkOTIyZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJs aWMvV2ViQ2xpcGJvYXJkLmgKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2Vi Q2xpcGJvYXJkLmgKQEAgLTMyLDYgKzMyLDcgQEAKICNkZWZpbmUgV2ViQ2xpcGJvYXJkX2gKIAog I2luY2x1ZGUgIldlYkNvbW1vbi5oIgorI2luY2x1ZGUgIldlYkRhdGEuaCIKICNpbmNsdWRlICJX ZWJJbWFnZS5oIgogI2luY2x1ZGUgIldlYlN0cmluZy5oIgogI2luY2x1ZGUgIldlYlZlY3Rvci5o IgpAQCAtNjIsNyArNjMsNyBAQCBwdWJsaWM6CiAKICAgICB2aXJ0dWFsIFdlYlN0cmluZyByZWFk UGxhaW5UZXh0KEJ1ZmZlcikgeyByZXR1cm4gV2ViU3RyaW5nKCk7IH0KICAgICB2aXJ0dWFsIFdl YlN0cmluZyByZWFkSFRNTChCdWZmZXIsIFdlYlVSTCopIHsgcmV0dXJuIFdlYlN0cmluZygpOyB9 Ci0gICAgdmlydHVhbCBXZWJJbWFnZSByZWFkSW1hZ2UoQnVmZmVyKSB7IHJldHVybiBXZWJJbWFn ZSgpOyB9CisgICAgdmlydHVhbCBXZWJEYXRhIHJlYWRJbWFnZShCdWZmZXIpIHsgcmV0dXJuIFdl YkRhdGEoKTsgfQogCiAgICAgdmlydHVhbCB2b2lkIHdyaXRlUGxhaW5UZXh0KGNvbnN0IFdlYlN0 cmluZyYpIHsgfQogICAgIHZpcnR1YWwgdm9pZCB3cml0ZUhUTUwoCg==