56226 2011-03-11 14:48:24 -0800 WebCore::Document should notify ChromeClient when the full screen renderer's backing changes. 2011-03-11 21:29:09 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 55993 1 jer.noble jer.noble dglazkov eric gustavo.noronha gustavo webkit.review.bot xan.lopez oldest_to_newest 366330 0 jer.noble 2011-03-11 14:48:24 -0800 WebCore::Document should notify ChromeClient when the full screen renderer's backing changes. 366340 1 85541 jer.noble 2011-03-11 14:54:47 -0800 Created attachment 85541 Patch 366345 2 webkit.review.bot 2011-03-11 14:57:44 -0800 Attachment 85541 did not build on chromium: Build output: http://queues.webkit.org/results/8132409 366353 3 jer.noble 2011-03-11 15:05:54 -0800 (In reply to comment #2) > Attachment 85541 [details] did not build on chromium: > Build output: http://queues.webkit.org/results/8132409 Forgot to mark this bug as blocked by #559933, which includes the necessary changes to ChromeClient.h. 366359 4 85545 jer.noble 2011-03-11 15:10:24 -0800 Created attachment 85545 Patch 366361 5 webkit.review.bot 2011-03-11 15:14:35 -0800 Attachment 85545 did not build on chromium: Build output: http://queues.webkit.org/results/8135469 366460 6 gustavo.noronha 2011-03-11 17:44:25 -0800 Attachment 85545 did not build on gtk: Build output: http://queues.webkit.org/results/8135536 366481 7 eric 2011-03-11 19:16:06 -0800 Attachment 85545 did not build on mac: Build output: http://queues.webkit.org/results/8148516 366489 8 jer.noble 2011-03-11 20:02:35 -0800 Committed r80922: <http://trac.webkit.org/changeset/80922> 366504 9 jer.noble 2011-03-11 21:03:27 -0800 webkit-patch closed the wrong bug. This last commit belongs to #56218. 366511 10 jer.noble 2011-03-11 21:29:09 -0800 Committed r80926: <http://trac.webkit.org/changeset/80926> 85541 2011-03-11 14:54:47 -0800 2011-03-11 15:10:22 -0800 Patch bug-56226-20110311145446.patch text/plain 3563 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogODA2MjcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBkOGNlMzM3ZDliMjFmYzMy M2M3MjRhNWI1MzA2OGQ0Y2JjMWIxMmQyLi43MmYzYTNiMWYzMTM5YzA5YmJlNGRlZDk1NjhlMTE2 ZTY3NWYyYWYzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0yLDYgKzIsMjAgQEAKIAogICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KIAorICAgICAgICBXZWJDb3JlOjpEb2N1bWVudCBzaG91bGQg bm90aWZ5IENocm9tZUNsaWVudCB3aGVuIHRoZSBmdWxsIHNjcmVlbiByZW5kZXJlcidzIGJhY2tp bmcgY2hhbmdlcy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTU2MjI2CisKKyAgICAgICAgKiBkb20vRG9jdW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6RG9jdW1lbnQ6OndlYmtpdFdpbGxFbnRlckZ1bGxTY3JlZW5Gb3JFbGVtZW50KToKKyAgICAg ICAgKFdlYkNvcmU6OkRvY3VtZW50Ojp3ZWJraXREaWRFbnRlckZ1bGxTY3JlZW5Gb3JFbGVtZW50 KToKKyAgICAgICAgKFdlYkNvcmU6OkRvY3VtZW50Ojp3ZWJraXRXaWxsRXhpdEZ1bGxTY3JlZW5G b3JFbGVtZW50KToKKyAgICAgICAgKFdlYkNvcmU6OkRvY3VtZW50Ojp3ZWJraXREaWRFeGl0RnVs bFNjcmVlbkZvckVsZW1lbnQpOgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnQ6OnNldEZ1bGxT Y3JlZW5SZW5kZXJlclNpemUpOgorCisyMDExLTAzLTExICBKZXIgTm9ibGUgIDxqZXIubm9ibGVA YXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCiAgICAg ICAgIENyZWF0ZSBuZXcgaW50ZXJmYWNlIHN0dWJzIHRvIHN1cHBvcnQgZnVsbCBzY3JlZW4gbW9k ZSBpbiBXZWJLaXQyLgogCiAgICAgICAgIFdlYktpdDI6IFBsdW1iIG5ldyBmdWxsIHNjcmVlbiBh bmltYXRpb24gQVBJcyB0aHJvdWdoIFdlYktpdDIuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9kb20vRG9jdW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAppbmRl eCBmY2YxYjRkZmMxYmU0NDQ5ODNhZDAxZDI1YzAzNjc0NTk5Yjg0OTQyLi45Njg4NDBiNTZmNTQ5 OTFkZDcyY2ZlYWUzMTBjNDNmMmZhODlmZTJmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9k b20vRG9jdW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKQEAg LTEyMCw2ICsxMjAsNyBAQAogI2luY2x1ZGUgIlJlZ2lzdGVyZWRFdmVudExpc3RlbmVyLmgiCiAj aW5jbHVkZSAiUmVuZGVyQXJlbmEuaCIKICNpbmNsdWRlICJSZW5kZXJMYXllci5oIgorI2luY2x1 ZGUgIlJlbmRlckxheWVyQmFja2luZy5oIgogI2luY2x1ZGUgIlJlbmRlclRleHRDb250cm9sLmgi CiAjaW5jbHVkZSAiUmVuZGVyVmlldy5oIgogI2luY2x1ZGUgIlJlbmRlcldpZGdldC5oIgpAQCAt NDkyMSwyMyArNDkyMiwzNCBAQCB2b2lkIERvY3VtZW50Ojp3ZWJraXRXaWxsRW50ZXJGdWxsU2Ny ZWVuRm9yRWxlbWVudChFbGVtZW50KiBlbGVtZW50KQogCiAgICAgcmVjYWxjU3R5bGUoRm9yY2Up OwogICAgIAotICAgIGlmIChtX2Z1bGxTY3JlZW5SZW5kZXJlcikKKyAgICBpZiAobV9mdWxsU2Ny ZWVuUmVuZGVyZXIpIHsKICAgICAgICAgbV9mdWxsU2NyZWVuUmVuZGVyZXItPnNldEFuaW1hdGlu Zyh0cnVlKTsKKyAgICAgICAgdmlldygpLT51cGRhdGVDb21wb3NpdGluZ0xheWVycygpOworICAg ICAgICBBU1NFUlQobV9mdWxsU2NyZWVuUmVuZGVyZXItPmxheWVyKCktPmJhY2tpbmcoKSk7Cisg ICAgICAgIHBhZ2UoKS0+Y2hyb21lKCktPmNsaWVudCgpLT5zZXRSb290RnVsbFNjcmVlbkxheWVy KG1fZnVsbFNjcmVlblJlbmRlcmVyLT5sYXllcigpLT5iYWNraW5nKCktPmdyYXBoaWNzTGF5ZXIo KSk7CisgICAgfQogfQogICAgIAogdm9pZCBEb2N1bWVudDo6d2Via2l0RGlkRW50ZXJGdWxsU2Ny ZWVuRm9yRWxlbWVudChFbGVtZW50KikKIHsKLSAgICBpZiAobV9mdWxsU2NyZWVuUmVuZGVyZXIp CisgICAgaWYgKG1fZnVsbFNjcmVlblJlbmRlcmVyKSB7CiAgICAgICAgIG1fZnVsbFNjcmVlblJl bmRlcmVyLT5zZXRBbmltYXRpbmcoZmFsc2UpOworICAgICAgICB2aWV3KCktPnVwZGF0ZUNvbXBv c2l0aW5nTGF5ZXJzKCk7CisgICAgICAgIEFTU0VSVCghbV9mdWxsU2NyZWVuUmVuZGVyZXItPmxh eWVyKCktPmJhY2tpbmcoKSk7CisgICAgICAgIHBhZ2UoKS0+Y2hyb21lKCktPmNsaWVudCgpLT5z ZXRSb290RnVsbFNjcmVlbkxheWVyKDApOworICAgIH0KICAgICBtX2Z1bGxTY3JlZW5DaGFuZ2VE ZWxheVRpbWVyLnN0YXJ0T25lU2hvdCgwKTsKIH0KIAogdm9pZCBEb2N1bWVudDo6d2Via2l0V2ls bEV4aXRGdWxsU2NyZWVuRm9yRWxlbWVudChFbGVtZW50KikKIHsKLSAgICBpZiAobV9mdWxsU2Ny ZWVuUmVuZGVyZXIpCisgICAgaWYgKG1fZnVsbFNjcmVlblJlbmRlcmVyKSB7CiAgICAgICAgIG1f ZnVsbFNjcmVlblJlbmRlcmVyLT5zZXRBbmltYXRpbmcodHJ1ZSk7Ci0KLSAgICByZWNhbGNTdHls ZShGb3JjZSk7CisgICAgICAgIG1fZnVsbFNjcmVlblJlbmRlcmVyLT5zZXRBbmltYXRpbmcodHJ1 ZSk7CisgICAgICAgIHZpZXcoKS0+dXBkYXRlQ29tcG9zaXRpbmdMYXllcnMoKTsKKyAgICAgICAg QVNTRVJUKG1fZnVsbFNjcmVlblJlbmRlcmVyLT5sYXllcigpLT5iYWNraW5nKCkpOworICAgICAg ICBwYWdlKCktPmNocm9tZSgpLT5jbGllbnQoKS0+c2V0Um9vdEZ1bGxTY3JlZW5MYXllcihtX2Z1 bGxTY3JlZW5SZW5kZXJlci0+bGF5ZXIoKS0+YmFja2luZygpLT5ncmFwaGljc0xheWVyKCkpOwor ICAgIH0KIH0KIAogdm9pZCBEb2N1bWVudDo6d2Via2l0RGlkRXhpdEZ1bGxTY3JlZW5Gb3JFbGVt ZW50KEVsZW1lbnQqKQpAQCAtNDk1Miw2ICs0OTY0LDcgQEAgdm9pZCBEb2N1bWVudDo6d2Via2l0 RGlkRXhpdEZ1bGxTY3JlZW5Gb3JFbGVtZW50KEVsZW1lbnQqKQogICAgICAgICBtX2Z1bGxTY3Jl ZW5FbGVtZW50LT5kZXRhY2goKTsKICAgICAKICAgICBzZXRGdWxsU2NyZWVuUmVuZGVyZXIoMCk7 CisgICAgcGFnZSgpLT5jaHJvbWUoKS0+Y2xpZW50KCktPnNldFJvb3RGdWxsU2NyZWVuTGF5ZXIo MCk7CiAgICAgcmVjYWxjU3R5bGUoRm9yY2UpOwogICAgIAogICAgIG1fZnVsbFNjcmVlbkNoYW5n ZURlbGF5VGltZXIuc3RhcnRPbmVTaG90KDApOwpAQCAtNDk3OSw2ICs0OTkyLDcgQEAgdm9pZCBE b2N1bWVudDo6c2V0RnVsbFNjcmVlblJlbmRlcmVyU2l6ZShjb25zdCBJbnRTaXplJiBzaXplKQog ICAgICAgICBuZXdTdHlsZS0+c2V0VG9wKExlbmd0aCgwLCBXZWJDb3JlOjpGaXhlZCkpOwogICAg ICAgICBuZXdTdHlsZS0+c2V0TGVmdChMZW5ndGgoMCwgV2ViQ29yZTo6Rml4ZWQpKTsKICAgICAg ICAgbV9mdWxsU2NyZWVuUmVuZGVyZXItPnNldFN0eWxlKG5ld1N0eWxlKTsKKyAgICAgICAgdXBk YXRlTGF5b3V0KCk7CiAgICAgfQogfQogICAgIAo= 85545 2011-03-11 15:10:24 -0800 2011-03-11 17:06:24 -0800 Patch bug-56226-20110311151023.patch text/plain 3657 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogODA2MjcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBkOGNlMzM3ZDliMjFmYzMy M2M3MjRhNWI1MzA2OGQ0Y2JjMWIxMmQyLi5lNmYwMzk4ZDhiNzgwY2NlYzkxNTI4NzkxZTJiNjI4 YzJhMWI0ODE4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0yLDYgKzIsMjAgQEAKIAogICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KIAorICAgICAgICBXZWJDb3JlOjpEb2N1bWVudCBzaG91bGQg bm90aWZ5IENocm9tZUNsaWVudCB3aGVuIHRoZSBmdWxsIHNjcmVlbiByZW5kZXJlcidzIGJhY2tp bmcgY2hhbmdlcy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTU2MjI2CisKKyAgICAgICAgKiBkb20vRG9jdW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6RG9jdW1lbnQ6OndlYmtpdFdpbGxFbnRlckZ1bGxTY3JlZW5Gb3JFbGVtZW50KTogQ2FsbCBz ZXRSb290RnVsbFNjcmVlbkxheWVyKCkuCisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudDo6d2Vi a2l0RGlkRW50ZXJGdWxsU2NyZWVuRm9yRWxlbWVudCk6IERpdHRvLgorICAgICAgICAoV2ViQ29y ZTo6RG9jdW1lbnQ6OndlYmtpdFdpbGxFeGl0RnVsbFNjcmVlbkZvckVsZW1lbnQpOiBEaXR0by4K KyAgICAgICAgKFdlYkNvcmU6OkRvY3VtZW50Ojp3ZWJraXREaWRFeGl0RnVsbFNjcmVlbkZvckVs ZW1lbnQpOiBEaXR0by4KKyAgICAgICAgKFdlYkNvcmU6OkRvY3VtZW50OjpzZXRGdWxsU2NyZWVu UmVuZGVyZXJTaXplKTogTGF5b3V0IGFmdGVyIHNldHRpbmcgdGhlIHJlbmRlcmVyJ3Mgc2l6ZS4K KworMjAxMS0wMy0xMSAgSmVyIE5vYmxlICA8amVyLm5vYmxlQGFwcGxlLmNvbT4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwogICAgICAgICBDcmVhdGUgbmV3IGludGVy ZmFjZSBzdHVicyB0byBzdXBwb3J0IGZ1bGwgc2NyZWVuIG1vZGUgaW4gV2ViS2l0Mi4KIAogICAg ICAgICBXZWJLaXQyOiBQbHVtYiBuZXcgZnVsbCBzY3JlZW4gYW5pbWF0aW9uIEFQSXMgdGhyb3Vn aCBXZWJLaXQyLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcCBi L1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKaW5kZXggZmNmMWI0ZGZjMWJlNDQ0OTgz YWQwMWQyNWMwMzY3NDU5OWI4NDk0Mi4uOTY4ODQwYjU2ZjU0OTkxZGQ3MmNmZWFlMzEwYzQzZjJm YTg5ZmUyZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCkBAIC0xMjAsNiArMTIwLDcgQEAKICNp bmNsdWRlICJSZWdpc3RlcmVkRXZlbnRMaXN0ZW5lci5oIgogI2luY2x1ZGUgIlJlbmRlckFyZW5h LmgiCiAjaW5jbHVkZSAiUmVuZGVyTGF5ZXIuaCIKKyNpbmNsdWRlICJSZW5kZXJMYXllckJhY2tp bmcuaCIKICNpbmNsdWRlICJSZW5kZXJUZXh0Q29udHJvbC5oIgogI2luY2x1ZGUgIlJlbmRlclZp ZXcuaCIKICNpbmNsdWRlICJSZW5kZXJXaWRnZXQuaCIKQEAgLTQ5MjEsMjMgKzQ5MjIsMzQgQEAg dm9pZCBEb2N1bWVudDo6d2Via2l0V2lsbEVudGVyRnVsbFNjcmVlbkZvckVsZW1lbnQoRWxlbWVu dCogZWxlbWVudCkKIAogICAgIHJlY2FsY1N0eWxlKEZvcmNlKTsKICAgICAKLSAgICBpZiAobV9m dWxsU2NyZWVuUmVuZGVyZXIpCisgICAgaWYgKG1fZnVsbFNjcmVlblJlbmRlcmVyKSB7CiAgICAg ICAgIG1fZnVsbFNjcmVlblJlbmRlcmVyLT5zZXRBbmltYXRpbmcodHJ1ZSk7CisgICAgICAgIHZp ZXcoKS0+dXBkYXRlQ29tcG9zaXRpbmdMYXllcnMoKTsKKyAgICAgICAgQVNTRVJUKG1fZnVsbFNj cmVlblJlbmRlcmVyLT5sYXllcigpLT5iYWNraW5nKCkpOworICAgICAgICBwYWdlKCktPmNocm9t ZSgpLT5jbGllbnQoKS0+c2V0Um9vdEZ1bGxTY3JlZW5MYXllcihtX2Z1bGxTY3JlZW5SZW5kZXJl ci0+bGF5ZXIoKS0+YmFja2luZygpLT5ncmFwaGljc0xheWVyKCkpOworICAgIH0KIH0KICAgICAK IHZvaWQgRG9jdW1lbnQ6OndlYmtpdERpZEVudGVyRnVsbFNjcmVlbkZvckVsZW1lbnQoRWxlbWVu dCopCiB7Ci0gICAgaWYgKG1fZnVsbFNjcmVlblJlbmRlcmVyKQorICAgIGlmIChtX2Z1bGxTY3Jl ZW5SZW5kZXJlcikgewogICAgICAgICBtX2Z1bGxTY3JlZW5SZW5kZXJlci0+c2V0QW5pbWF0aW5n KGZhbHNlKTsKKyAgICAgICAgdmlldygpLT51cGRhdGVDb21wb3NpdGluZ0xheWVycygpOworICAg ICAgICBBU1NFUlQoIW1fZnVsbFNjcmVlblJlbmRlcmVyLT5sYXllcigpLT5iYWNraW5nKCkpOwor ICAgICAgICBwYWdlKCktPmNocm9tZSgpLT5jbGllbnQoKS0+c2V0Um9vdEZ1bGxTY3JlZW5MYXll cigwKTsKKyAgICB9CiAgICAgbV9mdWxsU2NyZWVuQ2hhbmdlRGVsYXlUaW1lci5zdGFydE9uZVNo b3QoMCk7CiB9CiAKIHZvaWQgRG9jdW1lbnQ6OndlYmtpdFdpbGxFeGl0RnVsbFNjcmVlbkZvckVs ZW1lbnQoRWxlbWVudCopCiB7Ci0gICAgaWYgKG1fZnVsbFNjcmVlblJlbmRlcmVyKQorICAgIGlm IChtX2Z1bGxTY3JlZW5SZW5kZXJlcikgewogICAgICAgICBtX2Z1bGxTY3JlZW5SZW5kZXJlci0+ c2V0QW5pbWF0aW5nKHRydWUpOwotCi0gICAgcmVjYWxjU3R5bGUoRm9yY2UpOworICAgICAgICBt X2Z1bGxTY3JlZW5SZW5kZXJlci0+c2V0QW5pbWF0aW5nKHRydWUpOworICAgICAgICB2aWV3KCkt PnVwZGF0ZUNvbXBvc2l0aW5nTGF5ZXJzKCk7CisgICAgICAgIEFTU0VSVChtX2Z1bGxTY3JlZW5S ZW5kZXJlci0+bGF5ZXIoKS0+YmFja2luZygpKTsKKyAgICAgICAgcGFnZSgpLT5jaHJvbWUoKS0+ Y2xpZW50KCktPnNldFJvb3RGdWxsU2NyZWVuTGF5ZXIobV9mdWxsU2NyZWVuUmVuZGVyZXItPmxh eWVyKCktPmJhY2tpbmcoKS0+Z3JhcGhpY3NMYXllcigpKTsKKyAgICB9CiB9CiAKIHZvaWQgRG9j dW1lbnQ6OndlYmtpdERpZEV4aXRGdWxsU2NyZWVuRm9yRWxlbWVudChFbGVtZW50KikKQEAgLTQ5 NTIsNiArNDk2NCw3IEBAIHZvaWQgRG9jdW1lbnQ6OndlYmtpdERpZEV4aXRGdWxsU2NyZWVuRm9y RWxlbWVudChFbGVtZW50KikKICAgICAgICAgbV9mdWxsU2NyZWVuRWxlbWVudC0+ZGV0YWNoKCk7 CiAgICAgCiAgICAgc2V0RnVsbFNjcmVlblJlbmRlcmVyKDApOworICAgIHBhZ2UoKS0+Y2hyb21l KCktPmNsaWVudCgpLT5zZXRSb290RnVsbFNjcmVlbkxheWVyKDApOwogICAgIHJlY2FsY1N0eWxl KEZvcmNlKTsKICAgICAKICAgICBtX2Z1bGxTY3JlZW5DaGFuZ2VEZWxheVRpbWVyLnN0YXJ0T25l U2hvdCgwKTsKQEAgLTQ5NzksNiArNDk5Miw3IEBAIHZvaWQgRG9jdW1lbnQ6OnNldEZ1bGxTY3Jl ZW5SZW5kZXJlclNpemUoY29uc3QgSW50U2l6ZSYgc2l6ZSkKICAgICAgICAgbmV3U3R5bGUtPnNl dFRvcChMZW5ndGgoMCwgV2ViQ29yZTo6Rml4ZWQpKTsKICAgICAgICAgbmV3U3R5bGUtPnNldExl ZnQoTGVuZ3RoKDAsIFdlYkNvcmU6OkZpeGVkKSk7CiAgICAgICAgIG1fZnVsbFNjcmVlblJlbmRl cmVyLT5zZXRTdHlsZShuZXdTdHlsZSk7CisgICAgICAgIHVwZGF0ZUxheW91dCgpOwogICAgIH0K IH0KICAgICAK