56205 2011-03-11 10:35:45 -0800 m_restrictions needs to allow multiple values (a bitfield) 2011-03-11 12:30:16 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 dino dino eric.carlson oldest_to_newest 366094 0 dino 2011-03-11 10:35:45 -0800 m_restrictions needs to allow multiple values (a bitfield) 366107 1 85492 dino 2011-03-11 10:47:08 -0800 Created attachment 85492 Patch 366148 2 85492 simon.fraser 2011-03-11 11:21:28 -0800 Comment on attachment 85492 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=85492&action=review > Source/WebCore/ChangeLog:9 > + https://bugs.webkit.org/show_bug.cgi?id=56205 > + m_restrictions needs to allow multiple values (a bitfield) > + > + Make the m_restrictions ivar of unsigned type, so that it > + can hold multiple values of BehaviorRestrictions. Somewhere in this text you should mention media elements. > Source/WebCore/html/HTMLMediaElement.h:363 > - BehaviorRestrictions m_restrictions; > + unsigned m_restrictions; I think you should add a typedef for BehaviorRestrictions, and rename the enum to BehaviorRestrictionFlags 366168 3 85502 dino 2011-03-11 11:39:35 -0800 Created attachment 85502 Patch 366170 4 85502 simon.fraser 2011-03-11 11:41:43 -0800 Comment on attachment 85502 Patch Doesn't that feel better? 366184 5 dino 2011-03-11 11:51:56 -0800 (In reply to comment #4) > (From update of attachment 85502 [details]) > Doesn't that feel better? I have a warm feeling in my stomach. I will sleep soundly tonight. 366235 6 dino 2011-03-11 12:30:07 -0800 Committing to http://svn.webkit.org/repository/webkit/trunk ... M Source/WebCore/ChangeLog M Source/WebCore/html/HTMLMediaElement.h Committed r80873 85492 2011-03-11 10:47:08 -0800 2011-03-11 11:39:30 -0800 Patch bug-56205-20110312054706.patch text/plain 1847 dino U3VidmVyc2lvbiBSZXZpc2lvbjogODA4NTMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA2NDhkYzcyNjk4ZjcyNjA4 N2Y3NmU1MWViOTBhOWEwNDllNGMwZjQ5Li42ZWNkZDA0M2YxZGQxNWY4ODNkNmRiYTVmYzBjZmE5 YWYyNWFmYzc4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTggQEAKIDIwMTEtMDMtMTEgIERlYW4g SmFja3NvbiAgPGRpbm9AYXBwbGUuY29tPgogCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD01NjIwNQorICAgICAgICBtX3Jlc3RyaWN0aW9ucyBuZWVkcyB0byBhbGxvdyBtdWx0aXBsZSB2 YWx1ZXMgKGEgYml0ZmllbGQpCisKKyAgICAgICAgTWFrZSB0aGUgbV9yZXN0cmljdGlvbnMgaXZh ciBvZiB1bnNpZ25lZCB0eXBlLCBzbyB0aGF0IGl0CisgICAgICAgIGNhbiBob2xkIG11bHRpcGxl IHZhbHVlcyBvZiBCZWhhdmlvclJlc3RyaWN0aW9ucy4KKworICAgICAgICAqIGh0bWwvSFRNTE1l ZGlhRWxlbWVudC5oOgorICAgICAgICAoV2ViQ29yZTo6SFRNTE1lZGlhRWxlbWVudDo6c2V0QmVo YXZpb3JSZXN0cmljdGlvbnMpOgorCisyMDExLTAzLTExICBEZWFuIEphY2tzb24gIDxkaW5vQGFw cGxlLmNvbT4KKwogICAgICAgICBVbnJldmlld2VkLgogCiAgICAgICAgIEJ1aWxkIGZpeGVzIGZv ciBHVEsgYW5kIExlb3BhcmQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxN ZWRpYUVsZW1lbnQuaCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5oCmlu ZGV4IGY4NzA1ODZiYjI4ZjUwZDQ2MjU5YzlkNzU4OWJmODBjYWUxMTZjZjIuLjcxNWM2MDM0ZGUx Njg0N2M4ZDYxZWZmNDg1ZDczNDhiNDg2ZTcwOTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2h0bWwvSFRNTE1lZGlhRWxlbWVudC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1l ZGlhRWxlbWVudC5oCkBAIC0xOTAsNyArMTkwLDcgQEAgcHVibGljOgogICAgIGJvb2wgcmVxdWly ZVVzZXJHZXN0dXJlRm9yUmF0ZUNoYW5nZSgpIGNvbnN0IHsgcmV0dXJuIG1fcmVzdHJpY3Rpb25z ICYgUmVxdWlyZVVzZXJHZXN0dXJlRm9yUmF0ZUNoYW5nZVJlc3RyaWN0aW9uOyB9CiAgICAgYm9v bCByZXF1aXJlVXNlckdlc3R1cmVGb3JGdWxsU2NyZWVuKCkgY29uc3QgeyByZXR1cm4gbV9yZXN0 cmljdGlvbnMgJiBSZXF1aXJlVXNlckdlc3R1cmVGb3JGdWxsU2NyZWVuUmVzdHJpY3Rpb247IH0K IAotICAgIHZvaWQgc2V0QmVoYXZpb3JSZXN0cmljdGlvbnMoQmVoYXZpb3JSZXN0cmljdGlvbnMg cmVzdHJpY3Rpb25zKSB7IG1fcmVzdHJpY3Rpb25zID0gcmVzdHJpY3Rpb25zOyB9CisgICAgdm9p ZCBzZXRCZWhhdmlvclJlc3RyaWN0aW9ucyh1bnNpZ25lZCByZXN0cmljdGlvbnMpIHsgbV9yZXN0 cmljdGlvbnMgPSByZXN0cmljdGlvbnM7IH0KIAogICAgIC8vIE1lZGlhIGNhY2hlIG1hbmFnZW1l bnQuCiAgICAgc3RhdGljIHZvaWQgZ2V0U2l0ZXNJbk1lZGlhQ2FjaGUoVmVjdG9yPFN0cmluZz4m KTsKQEAgLTM2MCw3ICszNjAsNyBAQCBwcml2YXRlOgogICAgIFJlZlB0cjxXaWRnZXQ+IG1fcHJv eHlXaWRnZXQ7CiAjZW5kaWYKIAotICAgIEJlaGF2aW9yUmVzdHJpY3Rpb25zIG1fcmVzdHJpY3Rp b25zOworICAgIHVuc2lnbmVkIG1fcmVzdHJpY3Rpb25zOwogICAgIAogICAgIE1lZGlhUGxheWVy OjpQcmVsb2FkIG1fcHJlbG9hZDsKIAo= 85502 2011-03-11 11:39:35 -0800 2011-03-11 11:41:43 -0800 Patch bug-56205-20110312063933.patch text/plain 1987 dino U3VidmVyc2lvbiBSZXZpc2lvbjogODA4NTMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA2NDhkYzcyNjk4ZjcyNjA4 N2Y3NmU1MWViOTBhOWEwNDllNGMwZjQ5Li5lNWUzZGFiZmFmNTUxNGJjMDQxNmJiZTQ3Yzk1MTg1 ZGE1ZDc5OTFmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTkgQEAKIDIwMTEtMDMtMTEgIERlYW4g SmFja3NvbiAgPGRpbm9AYXBwbGUuY29tPgogCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD01NjIwNQorICAgICAgICBtX3Jlc3RyaWN0aW9ucyBuZWVkcyB0byBhbGxvdyBtdWx0aXBsZSB2 YWx1ZXMgKGEgYml0ZmllbGQpCisKKyAgICAgICAgSFRNTE1lZGlhRWxlbWVudDo6bV9yZXN0cmlj dGlvbnMgbmVlZHMgdG8gaG9sZCBtdWx0aXBsZSB2YWx1ZXMsIHNvCisgICAgICAgIGNoYW5nZSBC ZWhhdmlvclJlc3RyaWN0aW9ucyB0byBhbiB1bnNpZ25lZCB0eXBlZGVmIGFuZCByZW5hbWUgdGhl CisgICAgICAgIGV4aXN0aW5nIGVudW0gQmVoYXZpb3JSZXN0cmljdGlvbkZsYWdzLgorCisgICAg ICAgICogaHRtbC9IVE1MTWVkaWFFbGVtZW50Lmg6CisgICAgICAgIChXZWJDb3JlOjpIVE1MTWVk aWFFbGVtZW50OjpzZXRCZWhhdmlvclJlc3RyaWN0aW9ucyk6CisKKzIwMTEtMDMtMTEgIERlYW4g SmFja3NvbiAgPGRpbm9AYXBwbGUuY29tPgorCiAgICAgICAgIFVucmV2aWV3ZWQuCiAKICAgICAg ICAgQnVpbGQgZml4ZXMgZm9yIEdUSyBhbmQgTGVvcGFyZC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5oIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1M TWVkaWFFbGVtZW50LmgKaW5kZXggZjg3MDU4NmJiMjhmNTBkNDYyNTljOWQ3NTg5YmY4MGNhZTEx NmNmMi4uNmY0NGZkZGVlNjBmZDViYzE3Zjg5YTQxNTliYTJlNDJjMDFkYzczMCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmgKKysrIGIvU291cmNlL1dl YkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmgKQEAgLTE3OSwxMyArMTc5LDE0IEBAIHB1Ymxp YzoKICAgICB2b2lkIHByaXZhdGVCcm93c2luZ1N0YXRlRGlkQ2hhbmdlKCk7CiAKICAgICAvLyBS ZXN0cmljdGlvbnMgdG8gY2hhbmdlIGRlZmF1bHQgYmVoYXZpb3JzLgotICAgIGVudW0gQmVoYXZp b3JSZXN0cmljdGlvbnMgeworICAgIGVudW0gQmVoYXZpb3JSZXN0cmljdGlvbkZsYWdzIHsKICAg ICAgICAgTm9SZXN0cmljdGlvbnMgPSAwLAogICAgICAgICBSZXF1aXJlVXNlckdlc3R1cmVGb3JM b2FkUmVzdHJpY3Rpb24gPSAxIDw8IDAsCiAgICAgICAgIFJlcXVpcmVVc2VyR2VzdHVyZUZvclJh dGVDaGFuZ2VSZXN0cmljdGlvbiA9IDEgPDwgMSwKICAgICAgICAgUmVxdWlyZVVzZXJHZXN0dXJl Rm9yRnVsbFNjcmVlblJlc3RyaWN0aW9uID0gMSA8PCAyCiAgICAgfTsKLQorICAgIHR5cGVkZWYg dW5zaWduZWQgQmVoYXZpb3JSZXN0cmljdGlvbnM7CisgICAgCiAgICAgYm9vbCByZXF1aXJlVXNl ckdlc3R1cmVGb3JMb2FkKCkgY29uc3QgeyByZXR1cm4gbV9yZXN0cmljdGlvbnMgJiBSZXF1aXJl VXNlckdlc3R1cmVGb3JMb2FkUmVzdHJpY3Rpb247IH0KICAgICBib29sIHJlcXVpcmVVc2VyR2Vz dHVyZUZvclJhdGVDaGFuZ2UoKSBjb25zdCB7IHJldHVybiBtX3Jlc3RyaWN0aW9ucyAmIFJlcXVp cmVVc2VyR2VzdHVyZUZvclJhdGVDaGFuZ2VSZXN0cmljdGlvbjsgfQogICAgIGJvb2wgcmVxdWly ZVVzZXJHZXN0dXJlRm9yRnVsbFNjcmVlbigpIGNvbnN0IHsgcmV0dXJuIG1fcmVzdHJpY3Rpb25z ICYgUmVxdWlyZVVzZXJHZXN0dXJlRm9yRnVsbFNjcmVlblJlc3RyaWN0aW9uOyB9Cg==