56195 2011-03-11 08:12:49 -0800 line 259 in svg/SVGElement.cpp fails to compile on Solaris10/SS12 2011-03-19 06:09:17 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) PC Other RESOLVED FIXED P2 Major --- 0 bentaylor.solx86 webkit-unassigned commit-queue zimmermann oldest_to_newest 366011 0 bentaylor.solx86 2011-03-11 08:12:49 -0800 qt-everywhere-opensource-src-4.7.1/src/3rdparty/webkit/WebCore/svg/SVGElement.cpp Compiling qt-4.7.1 on Solaris 10 with a relatively patched Sun Studio 12 compiler 247 void SVGElement::sendSVGLoadEventIfPossible(bool sendParentLoadEvents) 248 { 249 RefPtr<SVGElement> currentTarget = this; 250 while (currentTarget && currentTarget->haveLoadedRequiredResources()) { 251 RefPtr<Node> parent; 252 if (sendParentLoadEvents) 253 parent = currentTarget->parentNode(); // save the next parent to dispatch too incase dispatching the event changes the tree 254 if (hasLoadListener(currentTarget.get())) { 255 RefPtr<Event> event = Event::create(eventNames().loadEvent, false, false); 256 event->setTarget(currentTarget); 257 currentTarget->dispatchGenericEvent(event.release()); 258 } 259 currentTarget = (parent && parent->isSVGElement()) ? static_pointer_cast<SVGElement>(parent) : 0; 260 } 261 } The error emitted by the compiler is: "svg/SVGElement.cpp", line 259: Error: Ambiguous "?:" expression, second operand of type "WTF::RefPtr<WebCore::SVGElement>" and third operand of type "int" can be converted to one another. This patch makes the compilation succeed. --- qt-everywhere-opensource-src-4.7.1/src/3rdparty/webkit/WebCore/svg/SVGElement.cpp.ORIG 2011-03-09 15:06:34.146973419 +0000 +++ qt-everywhere-opensource-src-4.7.1/src/3rdparty/webkit/WebCore/svg/SVGElement.cpp 2011-03-09 14:40:15.952738383 +0000 @@ -256,7 +256,7 @@ event->setTarget(currentTarget); currentTarget->dispatchGenericEvent(event.release()); } - currentTarget = (parent && parent->isSVGElement()) ? static_pointer_cast<SVGElement>(parent) : 0; + currentTarget = (parent && parent->isSVGElement()) ? static_pointer_cast<SVGElement>(parent) : RefPtr<SVGElement>(); } } 366555 1 zimmermann 2011-03-12 02:07:30 -0800 Can you submit a full patch please? http://www.webkit.org/coding/contributing.html Flag it as r?, cq?, and I'll make sure it gets landed, thanks! 366578 2 85592 bentaylor.solx86 2011-03-12 07:12:52 -0800 Created attachment 85592 Proposed patch which compiles correctly in qt-4.7.1 with webkit enabled on Solaris 10 with SS12 C++ compiler This fix is against webkit head, but works for the webkit distributed with qt-4.7.1. This fix is similar to one in bug 56198 which passed muster. 370111 3 85592 zimmermann 2011-03-19 04:42:44 -0700 Comment on attachment 85592 Proposed patch which compiles correctly in qt-4.7.1 with webkit enabled on Solaris 10 with SS12 C++ compiler r=me, sorry for the delay, I've been ill. 370125 4 85592 commit-queue 2011-03-19 06:09:14 -0700 Comment on attachment 85592 Proposed patch which compiles correctly in qt-4.7.1 with webkit enabled on Solaris 10 with SS12 C++ compiler Clearing flags on attachment: 85592 Committed r81549: <http://trac.webkit.org/changeset/81549> 370126 5 commit-queue 2011-03-19 06:09:17 -0700 All reviewed patches have been landed. Closing bug. 85592 2011-03-12 07:12:52 -0800 2011-03-19 06:09:14 -0700 Proposed patch which compiles correctly in qt-4.7.1 with webkit enabled on Solaris 10 with SS12 C++ compiler webkit-bug-56195-svg-SVGElement.cpp.diff text/plain 1442 bentaylor.solx86 SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDgwOTM1KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDMtMTIgIEJlbiBUYXls b3IgIDxiZW50YXlsb3Iuc29seDg2QGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NTYxOTUKKyAgICAgICAgRml4IGNvbmRpdGlvbmFsIHdoaWNoIGhhZCBhbiBpbnQg Zm9yIG9uZSBjYXNlIGFuZCBhIHBvaW50ZXIgZm9yIGFub3RoZXIuCisgICAgICAgIFNpbWlsYXIg Zml4IGFzIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NjE5OAorCisg ICAgICAgIE5vIG5ldyB0ZXN0cy4gRml4IGNvbXBpbGF0aW9uIG9uIFNvbGFyaXMgMTAgd2l0aCBT dW4gU3R1ZGlvIEMrKworCisgICAgICAgICogc3ZnL1NWR0VsZW1lbnQuY3BwOgorICAgICAgICAo V2ViQ29yZTo6U1ZHRWxlbWVudDo6c2VuZFNWR0xvYWRFdmVudElmUG9zc2libGUpOgorCiAyMDEx LTAzLTEyICBQYXZlbCBGZWxkbWFuICA8cGZlbGRtYW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAg IE5vdCByZXZpZXdlZDogSW5zcGVjdCBFbGVtZW50IGFjdGlvbiByZWdyZXNzaW9uIGZpeC4KSW5k ZXg6IFNvdXJjZS9XZWJDb3JlL3N2Zy9TVkdFbGVtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViQ29yZS9zdmcvU1ZHRWxlbWVudC5jcHAJKHJldmlzaW9uIDgwOTM1KQorKysgU291cmNl L1dlYkNvcmUvc3ZnL1NWR0VsZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMjEsNyArMzIx LDcgQEAgdm9pZCBTVkdFbGVtZW50OjpzZW5kU1ZHTG9hZEV2ZW50SWZQb3NzaQogICAgICAgICAg ICAgZXZlbnQtPnNldFRhcmdldChjdXJyZW50VGFyZ2V0KTsKICAgICAgICAgICAgIGN1cnJlbnRU YXJnZXQtPmRpc3BhdGNoR2VuZXJpY0V2ZW50KGV2ZW50LnJlbGVhc2UoKSk7CiAgICAgICAgIH0K LSAgICAgICAgY3VycmVudFRhcmdldCA9IChwYXJlbnQgJiYgcGFyZW50LT5pc1NWR0VsZW1lbnQo KSkgPyBzdGF0aWNfcG9pbnRlcl9jYXN0PFNWR0VsZW1lbnQ+KHBhcmVudCkgOiAwOworICAgICAg ICBjdXJyZW50VGFyZ2V0ID0gKHBhcmVudCAmJiBwYXJlbnQtPmlzU1ZHRWxlbWVudCgpKSA/IHN0 YXRpY19wb2ludGVyX2Nhc3Q8U1ZHRWxlbWVudD4ocGFyZW50KSA6IFJlZlB0cjxTVkdFbGVtZW50 PigpOwogICAgIH0KIH0KIAo=