56183 2011-03-11 06:15:26 -0800 Web Inspector: REGRESSION: Messed up with the tabIndex for text editor 2011-03-14 05:11:53 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 aandrey webkit-unassigned apavlov bweinstein joepeck keishi loislo pfeldman pmuellr podivilov rik timothy yurys oldest_to_newest 365959 0 aandrey 2011-03-11 06:15:26 -0800 We should have tabIndex="0" set even in readOnly mode, so that navigation via keyboard (up, down, PgUp, PgDown and etc.) should work. Otherwise, it looses the focus after a change in the DOM, and navigation stops working. Also, the console should be opening/closing on pressing the ESC button when in readOnly mode. 365960 1 85466 aandrey 2011-03-11 06:17:03 -0800 Created attachment 85466 Patch 366936 2 85466 podivilov 2011-03-14 05:11:45 -0700 Comment on attachment 85466 Patch Clearing flags on attachment: 85466 Committed r81017: <http://trac.webkit.org/changeset/81017> 366937 3 podivilov 2011-03-14 05:11:53 -0700 All reviewed patches have been landed. Closing bug. 85466 2011-03-11 06:17:03 -0800 2011-03-14 05:11:44 -0700 Patch bug-56183-20110311171701.patch text/plain 4274 aandrey U3VidmVyc2lvbiBSZXZpc2lvbjogODA4MzEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBkNTk4ZjZmMGJlZjZmMzA5 YWVlMzVlOTRmYTk0MTQ5OGYzMjYwZGU3Li40NTkzYmJjOTU3Y2MzNWI2Y2NkMWE5OGVhZTNiMzE0 NTRkZTM3MDAzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDMtMTEgIEFuZHJl eSBBZGFpa2luICA8YWFuZHJleUBnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IFJFR1JFU1NJT046IE1lc3Nl ZCB1cCB3aXRoIHRoZSB0YWJJbmRleCBmb3IgdGV4dCBlZGl0b3IKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU2MTgzCisKKyAgICAgICAgKiBpbnNwZWN0 b3IvZnJvbnQtZW5kL1NvdXJjZUZyYW1lLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlNvdXJj ZUZyYW1lLnByb3RvdHlwZS5faGFuZGxlS2V5RG93bik6CisgICAgICAgIChXZWJJbnNwZWN0b3Iu U291cmNlRnJhbWUucHJvdG90eXBlLl9oYW5kbGVTYXZlKToKKyAgICAgICAgKFdlYkluc3BlY3Rv ci5Tb3VyY2VGcmFtZS5wcm90b3R5cGUuX2hhbmRsZVJldmVydEVkaXRpbmcpOgorICAgICAgICAq IGluc3BlY3Rvci9mcm9udC1lbmQvVGV4dFZpZXdlci5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rv ci5UZXh0RWRpdG9yTWFpblBhbmVsKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UZXh0RWRpdG9y TWFpblBhbmVsLnByb3RvdHlwZS5zZXQgcmVhZE9ubHkpOgorCiAyMDExLTAzLTEwICBBbGV4YW5k ZXIgUGF2bG92ICA8YXBhdmxvdkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg WXVyeSBTZW1pa2hhdHNreS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9m cm9udC1lbmQvU291cmNlRnJhbWUuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQt ZW5kL1NvdXJjZUZyYW1lLmpzCmluZGV4IDExNTdiMDMyY2NmMGZmYzRkODRiMDgyOWY0OWFhODA1 OTkzYWE2YmEuLmQzMzg4Yzk2MTBlMmMxODMzYzNkMWM1ZGNkOGRiZGM4NmY5YWFkZjMgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU291cmNlRnJhbWUuanMK KysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Tb3VyY2VGcmFtZS5qcwpA QCAtNzgyLDggKzc4Miw3IEBAIFdlYkluc3BlY3Rvci5Tb3VyY2VGcmFtZS5wcm90b3R5cGUgPSB7 CiAgICAgewogICAgICAgICB2YXIgc2hvcnRjdXRLZXkgPSBXZWJJbnNwZWN0b3IuS2V5Ym9hcmRT aG9ydGN1dC5tYWtlS2V5RnJvbUV2ZW50KGUpOwogICAgICAgICB2YXIgaGFuZGxlciA9IHRoaXMu X3Nob3J0Y3V0c1tzaG9ydGN1dEtleV07Ci0gICAgICAgIGlmIChoYW5kbGVyKSB7Ci0gICAgICAg ICAgICBoYW5kbGVyLmNhbGwodGhpcyk7CisgICAgICAgIGlmIChoYW5kbGVyICYmIGhhbmRsZXIu Y2FsbCh0aGlzKSkgewogICAgICAgICAgICAgZS5wcmV2ZW50RGVmYXVsdCgpOwogICAgICAgICAg ICAgZS5zdG9wUHJvcGFnYXRpb24oKTsKICAgICAgICAgfQpAQCAtNzkxLDIyICs3OTAsMjcgQEAg V2ViSW5zcGVjdG9yLlNvdXJjZUZyYW1lLnByb3RvdHlwZSA9IHsKIAogICAgIF9oYW5kbGVTYXZl OiBmdW5jdGlvbigpCiAgICAgewotICAgICAgICBpZiAoIXRoaXMuX2RlbGVnYXRlLmNhbkVkaXRT Y3JpcHRTb3VyY2UoKSkKLSAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgaWYgKHRoaXMuX3Rl eHRWaWV3ZXIucmVhZE9ubHkgfHwgIXRoaXMuX2RlbGVnYXRlLmNhbkVkaXRTY3JpcHRTb3VyY2Uo KSkKKyAgICAgICAgICAgIHJldHVybiBmYWxzZTsKIAogICAgICAgICB2YXIgbmV3U291cmNlID0g dGhpcy5fdGV4dE1vZGVsLnRleHQ7CiAgICAgICAgIGlmICh0aGlzLl9vcmlnaW5hbFRleHRNb2Rl bENvbnRlbnQgIT09IG5ld1NvdXJjZSkKICAgICAgICAgICAgIHRoaXMuX2RlbGVnYXRlLmVkaXRT Y3JpcHRTb3VyY2UobmV3U291cmNlKTsKICAgICAgICAgZGVsZXRlIHRoaXMuX29yaWdpbmFsVGV4 dE1vZGVsQ29udGVudDsKICAgICAgICAgdGhpcy5fdGV4dFZpZXdlci5yZWFkT25seSA9IHRydWU7 CisgICAgICAgIHJldHVybiB0cnVlOwogICAgIH0sCiAKICAgICBfaGFuZGxlUmV2ZXJ0RWRpdGlu ZzogZnVuY3Rpb24oKQogICAgIHsKKyAgICAgICAgaWYgKHRoaXMuX3RleHRWaWV3ZXIucmVhZE9u bHkpCisgICAgICAgICAgICByZXR1cm4gZmFsc2U7CisKICAgICAgICAgaWYgKHRoaXMuX29yaWdp bmFsVGV4dE1vZGVsQ29udGVudCAhPT0gdW5kZWZpbmVkKQogICAgICAgICAgICAgdGhpcy5fdGV4 dE1vZGVsLnNldFRleHQobnVsbCwgdGhpcy5fb3JpZ2luYWxUZXh0TW9kZWxDb250ZW50KTsKICAg ICAgICAgZGVsZXRlIHRoaXMuX29yaWdpbmFsVGV4dE1vZGVsQ29udGVudDsKICAgICAgICAgdGhp cy5fdGV4dFZpZXdlci5yZWFkT25seSA9IHRydWU7CisgICAgICAgIHJldHVybiB0cnVlOwogICAg IH0sCiAKICAgICBfZG91YmxlQ2xpY2s6IGZ1bmN0aW9uKGV2ZW50KQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9UZXh0Vmlld2VyLmpzIGIvU291cmNlL1dl YkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9UZXh0Vmlld2VyLmpzCmluZGV4IDNiODk4ODJiZGNk OTNjYWFhNThkYzE2OTIzNDgxM2NlOGI3ZTkxOTkuLmVlYWI2M2M0MDM4ODBhOWJiMTYyNzJmNjc2 YWNiZjZkNTJjYzA4NDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9u dC1lbmQvVGV4dFZpZXdlci5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQt ZW5kL1RleHRWaWV3ZXIuanMKQEAgLTY4NSw5ICs2ODUsMTEgQEAgV2ViSW5zcGVjdG9yLlRleHRF ZGl0b3JNYWluUGFuZWwgPSBmdW5jdGlvbih0ZXh0TW9kZWwsIHVybCwgc3luY1Njcm9sbExpc3Rl bmVyLAogCiAgICAgdGhpcy5lbGVtZW50ID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgiZGl2Iik7 CiAgICAgdGhpcy5lbGVtZW50LmNsYXNzTmFtZSA9ICJ0ZXh0LWVkaXRvci1jb250ZW50cyI7Cisg ICAgdGhpcy5lbGVtZW50LnRhYkluZGV4ID0gMDsKIAogICAgIHRoaXMuX2NvbnRhaW5lciA9IGRv Y3VtZW50LmNyZWF0ZUVsZW1lbnQoImRpdiIpOwogICAgIHRoaXMuX2NvbnRhaW5lci5jbGFzc05h bWUgPSAiaW5uZXItY29udGFpbmVyIjsKKyAgICB0aGlzLl9jb250YWluZXIudGFiSW5kZXggPSAw OwogICAgIHRoaXMuZWxlbWVudC5hcHBlbmRDaGlsZCh0aGlzLl9jb250YWluZXIpOwogCiAgICAg dGhpcy5lbGVtZW50LmFkZEV2ZW50TGlzdGVuZXIoInNjcm9sbCIsIHRoaXMuX3Njcm9sbC5iaW5k KHRoaXMpLCBmYWxzZSk7CkBAIC03MjMsMTggKzcyNSwxMCBAQCBXZWJJbnNwZWN0b3IuVGV4dEVk aXRvck1haW5QYW5lbC5wcm90b3R5cGUgPSB7CiAKICAgICAgICAgdGhpcy5iZWdpbkRvbVVwZGF0 ZXMoKTsKICAgICAgICAgdGhpcy5fcmVhZE9ubHkgPSByZWFkT25seTsKLSAgICAgICAgaWYgKHRo aXMuX3JlYWRPbmx5KSB7Ci0gICAgICAgICAgICB0aGlzLmVsZW1lbnQucmVtb3ZlQXR0cmlidXRl KCJ0YWJJbmRleCIpOwotICAgICAgICAgICAgdGhpcy5fY29udGFpbmVyLnJlbW92ZUF0dHJpYnV0 ZSgidGFiSW5kZXgiKTsKKyAgICAgICAgaWYgKHRoaXMuX3JlYWRPbmx5KQogICAgICAgICAgICAg dGhpcy5fY29udGFpbmVyLnJlbW92ZVN0eWxlQ2xhc3MoInRleHQtZWRpdG9yLWVkaXRhYmxlIik7 Ci0gICAgICAgICAgICAvLyBSZW1vdmUgdGhlIGZvY3VzIGZyb20gdGhlIGVkaXRhYmxlIGFyZWEu Ci0gICAgICAgICAgICB0aGlzLl9jb250YWluZXIuYmx1cigpOwotICAgICAgICAgICAgdGhpcy5l bGVtZW50LmJsdXIoKTsKLSAgICAgICAgfSBlbHNlIHsKLSAgICAgICAgICAgIHRoaXMuZWxlbWVu dC5zZXRBdHRyaWJ1dGUoInRhYkluZGV4IiwgIjAiKTsKLSAgICAgICAgICAgIHRoaXMuX2NvbnRh aW5lci5zZXRBdHRyaWJ1dGUoInRhYkluZGV4IiwgIjAiKTsKKyAgICAgICAgZWxzZQogICAgICAg ICAgICAgdGhpcy5fY29udGFpbmVyLmFkZFN0eWxlQ2xhc3MoInRleHQtZWRpdG9yLWVkaXRhYmxl Iik7Ci0gICAgICAgIH0KICAgICAgICAgdGhpcy5lbmREb21VcGRhdGVzKCk7CiAgICAgfSwKIAo=