56160 2011-03-10 18:02:18 -0800 WebKit2 UI process crashes if web process crashes while computing page rects for printing 2011-03-10 23:55:05 -0800 1 1 1 Unclassified WebKit Printing 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 ap ap commit-queue oldest_to_newest 365718 0 ap 2011-03-10 18:02:18 -0800 Need to add null checks, sigh. <rdar://problem/9027410> 365722 1 85417 ap 2011-03-10 18:11:21 -0800 Created attachment 85417 proposed fix 365847 2 85417 commit-queue 2011-03-10 23:55:01 -0800 Comment on attachment 85417 proposed fix Clearing flags on attachment: 85417 Committed r80825: <http://trac.webkit.org/changeset/80825> 365849 3 commit-queue 2011-03-10 23:55:05 -0800 All reviewed patches have been landed. Closing bug. 85417 2011-03-10 18:11:21 -0800 2011-03-10 23:55:01 -0800 proposed fix KnowsPageRangesCrash.txt text/plain 4600 ap SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDgwODAxKQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTEtMDMtMTAgIEFsZXhleSBQ cm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgV2ViS2l0MiBVSSBwcm9jZXNzIGNyYXNoZXMgaWYgd2ViIHBy b2Nlc3MgY3Jhc2hlcyB3aGlsZSBjb21wdXRpbmcgcGFnZSByZWN0cyBmb3IgcHJpbnRpbmcKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU2MTYwCisgICAg ICAgIDxyZGFyOi8vcHJvYmxlbS85MDI3NDEwPgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9t YWMvV0tQcmludGluZ1ZpZXcubW06CisgICAgICAgICgtW1dLUHJpbnRpbmdWaWV3IF9zdXNwZW5k QXV0b2Rpc3BsYXldKTogQWRkZWQgYSBudWxsIGNoZWNrIGZvciBwYWdlLCBtYXRjaGluZyBvbmUg dGhhdAorICAgICAgICB3ZSBoYXZlIHdoZW4gcmVzdW1pbmcgYXV0b2Rpc3BsYXkuCisgICAgICAg ICgtW1dLUHJpbnRpbmdWaWV3IF9kZWxheWVkUmVzdW1lQXV0b2Rpc3BsYXlUaW1lckZpcmVkXSk6 IEFkZGVkIGEgRklYTUUuCisgICAgICAgIChwYWdlRGlkQ29tcHV0ZVBhZ2VSZWN0cyk6IFNhbml0 aXplIHJlc3VsdHMgY29taW5nIGZyb20gdGhlIHdlYiBwcm9jZXNzIChhbmQgYXZvaWQgY3Jhc2hp bmcKKyAgICAgICAgd2hlbiB0aGVyZSBpcyBhIGNvbW11bmljYXRpb24gZXJyb3IsIHNvIHJlc3Vs dHMgYXJlIGFsbCBudWxsKS4KKyAgICAgICAgKC1bV0tQcmludGluZ1ZpZXcga25vd3NQYWdlUmFu Z2U6XSk6IElmIHRoZXJlIGlzIG5vIHBhZ2UgYW55IG1vcmUsIHdlIGNhbid0IHRlbGwgaG93IG1h bnkKKyAgICAgICAgcGFnZXMgaXQgaGFkLgorICAgICAgICAoLVtXS1ByaW50aW5nVmlldyByZWN0 Rm9yUGFnZTpdKTogSGFuZGxlIHRoZSBjYXNlIHdoZXJlIHdlIGFyZSBuZWl0aGVyIGNhbGN1bGF0 aW5nIHBhZ2VzCisgICAgICAgIG5vciBrbm93aW5nIHRoZW0sIGFzIGl0IGhhcHBlbnMgd2hlbiB0 aGUgd2ViIHByb2Nlc3MgY3Jhc2hlcy4gICAgICAgIAorCiAyMDExLTAzLTEwICBNYXJrIFJvd2Ug IDxtcm93ZUBhcHBsZS5jb20+CiAKICAgICAgICAgUnViYmVyLXN0YW1wZWQgYnkgU2FtIFdlaW5p Zy4KSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1dLUHJpbnRpbmdWaWV3 Lm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1dLUHJp bnRpbmdWaWV3Lm1tCShyZXZpc2lvbiA4MDY3NSkKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9BUEkvbWFjL1dLUHJpbnRpbmdWaWV3Lm1tCSh3b3JraW5nIGNvcHkpCkBAIC02Niw4ICs2Niwx MCBAQCAtICh2b2lkKV9zdXNwZW5kQXV0b2Rpc3BsYXkKICAgICBpZiAoX2F1dG9kaXNwbGF5UmVz dW1lVGltZXIpIHsKICAgICAgICAgW19hdXRvZGlzcGxheVJlc3VtZVRpbWVyIGludmFsaWRhdGVd OwogICAgICAgICBfYXV0b2Rpc3BsYXlSZXN1bWVUaW1lciA9IG5pbDsKLSAgICB9IGVsc2UKLSAg ICAgICAgX3dlYkZyYW1lLT5wYWdlKCktPnNldEF1dG9kaXNwbGF5KGZhbHNlKTsKKyAgICB9IGVs c2UgeworICAgICAgICBpZiAoV2ViUGFnZVByb3h5KiBwYWdlID0gX3dlYkZyYW1lLT5wYWdlKCkp CisgICAgICAgICAgICBwYWdlLT5zZXRBdXRvZGlzcGxheShmYWxzZSk7CisgICAgfQogfQogCiAt ICh2b2lkKV9kZWxheWVkUmVzdW1lQXV0b2Rpc3BsYXlUaW1lckZpcmVkCkBAIC03NSw2ICs3Nyw4 IEBAIC0gKHZvaWQpX2RlbGF5ZWRSZXN1bWVBdXRvZGlzcGxheVRpbWVyRmkKICAgICBBU1NFUlQo aXNNYWluVGhyZWFkKCkpOwogICAgIAogICAgIF9hdXRvZGlzcGxheVJlc3VtZVRpbWVyID0gbmls OworCisgICAgLy8gRklYTUU6IFRoZSBwYWdlIGlzIG51bGwsIGJ1dCBOU1dpbmRvdyBpcyBzdGls bCBhcm91bmQsIGFuZCBzaG91bGQgYmUgdG9sZCB0byByZXN1bWUgYXV0b2Rpc3BsYXkuCiAgICAg aWYgKFdlYlBhZ2VQcm94eSogcGFnZSA9IF93ZWJGcmFtZS0+cGFnZSgpKQogICAgICAgICBwYWdl LT5zZXRBdXRvZGlzcGxheSh0cnVlKTsKIH0KQEAgLTI2NSw2ICsyNjksMTIgQEAgc3RhdGljIHZv aWQgcGFnZURpZENvbXB1dGVQYWdlUmVjdHMoY29ucwogICAgICAgICB2aWV3LT5fcHJpbnRpbmdQ YWdlUmVjdHMgPSBwYWdlUmVjdHM7CiAgICAgICAgIHZpZXctPl90b3RhbFNjYWxlRmFjdG9yRm9y UHJpbnRpbmcgPSB0b3RhbFNjYWxlRmFjdG9yRm9yUHJpbnRpbmc7CiAKKyAgICAgICAgLy8gU2Fu aXRpemUgYSByZXNwb25zZSBjb21pbmcgZnJvbSB0aGUgV2ViIHByb2Nlc3MuCisgICAgICAgIGlm ICh2aWV3LT5fcHJpbnRpbmdQYWdlUmVjdHMuaXNFbXB0eSgpKQorICAgICAgICAgICAgdmlldy0+ X3ByaW50aW5nUGFnZVJlY3RzLmFwcGVuZChJbnRSZWN0KDAsIDAsIDEsIDEpKTsKKyAgICAgICAg aWYgKHZpZXctPl90b3RhbFNjYWxlRmFjdG9yRm9yUHJpbnRpbmcgPD0gMCkKKyAgICAgICAgICAg IHZpZXctPl90b3RhbFNjYWxlRmFjdG9yRm9yUHJpbnRpbmcgPSAxOworCiAgICAgICAgIGNvbnN0 IEludFJlY3QmIGxhc3RQcmludGluZ1BhZ2VSZWN0ID0gdmlldy0+X3ByaW50aW5nUGFnZVJlY3Rz W3ZpZXctPl9wcmludGluZ1BhZ2VSZWN0cy5zaXplKCkgLSAxXTsKICAgICAgICAgTlNSZWN0IG5l d0ZyYW1lU2l6ZSA9IE5TTWFrZVJlY3QoMCwgMCwgCiAgICAgICAgICAgICBjZWlsKGxhc3RQcmlu dGluZ1BhZ2VSZWN0Lm1heFgoKSAqIHZpZXctPl90b3RhbFNjYWxlRmFjdG9yRm9yUHJpbnRpbmcp LCAKQEAgLTMzMSw2ICszNDEsMTEgQEAgLSAoQk9PTClrbm93c1BhZ2VSYW5nZTooTlNSYW5nZVBv aW50ZXIpcgogICAgIGlmICghaXNNYWluVGhyZWFkKCkpCiAgICAgICAgIF9pc1ByaW50aW5nRnJv bVNlY29uZGFyeVRocmVhZCA9IFlFUzsKIAorICAgIGlmICghX3dlYkZyYW1lLT5wYWdlKCkpIHsK KyAgICAgICAgKnJhbmdlID0gTlNNYWtlUmFuZ2UoMSwgTlNJbnRlZ2VyTWF4KTsKKyAgICAgICAg cmV0dXJuIFlFUzsKKyAgICB9CisKICAgICBbc2VsZiBfc3VzcGVuZEF1dG9kaXNwbGF5XTsKICAg ICAKICAgICBbc2VsZiBfYWRqdXN0UHJpbnRpbmdNYXJnaW5zRm9ySGVhZGVyQW5kRm9vdGVyXTsK QEAgLTUyNSwxMSArNTQwLDIyIEBAIC0gKE5TUmVjdClyZWN0Rm9yUGFnZTooTlNJbnRlZ2VyKXBh Z2UKICAgICBBU1NFUlQoX3ByaW50T3BlcmF0aW9uID09IFtOU1ByaW50T3BlcmF0aW9uIGN1cnJl bnRPcGVyYXRpb25dKTsKICAgICBpZiAoIVtzZWxmIF9oYXNQYWdlUmVjdHNdKSB7CiAgICAgICAg IExPRyhWaWV3LCAiLVtXS1ByaW50aW5nVmlldyAlcCByZWN0Rm9yUGFnZTolZF0gLSBkYXRhIGlz IG5vdCB5ZXQgYXZhaWxhYmxlIiwgc2VsZiwgKGludClwYWdlKTsKKyAgICAgICAgaWYgKCFfd2Vi RnJhbWUtPnBhZ2UoKSkgeworICAgICAgICAgICAgLy8gV2UgbWF5IGhhdmUgbm90IHRvbGQgQXBw S2l0IGhvdyBtYW55IHBhZ2VzIHRoZXJlIGFyZSwgc28gaXQgd2lsbCB0cnkgdG8gcHJpbnQgdW50 aWwgYSBudWxsIHJlY3QgaXMgcmV0dXJuZWQuCisgICAgICAgICAgICByZXR1cm4gTlNNYWtlUmVj dCgwLCAwLCAwLCAwKTsKKyAgICAgICAgfQogICAgICAgICAvLyBXZSBtdXN0IGJlIHN0aWxsIGNh bGN1bGF0aW5nIHRoZSBwYWdlIHJhbmdlLgogICAgICAgICBBU1NFUlQoX2V4cGVjdGVkQ29tcHV0 ZWRQYWdlc0NhbGxiYWNrKTsKICAgICAgICAgcmV0dXJuIE5TTWFrZVJlY3QoMCwgMCwgMSwgMSk7 CiAgICAgfQogCisgICAgLy8gSWYgV2ViIHByb2Nlc3MgY3Jhc2hlcyB3aGlsZSBjb21wdXRpbmcg cGFnZSByZWN0cywgd2UgbmV2ZXIgdGVsbCBBcHBLaXQgaG93IG1hbnkgcGFnZXMgdGhlcmUgYXJl LgorICAgIC8vIFJldHVybmluZyBhIG51bGwgcmVjdCBwcmV2ZW50cyBzZWxlY3Rpbmcgbm9uLWV4 aXN0ZW50IHBhZ2VzIGluIHByZXZpZXcgZGlhbG9nLgorICAgIGlmIChzdGF0aWNfY2FzdDx1bnNp Z25lZD4ocGFnZSkgPiBfcHJpbnRpbmdQYWdlUmVjdHMuc2l6ZSgpKSB7CisgICAgICAgIEFTU0VS VCghX3dlYkZyYW1lLT5wYWdlKCkpOworICAgICAgICByZXR1cm4gTlNNYWtlUmVjdCgwLCAwLCAw LCAwKTsKKyAgICB9CisKICAgICBJbnRSZWN0IHJlY3QgPSBfcHJpbnRpbmdQYWdlUmVjdHNbcGFn ZSAtIDFdOwogICAgIHJlY3Quc2NhbGUoX3RvdGFsU2NhbGVGYWN0b3JGb3JQcmludGluZyk7CiAg ICAgTE9HKFZpZXcsICItW1dLUHJpbnRpbmdWaWV3ICVwIHJlY3RGb3JQYWdlOiVkXSAtPiB4ICVk LCB5ICVkLCB3aWR0aCAlZCwgaGVpZ2h0ICVkIiwgc2VsZiwgKGludClwYWdlLCByZWN0LngoKSwg cmVjdC55KCksIHJlY3Qud2lkdGgoKSwgcmVjdC5oZWlnaHQoKSk7Cg==