56159 2011-03-10 17:51:53 -0800 provide API for creating WKImage from CGImageRef 2011-03-14 17:49:32 -0700 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 alice.barraclough alice.barraclough sam oldest_to_newest 365713 0 alice.barraclough 2011-03-10 17:51:53 -0800 a WKImage can provide its image data as a CGImageRef (via WKImageCreateCGImage), but we don't have the ability to go the other way around, to create a WKImage from CGImage data. 365766 1 85426 alice.barraclough 2011-03-10 19:37:44 -0800 Created attachment 85426 patch 365816 2 85426 sam 2011-03-10 21:37:09 -0800 Comment on attachment 85426 patch View in context: https://bugs.webkit.org/attachment.cgi?id=85426&action=review > Source/WebKit2/Shared/API/c/cg/WKImageCG.h:31 > +#include <WebKit2/WKImage.h> This include should not be necessary. If it is, please sort these. > Source/WebKit2/Shared/API/c/cg/WKImageCG.h:40 > +WK_EXPORT WKImageRef WKImageCreateFromCGImage(CGImageRef imageRef, WKSize size, WKImageOptions options); Why not just get the size from the CGImageRef? 365901 3 85453 alice.barraclough 2011-03-11 02:51:17 -0800 Created attachment 85453 patch without WKSize the inclusion of WKImage.h is needed for WKImageOptions. 367387 4 alice.barraclough 2011-03-14 17:49:32 -0700 committed http://trac.webkit.org/projects/webkit/changeset/81087 85426 2011-03-10 19:37:44 -0800 2011-03-11 02:51:17 -0800 patch patch-wkimage-from-cgimage.txt text/plain 2357 alice.barraclough SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDgwNjk0KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDMtMDkgIEFsaWNlIExp dSAgPGFsaWNlLmxpdUBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgUHJvdmlkZSBBUEkgZm9yIGNyZWF0aW5nIFdLSW1hZ2UgZnJvbSBD R0ltYWdlUmVmCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD01NjE1OQorCisgICAgICAgIEFkZCBmdW5jdGlvbiBmb3IgY3JlYXRpbmcgYSBXS0ltYWdlIGZy b20gQ0dJbWFnZSBkYXRhLgorICAgICAgICAqIFNoYXJlZC9BUEkvYy9jZy9XS0ltYWdlQ0cuY3Bw OgorICAgICAgICAoV0tJbWFnZUNyZWF0ZUZyb21DR0ltYWdlKTogQWRkZWQuIENyZWF0ZXMgYSBn cmFwaGljcyBjb250ZXh0IGZvciB0aGUgYml0bWFwLWJhY2tlZCBpbWFnZSBhbmQgZHJhd3MgaW50 byBpdC4gCisgICAgICAgICogU2hhcmVkL0FQSS9jL2NnL1dLSW1hZ2VDRy5oOgorCiAyMDExLTAz LTA5ICBQZXRlciBLYXN0aW5nICA8cGthc3RpbmdAZ29vZ2xlLmNvbT4KIAogICAgICAgICBSZXZp ZXdlZCBieSBNaWhhaSBQYXJwYXJpdGEuCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvQVBJ L2MvY2cvV0tJbWFnZUNHLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQv QVBJL2MvY2cvV0tJbWFnZUNHLmNwcAkocmV2aXNpb24gODA0NzcpCisrKyBTb3VyY2UvV2ViS2l0 Mi9TaGFyZWQvQVBJL2MvY2cvV0tJbWFnZUNHLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzQsNiAr MzQsMTQgQEAKIHVzaW5nIG5hbWVzcGFjZSBXZWJLaXQ7CiB1c2luZyBuYW1lc3BhY2UgV2ViQ29y ZTsKIAorV0tJbWFnZVJlZiBXS0ltYWdlQ3JlYXRlRnJvbUNHSW1hZ2UoQ0dJbWFnZVJlZiBpbWFn ZVJlZiwgV0tTaXplIHNpemUsIFdLSW1hZ2VPcHRpb25zIG9wdGlvbnMpCit7CisgICAgUmVmUHRy PFdlYkltYWdlPiB3ZWJJbWFnZSA9IFdlYkltYWdlOjpjcmVhdGUodG9JbnRTaXplKHNpemUpLCB0 b0ltYWdlT3B0aW9ucyhvcHRpb25zKSk7CisgICAgT3duUHRyPEdyYXBoaWNzQ29udGV4dD4gZ3Jh cGhpY3NDb250ZXh0ID0gd2ViSW1hZ2UtPmJpdG1hcCgpLT5jcmVhdGVHcmFwaGljc0NvbnRleHQo KTsKKyAgICBDR0NvbnRleHREcmF3SW1hZ2UoZ3JhcGhpY3NDb250ZXh0LT5wbGF0Zm9ybUNvbnRl eHQoKSwgQ0dSZWN0TWFrZSgwLCAwLCBzaXplLndpZHRoLCBzaXplLmhlaWdodCksIGltYWdlUmVm KTsKKyAgICByZXR1cm4gdG9BUEkod2ViSW1hZ2UucmVsZWFzZSgpLmxlYWtSZWYoKSk7Cit9CisK IENHSW1hZ2VSZWYgV0tJbWFnZUNyZWF0ZUNHSW1hZ2UoV0tJbWFnZVJlZiBpbWFnZVJlZikKIHsK ICAgICBPd25QdHI8R3JhcGhpY3NDb250ZXh0PiBzb3VyY2VDb250ZXh0ID0gdG9JbXBsKGltYWdl UmVmKS0+Yml0bWFwKCktPmNyZWF0ZUdyYXBoaWNzQ29udGV4dCgpOwpJbmRleDogU291cmNlL1dl YktpdDIvU2hhcmVkL0FQSS9jL2NnL1dLSW1hZ2VDRy5oCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJLaXQyL1NoYXJlZC9BUEkvYy9jZy9XS0ltYWdlQ0cuaAkocmV2aXNpb24gODA0NzcpCisrKyBT b3VyY2UvV2ViS2l0Mi9TaGFyZWQvQVBJL2MvY2cvV0tJbWFnZUNHLmgJKHdvcmtpbmcgY29weSkK QEAgLTI4LDYgKzI4LDggQEAKIAogI2luY2x1ZGUgPENvcmVHcmFwaGljcy9DR0ltYWdlLmg+CiAj aW5jbHVkZSA8V2ViS2l0Mi9XS0Jhc2UuaD4KKyNpbmNsdWRlIDxXZWJLaXQyL1dLSW1hZ2UuaD4K KyNpbmNsdWRlIDxXZWJLaXQyL1dLR2VvbWV0cnkuaD4KIAogI2lmZGVmIF9fY3BsdXNwbHVzCiBl eHRlcm4gIkMiIHsKQEAgLTM1LDYgKzM3LDggQEAgZXh0ZXJuICJDIiB7CiAKIFdLX0VYUE9SVCBD R0ltYWdlUmVmIFdLSW1hZ2VDcmVhdGVDR0ltYWdlKFdLSW1hZ2VSZWYgaW1hZ2UpOwogCitXS19F WFBPUlQgV0tJbWFnZVJlZiBXS0ltYWdlQ3JlYXRlRnJvbUNHSW1hZ2UoQ0dJbWFnZVJlZiBpbWFn ZVJlZiwgV0tTaXplIHNpemUsIFdLSW1hZ2VPcHRpb25zIG9wdGlvbnMpOworCiAjaWZkZWYgX19j cGx1c3BsdXMKIH0KICNlbmRpZgo= 85453 2011-03-11 02:51:17 -0800 2011-03-14 17:41:36 -0700 patch without WKSize patch-wkimage-from-cgimage.txt text/plain 2385 alice.barraclough SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDgwNjk0KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDMtMTEgIEFsaWNlIExp dSAgPGFsaWNlLmxpdUBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgUHJvdmlkZSBBUEkgZm9yIGNyZWF0aW5nIFdLSW1hZ2UgZnJvbSBD R0ltYWdlUmVmCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD01NjE1OQorCisgICAgICAgIEFkZCBmdW5jdGlvbiBmb3IgY3JlYXRpbmcgYSBXS0ltYWdlIGZy b20gQ0dJbWFnZSBkYXRhLgorICAgICAgICAqIFNoYXJlZC9BUEkvYy9jZy9XS0ltYWdlQ0cuY3Bw OgorICAgICAgICAoV0tJbWFnZUNyZWF0ZUZyb21DR0ltYWdlKTogQWRkZWQuIENyZWF0ZXMgYSBn cmFwaGljcyBjb250ZXh0IGZvciB0aGUgYml0bWFwLWJhY2tlZCBpbWFnZSBhbmQgZHJhd3MgaW50 byBpdC4gCisgICAgICAgICogU2hhcmVkL0FQSS9jL2NnL1dLSW1hZ2VDRy5oOgorCiAyMDExLTAz LTA5ICBQZXRlciBLYXN0aW5nICA8cGthc3RpbmdAZ29vZ2xlLmNvbT4KIAogICAgICAgICBSZXZp ZXdlZCBieSBNaWhhaSBQYXJwYXJpdGEuCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvQVBJ L2MvY2cvV0tJbWFnZUNHLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQv QVBJL2MvY2cvV0tJbWFnZUNHLmNwcAkocmV2aXNpb24gODA2OTUpCisrKyBTb3VyY2UvV2ViS2l0 Mi9TaGFyZWQvQVBJL2MvY2cvV0tJbWFnZUNHLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzQsNiAr MzQsMTUgQEAKIHVzaW5nIG5hbWVzcGFjZSBXZWJLaXQ7CiB1c2luZyBuYW1lc3BhY2UgV2ViQ29y ZTsKIAorV0tJbWFnZVJlZiBXS0ltYWdlQ3JlYXRlRnJvbUNHSW1hZ2UoQ0dJbWFnZVJlZiBpbWFn ZVJlZiwgV0tJbWFnZU9wdGlvbnMgb3B0aW9ucykKK3sKKyAgICBJbnRTaXplIGltYWdlU2l6ZShD R0ltYWdlR2V0V2lkdGgoaW1hZ2VSZWYpLCBDR0ltYWdlR2V0SGVpZ2h0KGltYWdlUmVmKSk7Cisg ICAgUmVmUHRyPFdlYkltYWdlPiB3ZWJJbWFnZSA9IFdlYkltYWdlOjpjcmVhdGUoaW1hZ2VTaXpl LCB0b0ltYWdlT3B0aW9ucyhvcHRpb25zKSk7CisgICAgT3duUHRyPEdyYXBoaWNzQ29udGV4dD4g Z3JhcGhpY3NDb250ZXh0ID0gd2ViSW1hZ2UtPmJpdG1hcCgpLT5jcmVhdGVHcmFwaGljc0NvbnRl eHQoKTsKKyAgICBDR0NvbnRleHREcmF3SW1hZ2UoZ3JhcGhpY3NDb250ZXh0LT5wbGF0Zm9ybUNv bnRleHQoKSwgQ0dSZWN0TWFrZSgwLCAwLCBpbWFnZVNpemUud2lkdGgoKSwgaW1hZ2VTaXplLmhl aWdodCgpKSwgaW1hZ2VSZWYpOworICAgIHJldHVybiB0b0FQSSh3ZWJJbWFnZS5yZWxlYXNlKCku bGVha1JlZigpKTsKK30KKwogQ0dJbWFnZVJlZiBXS0ltYWdlQ3JlYXRlQ0dJbWFnZShXS0ltYWdl UmVmIGltYWdlUmVmKQogewogICAgIE93blB0cjxHcmFwaGljc0NvbnRleHQ+IHNvdXJjZUNvbnRl eHQgPSB0b0ltcGwoaW1hZ2VSZWYpLT5iaXRtYXAoKS0+Y3JlYXRlR3JhcGhpY3NDb250ZXh0KCk7 CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvQVBJL2MvY2cvV0tJbWFnZUNHLmgKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYktpdDIvU2hhcmVkL0FQSS9jL2NnL1dLSW1hZ2VDRy5oCShyZXZp c2lvbiA4MDY5NSkKKysrIFNvdXJjZS9XZWJLaXQyL1NoYXJlZC9BUEkvYy9jZy9XS0ltYWdlQ0cu aAkod29ya2luZyBjb3B5KQpAQCAtMjgsNiArMjgsNyBAQAogCiAjaW5jbHVkZSA8Q29yZUdyYXBo aWNzL0NHSW1hZ2UuaD4KICNpbmNsdWRlIDxXZWJLaXQyL1dLQmFzZS5oPgorI2luY2x1ZGUgPFdl YktpdDIvV0tJbWFnZS5oPgogCiAjaWZkZWYgX19jcGx1c3BsdXMKIGV4dGVybiAiQyIgewpAQCAt MzUsNiArMzYsOCBAQCBleHRlcm4gIkMiIHsKIAogV0tfRVhQT1JUIENHSW1hZ2VSZWYgV0tJbWFn ZUNyZWF0ZUNHSW1hZ2UoV0tJbWFnZVJlZiBpbWFnZSk7CiAKK1dLX0VYUE9SVCBXS0ltYWdlUmVm IFdLSW1hZ2VDcmVhdGVGcm9tQ0dJbWFnZShDR0ltYWdlUmVmIGltYWdlUmVmLCBXS0ltYWdlT3B0 aW9ucyBvcHRpb25zKTsKKwogI2lmZGVmIF9fY3BsdXNwbHVzCiB9CiAjZW5kaWYK