56158 2011-03-10 17:51:48 -0800 support encoding /decoding WebData in usermessages 2011-03-11 19:35:52 -0800 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 alice.barraclough alice.barraclough oldest_to_newest 365712 0 alice.barraclough 2011-03-10 17:51:48 -0800 UserMessage[De|En]coder::base[De|En]code are missing cases for APIObject::TypeData. This results in WKData not being able to be sent across ipc messages. 365765 1 85425 alice.barraclough 2011-03-10 19:37:14 -0800 Created attachment 85425 patch 365813 2 85425 sam 2011-03-10 21:34:53 -0800 Comment on attachment 85425 patch View in context: https://bugs.webkit.org/attachment.cgi?id=85425&action=review > Source/WebKit2/Shared/UserMessageCoders.h:305 > + coder.m_root = WebData::create(buffer); > + break; > + } I think this should return true, hm, we are inconsistent here. I should fix that, the break is fine I guess. 366486 3 alice.barraclough 2011-03-11 19:35:52 -0800 http://trac.webkit.org/changeset/80921 85425 2011-03-10 19:37:14 -0800 2011-03-10 21:34:53 -0800 patch patch-wkdata-encode-decode.txt text/plain 2532 alice.barraclough SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDgwNjk0KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDMtMDkgIEFsaWNlIExp dSAgPGFsaWNlLmxpdUBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgU3VwcG9ydCBlbmNvZGluZyAvZGVjb2RpbmcgV2ViRGF0YSBpbiB1 c2VybWVzc2FnZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTU2MTU4CisKKyAgICAgICAgQWRkZWQgZW5jb2RpbmcvZGVjb2RpbmcgZm9yIEFQSU9iamVj dDo6VHlwZURhdGEKKyAgICAgICAgKiBTaGFyZWQvVXNlck1lc3NhZ2VDb2RlcnMuaDoKKyAgICAg ICAgKFdlYktpdDo6VXNlck1lc3NhZ2VFbmNvZGVyOjpiYXNlRW5jb2RlKToKKyAgICAgICAgKFdl YktpdDo6VXNlck1lc3NhZ2VEZWNvZGVyOjpiYXNlRGVjb2RlKToKKwogMjAxMS0wMy0wOSAgUGV0 ZXIgS2FzdGluZyAgPHBrYXN0aW5nQGdvb2dsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg TWloYWkgUGFycGFyaXRhLgpJbmRleDogU291cmNlL1dlYktpdDIvU2hhcmVkL1VzZXJNZXNzYWdl Q29kZXJzLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvU2hhcmVkL1VzZXJNZXNzYWdl Q29kZXJzLmgJKHJldmlzaW9uIDgwNDc3KQorKysgU291cmNlL1dlYktpdDIvU2hhcmVkL1VzZXJN ZXNzYWdlQ29kZXJzLmgJKHdvcmtpbmcgY29weSkKQEAgLTMyLDYgKzMyLDcgQEAKICNpbmNsdWRl ICJJbW11dGFibGVEaWN0aW9uYXJ5LmgiCiAjaW5jbHVkZSAiU2hhcmVhYmxlQml0bWFwLmgiCiAj aW5jbHVkZSAiV2ViQ29yZUFyZ3VtZW50Q29kZXJzLmgiCisjaW5jbHVkZSAiV2ViRGF0YS5oIgog I2luY2x1ZGUgIldlYkltYWdlLmgiCiAjaW5jbHVkZSAiV2ViTnVtYmVyLmgiCiAjaW5jbHVkZSAi V2ViU2VyaWFsaXplZFNjcmlwdFZhbHVlLmgiCkBAIC00Nyw2ICs0OCw3IEBAIG5hbWVzcGFjZSBX ZWJLaXQgewogLy8gICAtIFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZSAtPiBTZXJpYWxpemVkU2NyaXB0 VmFsdWUKIC8vICAgLSBTdHJpbmcgLT4gU3RyaW5nCiAvLyAgIC0gVXNlckNvbnRlbnRVUkxQYXR0 ZXJuIC0+IFVzZXJDb250ZW50VVJMUGF0dGVybgorLy8gICAtIFdlYkRhdGEgLT4gV2ViRGF0YQog Ly8gICAtIFdlYkRvdWJsZSAtPiBXZWJEb3VibGUKIC8vICAgLSBXZWJJbWFnZSAtPiBXZWJJbWFn ZQogLy8gICAtIFdlYlVJbnQ2NCAtPiBXZWJVSW50NjQKQEAgLTEzOCw2ICsxNDAsMTEgQEAgcHVi bGljOgogICAgICAgICAgICAgZW5jb2Rlci0+ZW5jb2RlKGhhbmRsZSk7CiAgICAgICAgICAgICBy ZXR1cm4gdHJ1ZTsKICAgICAgICAgfQorICAgICAgICBjYXNlIEFQSU9iamVjdDo6VHlwZURhdGE6 IHsKKyAgICAgICAgICAgIFdlYkRhdGEqIGRhdGEgPSBzdGF0aWNfY2FzdDxXZWJEYXRhKj4obV9y b290KTsKKyAgICAgICAgICAgIGVuY29kZXItPmVuY29kZUJ5dGVzKGRhdGEtPmJ5dGVzKCksIGRh dGEtPnNpemUoKSk7CisgICAgICAgICAgICByZXR1cm4gdHJ1ZTsKKyAgICAgICAgfQogICAgICAg ICBkZWZhdWx0OgogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIH0KQEAgLTE2Miw2ICsxNjks NyBAQCBwcm90ZWN0ZWQ6CiAvLyAgIC0gU2VyaWFsaXplZFNjcmlwdFZhbHVlIC0+IFNlcmlhbGl6 ZWRTY3JpcHRWYWx1ZQogLy8gICAtIFN0cmluZyAtPiBTdHJpbmcKIC8vICAgLSBVc2VyQ29udGVu dFVSTFBhdHRlcm4gLT4gVXNlckNvbnRlbnRVUkxQYXR0ZXJuCisvLyAgIC0gV2ViRGF0YSAtPiBX ZWJEYXRhCiAvLyAgIC0gV2ViRG91YmxlIC0+IFdlYkRvdWJsZQogLy8gICAtIFdlYkltYWdlIC0+ IFdlYkltYWdlCiAvLyAgIC0gV2ViVUludDY0IC0+IFdlYlVJbnQ2NApAQCAtMjg4LDYgKzI5Niwx NCBAQCBwdWJsaWM6CiAgICAgICAgICAgICBjb2Rlci5tX3Jvb3QgPSBXZWJJbWFnZTo6Y3JlYXRl KFNoYXJlYWJsZUJpdG1hcDo6Y3JlYXRlKHNpemUsIGhhbmRsZSkpOwogICAgICAgICAgICAgcmV0 dXJuIHRydWU7CiAgICAgICAgIH0KKyAgICAgICAgY2FzZSBBUElPYmplY3Q6OlR5cGVEYXRhOiB7 CisgICAgICAgICAgICBWZWN0b3I8dWludDhfdD4gYnVmZmVyOworICAgICAgICAgICAgaWYgKCFk ZWNvZGVyLT5kZWNvZGVCeXRlcyhidWZmZXIpKQorICAgICAgICAgICAgICAgIHJldHVybiBmYWxz ZTsKKyAgICAgICAgICAgIGNvZGVyLm1fcm9vdCA9IFdlYkRhdGE6OmNyZWF0ZShidWZmZXIpOwor ICAgICAgICAgICAgYnJlYWs7CisgICAgICAgIH0KKwogICAgICAgICBkZWZhdWx0OgogICAgICAg ICAgICAgYnJlYWs7CiAgICAgICAgIH0K