56133 2011-03-10 12:25:44 -0800 [Qt] Warning that round/roundf functions are already defined when compiled with RVCT 4 on symbian. 2011-03-14 16:47:31 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) S60 Hardware S60 3rd edition RESOLVED FIXED Qt, QtTriaged P5 Minor --- 1 ostap73 webkit-unassigned benjamin commit-queue dbates laszlo.gombos nlandry skyul yong.li.webkit oldest_to_newest 365418 0 ostap73 2011-03-10 12:25:44 -0800 compile : JavaScriptCore\wtf\DateMath.cpp [armv5_udeb.slimdebug] "W:/webkit/Source/JavaScriptCore/wtf/MathExtras.h", line 112: Warning: #1559-D: dllexport/dllimport conflict with "round" (declared at line 344 of "W:/epoc32/include/stdapis/math.h"); dllexport assumed static double round(double num) ^ "W:/webkit/Source/JavaScriptCore/wtf/MathExtras.h", line 119: Warning: #1559-D: dllexport/dllimport conflict with "roundf" (declared at line 405 of "W:/epoc32/include/stdapis/math.h"); dllexport assumed static float roundf(float num) 365433 1 85371 ostap73 2011-03-10 12:35:33 -0800 Created attachment 85371 #ifdef out math round replacement functions on RVCT from 3.0.0 365578 2 laszlo.gombos 2011-03-10 15:25:42 -0800 CCing Nick, Daniel and Kwang for their feedback. The change in the code looks good to me. 367029 3 85371 laszlo.gombos 2011-03-14 09:59:16 -0700 Comment on attachment 85371 #ifdef out math round replacement functions on RVCT from 3.0.0 LGTM, r=me. 367348 4 85371 commit-queue 2011-03-14 16:47:27 -0700 Comment on attachment 85371 #ifdef out math round replacement functions on RVCT from 3.0.0 Clearing flags on attachment: 85371 Committed r81081: <http://trac.webkit.org/changeset/81081> 367349 5 commit-queue 2011-03-14 16:47:31 -0700 All reviewed patches have been landed. Closing bug. 85371 2011-03-10 12:35:33 -0800 2011-03-14 16:47:27 -0700 #ifdef out math round replacement functions on RVCT from 3.0.0 math_round_fix_01.diff text/plain 1405 ostap73 ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGUzMGVkYjQuLjhkYTFiMzMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDExLTAzLTEwICBWaWF0Y2hlc2xhdiBP c3RhcGVua28gIDxvc3RhcGVua28udmlhdGNoZXNsYXZAbm9raWEuY29tPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gV2FybmluZyB0aGF0IHJv dW5kL3JvdW5kZiBmdW5jdGlvbnMgYXJlIGFscmVhZHkgZGVmaW5lZCB3aGVuIGNvbXBpbGVkIHdp dGggUlZDVCA0IG9uIHN5bWJpYW4uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD01NjEzMworCisgICAgICAgIEFkZCBjb25kaXRpb24gdG8gbm90IGNvbXBp bGUgd2Via2l0IGludGVybmFsIG1hdGggcm91bmQgZnVuY3Rpb25zIG9uIFJWQ1QgY29tcGlsZXIg dmVyc2lvbnMgCisgICAgICAgIGZyb20gMy4wLjAgYmVjYXVzZSB0aGV5IGFyZSBhbHJlYWR5IGRl ZmluZWQgaW4gY29tcGlsZXIgbWF0aCBsaWJyYXJ5LgorCisgICAgICAgICogd3RmL01hdGhFeHRy YXMuaDoKKwogMjAxMS0wMy0wOSAgRGFuaWVsIEJhdGVzICA8ZGJhdGVzQHJpbS5jb20+CiAKICAg ICAgICAgQXR0ZW1wdCB0byBmaXggdGhlIFdpbkNFIGJ1aWxkIGFmdGVyIGNoYW5nZXNldCA4MDY4 NCA8aHR0cDovL3RyYWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvODA2ODQ+CmRpZmYgLS1naXQgYS9T b3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL01hdGhFeHRyYXMuaCBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS93dGYvTWF0aEV4dHJhcy5oCmluZGV4IGVjMjdmNWYuLjA0NmM5MjQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvTWF0aEV4dHJhcy5oCisrKyBiL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS93dGYvTWF0aEV4dHJhcy5oCkBAIC0xMDYsNyArMTA2LDcgQEAgaW5saW5lIGJv b2wgc2lnbmJpdChkb3VibGUgeCkgeyBzdHJ1Y3QgaWVlZV9kb3VibGUgKnAgPSAoc3RydWN0IGll ZWVfZG91YmxlICopJngKIAogI2VuZGlmCiAKLSNpZiBDT01QSUxFUihNU1ZDKSB8fCBDT01QSUxF UihSVkNUKQorI2lmIENPTVBJTEVSKE1TVkMpIHx8IChDT01QSUxFUihSVkNUKSAmJiAhKFJWQ1Rf VkVSU0lPTl9BVF9MRUFTVCgzLCAwLCAwLCAwKSkpCiAKIC8vIFdlIG11c3Qgbm90IGRvICdudW0g KyAwLjUnIG9yICdudW0gLSAwLjUnIGJlY2F1c2UgdGhleSBjYW4gY2F1c2UgcHJlY2lzaW9uIGxv c3MuCiBzdGF0aWMgZG91YmxlIHJvdW5kKGRvdWJsZSBudW0pCg==