56129 2011-03-10 11:55:00 -0800 Vertical text broken on Lion and Leopard 2011-03-10 12:16:10 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED InRadar P2 Normal --- 1 hyatt hyatt oldest_to_newest 365386 0 hyatt 2011-03-10 11:55:00 -0800 Vertical text is offset by a large amount on Lion and Leopard. It appears that the CTFontGetVerticalTranslationsForGlyphs method is different only on Snow Leopard. 365389 1 85359 hyatt 2011-03-10 11:56:37 -0800 Created attachment 85359 Patch 365393 2 mitz 2011-03-10 11:58:25 -0800 <rdar://problem/9116368> 365399 3 85363 hyatt 2011-03-10 12:07:15 -0800 Created attachment 85363 Patch 365403 4 85363 mitz 2011-03-10 12:08:43 -0800 Comment on attachment 85363 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=85363&action=review > Source/WebCore/ChangeLog:5 > + Add Snow Leopard ifdefs for the scaling by point size and then the division by unitsPerEm. Please add the bugs.webkit.org URL 365410 5 hyatt 2011-03-10 12:15:53 -0800 Fixed in r80470. 365411 6 hyatt 2011-03-10 12:16:10 -0800 Sorry, r80740. 85359 2011-03-10 11:56:37 -0800 2011-03-10 12:07:15 -0800 Patch patch.txt text/plain 2326 hyatt SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDgwNzM5KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDMtMTAgIERhdmlkIEh5 YXR0ICA8aHlhdHRAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEFkZCBTbm93IExlb3BhcmQgaWZkZWZzIGZvciB0aGUgc2NhbGluZyBi eSBwb2ludCBzaXplIGFuZCB0aGVuIHRoZSBkaXZpc2lvbiBieSB1bml0c1BlckVtLgorCisgICAg ICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvbWFjL0ZvbnRNYWMubW06CisgICAgICAgIChXZWJDb3Jl OjpzaG93R2x5cGhzV2l0aEFkdmFuY2VzKToKKwogMjAxMS0wMy0xMCAgU2hlcmlmZiBCb3QgIDx3 ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGlu ZyBvdXQgcjgwNzAxLgpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvbWFj L0ZvbnRNYWMubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvbWFjL0ZvbnRNYWMubW0JKHJldmlzaW9uIDgwNjY1KQorKysgU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvbWFjL0ZvbnRNYWMubW0JKHdvcmtpbmcgY29weSkKQEAgLTY2LDExICs2 NiwxOSBAQCBzdGF0aWMgdm9pZCBzaG93R2x5cGhzV2l0aEFkdmFuY2VzKGNvbnN0CiAgICAgICAg ICAgICBDR0FmZmluZVRyYW5zZm9ybSBydW5NYXRyaXggPSBDR0FmZmluZVRyYW5zZm9ybUNvbmNh dChzYXZlZE1hdHJpeCwgcm90YXRlTGVmdFRyYW5zZm9ybSk7CiAgICAgICAgICAgICBDR0NvbnRl eHRTZXRUZXh0TWF0cml4KGNvbnRleHQsIHJ1bk1hdHJpeCk7CiAgICAgICAgICAgICAKLSAgICAg ICAgICAgIENHQWZmaW5lVHJhbnNmb3JtIHRyYW5zbGF0aW9uc1RyYW5zZm9ybSA9IENHQWZmaW5l VHJhbnNmb3JtTWFrZShwbGF0Zm9ybURhdGEubV9zaXplLCAwLCAwLCBwbGF0Zm9ybURhdGEubV9z aXplLCAwLCAwKTsKKyAgICAgICAgICAgIC8vIENURm9udEdldFZlcnRpY2FsVHJhbnNsYXRpb25z Rm9yR2x5cGhzIGlzIGRpZmZlcmVudCBvbiBTbm93IExlb3BhcmQuICBJdCByZXR1cm5zIHZhbHVl cyBmb3IgYSBmb250LXNpemUgb2YgMQorICAgICAgICAgICAgLy8gd2l0aG91dCB1bml0c1BlckVt IGFwcGxpZWQuICBXZSBoYXZlIHRvIGFwcGx5IGEgdHJhbnNmb3JtIHRoYXQgc2NhbGVzIHVwIHRv IHRoZSBwb2ludCBzaXplIGFuZCB0aGF0IGFsc28gCisgICAgICAgICAgICAvLyBkaXZpZGVzIGJ5 IHVuaXRzUGVyRW0uCisgICAgICAgICAgICBDR0Zsb2F0IHRyYW5zbGF0aW9uc1NjYWxlID0gMTsK KyNpZiBkZWZpbmVkKEJVSUxESU5HX09OX1NOT1dfTEVPUEFSRCkKKyAgICAgICAgICAgIHRyYW5z bGF0aW9uc1NjYWxlID0gcGxhdGZvcm1EYXRhLm1fc2l6ZTsKKyNlbmRpZgorICAgICAgICAgICAg Q0dBZmZpbmVUcmFuc2Zvcm0gdHJhbnNsYXRpb25zVHJhbnNmb3JtID0gQ0dBZmZpbmVUcmFuc2Zv cm1NYWtlKHRyYW5zbGF0aW9uc1NjYWxlLCAwLCAwLCB0cmFuc2xhdGlvbnNTY2FsZSwgMCwgMCk7 CiAgICAgICAgICAgICB0cmFuc2xhdGlvbnNUcmFuc2Zvcm0gPSBDR0FmZmluZVRyYW5zZm9ybUNv bmNhdCh0cmFuc2xhdGlvbnNUcmFuc2Zvcm0sIHJvdGF0ZUxlZnRUcmFuc2Zvcm0pOworI2lmIGRl ZmluZWQoQlVJTERJTkdfT05fU05PV19MRU9QQVJEKQogICAgICAgICAgICAgQ0dGbG9hdCB1bml0 c1BlckVtID0gQ0dGb250R2V0VW5pdHNQZXJFbShwbGF0Zm9ybURhdGEuY2dGb250KCkpOwogICAg ICAgICAgICAgdHJhbnNsYXRpb25zVHJhbnNmb3JtID0gQ0dBZmZpbmVUcmFuc2Zvcm1Db25jYXQo dHJhbnNsYXRpb25zVHJhbnNmb3JtLCBDR0FmZmluZVRyYW5zZm9ybU1ha2VTY2FsZSgxIC8gdW5p dHNQZXJFbSwgMSAvIHVuaXRzUGVyRW0pKTsKLQorI2VuZGlmCiAgICAgICAgICAgICBWZWN0b3I8 Q0dTaXplLCAyNTY+IHRyYW5zbGF0aW9ucyhjb3VudCk7CiAgICAgICAgICAgICBDVEZvbnRHZXRW ZXJ0aWNhbFRyYW5zbGF0aW9uc0ZvckdseXBocyhwbGF0Zm9ybURhdGEuY3RGb250KCksIGdseXBo cywgdHJhbnNsYXRpb25zLmRhdGEoKSwgY291bnQpOwogICAgICAgICAgICAgCg== 85363 2011-03-10 12:07:15 -0800 2011-03-10 12:08:43 -0800 Patch patch.txt text/plain 2136 hyatt SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDgwNzM5KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDMtMTAgIERhdmlkIEh5 YXR0ICA8aHlhdHRAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEFkZCBTbm93IExlb3BhcmQgaWZkZWZzIGZvciB0aGUgc2NhbGluZyBi eSBwb2ludCBzaXplIGFuZCB0aGVuIHRoZSBkaXZpc2lvbiBieSB1bml0c1BlckVtLgorCisgICAg ICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvbWFjL0ZvbnRNYWMubW06CisgICAgICAgIChXZWJDb3Jl OjpzaG93R2x5cGhzV2l0aEFkdmFuY2VzKToKKwogMjAxMS0wMy0xMCAgU2hlcmlmZiBCb3QgIDx3 ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGlu ZyBvdXQgcjgwNzAxLgpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvbWFj L0ZvbnRNYWMubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvbWFjL0ZvbnRNYWMubW0JKHJldmlzaW9uIDgwNjY1KQorKysgU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvbWFjL0ZvbnRNYWMubW0JKHdvcmtpbmcgY29weSkKQEAgLTY2LDExICs2 NiwxNyBAQCBzdGF0aWMgdm9pZCBzaG93R2x5cGhzV2l0aEFkdmFuY2VzKGNvbnN0CiAgICAgICAg ICAgICBDR0FmZmluZVRyYW5zZm9ybSBydW5NYXRyaXggPSBDR0FmZmluZVRyYW5zZm9ybUNvbmNh dChzYXZlZE1hdHJpeCwgcm90YXRlTGVmdFRyYW5zZm9ybSk7CiAgICAgICAgICAgICBDR0NvbnRl eHRTZXRUZXh0TWF0cml4KGNvbnRleHQsIHJ1bk1hdHJpeCk7CiAgICAgICAgICAgICAKKyNpZiBk ZWZpbmVkKEJVSUxESU5HX09OX1NOT1dfTEVPUEFSRCkKKyAgICAgICAgICAgIC8vIENURm9udEdl dFZlcnRpY2FsVHJhbnNsYXRpb25zRm9yR2x5cGhzIGlzIGRpZmZlcmVudCBvbiBTbm93IExlb3Bh cmQuICBJdCByZXR1cm5zIHZhbHVlcyBmb3IgYSBmb250LXNpemUgb2YgMQorICAgICAgICAgICAg Ly8gd2l0aG91dCB1bml0c1BlckVtIGFwcGxpZWQuICBXZSBoYXZlIHRvIGFwcGx5IGEgdHJhbnNm b3JtIHRoYXQgc2NhbGVzIHVwIHRvIHRoZSBwb2ludCBzaXplIGFuZCB0aGF0IGFsc28gCisgICAg ICAgICAgICAvLyBkaXZpZGVzIGJ5IHVuaXRzUGVyRW0uCiAgICAgICAgICAgICBDR0FmZmluZVRy YW5zZm9ybSB0cmFuc2xhdGlvbnNUcmFuc2Zvcm0gPSBDR0FmZmluZVRyYW5zZm9ybU1ha2UocGxh dGZvcm1EYXRhLm1fc2l6ZSwgMCwgMCwgcGxhdGZvcm1EYXRhLm1fc2l6ZSwgMCwgMCk7CiAgICAg ICAgICAgICB0cmFuc2xhdGlvbnNUcmFuc2Zvcm0gPSBDR0FmZmluZVRyYW5zZm9ybUNvbmNhdCh0 cmFuc2xhdGlvbnNUcmFuc2Zvcm0sIHJvdGF0ZUxlZnRUcmFuc2Zvcm0pOwogICAgICAgICAgICAg Q0dGbG9hdCB1bml0c1BlckVtID0gQ0dGb250R2V0VW5pdHNQZXJFbShwbGF0Zm9ybURhdGEuY2dG b250KCkpOwogICAgICAgICAgICAgdHJhbnNsYXRpb25zVHJhbnNmb3JtID0gQ0dBZmZpbmVUcmFu c2Zvcm1Db25jYXQodHJhbnNsYXRpb25zVHJhbnNmb3JtLCBDR0FmZmluZVRyYW5zZm9ybU1ha2VT Y2FsZSgxIC8gdW5pdHNQZXJFbSwgMSAvIHVuaXRzUGVyRW0pKTsKLQorI2Vsc2UKKyAgICAgICAg ICAgIENHQWZmaW5lVHJhbnNmb3JtIHRyYW5zbGF0aW9uc1RyYW5zZm9ybSA9IHJvdGF0ZUxlZnRU cmFuc2Zvcm07CisjZW5kaWYKICAgICAgICAgICAgIFZlY3RvcjxDR1NpemUsIDI1Nj4gdHJhbnNs YXRpb25zKGNvdW50KTsKICAgICAgICAgICAgIENURm9udEdldFZlcnRpY2FsVHJhbnNsYXRpb25z Rm9yR2x5cGhzKHBsYXRmb3JtRGF0YS5jdEZvbnQoKSwgZ2x5cGhzLCB0cmFuc2xhdGlvbnMuZGF0 YSgpLCBjb3VudCk7CiAgICAgICAgICAgICAK