56127 2011-03-10 11:38:53 -0800 Fix allocation of native function with a cached thunk 2011-03-11 04:08:55 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 oliver oliver barraclough svillar oldest_to_newest 365362 0 oliver 2011-03-10 11:38:53 -0800 Fix allocation of native function with a cached thunk 365363 1 85355 oliver 2011-03-10 11:40:14 -0800 Created attachment 85355 Patch 365427 2 barraclough 2011-03-10 12:31:56 -0800 Fixed in r80743 365435 3 oliver 2011-03-10 12:36:27 -0800 Errr wrong bug mate :) 365475 4 oliver 2011-03-10 13:17:08 -0800 Committed r80751: <http://trac.webkit.org/changeset/80751> 365519 5 barraclough 2011-03-10 14:02:48 -0800 Oooops! 365904 6 svillar 2011-03-11 03:02:35 -0800 I think this commit maybe the source of some JSC crashes in GTK 32bit Release bot we have been observing recently. In particular these two tests are failing consistently since then: fast/profiler/dead-time.html fast/profiler/stop-profiling-after-setTimeout.html 365919 7 svillar 2011-03-11 04:08:55 -0800 (In reply to comment #6) > I think this commit maybe the source of some JSC crashes in GTK 32bit Release bot we have been observing recently. In particular these two tests are failing consistently since then: > > fast/profiler/dead-time.html > fast/profiler/stop-profiling-after-setTimeout.html Looks like I was wrong, after reverting 80742 and 80743 no crash at all. Sorry for the noise. 85355 2011-03-10 11:40:14 -0800 2011-03-10 11:51:19 -0800 Patch bug-56127-20110310114013.patch text/plain 6603 oliver U3VidmVyc2lvbiBSZXZpc2lvbjogODA3MzgKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDE2 NTRhZmY3ZWJjZmQ1MTczNjk0NjlkZWYwNDdmZjljNDg1NzkyN2YuLjBkZDZkMWJhZjdmNGY4NTE3 YmY3Y2ZmM2JjMWVmYTRiZDQwYTRhNTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDI3IEBACisyMDExLTAzLTEwICBPbGl2ZXIgSHVudCAgPG9saXZlckBhcHBsZS5jb20+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IGFsbG9j YXRpb24gb2YgbmF0aXZlIGZ1bmN0aW9uIHdpdGggYSBjYWNoZWQgdGh1bmsKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU2MTI3CisKKyAgICAgICAgRml4 IHRoaXMgcmFjZSBjb25kaXRpb24gZm91bmQgd2hpbGUgZml4aW5nIHpvbWJpZXMuCisKKyAgICAg ICAgKiBjb2xsZWN0b3IvaGFuZGxlcy9IYW5kbGVIZWFwLmNwcDoKKyAgICAgICAgKEpTQzo6SGFu ZGxlSGVhcDo6Y2xlYXJXZWFrUG9pbnRlcnMpOgorICAgICAgICAqIHJ1bnRpbWUvSGVhcC5jcHA6 CisgICAgICAgIChKU0M6OkhlYXA6OnJlc2V0KToKKyAgICAgICAgKiBydW50aW1lL0pTRnVuY3Rp b24uY3BwOgorICAgICAgICAoSlNDOjpKU0Z1bmN0aW9uOjpKU0Z1bmN0aW9uKToKKyAgICAgICAg KEpTQzo6SlNGdW5jdGlvbjo6bWFya0NoaWxkcmVuKToKKyAgICAgICAgKiBydW50aW1lL0pTVmFs dWUuaDoKKyAgICAgICAgKEpTQzo6SlNWYWx1ZTo6ZGVjb2RlKToKKyAgICAgICAgKiBydW50aW1l L0pTWm9tYmllLmNwcDoKKyAgICAgICAgKEpTQzo6SlNab21iaWU6OmxlYWtlZFpvbWJpZVN0cnVj dHVyZSk6CisgICAgICAgICogcnVudGltZS9KU1pvbWJpZS5oOgorICAgICAgICAoSlNDOjpKU1pv bWJpZTo6Y3JlYXRlU3RydWN0dXJlKToKKyAgICAgICAgKiBydW50aW1lL01hcmtlZEJsb2NrLmNw cDoKKwogMjAxMS0wMy0wOSAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IEdhdmluIEJhcnJhY2xvdWdoLgpkaWZmIC0tZ2l0IGEvU291cmNlL0ph dmFTY3JpcHRDb3JlL2NvbGxlY3Rvci9oYW5kbGVzL0hhbmRsZUhlYXAuY3BwIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL2NvbGxlY3Rvci9oYW5kbGVzL0hhbmRsZUhlYXAuY3BwCmluZGV4IDMyZmE0 MmQxNGQxYjc4NTA0MzM5MmI2MDE4NzA5Yjc5ODg0NjhiZDQuLjg1OGUxY2I1MjU1N2U3M2FlY2U1 ODk0YzFkMThjOWQzYTg3YzcxNDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9j b2xsZWN0b3IvaGFuZGxlcy9IYW5kbGVIZWFwLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvY29sbGVjdG9yL2hhbmRsZXMvSGFuZGxlSGVhcC5jcHAKQEAgLTc5LDcgKzc5LDEwIEBAIHZv aWQgSGFuZGxlSGVhcDo6Y2xlYXJXZWFrUG9pbnRlcnMoKQogICAgICAgICAKICAgICAgICAgSlND ZWxsKiBjZWxsID0gdmFsdWUuYXNDZWxsKCk7CiAgICAgICAgIEFTU0VSVCghY2VsbCB8fCBjZWxs LT5zdHJ1Y3R1cmUoKSk7Ci0KKyAgICAgICAgCisjaWYgRU5BQkxFKEpTQ19aT01CSUVTKQorICAg ICAgICBBU1NFUlQoIWNlbGwtPmlzWm9tYmllKCkpOworI2VuZGlmCiAgICAgICAgIGlmIChIZWFw Ojppc01hcmtlZChjZWxsKSkKICAgICAgICAgICAgIGNvbnRpbnVlOwogICAgICAgICAKZGlmZiAt LWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0hlYXAuY3BwIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL3J1bnRpbWUvSGVhcC5jcHAKaW5kZXggMTc4MTU4MjQ5OGRjMThlYmQyMzg1 NjQ4YjMzYzA2NTBiYzBlODM2ZC4uZjQyYmRkNTc3MDlmMGIwZTMyYTg4NzljZTg4YmQxYmY1ZDgy ZmY4NyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSGVhcC5jcHAK KysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSGVhcC5jcHAKQEAgLTM3MCw3ICsz NzAsNyBAQCB2b2lkIEhlYXA6OnJlc2V0KFN3ZWVwVG9nZ2xlIHN3ZWVwVG9nZ2xlKQogICAgIG1f ZXh0cmFDb3N0ID0gMDsKIAogI2lmIEVOQUJMRShKU0NfWk9NQklFUykKLSAgICBzd2VlcCgpOwor ICAgIHN3ZWVwVG9nZ2xlID0gRG9Td2VlcDsKICNlbmRpZgogCiAgICAgaWYgKHN3ZWVwVG9nZ2xl ID09IERvU3dlZXApIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1l L0pTRnVuY3Rpb24uY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNGdW5jdGlv bi5jcHAKaW5kZXggOGU3NzQ3YjkxYTBjNWY4NDc0ZWQyMGU0MDk1YTJhNWI5MDVmMWRjYS4uZGJm YzYwNjU1ZTJjMzNjZmUwNWViZGE2NzQ0NmY3OTZlNzIwMDM0YyAxMDA2NDQKLS0tIGEvU291cmNl L0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNGdW5jdGlvbi5jcHAKKysrIGIvU291cmNlL0phdmFT Y3JpcHRDb3JlL3J1bnRpbWUvSlNGdW5jdGlvbi5jcHAKQEAgLTc1LDEwICs3NSwxMyBAQCBKU0Z1 bmN0aW9uOjpKU0Z1bmN0aW9uKEV4ZWNTdGF0ZSogZXhlYywgSlNHbG9iYWxPYmplY3QqIGdsb2Jh bE9iamVjdCwgTm9uTnVsbFBhcwogCiBKU0Z1bmN0aW9uOjpKU0Z1bmN0aW9uKEV4ZWNTdGF0ZSog ZXhlYywgSlNHbG9iYWxPYmplY3QqIGdsb2JhbE9iamVjdCwgTm9uTnVsbFBhc3NSZWZQdHI8U3Ry dWN0dXJlPiBzdHJ1Y3R1cmUsIGludCBsZW5ndGgsIGNvbnN0IElkZW50aWZpZXImIG5hbWUsIE5h dGl2ZUZ1bmN0aW9uIGZ1bmMpCiAgICAgOiBCYXNlKGdsb2JhbE9iamVjdCwgc3RydWN0dXJlKQot ICAgICwgbV9leGVjdXRhYmxlKGV4ZWMtPmdsb2JhbERhdGEoKSwgdGhpcywgZXhlYy0+Z2xvYmFs RGF0YSgpLmdldEhvc3RGdW5jdGlvbihmdW5jKSkKICAgICAsIG1fc2NvcGVDaGFpbihleGVjLT5n bG9iYWxEYXRhKCksIHRoaXMsIGdsb2JhbE9iamVjdC0+Z2xvYmFsU2NvcGVDaGFpbigpKQogewog ICAgIEFTU0VSVChpbmhlcml0cygmc19pbmZvKSk7CisgICAgLy8gV2Ugc2VwYXJhdGUgb3V0IGlu dGlhbGlzYXRpb24gZnJvbSBzZXR0aW5nIHRoZSBleGVjdXRhYmxlCisgICAgLy8gYXMgZ2V0SG9z dEZ1bmN0aW9uIG1heSBwZXJmb3JtIGEgR0MgYWxsb2NhdGlvbiwgc28gd2UgaGF2ZSB0byBiZSBh YmxlIHRvCisgICAgLy8gbWFyayBvdXJzZWx2ZXMgc2FmZWx5CisgICAgbV9leGVjdXRhYmxlLnNl dChleGVjLT5nbG9iYWxEYXRhKCksIHRoaXMsIGV4ZWMtPmdsb2JhbERhdGEoKS5nZXRIb3N0RnVu Y3Rpb24oZnVuYykpOwogICAgIHB1dERpcmVjdChleGVjLT5nbG9iYWxEYXRhKCksIGV4ZWMtPmds b2JhbERhdGEoKS5wcm9wZXJ0eU5hbWVzLT5uYW1lLCBqc1N0cmluZyhleGVjLCBuYW1lLmlzTnVs bCgpID8gIiIgOiBuYW1lLnVzdHJpbmcoKSksIERvbnREZWxldGUgfCBSZWFkT25seSB8IERvbnRF bnVtKTsKICAgICBwdXREaXJlY3QoZXhlYy0+Z2xvYmFsRGF0YSgpLCBleGVjLT5wcm9wZXJ0eU5h bWVzKCkubGVuZ3RoLCBqc051bWJlcihsZW5ndGgpLCBEb250RGVsZXRlIHwgUmVhZE9ubHkgfCBE b250RW51bSk7CiB9CkBAIC0xMzUsOSArMTM4LDEzIEBAIGNvbnN0IFVTdHJpbmcgSlNGdW5jdGlv bjo6Y2FsY3VsYXRlZERpc3BsYXlOYW1lKEV4ZWNTdGF0ZSogZXhlYykKIHZvaWQgSlNGdW5jdGlv bjo6bWFya0NoaWxkcmVuKE1hcmtTdGFjayYgbWFya1N0YWNrKQogewogICAgIEJhc2U6Om1hcmtD aGlsZHJlbihtYXJrU3RhY2spOwotICAgIG1hcmtTdGFjay5hcHBlbmQoJm1fZXhlY3V0YWJsZSk7 Ci0gICAgaWYgKCFpc0hvc3RGdW5jdGlvbigpKSB7Ci0gICAgICAgIG1hcmtTdGFjay5hcHBlbmQo Jm1fc2NvcGVDaGFpbik7CisKKyAgICBtYXJrU3RhY2suYXBwZW5kKCZtX3Njb3BlQ2hhaW4pOwor ICAgIGlmIChtX2V4ZWN1dGFibGUpIHsKKyAgICAgICAgLy8gRGVsaWdodGZ1bCByYWNlIGNvbmRp dGlvbjogbV9leGVjdXRhYmxlIG1heSBub3QgaGF2ZSBiZWVuIGluaXRpYWxpc2VkCisgICAgICAg IC8vIGlmIHRoaXMgaXMgYSBob3N0IGZ1bmN0aW9uLCBhcyB0aGUgZXhlY3V0YWJsZSBpc24ndCBu ZWNlc3NhcmlseSBjcmVhdGVkIAorICAgICAgICAvLyB1bnRpbCBhZnRlciB0aGUgZnVuY3Rpb24g aGFzIGJlZW4gYWxsb2NhdGVkLgorICAgICAgICBtYXJrU3RhY2suYXBwZW5kKCZtX2V4ZWN1dGFi bGUpOwogICAgIH0KIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRp bWUvSlNWYWx1ZS5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNWYWx1ZS5oCmlu ZGV4IGIyZTdhNTFlNTgxMTk4ODYyZGJiZDg2ZWQ5NThlZWY2YzBlZWUxZTkuLjczOGVkYTBmODFh MWY0NjM0NWQyMjE5MjBhNGMzNDIzYjVkNWRjNDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9ydW50aW1lL0pTVmFsdWUuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVu dGltZS9KU1ZhbHVlLmgKQEAgLTM5Miw5ICszOTIsNiBAQCBuYW1lc3BhY2UgSlNDIHsKICAgICB7 CiAgICAgICAgIEpTVmFsdWUgdjsKICAgICAgICAgdi51LmFzRW5jb2RlZEpTVmFsdWUgPSBlbmNv ZGVkSlNWYWx1ZTsKLSNpZiBFTkFCTEUoSlNDX1pPTUJJRVMpCi0gICAgICAgIEFTU0VSVCghdi5p c1pvbWJpZSgpKTsKLSNlbmRpZgogICAgICAgICByZXR1cm4gdjsKICAgICB9CiAKZGlmZiAtLWdp dCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTWm9tYmllLmNwcCBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTWm9tYmllLmNwcAppbmRleCBjMGM1ZjExNjBiM2M1ZDVm NmQ4ZTgxYzUwYmFiNThlZDlhNWUyNGJhLi44NmRjYzcyNmIyNTcwN2FjZTlmYTBkZTYwMTI3OWJm YzliNGQ4OTk0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU1pv bWJpZS5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNab21iaWUuY3Bw CkBAIC0zOCw3ICszOCw3IEBAIFN0cnVjdHVyZSogSlNab21iaWU6OmxlYWtlZFpvbWJpZVN0cnVj dHVyZSgpIHsKICAgICBzdGF0aWMgU3RydWN0dXJlKiBzdHJ1Y3R1cmUgPSAwOwogICAgIGlmICgh c3RydWN0dXJlKSB7CiAgICAgICAgIFN0cnVjdHVyZTo6c3RhcnRJZ25vcmluZ0xlYWtzKCk7Ci0g ICAgICAgIHN0cnVjdHVyZSA9IFN0cnVjdHVyZTo6Y3JlYXRlKGpzTnVsbCgpLCBUeXBlSW5mbyhV bnNwZWNpZmllZFR5cGUpLCAwLCAmaW5mbykubGVha1JlZigpOworICAgICAgICBzdHJ1Y3R1cmUg PSBTdHJ1Y3R1cmU6OmNyZWF0ZShqc051bGwoKSwgVHlwZUluZm8oVW5zcGVjaWZpZWRUeXBlKSwg MCwgJnNfaW5mbykubGVha1JlZigpOwogICAgICAgICBTdHJ1Y3R1cmU6OnN0b3BJZ25vcmluZ0xl YWtzKCk7CiAgICAgfQogICAgIHJldHVybiBzdHJ1Y3R1cmU7CmRpZmYgLS1naXQgYS9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvcnVudGltZS9KU1pvbWJpZS5oIGIvU291cmNlL0phdmFTY3JpcHRDb3Jl L3J1bnRpbWUvSlNab21iaWUuaAppbmRleCA1ZmU2YjZkYTJiM2QyMDE2M2U0ZjJiZDBmYjM2YTk3 YmUxZjYwNDBmLi5lNTc1YWM1NTIxNmNjZTE0OTdkZTM2NGE5NzI4YmNmZmIyN2I0ZmQ2IDEwMDY0 NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU1pvbWJpZS5oCisrKyBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTWm9tYmllLmgKQEAgLTY4LDcgKzY4LDcgQEAg cHVibGljOgogICAgIAogICAgIHN0YXRpYyBQYXNzUmVmUHRyPFN0cnVjdHVyZT4gY3JlYXRlU3Ry dWN0dXJlKEpTVmFsdWUgcHJvdG90eXBlKQogICAgIHsKLSAgICAgICAgcmV0dXJuIFN0cnVjdHVy ZTo6Y3JlYXRlKHByb3RvdHlwZSwgVHlwZUluZm8oT2JqZWN0VHlwZSwgU3RydWN0dXJlRmxhZ3Mp LCBBbm9ueW1vdXNTbG90Q291bnQsICZzX2luZm8pOworICAgICAgICByZXR1cm4gU3RydWN0dXJl OjpjcmVhdGUocHJvdG90eXBlLCBUeXBlSW5mbyhPYmplY3RUeXBlLCAwKSwgQW5vbnltb3VzU2xv dENvdW50LCAmc19pbmZvKTsKICAgICB9CiAKICAgICBzdGF0aWMgY29uc3QgQ2xhc3NJbmZvIHNf aW5mbzsKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL01hcmtlZEJs b2NrLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL01hcmtlZEJsb2NrLmNwcApp bmRleCA0OGRkYTRjNzg3MGY1NjE1MThiOWZmMjMzNjBkYjQzNTJmZDYzYTBiLi5iOTg2NWZhMTM0 MDhkZDk0MWFhNmM2YzFhZDY0M2MwMmJlMzg0MTdlIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvcnVudGltZS9NYXJrZWRCbG9jay5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL3J1bnRpbWUvTWFya2VkQmxvY2suY3BwCkBAIC0yNyw2ICsyNyw3IEBACiAjaW5jbHVkZSAi TWFya2VkQmxvY2suaCIKIAogI2luY2x1ZGUgIkpTQ2VsbC5oIgorI2luY2x1ZGUgIkpTWm9tYmll LmgiCiAjaW5jbHVkZSAiU2NvcGVDaGFpbi5oIgogCiBuYW1lc3BhY2UgSlNDIHsK